RE: moving JAM to org.apache.jam
VERY QUICK REPLY: Looks interesting. Some more issues to keep in mind: + There are users of C-A out there: Spring Framework (www.springframework.org) is one of them. This means that we can't just replace C-A with JAM. Even though it is in sandbox, going from one API to another isn't the proper way to ever get out of sandbox. + There are users of JAM out there: XMLBeans, for one. This means that we can't just replace JAM with C-A. Even though it is in incubator, going from one API to another isn't theproper way to ever get out of incubator. + The two APIs are quite different in their approach. But let's try a merge anyway. I'm up for it. /LS From: Leo Simons [mailto:[EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28002] New: - [Codec][Patch] RFC 1522 codecs (Q-codec B-codec)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28002. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28002 [Codec][Patch] RFC 1522 codecs (Q-codec B-codec) Summary: [Codec][Patch] RFC 1522 codecs (Q-codec B-codec) Product: Commons Version: 1.2 Final Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Codec AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The patch implements the Q-codec and B-codec as defined in the RFC 1522. Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28002] - [Codec][Patch] RFC 1522 codecs (Q-codec B-codec)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28002. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28002 [Codec][Patch] RFC 1522 codecs (Q-codec B-codec) --- Additional Comments From [EMAIL PROTECTED] 2004-03-28 13:23 --- Created an attachment (id=11022) Patch (take 1) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration JNDIConfiguration.java
epugh 2004/03/28 06:42:45
Modified:configuration/src/test/org/apache/commons/configuration
TestJNDIConfiguration.java
configuration/src/java/org/apache/commons/configuration
JNDIConfiguration.java
Log:
Refactor from ebourg:
- extend AbstractConfiguration instead of BaseConfiguration
- rename getValueFromJNDI into getPropertyDirect
- add a setPropertyDirect method throwing an UnsupportedOperationException
- throw an UnsupportedOperationException on write operations instead of
a java.lang.Error
- remove the default constructor
- clearedProperties is now a Set instead of a List
- more tests for subset(), clearProperty(), getKeys() and isEmpty().
- minor javadoc style changes
Revision ChangesPath
1.6 +113 -115
jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestJNDIConfiguration.java
Index: TestJNDIConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestJNDIConfiguration.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- TestJNDIConfiguration.java27 Feb 2004 17:41:34 - 1.5
+++ TestJNDIConfiguration.java28 Mar 2004 14:42:45 - 1.6
@@ -1,5 +1,3 @@
-package org.apache.commons.configuration;
-
/*
* Copyright 2001-2004 The Apache Software Foundation.
*
@@ -16,129 +14,129 @@
* limitations under the License.
*/
-import java.util.Iterator;
+package org.apache.commons.configuration;
import junit.framework.TestCase;
+import java.util.Iterator;
+
/**
- * test if non-string properties are handled correctly
+ * Test to see if the JNDIConfiguration works properly. Currently excluded
+ * in the project.xml unitTest section as our JNDI provider doesn't
+ * properly support the listBindings() method.
+ *
+ * This does work fine with Tomcat's JNDI provider however.
*
* @version $Id$
*/
-public class TestJNDIConfiguration extends TestCase
-{
- private Configuration conf;
- private NonStringTestHolder nonStringTestHolder;
-
-
-
-public void setUp() throws Exception
-{
- //InitialContext context = new InitialContext();
- //assertNotNull(context);
-
-JNDIConfiguration jndiConfiguration = new JNDIConfiguration();
- jndiConfiguration.setPrefix();
-conf = jndiConfiguration;
+public class TestJNDIConfiguration extends TestCase {
+
+private JNDIConfiguration conf;
+private NonStringTestHolder nonStringTestHolder;
+
+public void setUp() throws Exception {
+//InitialContext context = new InitialContext();
+//assertNotNull(context);
+
+conf = new JNDIConfiguration();
+conf.setPrefix();
+
nonStringTestHolder = new NonStringTestHolder();
nonStringTestHolder.setConfiguration(conf);
+}
+
+public void testBoolean() throws Exception {
+nonStringTestHolder.testBoolean();
+}
+
+public void testBooleanDefaultValue() throws Exception {
+nonStringTestHolder.testBooleanDefaultValue();
+}
+
+public void testByte() throws Exception {
+nonStringTestHolder.testByte();
+}
+
+public void testDouble() throws Exception {
+nonStringTestHolder.testDouble();
+}
+
+public void testDoubleDefaultValue() throws Exception {
+nonStringTestHolder.testDoubleDefaultValue();
+}
+public void testFloat() throws Exception {
+nonStringTestHolder.testFloat();
}
-
- public void testBoolean() throws Exception
- {
- nonStringTestHolder.testBoolean();
- }
-
- public void testBooleanDefaultValue() throws Exception
- {
- nonStringTestHolder.testBooleanDefaultValue();
- }
-
- public void testByte() throws Exception
- {
- nonStringTestHolder.testByte();
- }
-
- public void testDouble() throws Exception
- {
- nonStringTestHolder.testDouble();
- }
-
- public void testDoubleDefaultValue() throws Exception
- {
- nonStringTestHolder.testDoubleDefaultValue();
- }
-
- public void testFloat() throws Exception
- {
- nonStringTestHolder.testFloat();
- }
-
- public void testFloatDefaultValue() throws Exception
- {
- nonStringTestHolder.testFloatDefaultValue();
-
- }
-
- public void testInteger() throws Exception
- {
- nonStringTestHolder.testInteger();
- }
-
- public void
cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration HierarchicalConfiguration.java PropertiesConfiguration.java ConfigurationUtils.java BasePropertiesConfiguration.java
epugh 2004/03/28 06:43:04
Modified:configuration/src/java/org/apache/commons/configuration
HierarchicalConfiguration.java
PropertiesConfiguration.java
ConfigurationUtils.java
BasePropertiesConfiguration.java
Log:
Fixes suggested by findbugs
Revision ChangesPath
1.6 +2 -8
jakarta-commons/configuration/src/java/org/apache/commons/configuration/HierarchicalConfiguration.java
Index: HierarchicalConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/HierarchicalConfiguration.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- HierarchicalConfiguration.java13 Mar 2004 17:04:04 - 1.5
+++ HierarchicalConfiguration.java28 Mar 2004 14:43:04 - 1.6
@@ -322,13 +322,7 @@
{
result.getRoot().addChild((Node) children.get(i));
} /* for */
-} /* if */
-else
-{
-// In this case we cannot shorten the key because only
-// values are found without further child nodes.
-// result.getRoot().addChild(visitor.getClone());
-} /* else */
+} /* if */
} /* for */
return (result.isEmpty()) ? new HierarchicalConfiguration() : result;
1.5 +2 -6
jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java
Index: PropertiesConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- PropertiesConfiguration.java 27 Feb 2004 17:41:35 - 1.4
+++ PropertiesConfiguration.java 28 Mar 2004 14:43:04 - 1.5
@@ -21,9 +21,6 @@
import java.net.MalformedURLException;
import java.net.URL;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
import org.apache.commons.lang.StringUtils;
/**
@@ -46,8 +43,7 @@
extends BasePropertiesConfiguration
implements Configuration
{
-/** Static logger */
-Log log = LogFactory.getLog(PropertiesConfiguration.class);
+
/** File separator. */
protected String fileSeparator = System.getProperty(file.separator);
1.3 +1 -1
jakarta-commons/configuration/src/java/org/apache/commons/configuration/ConfigurationUtils.java
Index: ConfigurationUtils.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/ConfigurationUtils.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ConfigurationUtils.java 27 Feb 2004 17:41:35 - 1.2
+++ ConfigurationUtils.java 28 Mar 2004 14:43:04 - 1.3
@@ -33,7 +33,7 @@
public class ConfigurationUtils
{
/** File separator. */
-protected static String fileSeparator = System.getProperty(file.separator);
+protected static final String fileSeparator =
System.getProperty(file.separator);
private ConfigurationUtils()
{
1.6 +11 -2
jakarta-commons/configuration/src/java/org/apache/commons/configuration/BasePropertiesConfiguration.java
Index: BasePropertiesConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/BasePropertiesConfiguration.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- BasePropertiesConfiguration.java 13 Mar 2004 17:34:37 - 1.5
+++ BasePropertiesConfiguration.java 28 Mar 2004 14:43:04 - 1.6
@@ -229,9 +229,10 @@
public void save(String filename)
throws ConfigurationException
{
+PropertiesWriter out = null;
File file = new File(filename);
try {
- PropertiesWriter out = new PropertiesWriter(file);
+ out = new PropertiesWriter(file);
out.writeComment(written by PropertiesConfiguration);
out.writeComment(new Date().toString());
@@ -246,6 +247,14 @@
out.close();
}
catch (IOException ioe){
+try {
+if (out !=null){
+out.close();
+}
+}
+catch (IOException ioe2){
+
+}
cvs commit: jakarta-commons/configuration/xdocs changes.xml
epugh 2004/03/28 06:43:20 Modified:configuration/xdocs changes.xml Log: Update changes Revision ChangesPath 1.16 +3 -0 jakarta-commons/configuration/xdocs/changes.xml Index: changes.xml === RCS file: /home/cvs/jakarta-commons/configuration/xdocs/changes.xml,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- changes.xml 9 Mar 2004 10:31:31 - 1.15 +++ changes.xml 28 Mar 2004 14:43:20 - 1.16 @@ -8,6 +8,9 @@ body release version=1.0-dev-4 date= action dev=ebourg type=update +Refactored JNDIConfiguration to use AbstractConfiguration. + /action + action dev=ebourg type=update Fixed bug 27427 by refactoring out the subset logic into a SubsetConfiguration. /action action dev=oheger type=fix - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration project.xml
epugh 2004/03/28 06:44:18 Modified:configuration project.xml Log: Exclude TestJNDIConfiguration until we get a better mock JNDI provider. Revision ChangesPath 1.12 +2 -1 jakarta-commons/configuration/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons/configuration/project.xml,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- project.xml 13 Mar 2004 17:22:48 - 1.11 +++ project.xml 28 Mar 2004 14:44:18 - 1.12 @@ -264,6 +264,7 @@ excludes exclude**/TestBasePropertiesConfiguration.java/exclude exclude**/NonStringTestHolder.java/exclude +exclude**/TestJNDIConfiguration.java/exclude /excludes resources resource - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[ID] UUID in JDK 1.5
FYI: http://java.sun.com/j2se/1.5.0/jcp/beta1/apidiffs/java/util/UUID.html Seems to me that it would make sense to have code in our library that provides a compatible interface. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Commons [2004/03/28]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 6508|Ass|Enh|2002-02-17|HttpClient now supports proxyHost and proxyPort - | | 6826|Ass|Enh|2002-03-04|Need to have xml files validated against DTDs as p| | 6829|Ass|Enh|2002-03-04|Allow easier way of user specified tests | | 7069|Ass|Enh|2002-03-13|DTD and DOM Validators| | 7135|Opn|Enh|2002-03-14|[beanutils] Misleading error message when beaninfo| | 7226|Opn|Enh|2002-03-19|Nested Bean Collection| | 7367|New|Nor|2002-03-22|[unspecified] ServiceManager not actually serializ| | 7465|New|Nor|2002-03-25|Need better 'dist' build | | 7981|Ver|Nor|2002-04-11|[codec][PATCH] add 2 new methods for encoding stri| | 8140|Ver|Nor|2002-04-16|Incorrect credentials loop infinitely | |10319|New|Enh|2002-06-28|Instantiate property if null in form bean | |10543|Ass|Enh|2002-07-08|generate ant task automatically from CLI | |10793|New|Enh|2002-07-15|User definable default headers support| |10810|New|Enh|2002-07-15|Response handlers | |10813|New|Enh|2002-07-15|RFC 2965 Support (Port sensitive cookies) | |10815|New|Enh|2002-07-15|Instrumentation for Timings | |10957|New|Nor|2002-07-18|Change Header/HeaderElement to handle a list as th| |12807|New|Nor|2002-09-19|[PATCH] x 2 Update build.xml to use commons-loggin| |13031|New|Enh|2002-09-26|Use regular expression (regex) pattern matching fo| |13390|New|Nor|2002-10-07|ResponseHeaderHandler and ResponseHeaderValidator | |13426|New|Enh|2002-10-08|[PATCH] xml-reference.xml responseHeader addition | |13743|Opn|Enh|2002-10-17|Need getPropertyType(Class theClass, String propNa| |14036|New|Enh|2002-10-29|MultipartPostMethod does not check for error messa| |14262|Opn|Maj|2002-11-05|SAXBeanWriter produces invalid XML| |14394|Ver|Nor|2002-11-08|Excessive exceptions log under security manager | |14471|Opn|Enh|2002-11-12|validator-rules.xml JavaScript fails when field no| |14667|Ver|Maj|2002-11-19|PropertyUtils.copyProperties does not copy to Dyna| |15082|Ass|Enh|2002-12-04|[lang] elapsed time formatting utility method | |15451|Opn|Enh|2002-12-17|Multiple mapped properties not possible / Direct m| |15519|Ver|Maj|2002-12-19|PropertyUtils.getPropertyType() for java.util.Coll| |15534|New|Nor|2002-12-19|Inadequate HTTP proxy server support in HttpClient| |15744|New|Nor|2002-12-31|[unspecified] Scaffold ResultSet used after statem| |15895|Unc|Nor|2003-01-08|In BeanMap all properties are writable (some with | |16038|Opn|Enh|2003-01-13|[beanutils] LocaleBeanUtils.copyProperties() does | |16124|New|Nor|2003-01-15|isHttp11 should have HttpClient scope | |16132|New|Maj|2003-01-15|[Jelly] core:file convert html to lt;htmlgt; | |16394|New|Enh|2003-01-24|Enhance the IndexedListProperty to handle nested l| |16525|Opn|Enh|2003-01-29|BeanUtils.setProperty is over-zealous at convertin| |16600|New|Nor|2003-01-30|JUnitTestAdapter throws SAXException because no DT| |16744|New|Enh|2003-02-04|Allow special positioning of error messages | |16859|New|Nor|2003-02-06|[unspecified] Can't supply a javax.mail.Session to| |16873|New|Enh|2003-02-07|Specifying a different latka.properties file | |16907|New|Enh|2003-02-08|Introduce Aspect oriented programming | |16920|Opn|Enh|2003-02-10|Declaration of Locale (language/country) in valida| |17002|Opn|Enh|2003-02-12|Problem with index property | |17102|New|Enh|2003-02-15|Can't embed characters in paramValue data. | |17306|Opn|Enh|2003-02-22|extend field tag with forward attribute for er| |17327|New|Enh|2003-02-24|[collections] Add BlockingQueue queue implementati| |17416|New|Enh|2003-02-26|Send InputStreams instead of files in MultipartPos| |17501|New|Enh|2003-02-27|Add dynamic discovery of mapped properties to Prop| |17619|New|Nor|2003-03-03|[jelly] ClassLoader Problems with XMLParser and XM|
DO NOT REPLY [Bug 27747] - [configuration] ClassCastException not thrown by getBoolean()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27747. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27747 [configuration] ClassCastException not thrown by getBoolean() --- Additional Comments From [EMAIL PROTECTED] 2004-03-28 15:18 --- Alessio, I think that the correct behavior needs to be either throw the NoSuchElementException if the value is missing, or the ClassCastException if the value can't be casted. However, can you submit a patch that applies this logic to ALL the various methods of AbstractConfiguration, like getDouble, getShort etc? I don't want to have getBoolean operating differently from the others. Also, a unit test would be good to verify which Exception was thrown. Thanks! Eric - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration PropertiesConfiguration.java
epugh 2004/03/28 07:34:23
Modified:configuration/src/java/org/apache/commons/configuration
PropertiesConfiguration.java
Log:
Bug in closing stream spotted by Stephen Colebourne.
Revision ChangesPath
1.6 +4 -2
jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java
Index: PropertiesConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- PropertiesConfiguration.java 28 Mar 2004 14:43:04 - 1.5
+++ PropertiesConfiguration.java 28 Mar 2004 15:34:23 - 1.6
@@ -99,7 +99,9 @@
public void load(String fileName) throws ConfigurationException
{
try {
- load(getPropertyStream(fileName));
+ InputStream is = getPropertyStream(fileName);
+ load(is);
+ is.close();
}
catch (IOException ioe){
throw new ConfigurationException(Could not load from file +
fileName,ioe);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: [configuration] Closing opened input streams
Hi Stephen, I think I have just resolved the problem! Thanks for sending it. Eric -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 17, 2004 9:30 PM To: Jakarta Commons Developers List Subject: [configuration] Closing opened input streams A bug was reported against [collections] ExtendedProperties http://issues.apache.org/bugzilla/show_bug.cgi?id=27737 I found that the input stream created in the constructor was not closed. I just checked PropertiesConfiguration, and the load() methods seem to have the same problem. Stephen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration maven.xml
epugh 2004/03/28 08:01:30 Modified:configuration maven.xml Log: Mimic lang with license Revision ChangesPath 1.2 +15 -5 jakarta-commons/configuration/maven.xml Index: maven.xml === RCS file: /home/cvs/jakarta-commons/configuration/maven.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- maven.xml 23 Dec 2003 15:09:05 - 1.1 +++ maven.xml 28 Mar 2004 16:01:29 - 1.2 @@ -1,10 +1,20 @@ ?xml version=1.0? -!-- = -- -!-- -- -!-- $Id$ -- -!-- -- -!-- = -- +!-- +Copyright 2002-2004 The Apache Software Foundation. + +Licensed under the Apache License, Version 2.0 (the License); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an AS IS BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +-- project default=jar:jar !-- NonStringTestHolder.java contains tests shared by JUnit and Cactus - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration project.properties
epugh 2004/03/28 08:01:56 Modified:configuration project.properties Added: configuration/conf MANIFEST.MF Log: Add Manifest.mf Revision ChangesPath 1.1 jakarta-commons/configuration/conf/MANIFEST.MF Index: MANIFEST.MF === Extension-Name: org.apache.commons.configuration Specification-Title: Jakarta Commons Configuration Specification-Vendor: Apache Software Foundation Specification-Version: 1.0 Implementation-Vendor: Apache Software Foundation Implementation-Title: org.apache.commons.configuration Implementation-Version: 1.0 1.7 +1 -0 jakarta-commons/configuration/project.properties Index: project.properties === RCS file: /home/cvs/jakarta-commons/configuration/project.properties,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- project.properties8 Mar 2004 23:21:31 - 1.6 +++ project.properties28 Mar 2004 16:01:56 - 1.7 @@ -1,6 +1,7 @@ # --- # P R O J E C T P R O P E R T I E S # --- +maven.jar.manifest=conf/MANIFEST.MF maven.xdoc.jsl=../commons-build/commons-site.jsl maven.xdoc.date=left - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration project.xml
epugh 2004/03/28 08:02:10 Modified:configuration project.xml Log: bump version to rc 1 Revision ChangesPath 1.13 +2 -2 jakarta-commons/configuration/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons/configuration/project.xml,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- project.xml 28 Mar 2004 14:44:18 - 1.12 +++ project.xml 28 Mar 2004 16:02:10 - 1.13 @@ -10,7 +10,7 @@ pomVersion3/pomVersion namecommons-configuration/name idcommons-configuration/id - currentVersion1.0-dev-3/currentVersion + currentVersion1.0-rc1/currentVersion organization nameApache Software Foundation/name - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[configuration] Cutting a 1.0 Release Help Needed
Hi all, In response to a large number of posts I have recieved both on the mailing list and privately regarding when Commons Configuration 1.0 will be released, I have gone ahead and applied the last of the patches for bugs and I would like to cut the RC1 for Commons Configuration. The remaining issues in BugZilla are all enhancements or refactorings and should be applied post 1.0. At this point I am somewhat stuck at the checksum creation stage. I followed the directions from this document: http://jakarta.apache.org/commons/releases/release.html for steps 1 through 3. However, because Configuration is Maven based, when I run 'maven dist' SSH'ed into jakarta.apache.org I get an error about maven not existing. Ant works, however it tanks on the junit task. Do I need to do steps 4,5,6 SSH'ed in, or can I do them locally and update the results? I have placed some candidates at http://jakarta.apache.org/~epugh/builds/. If the Release Candidate 1 files look good to people, then I will follow the steps here: http://jakarta.apache.org/commons/releases/release.html to cut the 1.0 release. However, I am on winxp, and haven't followed the process of creating md5 checksum's etc.. However, if some other kind soul wishes to play the Release Manager role, I'd be much obliged to them. Eric - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript validateByte.js validateCreditCard.js validateDate.js validateEmail.js validateFloat.js validateFloatRange.js validateIntRange.js validateInteger.js validateMask.js validateMaxLength.js validateMinLength.js validateRequired.js validateShort.js validateUtilities.js
rleland 2004/03/28 08:53:21
Modified:validator/src/javascript/org/apache/commons/validator/javascript
validateByte.js validateCreditCard.js
validateDate.js validateEmail.js validateFloat.js
validateFloatRange.js validateIntRange.js
validateInteger.js validateMask.js
validateMaxLength.js validateMinLength.js
validateRequired.js validateShort.js
validateUtilities.js
Log:
Use DOM Level 1 Compatable calls for getting attributes
Revision ChangesPath
1.9 +2 -3
jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateByte.js
Index: validateByte.js
===
RCS file:
/home/cvs/jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateByte.js,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- validateByte.js 25 Mar 2004 04:56:11 - 1.8
+++ validateByte.js 28 Mar 2004 16:53:21 - 1.9
@@ -11,8 +11,7 @@
var focusField = null;
var i = 0;
var fields = new Array();
-var formName = getAttribute(form,name);
-
+var formName = form.getAttributeNode(name);
oByte = eval('new ' + formName.value + '_ByteValidations()');
for (x in oByte) {
1.8 +2 -2
jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js
Index: validateCreditCard.js
===
RCS file:
/home/cvs/jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- validateCreditCard.js 25 Mar 2004 04:56:11 - 1.7
+++ validateCreditCard.js 28 Mar 2004 16:53:21 - 1.8
@@ -11,7 +11,7 @@
var focusField = null;
var i = 0;
var fields = new Array();
-var formName = getAttribute(form,name);
+var formName = form.getAttributeNode(name);
oCreditCard = eval('new ' + formName.value + '_creditCard()');
1.10 +2 -2
jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateDate.js
Index: validateDate.js
===
RCS file:
/home/cvs/jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateDate.js,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- validateDate.js 25 Mar 2004 04:56:11 - 1.9
+++ validateDate.js 28 Mar 2004 16:53:21 - 1.10
@@ -11,7 +11,7 @@
var focusField = null;
var i = 0;
var fields = new Array();
- var formName = getAttribute(form,name);
+ var formName = form.getAttributeNode(name);
oDate = eval('new ' + formName.value + '_DateValidations()');
1.9 +6 -3
jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateEmail.js
Index: validateEmail.js
===
RCS file:
/home/cvs/jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateEmail.js,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- validateEmail.js 25 Mar 2004 04:56:11 - 1.8
+++ validateEmail.js 28 Mar 2004 16:53:21 - 1.9
@@ -11,7 +11,8 @@
var focusField = null;
var i = 0;
var fields = new Array();
-var formName = getAttribute(form,name);
+var formName = form.getAttributeNode(name);
+
oEmail = eval('new ' + formName.value + '_email()');
@@ -88,4 +89,6 @@
return false;
}
return true;
-}
\ No newline at end of file
+}
+
+
\ No newline at end of file
1.11 +2 -2
jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateFloat.js
Index: validateFloat.js
===
RCS file:
/home/cvs/jakarta-commons/validator/src/javascript/org/apache/commons/validator/javascript/validateFloat.js,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- validateFloat.js 25 Mar 2004 04:56:11 - 1.10
+++ validateFloat.js 28 Mar 2004 16:53:21 - 1.11
@@ -11,7 +11,7 @@
var focusField = null;
var i = 0;
var fields = new Array();
-var formName = getAttribute(form,name);
+ var formName =
Re: [configuration] Cutting a 1.0 Release Help Needed
Eric Pugh wrote: Hi all, In response to a large number of posts I have recieved both on the mailing list and privately regarding when Commons Configuration 1.0 will be released, I have gone ahead and applied the last of the patches for bugs and I would like to cut the RC1 for Commons Configuration. Does that mean, the DOM JDK 1.4 support is not included in 1.0 ? Regards, Jörg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28004] New: - [configuration]Documentation updates
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28004 [configuration]Documentation updates Summary: [configuration]Documentation updates Product: Commons Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Configuration AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In the howto sections of the configuration documentation there are still some inconsistencies caused by lost files during the move from sandbox to proper. This patch updates the documentation. In the XML howto document some examples for configuration definition files used the className attribute. The patch replaces this by the hierarchicalDom4J element. The ConfigurationFactory howto contained the section about HierarchicalConfiguration. I removed this because it is doublicate (also contained in the XML howto where I think it belongs). Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28004] - [configuration]Documentation updates
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28004 [configuration]Documentation updates --- Additional Comments From [EMAIL PROTECTED] 2004-03-28 18:06 --- Created an attachment (id=11023) Documentation patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [subversion] Subversion for eXtreme Refactoring ( was [HiveMind] Discuss: CVS or Subversion?)
On Sat, 27 Mar 2004, Alex Karasulu wrote: Hi, Sorry to get into this one late. Had too though since I'm one of those directory folks :-). I'm finally finding that I can get svn installed on suse and os x [it's not without issue] and am looking forward to migrating to svn over the next year in all my endeavours. Some questions on the below though: Subversion for eXtreme Refactoring == Subversion affords us a more liberty. Besides the obvious renaming and deleting of files and directories without the loss of history etcetera, Never really had that much pain doing this on the CVS server. One of the pluses CVS had was that the system was easily understandable and if CVS did not support a feature, you could often use something like perl to gain said feature. CVS hackery was effectively an easy way to extend CVS. Lookinjg at the SVN repo, it looks a lot more complicated and will require far more in the way of effort to change, ie) writing [I assume] berkely db client code. we find that our development style can be geared towards XP. These features are changing our outlook. We are no longer worried about chewing up a repository to re-factor on a whim. I personally have re-factored conservatively on CVS because there was no way to easy way to cleanup the consequences afterwards: loss of history and empty directories. But now there are no inhibitions with subversion so we're free to be liberal with re-factoring - it's the way we code. Bang something rough out and then gradually reshape it as we discover new things along the way. Plus the ease of branching by just copying directories and merging them makes large re-factoring efforts without disrupting development a breeze. These features have for these reasons Branching and tagging in svn confuse me. People talk about them being easier, but the difficulty of such things in CVS is not the action, but the management of multiple branches of code. All i see in SVN so far is a different way [which may be faster on the server, but who cares unless there are lots of binary files] and not an improved way. Is there any concept of live vs dead branches? Any way to implement naming conventions? R/W setting of branches? Also, branches seem to have less in the way of support as you now have to come up with your own filing hierarchy to contain them. While the new SVN structure seems simpler, which might lead to a more easily implemented powerful system, there's nothing to crow about yet. Going back to CVS is not an option for me after tasting development using subversion: it would mean going backwards. The best description I can give of the having to use CVS after using subversion is when I have to use dial up rather than high speed internet access. It's just frustrating. Your anology reminds me of something that frustrated me. Subversion apparantly has a different commit method, it sends patches up and not full files [?]. This makes for less bandwidth usage. Anyways, the bit that frustrates me is the SVN seems unable to work with basic WebDAV clients, which I think quite a few of us assumed when it talked about using WebDAV [yeah, I don't grokk DAV]. Anyway, this means that I can't mount a subversion repo as a virtual drive and commit by simply copying a new version of a file in, or editing it, and I can't use a tool like Dreamweaver to change it. It does work in a read-only way though, just errors on commits. Subversion is the future that fits the latest paradigms in software development. I cannot stress the importance of the positive effects it will have for development here at the ASF not to mention for infrastructure. And ultimately the transition will have to happen at some point. From what I understand, SVN is written by the maintainers of CVS? Which implies that CVS is dead and SVN is basically a very non-backwards compatible CVS-2. That's the main reason to move for me. So far, the only improvements I've found are the ability to move files, a slightly nicer set of messages when committing and 'svn status' replacing 'cvs -nq update'. A lot of it feels more generic, which can be a good thing. BTW in the past I have been a CVS consult and lived and swore by it since it put food on the table. I cannot overstate how emphatic I have been regarding CVS. It was a religion for me. Now after years of using CVS, I swear by subversion and that's got to be worth something when said by a CVS diehard. I suspect complaints like but it's too complicated, it's not well supported etc were heard by RCS die-hards when CVS came out too :) I expect to not be using CVS in a year [home,apache,osjava,work], but it's going to take a good chunk of time to transform my cvs-admin knowledge over to svn. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28005] New: - Infinite Loop in Command-Line processing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28005. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28005 Infinite Loop in Command-Line processing Summary: Infinite Loop in Command-Line processing Product: Commons Version: 2.0 Alpha 1 Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: CLI AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] In some cases, CLI-2 hangs in an infinite loop. I've created the following Group: -- snip -- Option inputFormatOption = optionBuilder.withLongName(input-format) .create(); Argument argument = argumentBuilder.withName(file) .create(); Group children = groupBuilder.withName(options) .withOption(inputFormatOption) .create(); Command command = commandBuilder.withName(convert) .withChildren(children) .withArgument(argument) .create(); Group root = groupBuilder.withName(commands) .withOption(createConvertCommand()) .create(); -- snip -- When I use the group: --snip-- Parser parser = new Parser(); parser.setGroup(root); parser.parse(args); -- snip and use the following command line: convert test.txt --input-format a the parser hangs in an infinite loop. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28005] - [CLI] Infinite Loop in Command-Line processing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28005. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28005 [CLI] Infinite Loop in Command-Line processing [EMAIL PROTECTED] changed: What|Removed |Added Summary|Infinite Loop in Command- |[CLI] Infinite Loop in |Line processing |Command-Line processing - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [digester] can't resolve relative entities ?
hi paul On 27 Mar 2004, at 00:31, Paul Libbrecht wrote: Dear Digester-Gurus... While trying really much to resolve the possible responsability of a buggy dom4j in errors to resolve entities in maven project parsing, I finally realize that Digester may be the reason. We start with a guess: Digester.parse(File) is weird (around lines 1527...): it doesn't store, at all, the reference to the file but still offers himself as EntityResolver. How can it resolve an entity if it doesn't know the path ?? in many ways, digester builds a more user-friendly interface on top of SAX. the usual philosophy is to offer easy, out-of-the-box support for the most common use cases and then offer access to SAX for those who need more sophisticated solutions. entity resolution is a good example of this. digester offers simple support for common use cases by offering itself as the default entity resolving. digester maintains a simple map of publicIDs to URLs and a method for users (and digester) to register them. though this is better than the default adopted by most parsers, this approach has many limitations. the standard advice for users who need more sophisticated support is register a separate EntityResolver. (the business of creating and maintaining DTD catalog programs is best left to specialist components.) The pathology appears very while building taglibs of jelly: the project.xml of each taglibs, extends ../taglib-project.xml which itself should reference, by means of DTD-internal-subset ../commonDeps.ent. As this is buggy, the current jelly CVS contains a copy of commonDeps.ent. i've taken a fresh look at the specs and i think that buggy is probably too strong a word. '../taglib-project.xml' is not an URI and so parsers can legitimately refuse to resolve it but most common parsers interpret this as a path relative to the file (i think, please correct me if i'm wrong). i've taken a look at the digester source and it's probable that digester does not allow parsers to apply this feature since it will always interpret a system id as an URI and then rely on java to find it. it should be possible to alter the entity resolution code so that (when the URI is a relative file url) the java relative path is tested first and null returned if the file does not exist allowing the parser to use it's default resolution code which (i think) should find the file relative to the file path. does this sound like it would fix the jelly problems? and can anyone else see any problems with this approach? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [subversion] Subversion for eXtreme Refactoring ( was [HiveMind] Discuss: CVS or Subversion?)
CVS hackery was effectively an easy way to extend CVS. You may be a CVS guru, but do you really want to know how many times someone has crapped CVS by playing around with things they don't understand? Not directly related, perhaps, but we had to fix a problem just this past week where someone started using the live CVS repository on minotaur for their personal workspace. Lookinjg at the SVN repo, it looks a lot more complicated and will require far more in the way of effort to change, ie) writing [I assume] berkely db client code. Subversion has several well-defined interfaces, including WebDAV/DeltaV. Branching and tagging in svn confuse me. Branches and tags are just lightweight copies. A branch and a tag are the same thing. Placing them under branches/ and tags/ are just conventions. To quote the Subversion book: Subversion has no internal concept of a branch-only copies. When you copy a directory, the resulting directory is only a branch because you attach that meaning to it. You may think of the directory differently, or treat it differently, but to Subversion it's just an ordinary directory that happens to have been created by copying. To tag something, you make a copy of it. If you started editing the copy it is a branch, otherwise it is a tag. The important thing is that you used Subversion to copy, so that it tracks the file identity. The book, http://svnbook.red-bean.com/, should answer many of your questions. R/W setting of branches? We use mod_authz_svn for that purpose. the bit that frustrates me is the SVN seems unable to work with basic WebDAV clients, which I think quite a few of us assumed when it talked about using WebDAV I can't mount a subversion repo as a virtual drive and commit by simply copying a new version of a file in There is support for auto-versioning, but we may have it disabled. One of the issues with auto-versioning is that you don't get commit comments. I believe that DeltaV is the way out of it, but you would have to talk with the Subversion folks. In any event, it is a current limitation, not a design point. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator project.properties
dgraham 2004/03/28 11:30:16
Modified:validator project.properties
Log:
Added maven.changelog.range property.
Revision ChangesPath
1.7 +6 -16 jakarta-commons/validator/project.properties
Index: project.properties
===
RCS file: /home/cvs/jakarta-commons/validator/project.properties,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- project.properties29 Feb 2004 09:48:28 - 1.6
+++ project.properties28 Mar 2004 19:30:16 - 1.7
@@ -12,26 +12,17 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# ---
-# P R O J E C T P R O P E R T I E S - Modeled after Turbine project.properties
-#
-# $Id$
-#
-# Do not change this file. Please use build.properties in this directory
-# to do site or installation specific changes to the project build.
-# ---
-#
# You can uncomment this if you're willing to use the unofficial
# Validator-specific jar repository at the Validator site. This will
# contain all the jars needed to build Validator, even if a jar
# is missing on ibiblio
-#
+
#maven.repo.remote=http://www.ibiblio.org/maven/,http://jakarta.apache.org/commons/validator/repo
maven.checkstyle.properties = conf/share/ValidatorCheckStyle.xml
-#keep ant maven directories seperate.
+# Keep ant and maven directories seperate.
maven.build.dir=m-target
# Include legacy javadoc in build
@@ -39,19 +30,18 @@
# commons site LF
maven.xdoc.jsl=../commons-build/commons-site.jsl
-
-# No powered by Image
maven.xdoc.poweredby.image=
-
-# display the date on the site
maven.xdoc.date = left
-# Display the version the web site is documenting
maven.xdoc.version = ${pom.currentVersion}
compile.debug = on
compile.optimize = off
compile.deprecation = on
maven.compile.deprecation = on
+
+#maven.test.skip = true
+#maven.test.failure.ignore = true
+maven.changelog.range = 120
# ---
# N I G H T L Y B U I L D P R O P E R T I E S
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator project.xml
dgraham 2004/03/28 11:31:20 Modified:validator project.xml Log: Commented maven-tasklist-plugin report because it has no output. Revision ChangesPath 1.35 +2 -2 jakarta-commons/validator/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons/validator/project.xml,v retrieving revision 1.34 retrieving revision 1.35 diff -u -r1.34 -r1.35 --- project.xml 27 Mar 2004 23:49:42 - 1.34 +++ project.xml 28 Mar 2004 19:31:20 - 1.35 @@ -288,11 +288,11 @@ reportmaven-javadoc-plugin/report reportmaven-jxr-plugin/report reportmaven-junit-report-plugin/report -reportmaven-tasklist-plugin/report +!-- reportmaven-tasklist-plugin/report -- reportmaven-pmd-plugin/report reportmaven-simian-plugin/report reportmaven-faq-plugin/report -!--reportmaven-clover-plugin/report-- +!-- reportmaven-clover-plugin/report -- /reports /project - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/xdocs changes.xml tasks.xml
dgraham 2004/03/28 11:32:40 Modified:validator/xdocs tasks.xml Added: validator/xdocs changes.xml Log: Moved release note info from tasks.xml to new changes.xml file used by the maven-changes-plugin. Revision ChangesPath 1.11 +0 -208jakarta-commons/validator/xdocs/tasks.xml Index: tasks.xml === RCS file: /home/cvs/jakarta-commons/validator/xdocs/tasks.xml,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- tasks.xml 28 Mar 2004 00:07:53 - 1.10 +++ tasks.xml 28 Mar 2004 19:32:40 - 1.11 @@ -99,214 +99,6 @@ /ul /subsection /section -section name='Completed' -subsection name='Since 1.1.0 Release' -ul - li -Add javadoc to javascript, and use - a href=http://jsdoc.sf.net; jsdoc/a to process it. - /li - li -Ignore validation criteria when field is disabled for all field types. - /li - li - Add required check for single checkbox. - /li - li - Let max/min length also cover passwords fields. Don't use these for checking login pages, - only when the user is modifying the password. - /li - li - Added Field.getArgs(String) to make it easier to retrieve all of the Args for a given validator. - /li - li - Modify javascript to honor datapattern option. - /li - li - Add ability of required to handle checkboxes, radio,select-one, and select-multiple field types. - /li - li - Add ability to use required condition on array types like checkboxes. - /li -/ul -/subsection -subsection name='Since 1.0.2 Release' -ul - li - Move Digester rule configuration to XML file and remove ValidatorResourcesInitializer. - ValidatorResources now knows how to initialize itself. - /li - li - Clean up scopes of methods and variables. - /li - li - Make Arg system more flexible to allow any number of args in a message. - /li - li - Validate validation.xml files while initializing a Validator to alert developers to configuration - errors. - /li - li - Refactored codeGenericValidator/code methods into reusable objects. These include: - CreditCardValidator, EmailValidator, DateValidator, and UrlValidator. - /li - /ul -/subsection -/section -section name='Deprecated' -subsection name='Since 1.0.2 Release' - pSee the javadoc for details and replacements./p -ul -li - The lt;arg0-3gt; elements have been replaced with a single lt;arggt; element - with a new codeposition/code attribute. Setting position to 0 is the equivalent - of an lt;arg0gt; element. - /li - li - codeArg.getResource()/code - /li - li - codeCreditCardValidator.isValidPrefix()/code - /li - li - codeField.ARG_DEFAULT/code - /li - li - codeField.hDependencies/code - /li - li - codeField.hArg0 - Field.hArg3/code - /li - li - codeField.addArg0() - Field.addArg3()/code - /li - li - codeField.getArg0() - Field.getArg3()/code - /li - li - codeField.addVarParam()/code - /li - li - codeField.process()/code - /li - li - codeField.processMessageComponents()/code - /li - li - codeField.getDependencies()/code - /li - li - codeForm.getFieldMap()/code - /li - li - codeForm.process()/code - /li - li - codeFormSet.addConstant()/code - /li - li - codeFormSet.addConstantParam()/code - /li - li - codeFormSet.getForm(Object)/code - /li - li -
cvs commit: jakarta-commons/jelly/jelly-tags/jaxme .cvsignore
rdonkin 2004/03/28 11:33:42 Modified:jelly/jelly-tags/jaxme .cvsignore Log: Generalized log exclusion. Revision ChangesPath 1.2 +1 -1 jakarta-commons/jelly/jelly-tags/jaxme/.cvsignore Index: .cvsignore === RCS file: /home/cvs/jakarta-commons/jelly/jelly-tags/jaxme/.cvsignore,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- .cvsignore25 Mar 2004 22:02:11 - 1.1 +++ .cvsignore28 Mar 2004 19:33:42 - 1.2 @@ -1,2 +1,2 @@ target -maven.log +*.log - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator RELEASE-NOTES.readme
dgraham 2004/03/28 11:34:14 Modified:validator RELEASE-NOTES.readme Log: Point to changes-report.html for release notes. Revision ChangesPath 1.2 +1 -1 jakarta-commons/validator/RELEASE-NOTES.readme Index: RELEASE-NOTES.readme === RCS file: /home/cvs/jakarta-commons/validator/RELEASE-NOTES.readme,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- RELEASE-NOTES.readme 15 Dec 2003 06:10:51 - 1.1 +++ RELEASE-NOTES.readme 28 Mar 2004 19:34:14 - 1.2 @@ -4,4 +4,4 @@ and - http://jakarta.apache.org/commons/validator/tasks.html \ No newline at end of file + http://jakarta.apache.org/commons/validator/changes-report.html \ No newline at end of file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/xdocs changes.xml
dgraham 2004/03/28 11:48:28 Modified:validator/xdocs changes.xml Log: Added 1.1.2 release notes. Revision ChangesPath 1.2 +33 -2 jakarta-commons/validator/xdocs/changes.xml Index: changes.xml === RCS file: /home/cvs/jakarta-commons/validator/xdocs/changes.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- changes.xml 28 Mar 2004 19:32:40 - 1.1 +++ changes.xml 28 Mar 2004 19:48:28 - 1.2 @@ -40,8 +40,39 @@ release version=1.1.2 (alpha) date=in CVS action dev=rleland type=update - - /action +Allow multiple forms to be on the same page by +generating a unique variable name based on form name. +PR# 17667 + /action + action dev=rleland type=add +Validate file extensions for file uploads. PR# 26585 + /action + action dev=rleland type=add +Add Support for hidden fields in javascript +validations. PR# 26584 + /action + action dev=dgraham type=update +The framework will convert checked exceptions into +ValidatorExceptions so any ValidatorException thrown out +of the framework indicates a 'system' exception that +stops validation processing. If a pluggable validation +method throws a ValidatorException it will be rethrown +and passed out of the framework. Any other exception from +a pluggable validation method is still considered a validation +failure rather than a system exception to maintain backwards +compatibility. PR# 24369 + /action + action dev=dgraham type=add +Added a more flexible card validation system that doesn't +require CreditCardValidator to support every brand of +credit card. PR# 25869 + /action + action dev=dgraham type=update +Throw RuntimeException if clone fails instead of InternalError. + /action + action dev=dgraham type=add + Added Flags.clear(). + /action /release release version=1.1.1 (alpha) date=2003-12-15 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [collections] ReferenceMap changed for WeakIdentityMap but now broken
Janek Bogucki wrote: On Wed, 2004-03-24 at 21:57, Janek Bogucki wrote: At the end there is this which you did not mention in your original post so it might be new information [junit] Testcase: testPurgeValues took 4.903 sec [junit] Caused an ERROR [junit] null [junit] java.lang.OutOfMemoryError [junit] no stack trace available [junit] Testcase: testPurgeValues I now realize that this is actually how the test is intended to work. Sorry for the noise. It looks to me as though the intention would be to fail with Max iterations reached before resource released which happens if you decrease the bound on the loop to, say 20. This should probably be changed. The null test that is failing is valueReference.get() == null I have not fully grokked the code, so the following is speculation, but might be helpful. The test setup is WeakReference keyReference = new WeakReference(key); WeakReference valueReference = new WeakReference(value); Map testMap = new ReferenceMap(ReferenceMap.WEAK, ReferenceMap.HARD, true); so the valueReference release has to be triggered by releasing the key reference, but in ReferenceEntry.purge(ref), there is no check for purgeValues. Phil -Janek - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [configuration] Cutting a 1.0 Release Help Needed
To my mind, yes... I know that at least one objection was raised, and instead of stalling or rushing a decision, I'd rather delay it.. There is nothing that says that 1.1 has to take 6 months to release or anything like that! I would rather have a 1.0 go out, followed in a month by a 1.1. It would give us a chance to demonstrate to the community that we are actively releaseing.. What's the motto? Release often Release early? Eric -Original Message- From: news [mailto:[EMAIL PROTECTED] Behalf Of Jörg Schaible Sent: Sunday, March 28, 2004 5:59 PM To: [EMAIL PROTECTED] Subject: Re: [configuration] Cutting a 1.0 Release Help Needed Eric Pugh wrote: Hi all, In response to a large number of posts I have recieved both on the mailing list and privately regarding when Commons Configuration 1.0 will be released, I have gone ahead and applied the last of the patches for bugs and I would like to cut the RC1 for Commons Configuration. Does that mean, the DOM JDK 1.4 support is not included in 1.0 ? Regards, Jörg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration build.xml
epugh 2004/03/28 11:56:08 Modified:configuration build.xml Log: Don't run broken JNDI test until we fix the jndi context provider Revision ChangesPath 1.6 +3 -1 jakarta-commons/configuration/build.xml Index: build.xml === RCS file: /home/cvs/jakarta-commons/configuration/build.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- build.xml 9 Mar 2004 19:37:31 - 1.5 +++ build.xml 28 Mar 2004 19:56:08 - 1.6 @@ -130,9 +130,11 @@ include name=**/*Test*.java /include exclude name=**/TestBasePropertiesConfiguration.java - /exclude + /exclude exclude name=**/NonStringTestHolder.java /exclude + exclude name=**/TestJNDIConfiguration.java + /exclude /fileset /batchtest /junit - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jelly/jelly-tags/jaxme/src/java/org/apache/commons/jelly/tags/jaxme package.html
rdonkin 2004/03/28 11:56:27 Added: jelly/jelly-tags/jaxme/src/java/org/apache/commons/jelly/tags/jaxme package.html Log: Package documentation for jelly:jaxme Revision ChangesPath 1.1 jakarta-commons/jelly/jelly-tags/jaxme/src/java/org/apache/commons/jelly/tags/jaxme/package.html Index: package.html === !-- Copyright 2002,2004 The Apache Software Foundation. Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -- html head /head body pA a href='http://java.sun.com/xml/jaxb/'JAXB/a tag library using the a href='http://ws.apache.org/jaxme'Apache JaxMe/a implementation. Tags are provided for marshalling java objects into xml and unmarshalling xml into java objects which will work with any JAXB implementation. The generation tag generates java objects which can be marshalled and unmarshalled by JaxMe and are specific to that implementation. /p /body /html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jelly/jelly-tags/jaxme project.xml
rdonkin 2004/03/28 11:57:15 Modified:jelly/jelly-tags/jaxme project.xml Log: Added longer description for use in jellydoc Revision ChangesPath 1.2 +5 -1 jakarta-commons/jelly/jelly-tags/jaxme/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons/jelly/jelly-tags/jaxme/project.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- project.xml 25 Mar 2004 22:03:40 - 1.1 +++ project.xml 28 Mar 2004 19:57:15 - 1.2 @@ -25,7 +25,11 @@ inceptionYear2004/inceptionYear packageorg.apache.commons.jelly.tags.jaxme/package logo/logo - descriptionJaxMe Tag Library/description + description + JaxMe Tag Library. Apache JaxMe is an open source generative xml-object binder. + Tags are provided that generate java objects from schema using JaxMe + and that will marshall and unmarshall any JAXB complient implementations. + /description shortDescriptionJaxMe Tag Library/shortDescription dependencies - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [jelly] improved tag self-documentation?
On 26 Mar 2004, at 23:13, Paul Libbrecht wrote: On 26-Mar-04, at 23:30 Uhr, robert burrell donkin wrote: i quite like the generation of documentation for tab libraries. i might even add some documentation about it (once i've mastered it ;). Robert, you're reaching the heaven of jelly mastery! Taglib-documentation is a part of wizardy that too little people have been entering thus far... (if i have reached jelly nirvana, it is only through blindly stumbling into there by accident. i fully expect to be forced to perform a long, arduous and esoteric quest to regain the place again after being thrown out by it's inhabitants...) i've commit a short guide. i haven't regenerated the site on jakarta (because i'm running a version of maven i rolled myself which does not produce the standard commons look and feel). whilst i've been looking into documenting the jaxme tags, it has struck me that maybe custom tags might be a good way to mark things such as those tags which are mandatory. You would need to add a x-doclet tag for this, or ? not sure :) i'd need to look into it. it's unlike i'll find time for this in the immediate future but i'll try to come back to this later. i think that it might also be useful to ignore the @return tag when the description is compiled (since it probably doesn't read too well). Try it... I wonder wether it doesn't make sense to summarize these kind of observations into a file... just as a draft. probably the best place for such a file would on the wiki - but the commons wiki needs to be moved to the new wiki sometime soon. a job for another day :) - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient TestHttpConnectionManager.java
mbecke 2004/03/28 13:06:24
Modified:httpclient/src/java/org/apache/commons/httpclient Tag:
HTTPCLIENT_2_0_BRANCH
MultiThreadedHttpConnectionManager.java
httpclient/src/test/org/apache/commons/httpclient Tag:
HTTPCLIENT_2_0_BRANCH
TestHttpConnectionManager.java
Log:
Added MultiThreadedHttpConnectionManager shutdown() and shutdownAll().
PR: 27589
Submitted by: Michael Becke
Reviewed by: Oleg Kalnichevski
Revision ChangesPath
No revision
No revision
1.17.2.8 +169 -15
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java
Index: MultiThreadedHttpConnectionManager.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/MultiThreadedHttpConnectionManager.java,v
retrieving revision 1.17.2.7
retrieving revision 1.17.2.8
diff -u -r1.17.2.7 -r1.17.2.8
--- MultiThreadedHttpConnectionManager.java 22 Feb 2004 18:21:13 -
1.17.2.7
+++ MultiThreadedHttpConnectionManager.java 28 Mar 2004 21:06:24 -
1.17.2.8
@@ -39,11 +39,12 @@
import java.lang.ref.WeakReference;
import java.net.InetAddress;
import java.net.SocketException;
-import java.util.Collections;
+import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedList;
import java.util.Map;
+import java.util.WeakHashMap;
import org.apache.commons.httpclient.protocol.Protocol;
import org.apache.commons.logging.Log;
@@ -75,7 +76,7 @@
* A mapping from Reference to ConnectionSource. Used to reclaim resources
when connections
* are lost to the garbage collector.
*/
-public static final Map REFERENCE_TO_CONNECTION_SOURCE =
Collections.synchronizedMap(new HashMap());
+private static final Map REFERENCE_TO_CONNECTION_SOURCE = new HashMap();
/**
* The reference queue used to track when HttpConnections are lost to the
@@ -88,9 +89,40 @@
*/
private static ReferenceQueueThread REFERENCE_QUEUE_THREAD;
-static {
-REFERENCE_QUEUE_THREAD = new ReferenceQueueThread();
-REFERENCE_QUEUE_THREAD.start();
+/**
+ * Holds references to all active instances of this class.
+ */
+private static WeakHashMap ALL_CONNECTION_MANAGERS = new WeakHashMap();
+
+/**
+ * Shuts down and cleans up resources used by all instances of
+ * MultiThreadedHttpConnectionManager. All static resources are released, all
threads are
+ * stopped, and [EMAIL PROTECTED] #shutdown()} is called on all live instaces
of
+ * MultiThreadedHttpConnectionManager.
+ *
+ * @see #shutdown()
+ */
+public static void shutdownAll() {
+
+synchronized (REFERENCE_TO_CONNECTION_SOURCE) {
+// shutdown all connection managers
+synchronized (ALL_CONNECTION_MANAGERS) {
+Iterator connIter = ALL_CONNECTION_MANAGERS.keySet().iterator();
+while (connIter.hasNext()) {
+MultiThreadedHttpConnectionManager connManager =
+(MultiThreadedHttpConnectionManager) connIter.next();
+connIter.remove();
+connManager.shutdown();
+}
+}
+
+// shutdown static resources
+if (REFERENCE_QUEUE_THREAD != null) {
+REFERENCE_QUEUE_THREAD.shutdown();
+REFERENCE_QUEUE_THREAD = null;
+}
+REFERENCE_TO_CONNECTION_SOURCE.clear();
+}
}
/**
@@ -120,10 +152,57 @@
source.connectionPool = connectionPool;
source.hostConfiguration = hostConfiguration;
-REFERENCE_TO_CONNECTION_SOURCE.put(
-connection.reference,
-source
-);
+synchronized (REFERENCE_TO_CONNECTION_SOURCE) {
+
+// start the reference queue thread if needed
+if (REFERENCE_QUEUE_THREAD == null) {
+REFERENCE_QUEUE_THREAD = new ReferenceQueueThread();
+REFERENCE_QUEUE_THREAD.start();
+}
+
+REFERENCE_TO_CONNECTION_SOURCE.put(
+connection.reference,
+source
+);
+}
+}
+
+/**
+ * Closes and releases all connections currently checked out of the given
connection pool.
+ * @param connectionPool the connection pool to shutdown the connections for
+ */
+private static void shutdownCheckedOutConnections(ConnectionPool
RE: [site] maven matters
FYI, I've updated [lang] and [codec] such that they build with RC2 without errors. Thank you, Gary -Original Message- From: robert burrell donkin [mailto:[EMAIL PROTECTED] Sent: Sunday, March 28, 2004 12:05 To: Jakarta Commons Developers List Subject: [site] maven matters a couple of questions (aimed at the developer community): 1 should we move onto maven rc2 (this would mean i could regenerate websites)? 2 is there any reason why we shouldn't move onto the mavenized site soon? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [site] maven matters
On 28 Mar 2004, at 22:52, Eric Pugh wrote: I'm all for it.. As part of this, should the docs on how to cut a release etc be updated to use Maven versus Ant? it's only the site generation that's (probably) going to be generated using maven. components will still be able to use ant as their main build and release tool. instructions about how to cut a release using maven would be a useful addition, though. - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[codec] Rename Binary to BinaryCodec?
Hello, I am not fond of the class name Binary as it sounds too much like a data-type and not a codec. I would like to rename the class to BinaryCodec. Since this is a new class since 1.2, there are no compatibility issues. Opinions? Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [site] maven matters
--- Emmanuel Venisse [EMAIL PROTECTED] wrote: - Original Message - From: David Graham [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, March 28, 2004 10:22 PM Subject: Re: [site] maven matters --- robert burrell donkin [EMAIL PROTECTED] wrote: a couple of questions (aimed at the developer community): 1 should we move onto maven rc2 (this would mean i could regenerate websites)? I had problems with the new xdoc plugin throwing errors so I rolled back to rc1. What's your problems? I installed rc2 and deleted my existing .maven directory. Then I ran 'maven clean site' on the Commons Validator project. I get a bunch of identical exceptions ending with: Caused by: java.lang.NullPointerException at org.apache.maven.html2xdoc.Html2XdocBean.shouldBreakPara(Html2XdocBean.java:288) at org.apache.maven.html2xdoc.Html2XdocBean.addNode(Html2XdocBean.java:273) at org.apache.maven.html2xdoc.Html2XdocBean.processNode(Html2XdocBean.java:136) at org.apache.maven.html2xdoc.Html2XdocBean.addSections(Html2XdocBean.java:118) at org.apache.maven.html2xdoc.Html2XdocBean.convert(Html2XdocBean.java:96) ... 63 more Followed by this at the very end: BUILD FAILED File.. file:/C:/Documents and Settings/dgraham/.maven/plugins/maven-xdoc-plugin-1.6/plugin.jelly Element... x:parse Line.. 340 Column 43 Error on line -1 of document : Premature end of file. Nested exception: Premature end of file. So it looks like the xdoc and html2xdoc plugins are failing. RC1 works fine though. David 2 is there any reason why we shouldn't move onto the mavenized site soon? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/codec/src/java/org/apache/commons/codec/net QuotedPrintableCodec.java
ggregory2004/03/28 13:21:58 Modified:codec/src/java/org/apache/commons/codec/net QuotedPrintableCodec.java Log: Javadoc typo. Revision ChangesPath 1.3 +2 -2 jakarta-commons/codec/src/java/org/apache/commons/codec/net/QuotedPrintableCodec.java Index: QuotedPrintableCodec.java === RCS file: /home/cvs/jakarta-commons/codec/src/java/org/apache/commons/codec/net/QuotedPrintableCodec.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- QuotedPrintableCodec.java 23 Mar 2004 19:22:34 - 1.2 +++ QuotedPrintableCodec.java 28 Mar 2004 21:21:58 - 1.3 @@ -56,7 +56,7 @@ * Q codec. * /p * - * @see a href=http://http://www.ietf.org/rfc/rfc1521.txt; + * @see a href=http://www.ietf.org/rfc/rfc1521.txt; * MIME (Multipurpose Internet Mail Extensions) Part One/a * * @author Apache Software Foundation - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jelly/jelly-tags/jaxme build.xml
rdonkin 2004/03/28 13:24:30
Added: jelly/jelly-tags/jaxme build.xml
Log:
Build file for gump
Revision ChangesPath
1.1 jakarta-commons/jelly/jelly-tags/jaxme/build.xml
Index: build.xml
===
?xml version=1.0 encoding=UTF-8?
!--build.xml generated by maven from project.xml version 0.1
on date March 28 2004, time 2223--
project default=jar name=commons-jelly-tags-jaxme basedir=.
property name=defaulttargetdir value=target
/property
property name=libdir value=target/lib
/property
property name=classesdir value=target/classes
/property
property name=testclassesdir value=target/test-classes
/property
property name=testreportdir value=target/test-reports
/property
property name=distdir value=dist
/property
property name=javadocdir value=dist/docs/api
/property
property name=final.name value=commons-jelly-tags-jaxme-0.1
/property
target name=init description=o Initializes some properties
mkdir dir=${libdir}
/mkdir
condition property=noget
equals arg2=only arg1=${build.sysclasspath}
/equals
/condition
/target
target name=compile description=o Compile the code depends=get-deps
mkdir dir=${classesdir}
/mkdir
javac destdir=${classesdir} deprecation=true debug=true optimize=false
excludes=**/package.html
src
pathelement location=src/java
/pathelement
/src
classpath
fileset dir=${libdir}
include name=*.jar
/include
/fileset
/classpath
/javac
copy todir=${classesdir}
fileset dir=src/test
include name=**/*.jelly
/include
include name=**/*.properties
/include
include name=**/*.xml
/include
/fileset
/copy
copy todir=${testclassesdir}
fileset dir=src/test
include name=**/*.jelly
/include
include name=**/*.xml
/include
include name=**/*.xsl
/include
include name=**/*.rng
/include
include name=**/*.dtd
/include
include name=**/*.properties
/include
include name=**/*.html
/include
/fileset
/copy
/target
target name=jar description=o Create the jar depends=compile,test
jar jarfile=target/${final.name}.jar excludes=**/package.html
basedir=${classesdir}
/jar
/target
target name=clean description=o Clean up the generated directories
delete dir=${defaulttargetdir}
/delete
delete dir=${distdir}
/delete
/target
target name=dist description=o Create a distribution depends=jar, javadoc
mkdir dir=dist
/mkdir
copy todir=dist
fileset dir=${defaulttargetdir} includes=*.jar
/fileset
fileset dir=${basedir} includes=LICENSE*, README*
/fileset
/copy
/target
target name=test description=o Run the test cases if=test.failure
depends=internal-test
fail message=There were test failures.
/fail
/target
target name=internal-test depends=compile-tests
mkdir dir=${testreportdir}
/mkdir
junit dir=./ failureproperty=test.failure printSummary=yes fork=true
haltonerror=true
sysproperty key=basedir value=.
/sysproperty
formatter type=xml
/formatter
formatter usefile=false type=plain
/formatter
classpath
fileset dir=${libdir}
include name=*.jar
/include
/fileset
pathelement path=${testclassesdir}
/pathelement
pathelement path=${classesdir}
/pathelement
/classpath
batchtest todir=${testreportdir}
fileset dir=src/test
include name=**/*TestCase.java
/include
/fileset
/batchtest
/junit
/target
target name=compile-tests depends=compile
mkdir dir=${testclassesdir}
/mkdir
javac destdir=${testclassesdir} deprecation=true debug=true
optimize=false excludes=**/package.html
src
pathelement location=src/test
/pathelement
/src
classpath
fileset dir=${libdir}
include name=*.jar
/include
/fileset
pathelement path=${classesdir}
/pathelement
/classpath
/javac
/target
target name=javadoc description=o Generate javadoc depends=jar
mkdir dir=${javadocdir}
/mkdir
tstamp
format pattern=2004- property=year
/format
/tstamp
property name=copyright value=Copyright amp;copy; Apache Software
Foundation. All Rights Reserved.
/property
property name=title value=commons-jelly-tags-jaxme
cvs commit: jakarta-commons/codec/src/java/org/apache/commons/codec/net QuotedPrintableCodec.java
ggregory2004/03/28 13:24:46 Modified:codec/src/java/org/apache/commons/codec/net QuotedPrintableCodec.java Log: Fix Copyright date. This file was added in 2004, not 2001. Revision ChangesPath 1.4 +2 -2 jakarta-commons/codec/src/java/org/apache/commons/codec/net/QuotedPrintableCodec.java Index: QuotedPrintableCodec.java === RCS file: /home/cvs/jakarta-commons/codec/src/java/org/apache/commons/codec/net/QuotedPrintableCodec.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- QuotedPrintableCodec.java 28 Mar 2004 21:21:58 - 1.3 +++ QuotedPrintableCodec.java 28 Mar 2004 21:24:46 - 1.4 @@ -1,5 +1,5 @@ /* - * Copyright 2001-2004 The Apache Software Foundation. + * Copyright 2004 The Apache Software Foundation. * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jelly/jelly-tags/jaxme gump.xml
rdonkin 2004/03/28 13:24:52 Added: jelly/jelly-tags/jaxme gump.xml Log: Build file for gump Revision ChangesPath 1.1 jakarta-commons/jelly/jelly-tags/jaxme/gump.xml Index: gump.xml === ?xml version=1.0 encoding=UTF-8? module name=commons-jelly-tags-jaxme descriptionJaxMe Tag Library/description url href=http://jakarta.apache.org/commons/jelly/libs/jaxme/index.html; /url cvs module=jakarta-commons/jelly/jelly-tags/jaxme repository=jakarta /cvs project name=commons-jelly-tags-jaxme ant buildfile=build.xml target=dist property name=final.name value=commons-jelly-tags-jaxme-@@DATE@@ /property /ant packageorg.apache.commons.jelly.tags.jaxme/package depend project=commons-beanutils /depend depend project=commons-collections /depend depend project=commons-jelly /depend depend project=commons-jexl /depend depend project=commons-logging /depend depend project=dom4j /depend depend project=jakarta-ant /depend depend project=jaxme /depend depend project=xml-apis /depend depend project=xml-xerces /depend depend project=xml-xerces2 /depend depend project=xmlunit /depend work nested=target/classes /work home nested=target /home jar name=commons-jelly-tags-jaxme-@@DATE@@.jar /jar javadoc module=jakarta-commons nested=target/docs/apidocs /javadoc nag to=[EMAIL PROTECTED] from=commons-jelly-tags-jaxme development lt;[EMAIL PROTECTED]gt; /nag /project /module - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/java/org/apache/commons/httpclient MultiThreadedHttpConnectionManager.java
mbecke 2004/03/28 13:26:50
Modified:httpclient/src/test/org/apache/commons/httpclient
TestHttpConnectionManager.java
httpclient/src/java/org/apache/commons/httpclient
MultiThreadedHttpConnectionManager.java
Log:
Added MultiThreadedHttpConnectionManager shutdown() and shutdownAll().
PR: 27589
Submitted by: Michael Becke
Reviewed by: Oleg Kalnichevski
Revision ChangesPath
1.19 +99 -5
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestHttpConnectionManager.java
Index: TestHttpConnectionManager.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestHttpConnectionManager.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- TestHttpConnectionManager.java22 Feb 2004 18:08:49 - 1.18
+++ TestHttpConnectionManager.java28 Mar 2004 21:26:50 - 1.19
@@ -366,6 +366,94 @@
}
/**
+ * Tests that [EMAIL PROTECTED]
MultiThreadedHttpConnectionManager#shutdownAll()} closes all resources
+ * and makes all connection mangers unusable.
+ */
+public void testShutdownAll() {
+
+MultiThreadedHttpConnectionManager connectionManager = new
MultiThreadedHttpConnectionManager();
+connectionManager.setMaxConnectionsPerHost(1);
+connectionManager.setMaxTotalConnections(1);
+
+HostConfiguration host1 = new HostConfiguration();
+host1.setHost(host1, -1, http);
+
+// hold on to the only connection
+HttpConnection connection = connectionManager.getConnection(host1);
+
+// wait for a connection on another thread
+GetConnectionThread getConn = new GetConnectionThread(host1,
connectionManager, 0);
+getConn.start();
+
+MultiThreadedHttpConnectionManager.shutdownAll();
+
+// now release this connection, this should close the connection, but have
no other effect
+connection.releaseConnection();
+connection = null;
+
+try {
+getConn.join();
+} catch (InterruptedException e) {
+e.printStackTrace();
+}
+
+// this thread should have caught an exception without getting a connection
+assertNull(Not connection should have been checked out,
getConn.getConnection());
+assertNotNull(There should have been an exception,
getConn.getException());
+
+try {
+connectionManager.getConnection(host1);
+fail(An exception should have occurred);
+} catch (Exception e) {
+// this is expected
+}
+}
+
+/**
+ * Tests that [EMAIL PROTECTED] MultiThreadedHttpConnectionManager#shutdown()}
closes all resources
+ * and makes the connection manger unusable.
+ */
+public void testShutdown() {
+
+MultiThreadedHttpConnectionManager connectionManager = new
MultiThreadedHttpConnectionManager();
+connectionManager.setMaxConnectionsPerHost(1);
+connectionManager.setMaxTotalConnections(1);
+
+HostConfiguration host1 = new HostConfiguration();
+host1.setHost(host1, -1, http);
+
+// hold on to the only connection
+HttpConnection connection = connectionManager.getConnection(host1);
+
+// wait for a connection on another thread
+GetConnectionThread getConn = new GetConnectionThread(host1,
connectionManager, 0);
+getConn.start();
+
+connectionManager.shutdown();
+
+// now release this connection, this should close the connection, but have
no other effect
+connection.releaseConnection();
+connection = null;
+
+try {
+getConn.join();
+} catch (InterruptedException e) {
+e.printStackTrace();
+}
+
+// this thread should have caught an exception without getting a connection
+assertNull(Not connection should have been checked out,
getConn.getConnection());
+assertNotNull(There should have been an exception,
getConn.getException());
+
+try {
+connectionManager.getConnection(host1);
+fail(An exception should have occurred);
+} catch (Exception e) {
+// this is expected
+}
+}
+
+/**
* Tests the MultiThreadedHttpConnectionManager's ability to restrict the
maximum number
* of connections.
*/
@@ -599,6 +687,7 @@
private MultiThreadedHttpConnectionManager connectionManager;
private HttpConnection connection;
RE: [codec] Rename Binary to BinaryCodec?
+1 I thought the name confusing but never found a better alternative. Labeling it with the Codec suffix gives it more meaning. Alex -Original Message- From: Gary Gregory [mailto:[EMAIL PROTECTED] Sent: Sunday, March 28, 2004 4:14 PM To: Jakarta Commons Developers List Subject: [codec] Rename Binary to BinaryCodec? Hello, I am not fond of the class name Binary as it sounds too much like a data-type and not a codec. I would like to rename the class to BinaryCodec. Since this is a new class since 1.2, there are no compatibility issues. Opinions? Gary - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [site] maven matters
OK, I'll see at it. Emmanuel - Original Message - From: David Graham [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, March 28, 2004 11:20 PM Subject: Re: [site] maven matters --- Emmanuel Venisse [EMAIL PROTECTED] wrote: - Original Message - From: David Graham [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, March 28, 2004 10:22 PM Subject: Re: [site] maven matters --- robert burrell donkin [EMAIL PROTECTED] wrote: a couple of questions (aimed at the developer community): 1 should we move onto maven rc2 (this would mean i could regenerate websites)? I had problems with the new xdoc plugin throwing errors so I rolled back to rc1. What's your problems? I installed rc2 and deleted my existing .maven directory. Then I ran 'maven clean site' on the Commons Validator project. I get a bunch of identical exceptions ending with: Caused by: java.lang.NullPointerException at org.apache.maven.html2xdoc.Html2XdocBean.shouldBreakPara(Html2XdocBean.java: 288) at org.apache.maven.html2xdoc.Html2XdocBean.addNode(Html2XdocBean.java:273) at org.apache.maven.html2xdoc.Html2XdocBean.processNode(Html2XdocBean.java:136) at org.apache.maven.html2xdoc.Html2XdocBean.addSections(Html2XdocBean.java:118) at org.apache.maven.html2xdoc.Html2XdocBean.convert(Html2XdocBean.java:96) ... 63 more Followed by this at the very end: BUILD FAILED File.. file:/C:/Documents and Settings/dgraham/.maven/plugins/maven-xdoc-plugin-1.6/plugin.jelly Element... x:parse Line.. 340 Column 43 Error on line -1 of document : Premature end of file. Nested exception: Premature end of file. So it looks like the xdoc and html2xdoc plugins are failing. RC1 works fine though. David 2 is there any reason why we shouldn't move onto the mavenized site soon? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [site] maven matters
I fixed it in cvs. The problem was due to html2xdoc. You can checkout html2xdoc plugin and run : maven clean plugin:install plugin:deploy Emmanuel - Original Message - From: Emmanuel Venisse [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, March 28, 2004 11:52 PM Subject: Re: [site] maven matters OK, I'll see at it. Emmanuel - Original Message - From: David Graham [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, March 28, 2004 11:20 PM Subject: Re: [site] maven matters --- Emmanuel Venisse [EMAIL PROTECTED] wrote: - Original Message - From: David Graham [EMAIL PROTECTED] To: Jakarta Commons Developers List [EMAIL PROTECTED] Sent: Sunday, March 28, 2004 10:22 PM Subject: Re: [site] maven matters --- robert burrell donkin [EMAIL PROTECTED] wrote: a couple of questions (aimed at the developer community): 1 should we move onto maven rc2 (this would mean i could regenerate websites)? I had problems with the new xdoc plugin throwing errors so I rolled back to rc1. What's your problems? I installed rc2 and deleted my existing .maven directory. Then I ran 'maven clean site' on the Commons Validator project. I get a bunch of identical exceptions ending with: Caused by: java.lang.NullPointerException at org.apache.maven.html2xdoc.Html2XdocBean.shouldBreakPara(Html2XdocBean.java: 288) at org.apache.maven.html2xdoc.Html2XdocBean.addNode(Html2XdocBean.java:273) at org.apache.maven.html2xdoc.Html2XdocBean.processNode(Html2XdocBean.java:136) at org.apache.maven.html2xdoc.Html2XdocBean.addSections(Html2XdocBean.java:118) at org.apache.maven.html2xdoc.Html2XdocBean.convert(Html2XdocBean.java:96) ... 63 more Followed by this at the very end: BUILD FAILED File.. file:/C:/Documents and Settings/dgraham/.maven/plugins/maven-xdoc-plugin-1.6/plugin.jelly Element... x:parse Line.. 340 Column 43 Error on line -1 of document : Premature end of file. Nested exception: Premature end of file. So it looks like the xdoc and html2xdoc plugins are failing. RC1 works fine though. David 2 is there any reason why we shouldn't move onto the mavenized site soon? - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] ___[ Pub ] Inscrivez-vous gratuitement sur Tandaime et gagnez un voyage à Venise www.Tandaime.com/index.php?origine=4 Tandaime, et la vie vous sourit ! _ Envie de discuter en live avec vos amis ? Télécharger MSN Messenger http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France
cvs commit: jakarta-commons/validator/xdocs changes.xml
dgraham 2004/03/28 14:04:43 Modified:validator/xdocs changes.xml Log: Blame me instead of Rob for a change in 1.1.1 :-). Revision ChangesPath 1.3 +1 -1 jakarta-commons/validator/xdocs/changes.xml Index: changes.xml === RCS file: /home/cvs/jakarta-commons/validator/xdocs/changes.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- changes.xml 28 Mar 2004 19:48:28 - 1.2 +++ changes.xml 28 Mar 2004 22:04:43 - 1.3 @@ -91,7 +91,7 @@ these for checking login pages, only when the user is modifying the password. /action - action dev=rleland type=add + action dev=dgraham type=add Added Field.getArgs(String) to make it easier to retrieve all of the Args for a given validator. /action - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Validator] release(was : Re: Counting down to the 1.2.1 release)
Martin Cooper wrote: There have been some Validator discussions going on on commons-dev, related to JavaScript, so I'm going to wait for a green light from someone (David G?) before I roll Validator 1.1.2. Ok, Validator is now using DOM Level 1 compatable calls to resolve the form name. Thanks to Nacho and Matthew for reading the comments on the CVS log ! Also are you going to propose a release VOTE on commons ? -- Martin Cooper - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Validator] release(was : Re: Counting down to the 1.2.1 release)
On Sun, 28 Mar 2004, Robert Leland wrote: Martin Cooper wrote: There have been some Validator discussions going on on commons-dev, related to JavaScript, so I'm going to wait for a green light from someone (David G?) before I roll Validator 1.1.2. Ok, Validator is now using DOM Level 1 compatable calls to resolve the form name. Thanks to Nacho and Matthew for reading the comments on the CVS log ! Also are you going to propose a release VOTE on commons ? I guess I'd better, huh? ;-) I have to admit I'm slightly confused on when that should happen, now that we're doing the Tomcat-style release process, but I'm going to put up the candidate build and then send out the vote, I think, unless I hear any objections. -- Martin Cooper -- Martin Cooper - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [site] maven matters
Robert, Sorry, I got really busy last week, I was meaning to setup a Vote email and notify everyone that we are transitioning. In terms of rc2, I believe that, since I setup our own site.jsl and css style, that the site should still look the same no matter which subproject is being generated, but this needs doublechecking. So here are the tasks I think need completion: 1.) Vote and Notification of transition 2.) Regenerate the commons-mavenized site and several subproject sites with rc2 to verify they still maintain the LF. -Mark I think we should start a vote process to clarify robert burrell donkin wrote: On 28 Mar 2004, at 22:52, Eric Pugh wrote: I'm all for it.. As part of this, should the docs on how to cut a release etc be updated to use Maven versus Ant? it's only the site generation that's (probably) going to be generated using maven. components will still be able to use ant as their main build and release tool. instructions about how to cut a release using maven would be a useful addition, though. - robert - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Mark Diggory Software Developer Harvard MIT Data Center http://www.hmdc.harvard.edu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/daemon/src/native/nt/procrun procrun.c
billbarker2004/03/28 15:58:51
Modified:daemon/src/native/nt/procrun procrun.c
Log:
Refactor the JAVA_HOME auto-detection logic.
This will make it easier to extend to non-Sun JVMs later.
Also, adding in additional second-try at guessing that will allow procrun to recover
from at least some of the common JVM installation errors.
Finally, adding in support to specify JAVA_HOME via the --Environment configuration
option, so that it is possible to configure different services to use different JVM
installs.
Revision ChangesPath
1.16 +110 -84 jakarta-commons/daemon/src/native/nt/procrun/procrun.c
Index: procrun.c
===
RCS file: /home/cvs/jakarta-commons/daemon/src/native/nt/procrun/procrun.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- procrun.c 18 Mar 2004 04:20:19 - 1.15
+++ procrun.c 28 Mar 2004 23:58:51 - 1.16
@@ -61,6 +61,7 @@
int report_service_status(DWORD, DWORD, DWORD, process_t *);
int procrun_redirect(char *program, char **envp, procrun_t *env, int starting);
+static char *procrun_find_java(process_t *proc, char *jhome);
static int g_proc_stderr_file = 0;
int g_proc_mode = 0;
@@ -685,6 +686,103 @@
return rv;
}
+/* Locate the default JAVA_HOME from the registry only.
+ */
+static char *procrun_guess_reg_jhome(process_t *proc)
+{
+HKEY hkjs;
+char jbin[MAX_PATH+1];
+char reg[MAX_PATH+1];
+char *cver;
+unsigned long err, klen = MAX_PATH;
+strcpy(reg, JAVASOFT_REGKEY);
+cver = reg[sizeof(JAVASOFT_REGKEY)-1];
+
+if ((err = RegOpenKeyEx(HKEY_LOCAL_MACHINE, reg,
+0, KEY_READ, hkjs)) != ERROR_SUCCESS) {
+ /* No JRE key, so try the JDK */
+ strcpy(reg, JAVAHOME_REGKEY);
+ cver = reg[STRN_SIZE(JAVAHOME_REGKEY)];
+ if((err = RegOpenKeyEx(HKEY_LOCAL_MACHINE, reg,
+0, KEY_READ, hkjs)) != ERROR_SUCCESS) {
+DBPRINTF0(procrun_guess_reg_jhome() failed to open Registry key\n);
+return NULL;
+ }
+}
+if ((err = RegQueryValueEx(hkjs, CurrentVersion, NULL, NULL,
+ (unsigned char *)cver,
+ klen)) != ERROR_SUCCESS) {
+ DBPRINTF0(procrun_guess_jvm() failed obtaining Current Java Version\n);
+ RegCloseKey(hkjs);
+ return NULL;
+}
+RegCloseKey(hkjs);
+
+if ((err = RegOpenKeyEx(HKEY_LOCAL_MACHINE, reg,
+0, KEY_READ, hkjs) ) != ERROR_SUCCESS) {
+ DBPRINTF1(procrun_guess_jvm() failed to open Registry key %s\n, reg);
+ return NULL;
+}
+klen = MAX_PATH;
+if ((err = RegQueryValueEx(hkjs, JavaHome, NULL, NULL,
+ (unsigned char *)jbin,
+ klen)) != ERROR_SUCCESS) {
+ DBPRINTF0(procrun_guess_jvm() failed obtaining Java path\n);
+ RegCloseKey(hkjs);
+ return NULL;
+}
+RegCloseKey(hkjs);
+return pool_strdup(proc-pool, jbin);
+}
+
+/* Find the value for JAVA_HOME.
+ */
+static char *procrun_guess_javahome(process_t *proc, int *inenv)
+{
+char *cver = NULL;
+
+if(proc-service.environment != NULL) {
+char *env = proc-service.environment;
+while(*env) {
+ if(STRNI_COMPARE(env, JAVA_HOME=)) {
+ cver = pool_strdup(proc-pool,env + STRN_SIZE(JAVA_HOME=));
+ if(inenv != NULL)
+ *inenv = 1;
+ break;
+ }
+ env += strlen(env)+1;
+}
+}
+if(cver == NULL) {
+cver = getenv(JAVA_HOME);
+if(cver != NULL) {
+ cver = pool_strdup(proc-pool, cver);
+ if(inenv != NULL)
+*inenv = 1;
+}
+}
+if(cver == NULL) {
+cver = procrun_guess_reg_jhome(proc);
+if(inenv != NULL)
+ *inenv = 0;
+}
+return cver;
+}
+
+/* Find the default jvm.dll
+ * This function is the fall-back to try well-known locations if
+ * the registry search fails to find it.
+ */
+static char *procrun_guess_jvm2(process_t *proc)
+{
+char *jhome = procrun_guess_javahome(proc, NULL);
+
+if(jhome == NULL)
+return NULL;
+return procrun_find_java(proc, jhome);
+}
+
+
/* Find the default jvm.dll
* The function scans through registry and finds
* default JRE jvm.dll.
@@ -703,21 +801,21 @@
if ((err = RegOpenKeyEx(HKEY_LOCAL_MACHINE, reg,
0, KEY_READ, hkjs)) != ERROR_SUCCESS) {
DBPRINTF0(procrun_guess_jvm() failed to open Registry key\n);
- return NULL;
+ return procrun_guess_jvm2(proc);
}
if ((err =
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader MemoryDatabasePlugIn.java
husted 2004/03/28 16:49:38 Removed: chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader MemoryDatabasePlugIn.java Log: Remove obsolete file (using version under Struts example) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader MailReaderAction.java ContextAction.java CommandAction.java ActionHelperBase.java ActionHelper.java
husted 2004/03/28 16:50:21 Removed: chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader MailReaderAction.java ContextAction.java CommandAction.java ActionHelperBase.java ActionHelper.java Log: Refactor class and packages naming. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts - New directory
husted 2004/03/28 16:51:55 jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts MailReaderAction.java ContextAction.java CommandAction.java ActionHelperBase.java ActionHelper.java
husted 2004/03/28 16:52:09
Added:
chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts
MailReaderAction.java ContextAction.java
CommandAction.java ActionHelperBase.java
ActionHelper.java
Log:
Refactor class and packages naming.
Revision ChangesPath
1.1
jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts/MailReaderAction.java
Index: MailReaderAction.java
===
/*
* $Header:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts/MailReaderAction.java,v
1.1 2004/03/29 00:52:09 husted Exp $
* $Revision: 1.1 $
* $Date: 2004/03/29 00:52:09 $
*
* Copyright 1999-2004 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.chain.mailreader.struts;
import org.apache.commons.chain.Context;
import org.apache.commons.chain.mailreader.ClientContext;
import org.apache.commons.chain.mailreader.MailReaderBase;
import java.util.Locale;
/**
* pProcess Commands using a [EMAIL PROTECTED]
org.apache.commons.chain.mailreader.MailReader}
* [EMAIL PROTECTED] ClientContext}./p
*/
public class MailReaderAction extends CommandAction {
// See interface for JavaDoc
public ClientContext getContext(ActionHelper helper) {
Locale locale = helper.getLocale();
Context input = getInput(helper.getActionForm());
return new MailReaderBase(locale, input);
}
}
1.1
jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts/ContextAction.java
Index: ContextAction.java
===
/*
* $Header:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts/ContextAction.java,v
1.1 2004/03/29 00:52:09 husted Exp $
* $Revision: 1.1 $
* $Date: 2004/03/29 00:52:09 $
*
* Copyright 1999-2004 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.chain.mailreader.struts;
import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
/**
* p
* Create ActionHelper from standard codeexecute/code call
* and pass to a helper form of codeexecute/code,
* to be extended by a subclass.
* /p
*/
public abstract class ContextAction extends Action {
/**
* p
* Token representing a nominal outcome [success].
* /p
*/
private static String SUCCESS = success;
/**
* p
* Convenience method to find a forward named success.
* /p
* @param helper Our ActionHelper
* @return a forward named success or null.
*/
protected ActionForward findSuccess(ActionHelper helper) {
return helper.getMapping().findForward(SUCCESS);
}
/**
* p
* Convenience method to return the Input forward.
* Assumes the InputForward option and input property is set.
* Otherwise, returns codenull/code.
* /p
* @param helper Our ActionHelper
* @return a forward named success or null.
*/
protected ActionForward findInput(ActionHelper helper) {
return helper.getMapping().getInputForward();
}
/**
* p
* Process the request represented by the [EMAIL PROTECTED] ActionHelper}, and
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/commands LocaleChange.java LocaleCommand.java MailReader.java MailReaderBase.java
husted 2004/03/28 16:52:22
Modified:chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader
ClientContext.java
Added: chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader
MailReader.java MailReaderBase.java
chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/commands
LocaleChange.java
Removed:
chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/commands
LocaleCommand.java MailReader.java
MailReaderBase.java
Log:
Refactor class and packages naming.
Revision ChangesPath
1.2 +11 -3
jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/ClientContext.java
Index: ClientContext.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/ClientContext.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- ClientContext.java28 Mar 2004 03:20:55 - 1.1
+++ ClientContext.java29 Mar 2004 00:52:22 - 1.2
@@ -12,20 +12,28 @@
* representation.
* /p
* p
- * See [EMAIL PROTECTED]
org.apache.commons.chain.mailreader.commands.MailReaderBase}
+ * See [EMAIL PROTECTED] org.apache.commons.chain.mailreader.MailReaderBase}
* for an implementation.
* /p
*/
public interface ClientContext extends Context {
+/**
+ * Client [EMAIL PROTECTED] Locale} property.
+ */
public static String PN_LOCALE = locale;
-public boolean isLocale();
+
public void setLocale(Locale locale);
+
public Locale getLocale();
+/**
+ * Input [EMAIL PROTECTED] Context} property.
+ */
public static String PN_INPUT = input;
-public boolean isInput();
+
public void setInput(Context context);
+
public Context getInput();
}
1.1
jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReader.java
Index: MailReader.java
===
/*
* $Header:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReader.java,v
1.1 2004/03/29 00:52:22 husted Exp $
* $Revision: 1.1 $
* $Date: 2004/03/29 00:52:22 $
*
* Copyright 2000-2004 Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.chain.mailreader;
/**
* Application interface for MailReader Commands.
*/
public interface MailReader extends ClientContext {
/**
* Property name for the country field of a Locale.
*/
static String PN_COUNTRY = country;
/**
* Property name for the language field of a Locale.
*/
static String PN_LANGUAGE = language;
// Database
// User
}
1.1
jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReaderBase.java
Index: MailReaderBase.java
===
/*
* $Header:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReaderBase.java,v
1.1 2004/03/29 00:52:22 husted Exp $
* $Revision: 1.1 $
* $Date: 2004/03/29 00:52:22 $
*
* Copyright 2000-2004 Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.chain.mailreader;
import org.apache.commons.chain.Context;
import org.apache.commons.chain.impl.ContextBase;
import java.util.Locale;
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/resources/chain catalog.xml
husted 2004/03/28 16:53:28 Modified:chain/apps/mailreader/src/resources/chain catalog.xml Log: Come current Revision ChangesPath 1.2 +4 -1 jakarta-commons-sandbox/chain/apps/mailreader/src/resources/chain/catalog.xml Index: catalog.xml === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/resources/chain/catalog.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- catalog.xml 25 Mar 2004 12:41:32 - 1.1 +++ catalog.xml 29 Mar 2004 00:53:28 - 1.2 @@ -1,6 +1,9 @@ ?xml version=1.0 ? chains command -name=passThru +name=PassThru className=org.apache.commons.chain.mailreader.commands.PassThru / +command +name=LocaleChange +className=org.apache.commons.chain.mailreader.commands.LocaleChange / /chains - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test - New directory
husted 2004/03/28 16:53:46 jakarta-commons-sandbox/chain/apps/mailreader/src/test - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org - New directory
husted 2004/03/28 16:53:50 jakarta-commons-sandbox/chain/apps/mailreader/src/test/org - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache - New directory
husted 2004/03/28 16:53:54 jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons - New directory
husted 2004/03/28 16:53:57 jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader - New directory
husted 2004/03/28 16:54:01 jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader ChangeLocaleTest.java
husted 2004/03/28 16:54:23
Added: chain/apps/mailreader/src/test/org/apache/commons/mailreader
ChangeLocaleTest.java
Log:
Add LocaleChange test
Revision ChangesPath
1.1
jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader/ChangeLocaleTest.java
Index: ChangeLocaleTest.java
===
/*
* $Header:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader/ChangeLocaleTest.java,v
1.1 2004/03/29 00:54:23 husted Exp $
* $Revision: 1.1 $
* $Date: 2004/03/29 00:54:23 $
*
* Copyright 2000-2004 Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.mailreader;
import junit.framework.TestCase;
import org.apache.commons.chain.Command;
import org.apache.commons.chain.Context;
import org.apache.commons.chain.mailreader.MailReader;
import org.apache.commons.chain.mailreader.MailReaderBase;
import org.apache.commons.chain.mailreader.commands.LocaleChange;
import org.apache.commons.chain.impl.ContextBase;
import java.util.Locale;
/**
*/
public class ChangeLocaleTest extends TestCase {
private Command command;
public void setUp() {
command = new LocaleChange();
}
public void testCanadaFrench() {
Locale original = Locale.US;
Locale expected = Locale.CANADA_FRENCH;
Context input = new ContextBase();
input.put(MailReader.PN_COUNTRY,CA);
input.put(MailReader.PN_LANGUAGE,FR);
MailReader context = new MailReaderBase(original,input);
try {
command.execute(context);
}
catch(Exception e) {
fail(e.getMessage());
}
assertEquals(Unexpected Locale,expected,context.getLocale());
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/WEB-INF/struts-config locale.xml
husted 2004/03/28 16:54:59 Modified:chain/apps/mailreader/src/webapp welcome.jsp chain/apps/mailreader/src/webapp/WEB-INF web.xml chain/apps/mailreader/src/webapp/WEB-INF/struts-config locale.xml Log: Enable LocaleChange action Revision ChangesPath 1.2 +3 -3 jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/welcome.jsp Index: welcome.jsp === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/welcome.jsp,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- welcome.jsp 25 Mar 2004 12:36:11 - 1.1 +++ welcome.jsp 29 Mar 2004 00:54:59 - 1.2 @@ -16,9 +16,9 @@ h3Language Options/h3 ul -lihtml:link action=/Locale?language=enEnglish/html:link/li -lihtml:link action=/Locale?language=ja useLocalEncoding=trueJapanese/html:link/li -lihtml:link action=/Locale?language=ru useLocalEncoding=trueRussian/html:link/li +lihtml:link action=/LocaleChange?language=enEnglish/html:link/li +lihtml:link action=/LocaleChange?language=ja useLocalEncoding=trueJapanese/html:link/li +lihtml:link action=/LocaleChange?language=ru useLocalEncoding=trueRussian/html:link/li /ul hr / 1.2 +1 -1 jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/WEB-INF/web.xml Index: web.xml === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/WEB-INF/web.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- web.xml 25 Mar 2004 12:36:49 - 1.1 +++ web.xml 29 Mar 2004 00:54:59 - 1.2 @@ -9,7 +9,7 @@ !-- Commons Chain listener to load catalogs -- context-param -param-nameorg.apache.commons.chain.CONFIG_RESOURCE/param-name +param-nameorg.apache.commons.chain.CONFIG_CLASS_RESOURCE/param-name param-valueresources/catalog.xml/param-value /context-param 1.2 +6 -4 jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/WEB-INF/struts-config/locale.xml Index: locale.xml === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/webapp/WEB-INF/struts-config/locale.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- locale.xml25 Mar 2004 12:37:58 - 1.1 +++ locale.xml29 Mar 2004 00:54:59 - 1.2 @@ -15,7 +15,7 @@ form-beans form-bean -name=Locale +name=LocaleChange type=org.apache.struts.validator.DynaValidatorForm form-property name=language type=java.lang.String/ form-property name=country type=java.lang.String/ @@ -28,9 +28,11 @@ global-forwards/ action-mappings -action path=/Locale -name=Locale -forward=/missing.jsp / +action path=/LocaleChange +name=LocaleChange +type=org.apache.commons.chain.mailreader.struts.MailReaderAction +forward name=success path=/Welcome.do / +/action /action-mappings /struts-config - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/codec/src/java/org/apache/commons/codec/binary package.html
ggregory2004/03/28 17:20:06 Modified:codec/src/java/org/apache/commons/codec/binary package.html Log: Note new Binary codec. Revision ChangesPath 1.5 +1 -1 jakarta-commons/codec/src/java/org/apache/commons/codec/binary/package.html Index: package.html === RCS file: /home/cvs/jakarta-commons/codec/src/java/org/apache/commons/codec/binary/package.html,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- package.html 23 Feb 2004 07:32:50 - 1.4 +++ package.html 29 Mar 2004 01:20:06 - 1.5 @@ -15,6 +15,6 @@ -- html body - Base64 and Hexadecimal String encoding and decoding. + Base64, Binary, and Hexadecimal String encoding and decoding. /body /html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/codec default.properties
ggregory2004/03/28 17:23:28
Modified:codecdefault.properties
Log:
Use current version of JUnit (3.8.1).
Revision ChangesPath
1.11 +2 -2 jakarta-commons/codec/default.properties
Index: default.properties
===
RCS file: /home/cvs/jakarta-commons/codec/default.properties,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- default.properties23 Feb 2004 07:32:49 - 1.10
+++ default.properties29 Mar 2004 01:23:27 - 1.11
@@ -17,7 +17,7 @@
# $Id$
# The pathname of the junit.jar JAR file
-junit.jar = ${junit.home}/junit-3.7.jar
+junit.jar = ${junit.home}/junit-3.8.1.jar
# The name of this component
component.name = commons-codec
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/codec/src/java/org/apache/commons/codec/net QuotedPrintableCodec.java
ggregory2004/03/28 17:32:07 Modified:codec/src/java/org/apache/commons/codec/net QuotedPrintableCodec.java Log: Javadoc tweak. Revision ChangesPath 1.5 +5 -3 jakarta-commons/codec/src/java/org/apache/commons/codec/net/QuotedPrintableCodec.java Index: QuotedPrintableCodec.java === RCS file: /home/cvs/jakarta-commons/codec/src/java/org/apache/commons/codec/net/QuotedPrintableCodec.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- QuotedPrintableCodec.java 28 Mar 2004 21:24:46 - 1.4 +++ QuotedPrintableCodec.java 29 Mar 2004 01:32:07 - 1.5 @@ -29,7 +29,8 @@ /** * p - * Codec for RFC 1521 MIME (Multipurpose Internet Mail Extensions) Part One. + * Codec for the Quoted-Printable section of RFC 1521 MIME (Multipurpose Internet Mail Extensions) Part One + * Mechanisms for Specifying and Describing the Format of Internet Message Bodies. * /p * p * The Quoted-Printable encoding is intended to represent data that @@ -57,7 +58,8 @@ * /p * * @see a href=http://www.ietf.org/rfc/rfc1521.txt; - * MIME (Multipurpose Internet Mail Extensions) Part One/a + * RFC 1521 MIME (Multipurpose Internet Mail Extensions) Part One: Mechanisms for Specifying + * and Describing the Format of Internet Message Bodies/a * * @author Apache Software Foundation * @since 1.3 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader LogonUserTest.java
husted 2004/03/28 17:37:39
Added: chain/apps/mailreader/src/test/org/apache/commons/mailreader
LogonUserTest.java
Log:
Add LogonUser test.
Revision ChangesPath
1.1
jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader/LogonUserTest.java
Index: LogonUserTest.java
===
/*
* $Header:
/home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader/LogonUserTest.java,v
1.1 2004/03/29 01:37:39 husted Exp $
* $Revision: 1.1 $
* $Date: 2004/03/29 01:37:39 $
*
* Copyright 2000-2004 Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.mailreader;
import junit.framework.TestCase;
import junit.framework.Assert;
import org.apache.commons.chain.Command;
import org.apache.commons.chain.Context;
import org.apache.commons.chain.mailreader.MailReader;
import org.apache.commons.chain.mailreader.MailReaderBase;
import org.apache.commons.chain.mailreader.commands.LocaleChange;
import org.apache.commons.chain.impl.ContextBase;
import org.apache.struts.webapp.example.User;
import org.apache.struts.webapp.example.UserDatabase;
import org.apache.struts.webapp.example.memory.MemoryUserDatabase;
import java.util.Locale;
/**
*/
public class LogonUserTest extends TestCase {
private Locale locale = Locale.getDefault();
private UserDatabase database;
private Command command;
private static String USER = user;
private static String PASS = pass;
private static String FULL_NAME = John Q. User;
public void setUp() {
command = new LogonUser();
database = new MemoryUserDatabase();
User user = database.createUser(USER);
user.setPassword(PASS);
user.setFullName(FULL_NAME);
}
public void testJohnQ() {
Context input = new ContextBase();
input.put(MailReader.PN_USERNAME,USER);
input.put(MailReader.PN_PASSWORD,PASS);
MailReader context = new MailReaderBase(locale,input,database);
try {
command.execute(context);
}
catch(Exception e) {
fail(e.getMessage());
}
User user = context.getUser();
assertNotNull(Where's waldo?,user);
assertEquals(Who am I?,John Q. User,user.getFullName());
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Validator] Unit tests failing
The e-mail test is failing for me, with the stack trace below. Ideas, anyone? -- Martin Cooper [junit] Running org.apache.commons.validator.EmailTest [junit] Tests run: 8, Failures: 2, Errors: 0, Time elapsed: 1.913 sec [junit] [ERROR] TEST org.apache.commons.validator.EmailTest FAILED [junit] dir attribute ignored if running in the same VM [junit] Running org.apache.commons.validator.ExceptionTest Mar 28, 2004 5:32:49 PM org.apache.commons.validator.ValidatorAction executeVali dationMethod SEVERE: Unhandled exception thrown during validation: RUNTIME-EXCEPTION java.lang.RuntimeException: RUNTIME-EXCEPTION at org.apache.commons.validator.TestValidator.validateRaiseException(Tes tValidator.java:53) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.commons.validator.ValidatorAction.executeValidationMethod( ValidatorAction.java:570) at org.apache.commons.validator.Field.validateForRule(Field.java:808) at org.apache.commons.validator.Field.validate(Field.java:887) at org.apache.commons.validator.Form.validate(Form.java:171) at org.apache.commons.validator.Validator.validate(Validator.java:367) at org.apache.commons.validator.ExceptionTest.testRuntimeException(Excep tionTest.java:98) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUni tTestRunner.java:325) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JU nitTask.java:848) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitT ask.java:556) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitT ask.java:532) at org.apache.tools.ant.Task.perform(Task.java:341) at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:232) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233) at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:88) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233) at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:128) at com.werken.werkz.Goal.fire(Goal.java:639) at com.werken.werkz.Goal.attain(Goal.java:575) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at org.apache.maven.plugin.PluginManager.attainGoals(PluginManager.java: 448) at org.apache.maven.MavenSession.attainGoals(MavenSession.java:348) at org.apache.maven.cli.App.doMain(App.java:543) at org.apache.maven.cli.App.main(App.java:1109) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at com.werken.forehead.Forehead.run(Forehead.java:551) at com.werken.forehead.Forehead.main(Forehead.java:581) Mar 28, 2004 5:32:50 PM
cvs commit: jakarta-commons-sandbox/chain/apps/mailreader/src/test/org/apache/commons/mailreader ChangeLocaleTest.java LogonUserTest.java
husted 2004/03/28 18:34:20 Modified:chain/apps/mailreader project.xml chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader ClientContext.java MailReader.java MailReaderBase.java chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/commands LocaleChange.java chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/struts ActionHelper.java ActionHelperBase.java MailReaderAction.java chain/apps/mailreader/src/test/org/apache/commons/mailreader ChangeLocaleTest.java LogonUserTest.java Log: Implement code to pass LogonUser test. Test for failure. Revision ChangesPath 1.3 +6 -0 jakarta-commons-sandbox/chain/apps/mailreader/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/project.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- project.xml 26 Mar 2004 18:22:41 - 1.2 +++ project.xml 29 Mar 2004 02:34:19 - 1.3 @@ -27,6 +27,12 @@ !-- include in WAR -- + dependency +groupIdcommons-beanutils/groupId +artifactIdcommons-beanutils/artifactId +version1.6/version + /dependency + dependency groupIdcommons-collections/groupId artifactIdcommons-collections/artifactId 1.3 +16 -0 jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/ClientContext.java Index: ClientContext.java === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/ClientContext.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- ClientContext.java29 Mar 2004 00:52:22 - 1.2 +++ ClientContext.java29 Mar 2004 02:34:19 - 1.3 @@ -23,8 +23,16 @@ */ public static String PN_LOCALE = locale; +/** + * pAssign Locale property/p + * @param locale New Locale + */ public void setLocale(Locale locale); +/** + * pReturn Locale property/p + * @return This Locale property + */ public Locale getLocale(); /** @@ -32,8 +40,16 @@ */ public static String PN_INPUT = input; +/** + * pAssign Input property/p + * @param context New Input context + */ public void setInput(Context context); +/** + * pReturn Input property./p + * @return This Input property + */ public Context getInput(); } 1.2 +38 -5 jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReader.java Index: MailReader.java === RCS file: /home/cvs/jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReader.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- MailReader.java 29 Mar 2004 00:52:22 - 1.1 +++ MailReader.java 29 Mar 2004 02:34:19 - 1.2 @@ -19,6 +19,9 @@ */ package org.apache.commons.chain.mailreader; +import org.apache.struts.webapp.example.UserDatabase; +import org.apache.struts.webapp.example.User; + /** * Application interface for MailReader Commands. @@ -35,8 +38,38 @@ */ static String PN_LANGUAGE = language; +/** + * Property name for username. + */ +static String PN_USERNAME = username; + +/** + * Property name for password. + */ +static String PN_PASSWORD = password; + +/** + * pReturn user database or null./p + * @return user database or null. + */ +public UserDatabase getDatabase(); -// Database -// User +/** + * pAssign user database./p + * @param database The new database instance + */ +public void setDatabase(UserDatabase database); + +/** + * pReturn current user, if any/p + * @return + */ +public User getUser(); + +/** + * pAssign current user./p + * @param user The new user + */ +public void setUser(User user); } 1.2 +42 -20 jakarta-commons-sandbox/chain/apps/mailreader/src/java/org/apache/commons/chain/mailreader/MailReaderBase.java Index: MailReaderBase.java === RCS file:
cvs commit: jakarta-commons/net project.properties project.xml
brekke 2004/03/28 19:14:38
Modified:net project.properties project.xml
Log:
Using the commons-build project for the site and maven builds.
Revision ChangesPath
1.7 +6 -3 jakarta-commons/net/project.properties
Index: project.properties
===
RCS file: /home/cvs/jakarta-commons/net/project.properties,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- project.properties29 Feb 2004 10:27:29 - 1.6
+++ project.properties29 Mar 2004 03:14:38 - 1.7
@@ -15,9 +15,12 @@
maven.checkstyle.javadoc.scope = protected
maven.checkstyle.format = turbine
-maven.xdoc.date = left
-
maven.jar.excludes=**/examples/**/*
# commons site LF
-maven.xdoc.jsl=../commons-build/commons-site.jsl
\ No newline at end of file
+maven.xdoc.jsl=../commons-build/commons-site.jsl
+maven.xdoc.date=left
+maven.xdoc.version=${pom.currentVersion}
+maven.xdoc.developmentProcessUrl=http://jakarta.apache.org/commons/charter.html
+maven.xdoc.poweredby.image=maven-feather.png
+maven.javadoc.links=http://java.sun.com/j2se/1.3/docs/api/
1.40 +4 -41 jakarta-commons/net/project.xml
Index: project.xml
===
RCS file: /home/cvs/jakarta-commons/net/project.xml,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- project.xml 29 Feb 2004 10:27:29 - 1.39
+++ project.xml 29 Mar 2004 03:14:38 - 1.40
@@ -16,20 +16,13 @@
--
project
- pomVersion3/pomVersion
+ extend../commons-build/project.xml/extend
nameJakarta Commons/Net/name
idcommons-net/id
currentVersion1.2.0-dev/currentVersion
- organization
-nameApache Software Foundation/name
-urlhttp://jakarta.apache.org//url
-logo/images/jakarta-logo-blue.gif/logo
- /organization
inceptionYear1997/inceptionYear
packageorg.apache.commons.net/package
- gumpRepositoryIdjakarta/gumpRepositoryId
-
shortDescriptionJakarta Commons/Net/shortDescription
description
@@ -53,17 +46,6 @@
under the The Apache Software License.
/description
- urlhttp://jakarta.apache.org/commons/net//url
- issueTrackingUrlhttp://nagoya.apache.org/bugzilla//issueTrackingUrl
- siteAddressjakarta.apache.org/siteAddress
- siteDirectory/www/jakarta.apache.org/commons/net//siteDirectory
-
distributionDirectory/www/jakarta.apache.org/builds/jakarta-commons/release/commons-net//distributionDirectory
-
- repository
-connectionscm:cvs:pserver:[EMAIL
PROTECTED]:/home/cvspublic:jakarta-commons/net/connection
-urlhttp://cvs.apache.org/viewcvs/jakarta-commons/net//url
- /repository
-
versions
version
id1.0.0/id
@@ -76,21 +58,6 @@
tagNET_1_1_0/tag
/version
/versions
-
- mailingLists
-mailingList
- nameCommons User List/name
- subscribemailto:[EMAIL PROTECTED]/subscribe
- unsubscribemailto:[EMAIL PROTECTED]/unsubscribe
- archivehttp://nagoya.apache.org/eyebrowse/[EMAIL PROTECTED]/archive
-/mailingList
-mailingList
- nameCommons Developer List/name
- subscribemailto:[EMAIL PROTECTED]/subscribe
- unsubscribemailto:[EMAIL PROTECTED]/unsubscribe
- archivehttp://nagoya.apache.org/eyebrowse/[EMAIL PROTECTED]/archive
-/mailingList
- /mailingLists
developers
developer
@@ -139,12 +106,6 @@
/dependencies
build
-
-nagEmailAddress[EMAIL PROTECTED]/nagEmailAddress
-
-sourceDirectorysrc/java/sourceDirectory
-
-unitTestSourceDirectorysrc/test/unitTestSourceDirectory
unitTest
includes
@@ -160,13 +121,15 @@
reports
reportmaven-changes-plugin/report
reportmaven-tasklist-plugin/report
+reportmaven-statcvs-plugin/report
reportmaven-junit-report-plugin/report
reportmaven-jdepend-plugin/report
reportmaven-jcoverage-plugin/report
reportmaven-checkstyle-plugin/report
-reportmaven-statcvs-plugin/report
+reportmaven-simian-plugin/report
reportmaven-javadoc-plugin/report
reportmaven-jxr-plugin/report
+reportmaven-license-plugin/report
/reports
/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [net] [vote] Release Commons-Net 1.2
+1 to the 1.2 release. I just committed changes to the build to use the commons-build stuff. I've also pushed out the site. Let me know anyone sees any problems with it. http://jakarta.apache.org/commons/net/ On Sun, 28 Mar 2004 14:53:24 -0600, Steve Cohen [EMAIL PROTECTED] said: I would like to try and get a 1.2 release out the door, but the last time I tried, it died for want of a second. I recognize that I was probably throwing too many votes for you to deal with and trying to do too much at once, in a self-imposed time-frame of frantically trying to get things done before I started working again. Ironically, I've probably accomplished more for commons-net since I started working again in February than I was accomplishing at the end of January. Anyway, here's what we've got for this release: 1. Refactoring in January of the whole Entry Parser thing. I think this is much more solid and intuitive than it used to be. 2. Autodetection of system type - a BIG feature for the Ant user community and others. We missed the last Ant release and I'd like not to miss another. 3. I fixed all of the bugs that the functional tests contributed by Jeff Brekke in February uncovered. 4. We have a new parser! OS400, contributed by Mario Ivankovits. 5. A few miscellaneous bug fixes. One thing I never did get nailed down was 1.1 compatibility. There were issues with running under a JDK 1.1 JVM that I just couldn't solve. I asked on this list, but no one responded. But I think this is a relatively low priority, more of a nice to have than a prerequisite for a 1.2 release. We have a label for 1.1 compatibility and can always work off that to prepare a 1.1 release when someone is able to address these issues, which are contained in the attached zip file. For all I know these issues may be nothing more than an incorrect JDK 1.1 setup under Linux (1.1 java compilers for Linux came not from Sun but from Blackdown and were less stable than the Windows releases). Anyway, I would like to raise once again the issue of moving to a 1.2 release of commons-net. Please let's capitalize on the momentum we have. I will not bug you guys with a lot of votes. Steve PS. Note to Daniel Savarese: I originally tried to raise this issue in an off-list email to you and Jeff Brekke. However, two attempts at that have bounced back to me since yesterday. I don't know why, but there appears to be some issue with your email address. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- = Jeffrey D. Brekke [EMAIL PROTECTED] Wisconsin, USA [EMAIL PROTECTED] [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [configuration] Cutting a 1.0 Release Help Needed
What about enhancements which have been submitted to the bug tracker? Will those get in? -Original Message- From: Eric Pugh [mailto:[EMAIL PROTECTED] Sent: Sunday, March 28, 2004 12:29 PM To: Commons-Dev Subject: [configuration] Cutting a 1.0 Release Help Needed Hi all, In response to a large number of posts I have recieved both on the mailing list and privately regarding when Commons Configuration 1.0 will be released, I have gone ahead and applied the last of the patches for bugs and I would like to cut the RC1 for Commons Configuration. The remaining issues in BugZilla are all enhancements or refactorings and should be applied post 1.0. At this point I am somewhat stuck at the checksum creation stage. I followed the directions from this document: http://jakarta.apache.org/commons/releases/release.html for steps 1 through 3. However, because Configuration is Maven based, when I run 'maven dist' SSH'ed into jakarta.apache.org I get an error about maven not existing. Ant works, however it tanks on the junit task. Do I need to do steps 4,5,6 SSH'ed in, or can I do them locally and update the results? I have placed some candidates at http://jakarta.apache.org/~epugh/builds/. If the Release Candidate 1 files look good to people, then I will follow the steps here: http://jakarta.apache.org/commons/releases/release.html to cut the 1.0 release. However, I am on winxp, and haven't followed the process of creating md5 checksum's etc.. However, if some other kind soul wishes to play the Release Manager role, I'd be much obliged to them. Eric - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28007] New: - toString() for DelegatingPreparedStatement and DelegatingStatement
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28007. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28007 toString() for DelegatingPreparedStatement and DelegatingStatement Summary: toString() for DelegatingPreparedStatement and DelegatingStatement Product: Commons Version: 1.1 Final Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Dbcp AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Request for (small) enhancement: the existing DelegatingPreparedStatement and DelegatingStatement classes lack custom toString() methods. Such methods would be invaluable in debugging database problems. Affected code base: 1.1. I also checked the mailing list archives and CVS repositories to make sure this hadn't been updated in a future version. I've already produced patches for this, and have given them a brief run in my internal dev environment. I'll attach them to the next section of the Bugzilla report. -QM - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28007] - toString() for DelegatingPreparedStatement and DelegatingStatement
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28007. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28007 toString() for DelegatingPreparedStatement and DelegatingStatement --- Additional Comments From [EMAIL PROTECTED] 2004-03-29 04:08 --- Created an attachment (id=11024) adds toString() methods to DelegatingStatement and DelegatingPreparedStatement - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [digester] can't resolve relative entities ?
robert burrell donkin wrote: hi paul On 27 Mar 2004, at 00:31, Paul Libbrecht wrote: Dear Digester-Gurus... While trying really much to resolve the possible responsability of a buggy dom4j in errors to resolve entities in maven project parsing, I finally realize that Digester may be the reason. We start with a guess: Digester.parse(File) is weird (around lines 1527...): it doesn't store, at all, the reference to the file but still offers himself as EntityResolver. How can it resolve an entity if it doesn't know the path ?? in many ways, digester builds a more user-friendly interface on top of SAX. the usual philosophy is to offer easy, out-of-the-box support for the most common use cases and then offer access to SAX for those who need more sophisticated solutions. entity resolution is a good example of this. digester offers simple support for common use cases by offering itself as the default entity resolving. digester maintains a simple map of publicIDs to URLs and a method for users (and digester) to register them. though this is better than the default adopted by most parsers, this approach has many limitations. the standard advice for users who need more sophisticated support is register a separate EntityResolver. (the business of creating and maintaining DTD catalog programs is best left to specialist components.) The pathology appears very while building taglibs of jelly: the project.xml of each taglibs, extends ../taglib-project.xml which itself should reference, by means of DTD-internal-subset ../commonDeps.ent. As this is buggy, the current jelly CVS contains a copy of commonDeps.ent. i've taken a fresh look at the specs and i think that buggy is probably too strong a word. '../taglib-project.xml' is not an URI and so parsers can legitimately refuse to resolve it but most common parsers interpret this as a path relative to the file (i think, please correct me if i'm wrong). i've taken a look at the digester source and it's probable that digester does not allow parsers to apply this feature since it will always interpret a system id as an URI and then rely on java to find it. it should be possible to alter the entity resolution code so that (when the URI is a relative file url) the java relative path is tested first and null returned if the file does not exist allowing the parser to use it's default resolution code which (i think) should find the file relative to the file path. does this sound like it would fix the jelly problems? and can anyone else see any problems with this approach? One important ingredient in using relative references for entity resolution is to use the appropriate Digester.parse() method. If you use the one that takes an InputStream, as an example, there is no way for the SAX parser or Digester to know what the absolute URL of that resource is, and therefore no way to resolve relative references. On the other hand, if you use the entry point that takes a URL, or a (properly formatted) InputSource, then you are providing enough information for the parser to resolve relative references without doing anything else at all. As an example of this approach, this is a (slightly simplified) version of the logic that Struts uses to construct an InputSource for parsing struts-config.xml files: String path = /WEB-INF/struts-config.xml; InputStream stream = getServletContext().getResourceAsStream(path); URL url = getServletContext().getResource(path); InputSource source = new InputSource(url.toExternalForm()); source.setByteStream(stream); digester.parse(source); In this way, relative entity references in the struts-config.xml document get resolve to other XML documents in the /WEB-INF directory of my webapp, with no extra muss or fuss. The same approach will work for non-webapp based applications as well, as long as you always configure the InputSource with an absolute URL. - robert Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Validator] Unit tests failing
I think its the ExceptionTest which is failing and it looks like it should from the code. There are three tests in ExceptionTest - only one has code to pass the test if it gets the Exception its expecting - the other two are set to fail. The two test which have failures have code to pass the test if the expected Exception is received but its been commented out and replaced with fail code. Theres a note saying This will be true in Validator 2.0 above the commented out code in one of the tests but that doesn't really explain why the tests have been set up to throw an exception and then fail. I think the bugs are in the test! Niall - Original Message - From: Martin Cooper [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, March 29, 2004 2:46 AM Subject: [Validator] Unit tests failing The e-mail test is failing for me, with the stack trace below. Ideas, anyone? -- Martin Cooper [junit] Running org.apache.commons.validator.EmailTest [junit] Tests run: 8, Failures: 2, Errors: 0, Time elapsed: 1.913 sec [junit] [ERROR] TEST org.apache.commons.validator.EmailTest FAILED [junit] dir attribute ignored if running in the same VM [junit] Running org.apache.commons.validator.ExceptionTest Mar 28, 2004 5:32:49 PM org.apache.commons.validator.ValidatorAction executeVali dationMethod SEVERE: Unhandled exception thrown during validation: RUNTIME-EXCEPTION java.lang.RuntimeException: RUNTIME-EXCEPTION at org.apache.commons.validator.TestValidator.validateRaiseException(Tes tValidator.java:53) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.commons.validator.ValidatorAction.executeValidationMethod( ValidatorAction.java:570) at org.apache.commons.validator.Field.validateForRule(Field.java:808) at org.apache.commons.validator.Field.validate(Field.java:887) at org.apache.commons.validator.Form.validate(Form.java:171) at org.apache.commons.validator.Validator.validate(Validator.java:367) at org.apache.commons.validator.ExceptionTest.testRuntimeException(Excep tionTest.java:98) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUni tTestRunner.java:325) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JU nitTask.java:848) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitT ask.java:556) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitT ask.java:532) at org.apache.tools.ant.Task.perform(Task.java:341) at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:232) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233) at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:88) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233) at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:128) at com.werken.werkz.Goal.fire(Goal.java:639) at com.werken.werkz.Goal.attain(Goal.java:575) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at com.werken.werkz.Goal.attain(Goal.java:573) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at
Re: [Validator] Unit tests failing
On Mon, 29 Mar 2004, Niall Pemberton wrote: I think its the ExceptionTest which is failing and it looks like it should from the code. There are three tests in ExceptionTest - only one has code to pass the test if it gets the Exception its expecting - the other two are set to fail. The two test which have failures have code to pass the test if the expected Exception is received but its been commented out and replaced with fail code. Theres a note saying This will be true in Validator 2.0 above the commented out code in one of the tests but that doesn't really explain why the tests have been set up to throw an exception and then fail. I think the bugs are in the test! No, the problems I'm seeing are definitely in the e-mail tests. I've attached the Maven rest reports for the e-mail and exception tests, in which you can see that the former failed, while the latter succeeded. -- Martin Cooper Niall - Original Message - From: Martin Cooper [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, March 29, 2004 2:46 AM Subject: [Validator] Unit tests failing The e-mail test is failing for me, with the stack trace below. Ideas, anyone? -- Martin Cooper [junit] Running org.apache.commons.validator.EmailTest [junit] Tests run: 8, Failures: 2, Errors: 0, Time elapsed: 1.913 sec [junit] [ERROR] TEST org.apache.commons.validator.EmailTest FAILED [junit] dir attribute ignored if running in the same VM [junit] Running org.apache.commons.validator.ExceptionTest Mar 28, 2004 5:32:49 PM org.apache.commons.validator.ValidatorAction executeVali dationMethod SEVERE: Unhandled exception thrown during validation: RUNTIME-EXCEPTION java.lang.RuntimeException: RUNTIME-EXCEPTION at org.apache.commons.validator.TestValidator.validateRaiseException(Tes tValidator.java:53) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.apache.commons.validator.ValidatorAction.executeValidationMethod( ValidatorAction.java:570) at org.apache.commons.validator.Field.validateForRule(Field.java:808) at org.apache.commons.validator.Field.validate(Field.java:887) at org.apache.commons.validator.Form.validate(Form.java:171) at org.apache.commons.validator.Validator.validate(Validator.java:367) at org.apache.commons.validator.ExceptionTest.testRuntimeException(Excep tionTest.java:98) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces sorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUni tTestRunner.java:325) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeInVM(JU nitTask.java:848) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitT ask.java:556) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitT ask.java:532) at org.apache.tools.ant.Task.perform(Task.java:341) at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:232) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233) at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:88) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:279) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:135) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:233) at com.werken.werkz.jelly.GoalTag$1.performAction(GoalTag.java:128) at com.werken.werkz.Goal.fire(Goal.java:639) at com.werken.werkz.Goal.attain(Goal.java:575) at com.werken.werkz.Goal.attainPrecursors(Goal.java:488) at
[GUMP@lsd]: jelly-tags/commons-jelly-tags-junit failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For help
understanding the request please visit
http://gump.apache.org/nagged.html,
and/or contact [EMAIL PROTECTED]
Project commons-jelly-tags-junit has an issue affecting its community integration.
This issue affects 36 projects. The current state is 'Failed', for reason 'Build
Failed'
Full details are available at:
http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-junit.html, however
some snippets follow:
- - - - - -- -- G U M P
Gump provided these annotations:
- Info - Sole jar
[/data3/gump/jelly-tags/junit/target/commons-jelly-tags-junit-20040329.jar] identifier
set to project name
- Error - Failed with reason build failed
- Info - Enable debug output, due to build failure.
- - - - - -- -- G U M P
Gump performed this work:
Work Name: build_jelly-tags_commons-jelly-tags-junit (Type: Build)
State: Failed
Elapsed: 0 hours, 0 minutes, 13 seconds
Command Line: java
-Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xml-apis.jar
org.apache.tools.ant.Main -Dgump.merge=/data3/gump/gump-install/work/merge.xml
-Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-junit-20040329 jar
[Working Directory: /data3/gump/jelly-tags/junit]
-
[junit]
[junit]
[junit]
[junit] The exception was:
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:46:-1:
lt;test:failgt;
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:46:-1:
lt;test:failgt; This should always fail
[junit]
[junit]
[junit] The exception was:
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:62:-1:
lt;test:assertEqualsgt;
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:62:-1:
lt;test:assertEqualsgt; This should always fail expected:[def] but was:[abc]
[junit] Expected expression: def
[junit] Actual expression: ${foo}
[junit] Tests run: 4, Failures: 0, Errors: 1, Time elapsed: 0.291 sec
[junit] Testsuite: org.apache.commons.jelly.tags.junit.TestJUnit
[junit] Tests run: 4, Failures: 0, Errors: 1, Time elapsed: 0.291 sec
[junit] - Standard Error -
[junit] Mar 29, 2004 5:08:03 AM
org.apache.commons.jelly.tags.junit.AssertThrowsTag getThrowableClass
[junit] WARNING: The class: java.lang.Class is not an Exception class.
[junit] Mar 29, 2004 5:08:04 AM
org.apache.commons.jelly.tags.junit.AssertThrowsTag getThrowableClass
[junit] WARNING: Could not find exception class: foo.bar.Baz
[junit] - ---
[junit] Testcase: assertTests took 0.111 sec
[junit] Testcase: failTests took 0.017 sec
[junit] Testcase: assertEqualTests took 0.021 sec
[junit] Testcase: assertThrowsTests took 0.108 sec
[junit] Caused an ERROR
[junit]
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:118:-1:
test:assert
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:118:-1:
test:assert columnNumber not set. Assertion failed while evaluating test:
${ex.columnNumber gt 0}
[junit] org.apache.commons.jelly.JellyTagException:
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:118:-1:
test:assert
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:118:-1:
test:assert columnNumber not set. Assertion failed while evaluating test:
${ex.columnNumber gt 0}
[junit] at
org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:661)
[junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:250)
[junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89)
[junit] at
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] Caused by: org.apache.commons.jelly.tags.junit.JellyAssertionFailedError:
file:/data3/gump/jelly-tags/junit/target/test-classes/org/apache/commons/jelly/tags/junit/suite.jelly:118:-1:
test:assert columnNumber not set. Assertion failed while evaluating test:
${ex.columnNumber gt 0}
[junit] at
org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:39)
[junit] at
org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:50)
[junit] at
org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:58)
[junit] at
DO NOT REPLY [Bug 27589] - MultiThreadedConnectionManager should provide a shutdown
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27589. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27589 MultiThreadedConnectionManager should provide a shutdown [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tunneling non-HTTP through a web proxy with HttpClient
Here's a thought - provide get/setSocket in HttpConnection but make them protected. Then those who want to use them have to work harder (ie make a subclass) and will probably be less likely to use them incorrectly. Joe average user is unlikely to confused by them or use them this way. /Mike Sample - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tunneling non-HTTP through a web proxy with HttpClient
Agreed. This would be a better choice, as least for the short term. Mike On Mar 28, 2004, at 5:55 PM, [EMAIL PROTECTED] wrote: Here's a thought - provide get/setSocket in HttpConnection but make them protected. Then those who want to use them have to work harder (ie make a subclass) and will probably be less likely to use them incorrectly. Joe average user is unlikely to confused by them or use them this way. /Mike Sample - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
