Re: [ALL][VOTE][VFS] Promote commons-vfs to commons proper

2005-05-14 Thread Dion Gillard 
On 5/14/05, Mario Ivankovits <[EMAIL PROTECTED]> wrote:
> -- Cut Here --
> Vote to promote the "vfs" package from Sandbox to Commons proper
> [X] +1 I am in favor of this action and will help
> [ ] +0 I am in favor of this action but cannot help
> [ ] -0 I am not in favor of this action
> [ ] -1 I am opposed to this action and here is why:
> 
> Vote to release Commons VFS 1.0:
> [X] +1 I am in favor of this action and will help
> [ ] +0 I am in favor of this action but cannot help
> [ ] -0 I am not in favor of this action
> [ ] -1 I am opposed to this action and here is why:
> 
> -- Cut Here --
-- 
http://www.multitask.com.au/people/dion/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34919] - [Patch] [Email] Refactor Hashtable usage to Map

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34919





--- Additional Comments From [EMAIL PROTECTED]  2005-05-15 02:38 ---
Created an attachment (id=15031)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=15031&action=view)
Refactors Hashtable usage to Map 

I agree with you that breaking existing API's is a bad thing. However, the
project is currently at 1.0-dev and the main page itself states:

* The code is unreleased
* Methods and classes can and will appear and disappear without warning

While changing the API at this point is less than ideal, most people would
accept that there exists a potential of change between 1.0-dev and 1.0. When it
comes down to it, all we're talking about is changing a public method's return
object from a Hashtable to a Map. This is likely the last opportunity to make
this (trivial) change before the v1.0 release and it would then have to be
postponed until 1.1 (or whatever). I think changing it now is in everyone's
best interest.

Thanks,
Eric

Eric Spiegelberg wrote:

> Matt Benson wrote:
>
>>I just joined the list myself... (for sandbox
>>commons-pgp) but I noticed that in the non-checkstyle
>>changes from this patch, the signature of a public
>>method is modified in at least one place. This will
>>break already-compiled code running against the
>>library.  Over in Ant-land we consider that bad; I can
>>only assume the same would be true in Jakarta commons.
>>
>>$0.02,
>>Matt

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34919] New: - [Patch] [Email] Refactor Hashtable usage to Map

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34919

   Summary: [Patch] [Email] Refactor Hashtable usage to Map
   Product: Commons
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Email
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


This patch refactors the usage of Hashtable to the Map interface. Coding to
interfaces as opposed to implementations is considered a best practice and this
will also remove two errors from the Checkstyle report.

Thanks,
Eric Spiegelberg

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [ALL][VOTE][VFS] Promote commons-vfs to commons proper

2005-05-14 Thread Mark Diggory 
-- Cut Here --
Vote to promote the "vfs" package from Sandbox to Commons proper
[ ] +1 I am in favor of this action and will help
[X] +0 I am in favor of this action but cannot help
[ ] -0 I am not in favor of this action
[ ] -1 I am opposed to this action and here is why:
Vote to release Commons VFS 1.0:
[ ] +1 I am in favor of this action and will help
[X] +0 I am in favor of this action but cannot help
[ ] -0 I am not in favor of this action
[ ] -1 I am opposed to this action and here is why:
-- Cut Here --

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [ALL][VOTE][VFS] Promote commons-vfs to commons proper

2005-05-14 Thread Phil Steitz 
On 5/13/05, Mario Ivankovits <[EMAIL PROTECTED]> wrote:
> After long time in the sandbox I would like to promote
> commons-vfs to commons proper.
> 
> There are many user requests to enter a release cycle and
> there is consent that VFS is stable enough to offer it.
> 
> (0) Rationale
> 
> commons-vfs allows a single api to access many different
> filesystem, A plugin system allows it to extend the system
> with 3rd party libraries without the need to touch the
> core.
> 
> (1) Scope of the Package
> 
> The scope of VFS is to use other libraries to access those
> filesystems and insert as less overhead as possible.
> 
> (1.1) Currently supported filesystems
> 
> local files
> ftp
> http
> webdav
> sftp
> samba
> temporary
> 
> - and files packaged in
> zip
> jar
> tar
> gzip
> bzip2
> 
> (1.2) Access modes (depending on the filesystem capabilities)
> 
> create, list, read, write, delete, rename, random access, attributes
> 
> (2) Interaction with other packages
> 
> VFS uses junit for its testing and requires a couple
> of servers (apache, ssh, samba, ...) to pass them.
> Release 1.0 relies on jdk 1.3 only, though I have plans
> to migrate to jdk 1.5 for a release 2.0 with backward
> compatibility to jdk 1.4 using retroweaver.
> BUT this ONLY happens if a foregoing vote succeed.
> 
> Also there is a list of required resources on
> http://jakarta.apache.org/commons/sandbox/vfs/download.html
> Here the word "required" means "if the users would
> like to use a specific filesystem".
> If a library is missing VFS will not fail but do
> not provide its capabilities.
> 
> (3)  Required jakarta-commons resources
> 
> SVN Repository
> 
> Mailing List
> commons-dev/commons-user. [VFS] prefixed in the
> subject line.
> 
> Bugzilla
> http://issues.apache.org/bugzilla/
> 
> (4) Initial committers
> Adam Murdoch
> adammurdoch -at- apache.org
> 
> James Strachan
> jstrachan -at- apache.org
> 
> Dion Gillard
> dion -at- apache.org
> 
> Mario Ivankovits
> imario -at- apache.org
> 
> -- Cut Here --
> Vote to promote the "vfs" package from Sandbox to Commons proper
> [ ] +1 I am in favor of this action and will help
> [X] +0 I am in favor of this action but cannot help
> [ ] -0 I am not in favor of this action
> [ ] -1 I am opposed to this action and here is why:
> 
> Vote to release Commons VFS 1.0:
> [ ] +1 I am in favor of this action and will help
> [X] +0 I am in favor of this action but cannot help
> [ ] -0 I am not in favor of this action
> [ ] -1 I am opposed to this action and here is why:
> 
> -- Cut Here --
> 
> ---
> Mario
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34918] - [Patch] [Email] Resolve checkstyle errors

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34918





--- Additional Comments From [EMAIL PROTECTED]  2005-05-15 01:57 ---
Created an attachment (id=15030)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=15030&action=view)
Cleans up Checkstyle errors


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34918] New: - [Patch] [Email] Resolve checkstyle errors

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34918

   Summary: [Patch] [Email] Resolve checkstyle errors
   Product: Commons
   Version: unspecified
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Email
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


This patch includes trivial changes to clean up the Checkstyle reports of
Commons Email. Changes include modifying or adding missing javadoc, cleaning
indentation, curly braces, parenthesis, and removing tabs and trailing spaces at
the end of lines.

After applying this patch, Email.java contains two Checkstyle errors because of
its use of Hashtable's instead of Maps's. The 8 remaining errors indicate that
each file does not end with a newline, which they do. I assume this is an error
with the Maven-Checkstyle plugin.

Thanks,
Eric Spiegelberg

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Jakarta-commons Wiki] Update of "JakartaCommonsEtiquette" by SimonKitching

2005-05-14 Thread Apache Wiki 
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Jakarta-commons Wiki" 
for change notification.

The following page has been changed by SimonKitching:
http://wiki.apache.org/jakarta-commons/JakartaCommonsEtiquette

The comment on the change is:
Added "useful links" section

--
  
  * Please give the proposal enough time to give everything the chance to VOTE. 
I leave promotion VOTEs several days - maybe up to a week. When VOTEs have 
stopped coming in then please the proposer should post a 
[VOTE][RESULT] giving counts. Only the VOTEs of commons committers are 
binding so please make sure that these are tallied separately. The reason why a 
result email is good is that VOTE thread tend to peter out and so without a 
final email, it's hard to look back through the archives and find out what's 
happened. Another reason is that it's a good way to let everyone know what the 
result was. If there are any disagreements about the result, they can be 
resolved then. 
  
+ 
+ 
+ 
+ = Other Useful Links =
+ 
+  * http://jakarta.apache.org/site/source.html
+ 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[i18n] Re: Directory dissapeared from SVN

2005-05-14 Thread Mattias J 
Daniel, something strange must have happened here. First the latest tests 
but not the refactorings were checked in, so that the tests did not 
compile. Then the refactorings were checked in, and all the test classes 
were removed...?

Will you re-add the files so that I can create a diff, or should I just 
send you a ZIP will all the updated sources files?

At 2005-05-14 19:00, Martin Cooper wrote:
According to the Subversion logs, this change was part of a patch that
was supplied by you. Here's the relevant log entry:

r168590 | dflorey | 2005-05-06 03:36:38 -0700 (Fri, 06 May 2005) | 1 line
Changed paths:
   M /jakarta/commons/sandbox/i18n/trunk/project.properties
   M /jakarta/commons/sandbox/i18n/trunk/project.xml
   M 
/jakarta/commons/sandbox/i18n/trunk/src/examples/org/apache/i18n/examples/LocalizedExceptionExample.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/LocalizedBundle.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/MessageManager.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/ResourceBundleMessageProvider.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/XMLMessageProvider.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/bundles/ErrorBundle.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/bundles/MessageBundle.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/bundles/TextBundle.java
   D /jakarta/commons/sandbox/i18n/trunk/src/test/org/apache/commons/i18n
   D /jakarta/commons/sandbox/i18n/trunk/xdocs/downloads.xml
   M /jakarta/commons/sandbox/i18n/trunk/xdocs/index.xml

Incorporated changes proposed by Mattias J

--
Martin Cooper
On 5/14/05, Mattias J <[EMAIL PROTECTED]> wrote:
> I have made some changes to the i18n sandbox project and tried to create a
> patch for it to submit, although I noticed the patch did not contain
> everything I expected. At first I thought I had done something wrong, but
> after several tries I realized the i18n package has dissapeared from the
> test source dir in SVN; see
> 
http://svn.apache.org/repos/asf/jakarta/commons/sandbox/i18n/trunk/src/test/org/apache/commons/
>
> I have not seen any commit removing this directory (which would also be
> rather surprising), so I'm wondering has happened???

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34858] - [VFS] Files with "file:////" instead of "file:///"

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34858





--- Additional Comments From [EMAIL PROTECTED]  2005-05-14 20:54 ---
Oh ... thanks for reporting it!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34858] - [VFS] Files with "file:////" instead of "file:///"

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34858


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r170156 - in /jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local: GenericFileNameParser.java LocalFileName.java LocalFileNameParser.java WindowsFileNameParser.java

2005-05-14 Thread imario 
Author: imario
Date: Sat May 14 11:52:27 2005
New Revision: 170156

URL: http://svn.apache.org/viewcvs?rev=170156&view=rev
Log:
avoid file: for localfile filenames

PR: 34858
Reported By: Philippe Poulard

Modified:

jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java

jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileName.java

jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java

jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java

Modified: 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java?rev=170156&r1=170155&r2=170156&view=diff
==
--- 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java
 (original)
+++ 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/GenericFileNameParser.java
 Sat May 14 11:52:27 2005
@@ -16,6 +16,7 @@
 package org.apache.commons.vfs.provider.local;
 
 import org.apache.commons.vfs.FileSystemException;
+import org.apache.commons.vfs.FileName;
 
 /**
  * A general-purpose file name parser.
@@ -52,6 +53,17 @@
 throw new 
FileSystemException("vfs.provider.local/not-absolute-file-name.error", uri);
 }
 
+// do not strip the separator, BUT also return it ...
 return "/";
+}
+
+/*
+ * ... this is why whe need this:
+ * here the rootFilename can only be "/" (see above) put this "/" is also 
in the pathname
+ * so its of no value for the LocalFileName instance
+ */
+protected FileName createFileName(String scheme, final String rootFile, 
final String path)
+{
+return new LocalFileName(scheme, "", path);
 }
 }

Modified: 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileName.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileName.java?rev=170156&r1=170155&r2=170156&view=diff
==
--- 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileName.java
 (original)
+++ 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileName.java
 Sat May 14 11:52:27 2005
@@ -64,5 +64,5 @@
 buffer.append(getScheme());
 buffer.append("://");
 buffer.append(rootFile);
-} 
+}
 }

Modified: 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java?rev=170156&r1=170155&r2=170156&view=diff
==
--- 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java
 (original)
+++ 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/LocalFileNameParser.java
 Sat May 14 11:52:27 2005
@@ -78,6 +78,8 @@
 UriParser.normalisePath(name);
 final String path = name.toString();
 
-return new LocalFileName(scheme, rootFile, path);
+return createFileName(scheme, rootFile, path);
 }
+
+protected abstract FileName createFileName(String scheme, final String 
rootFile, final String path);
 }

Modified: 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java?rev=170156&r1=170155&r2=170156&view=diff
==
--- 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java
 (original)
+++ 
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/local/WindowsFileNameParser.java
 Sat May 14 11:52:27 2005
@@ -16,6 +16,7 @@
 package org.apache.commons.vfs.provider.local;
 
 import org.apache.commons.vfs.FileSystemException;
+import org.apache.commons.vfs.FileName;
 
 /**
  * A parser for Windows file names.
@@ -34,6 +35,11 @@
 throws FileSystemException
 {
 return extractWindowsRootPrefix(uri, name);
+}
+
+protected FileName createFileName(String scheme, final String rootFile, 
final String path)
+{
+return new LocalFileName(scheme, rootFile, path);

karma lists

2005-05-14 Thread Noel J. Bergman 
As configured in SVN,

  [/jakarta/commons]
  @jakarta-commons = rw

  [/jakarta/commons/sandbox]
  @jakarta-commons-sandbox = rw

anyone who has karma for Jakarta Commons has karma for Jakarta Commons
Sandbox.  Therefore, to make maintaining the lists easier, I changed them so
that the jakarta-commons-sandbox list has ONLY those people who have access
to the sandbox, but not to commons.

This should be totally transparent to all committers.  If not, let me know.

--- Noel


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: [VOTE][RESULT] Stefan Bodewig as commons proper committer

2005-05-14 Thread Noel J. Bergman 
> could someone please grant karma to Stefan ?

Done.

--- Noel

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Directory dissapeared from SVN

2005-05-14 Thread Martin Cooper 
According to the Subversion logs, this change was part of a patch that
was supplied by you. Here's the relevant log entry:


r168590 | dflorey | 2005-05-06 03:36:38 -0700 (Fri, 06 May 2005) | 1 line
Changed paths:
   M /jakarta/commons/sandbox/i18n/trunk/project.properties
   M /jakarta/commons/sandbox/i18n/trunk/project.xml
   M 
/jakarta/commons/sandbox/i18n/trunk/src/examples/org/apache/i18n/examples/LocalizedExceptionExample.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/LocalizedBundle.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/MessageManager.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/ResourceBundleMessageProvider.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/XMLMessageProvider.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/bundles/ErrorBundle.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/bundles/MessageBundle.java
   M 
/jakarta/commons/sandbox/i18n/trunk/src/java/org/apache/commons/i18n/bundles/TextBundle.java
   D /jakarta/commons/sandbox/i18n/trunk/src/test/org/apache/commons/i18n
   D /jakarta/commons/sandbox/i18n/trunk/xdocs/downloads.xml
   M /jakarta/commons/sandbox/i18n/trunk/xdocs/index.xml

Incorporated changes proposed by Mattias J


--
Martin Cooper


On 5/14/05, Mattias J <[EMAIL PROTECTED]> wrote:
> I have made some changes to the i18n sandbox project and tried to create a
> patch for it to submit, although I noticed the patch did not contain
> everything I expected. At first I thought I had done something wrong, but
> after several tries I realized the i18n package has dissapeared from the
> test source dir in SVN; see
> http://svn.apache.org/repos/asf/jakarta/commons/sandbox/i18n/trunk/src/test/org/apache/commons/
> 
> I have not seen any commit removing this directory (which would also be
> rather surprising), so I'm wondering has happened???
> 
> Thanks in advance,
>Mattias Jiderhamn
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34917] New: - Flat3Map.equals() bug

2005-05-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34917

   Summary: Flat3Map.equals() bug
   Product: Commons
   Version: unspecified
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: major
  Priority: P2
 Component: Collections
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Flat3Map.equals() fails a simple test:

public void testEquals()
{
Flat3Map map = new Flat3Map();
map.put("a", "testA");
map.put("b", "testB");
Flat3Map mapClone = new Flat3Map();
mapClone.put("a", "testB");
mapClone.put("b", "testA");

assertFalse("Maps should not be equal", map.equals(mapClone));
}

The code of Flat3Map.equals() is:

   public boolean equals(Object obj) {
if (obj == this) {
return true;
}
if (delegateMap != null) {
return delegateMap.equals(obj);
}
if (obj instanceof Map == false) {
return false;
}
Map other = (Map) obj;
if (size != other.size()) {
return false;
}
if (size > 0) {
Object otherValue = null;
switch (size) {  // drop through
case 3:
if (other.containsKey(key3) == false) {
otherValue = other.get(key3);
if (value3 == null ? otherValue != null :
!value3.equals(otherValue)) {
return false;
}
}
case 2:
if (other.containsKey(key2) == false) {
otherValue = other.get(key2);
if (value2 == null ? otherValue != null :
!value2.equals(otherValue)) {
return false;
}
}
case 1:
if (other.containsKey(key1) == false) {
otherValue = other.get(key1);
if (value1 == null ? otherValue != null :
!value1.equals(otherValue)) {
return false;
}
}
}
}
return true;
}

while it should probably be:

   public boolean equals(Object obj) {
if (obj == this) {
return true;
}
if (delegateMap != null) {
return delegateMap.equals(obj);
}
if (obj instanceof Map == false) {
return false;
}
Map other = (Map) obj;
if (size != other.size()) {
return false;
}
if (size > 0) {
Object otherValue = null;
switch (size) {  // drop through
case 3:
if (other.containsKey(key3)) {
otherValue = other.get(key3);
if (value3 == null ? otherValue != null :
!value3.equals(otherValue)) {
return false;
}
}
case 2:
if (other.containsKey(key2)) {
otherValue = other.get(key2);
if (value2 == null ? otherValue != null :
!value2.equals(otherValue)) {
return false;
}
}
case 1:
if (other.containsKey(key1)) {
otherValue = other.get(key1);
if (value1 == null ? otherValue != null :
!value1.equals(otherValue)) {
return false;
}
}
}
}
return true;
}

--
Stanislaw Osinski
http://www.carrot-search.com

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Directory dissapeared from SVN

2005-05-14 Thread Mattias J 
I have made some changes to the i18n sandbox project and tried to create a 
patch for it to submit, although I noticed the patch did not contain 
everything I expected. At first I thought I had done something wrong, but 
after several tries I realized the i18n package has dissapeared from the 
test source dir in SVN; see 
http://svn.apache.org/repos/asf/jakarta/commons/sandbox/i18n/trunk/src/test/org/apache/commons/

I have not seen any commit removing this directory (which would also be 
rather surprising), so I'm wondering has happened???

Thanks in advance,
  Mattias Jiderhamn
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Jakarta-commons Wiki] Update of "JakartaCommonsEtiquette" by SimonKitching

2005-05-14 Thread Martin Cooper 
On 5/14/05, Mattias J <[EMAIL PROTECTED]> wrote:
> At 2005-05-14 00:51, Simon Kitching wrote:
> >On Thu, 2005-05-12 at 09:44 +0200, Mattias J wrote:
> > > And if I am not currently a Jakarta commiter, but would like sandbox
> > commit
> > > access for existing sandbox projects?
> >
> >If you're not an ASF committer, then I think the current policy is that
> >no, you can't get commit access to the sandbox. However ... they can
> >always nominate you as a commons committer (or
> >any other relevant ASF project) which then gives you access to the sandbox
> >too.
> 
> So you cannot be a commons sandbox only committer?

Correct. The intent of the sandbox is to provide an area in which
existing ASF committers can explore the viability of extracting
potentially common code from an existing ASF code base into a
shareable component. (That intent has been stretched somewhat, but
that is still the real purpose of the sandbox.)

> >The main issue with having commit access is that you need to have signed
> >the appropriate legal forms.
> 
> As understand it, you must sign the CLA before anybody else commits your
> patches too.

That depends on the scale of the patches. For most patches that are
bug fixes or perhaps minor enhancements, a CLA is not generally
necessary. (I say "generally" because it may depend on your employer's
policies on IP ownership and contributing to open source projects.)
For substantial contributions, a CLA may be necessary.

--
Martin Cooper


> Anyway, a link to http://jakarta.apache.org/site/source.html or any of it's
> "parents" from the etiquette page might be appropriate.
> 
>/Mattias Jiderhamn
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[VOTE][RESULT] Stefan Bodewig as commons proper committer

2005-05-14 Thread Martin van den Bemt 
Hi all,
With 15 binding +1 votes within 21 hours, could someone please grant 
karma to Stefan ?
Welcome aboard Stefan ;)

People that voted +1 :
Martin van den Bemt
Joe Germuska
Noel J. Bergman
Phil Steitz
Oliver Zeigermann
Rory Winston
Davanum Srinivas
Daniel F. Saverse
Mario Ivankovits
James Carman
Martin Cooper
Steven Cohen
Brett Porter
Stephen Colebourne
Robert Burrel Donkin
Mvgr,
Martin
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Stefan Bodewig as commons proper committer

2005-05-14 Thread robert burrell donkin 
On Fri, 2005-05-13 at 14:53 +0200, Martin van den Bemt wrote:

> [X] +1 Let him commit
> [ ] 0
> [ ] -1 Maybe not, because..

- robert



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [Jakarta-commons Wiki] Update of "JakartaCommonsEtiquette" by SimonKitching

2005-05-14 Thread Mattias J 
At 2005-05-14 00:51, Simon Kitching wrote:
On Thu, 2005-05-12 at 09:44 +0200, Mattias J wrote:
> And if I am not currently a Jakarta commiter, but would like sandbox 
commit
> access for existing sandbox projects?

If you're not an ASF committer, then I think the current policy is that
no, you can't get commit access to the sandbox. However ... they can 
always nominate you as a commons committer (or
any other relevant ASF project) which then gives you access to the sandbox 
too.
So you cannot be a commons sandbox only committer?
The main issue with having commit access is that you need to have signed 
the appropriate legal forms.
As understand it, you must sign the CLA before anybody else commits your 
patches too.

Anyway, a link to http://jakarta.apache.org/site/source.html or any of it's 
"parents" from the etiquette page might be appropriate.


  /Mattias Jiderhamn