DO NOT REPLY [Bug 39375] - [vfs] VFS is not able to rename or move read-only files

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39375.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39375


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|VFS is not able to rename or|[vfs] VFS is not able to
   |move read-only files|rename or move read-only
   ||files




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 36873] - [lang] Extending VariableFormatter to use FormatPatterns

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=36873.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36873





--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 06:51 ---
In discussion on the mailing list.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39167] - [lang] escapeXML() - Not escaping low characters

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39167.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39167





--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 06:54 ---
There's been discussion on this on the user mailing list.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39254] - [lang] Expose DateIterator or add DateUtils.iterator(startDate, endDate)

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39254.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39254





--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 06:55 ---
Has been some discussion on the dev list. One question is whether to even keep
the DateIterator bits - should it instead be deprecated.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed

2006-04-29 Thread commons-jelly-tags-jsl development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-jsl-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 138 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-jsl-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on ant exists, no need to add for property 
maven.jar.ant-optional.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html
Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234)
[junit] at 
org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80)
[junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71)
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed

2006-04-29 Thread commons-jelly-tags-jsl development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-jsl-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 138 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-jsl-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on ant exists, no need to add for property 
maven.jar.ant-optional.
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html
Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:234)
[junit] at 
org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
[junit] at 
org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80)
[junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171)
[junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:102)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:91)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:78)
[junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:71)
[junit] at 

Re: Jira id naming convention for Jakarta projects; WAS Re: [all] Jira?

2006-04-29 Thread Oleg Kalnichevski
On Fri, 2006-04-28 at 23:58 +0200, Dennis Lundberg wrote:
 Henri Yandell wrote:
  On 4/28/06, Dennis Lundberg [EMAIL PROTECTED] wrote:
  
  I think that having a naming scheme is a good idea. From a user
  standpoint I see no reason for keeping the project ids short (3-4
  characters). If Jakarta will be sharing the Jira instance with other ASF
  projects then using a J prefix for Jakarta project should be used, like
  this:
  - JLANG
  - JDIGESTER
  - JCOLLECTIONS
  - JHTTPCORE
  
  It does seem to be that there's more interest in the full name than
  the shorter one.
  
  In terms of the J***, we should we be asking infra@ what they want to do.
 
 If infra don't require us to use a prefix then we shouldn't use one. 
 Keep it as simple as possible, but still readable.

Folks,

Then I will go ahead and try to scrap the existing project and create a
new one with JHTTPCORE as the project id. Please complain loudly if you
have any objections to that.

Oleg


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed

2006-04-29 Thread commons-jelly-tags-define development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-define-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 138 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-define-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html
Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 15 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at junit.framework.TestResult.run(TestResult.java:109)
[junit] at junit.framework.TestCase.run(TestCase.java:118)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
[junit] at junit.framework.TestSuite.run(TestSuite.java:203)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536)
[junit] Apr 29, 2006 4:32:08 AM 
org.apache.commons.jelly.expression.xpath.XPathExpression evaluate
[junit] SEVERE: Error constructing xpath
[junit] org.jaxen.XPathSyntaxException: Node-set expected
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131)
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156)
[junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101)
[junit] at 
org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78)
[junit] at 
org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] at junit.framework.TestCase.runBare(TestCase.java:127)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-define-test (in module commons-jelly) failed

2006-04-29 Thread commons-jelly-tags-define development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-define-test has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 138 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-define-test :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -WARNING- Overriding Maven properties: 
[/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties]
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define/target/test-reports



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-define-test/gump_work/build_commons-jelly_commons-jelly-tags-define-test.html
Work Name: build_commons-jelly_commons-jelly-tags-define-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 15 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/define]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar
-
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at junit.framework.TestResult.run(TestResult.java:109)
[junit] at junit.framework.TestCase.run(TestCase.java:118)
[junit] at junit.framework.TestSuite.runTest(TestSuite.java:208)
[junit] at junit.framework.TestSuite.run(TestSuite.java:203)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:536)
[junit] Apr 29, 2006 4:32:08 AM 
org.apache.commons.jelly.expression.xpath.XPathExpression evaluate
[junit] SEVERE: Error constructing xpath
[junit] org.jaxen.XPathSyntaxException: Node-set expected
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:131)
[junit] at org.jaxen.BaseXPath.init(BaseXPath.java:156)
[junit] at org.jaxen.dom4j.Dom4jXPath.init(Dom4jXPath.java:101)
[junit] at 
org.apache.commons.jelly.expression.xpath.XPathExpression.evaluate(XPathExpression.java:78)
[junit] at 
org.apache.commons.jelly.expression.ExpressionSupport.evaluateRecurse(ExpressionSupport.java:61)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:256)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] at junit.framework.TestCase.runBare(TestCase.java:127)
[junit] at junit.framework.TestResult$1.protect(TestResult.java:106)
[junit] at junit.framework.TestResult.runProtected(TestResult.java:124)
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed

2006-04-29 Thread commons-jelly-tags-html development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-html has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 138 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-html :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-html-29042006.jar] identifier set to 
project name
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html
Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build)
Work ended in a state of : Failed
Elapsed: 12 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar
-
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 
org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 

[EMAIL PROTECTED]: Project commons-jelly-tags-html (in module commons-jelly) failed

2006-04-29 Thread commons-jelly-tags-html development
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project commons-jelly-tags-html has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 138 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-jelly-tags-html :  Commons Jelly


Full details are available at:

http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [commons-jelly-tags-html-29042006.jar] identifier set to 
project name
 -DEBUG- Dependency on xml-xerces exists, no need to add for property 
maven.jar.xerces.
 -DEBUG- (Gump generated) Maven Properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/build.properties
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.xml
 -DEBUG- Maven project properties in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/project.properties
 -INFO- Project Reports in: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-reports
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-html/gump_work/build_commons-jelly_commons-jelly-tags-html.html
Work Name: build_commons-jelly_commons-jelly-tags-html (Type: Build)
Work ended in a state of : Failed
Elapsed: 12 secs
Command Line: maven --offline jar 
[Working Directory: 
/usr/local/gump/public/workspace/commons-jelly/jelly-tags/html]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/commons-jelly-tags-jsl-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-29042006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-29042006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-29042006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/packages/jaxen-1.1-beta-4/jaxen-1.1-beta-4.jar:/usr/local/gump/packages/nekohtml-0.9.5/nekohtml.jar
-
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testLowerCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:40:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 
org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:54)
[junit] at 
org.apache.commons.jelly.impl.TagScript.run(TagScript.java:262)
[junit] at 
org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
[junit] at 
org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59)
[junit] 
[junit] 
[junit] Testcase: 
testMixedCase(org.apache.commons.jelly.tags.junit.CaseTag$1): Caused an 
ERROR
[junit] 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] org.apache.commons.jelly.MissingAttributeException: 
file:/x1/gump/public/workspace/commons-jelly/jelly-tags/html/target/test-classes/org/apache/commons/jelly/html/suite.jelly:47:48:
 test:assert You must define an attribute called 'test' for this tag.
[junit] at 

DO NOT REPLY [Bug 39375] - [vfs] VFS is not able to rename or move read-only files

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39375.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39375


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 12:05 ---
@andrea: could you please provide smoe sample code about what you do here?

What I would like to know is, do you execute the rename commands is one 
sequence?
What filesystem do you use?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398153 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/junit/Asserter.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 07:00:09 2006
New Revision: 398153

URL: http://svn.apache.org/viewcvs?rev=398153view=rev
Log:
More checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/junit/Asserter.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/junit/Asserter.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/junit/Asserter.java?rev=398153r1=398152r2=398153view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/junit/Asserter.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/junit/Asserter.java
 Sat Apr 29 07:00:09 2006
@@ -1,12 +1,12 @@
 /*
  * Copyright 2003-2006 The Apache Software Foundation.
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398154 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 07:01:24 2006
New Revision: 398154

URL: http://svn.apache.org/viewcvs?rev=398154view=rev
Log:
More checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java?rev=398154r1=398153r2=398154view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java
 Sat Apr 29 07:01:24 2006
@@ -1,12 +1,12 @@
 /*
  * Copyright 2003-2006 The Apache Software Foundation.
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398156 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 07:01:47 2006
New Revision: 398156

URL: http://svn.apache.org/viewcvs?rev=398156view=rev
Log:
More checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java?rev=398156r1=398155r2=398156view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java
 Sat Apr 29 07:01:47 2006
@@ -20,7 +20,7 @@
 import org.apache.commons.jexl.util.Coercion;
 
 /**
- * Multiplication
+ * Multiplication.
  * 
  * @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
  * @version $Id$



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [lang] VariableFormatter issues

2006-04-29 Thread Oliver Heger
Tom Schindl wrote:

Gary Gregory wrote:
  

Hello:

I wonder if in the interest of getting version 2.2 out the door we
should keep VariableFormatter as-is. Anyone who likes the subclass can
obviously use it. If the feature is easy to add, we don't have to
discuss the following for post-2.2:

- Does the VariableFormatterWithFormating functionality belong in
VariableFormatter or should it be a subclass.

- It seems like we could also extend the current ${} syntax to include
the VariableFormatterWithFormating feature. Where this gets tricky and
could become difficult is if we cannot reuse MessageFormat.format. 

Tom (and all): 

Have you considered changing VariableFormatter itself to provide the
feature?




Yes but I thought if you want to turn on/off variable formatting (e.g.
because of performance issues) the API would get too bloated, you need
to duplicate all static functions, wouldn't you?

  

Would changing MapVariableResolver only do the trick?




Yes, I think so but I wasn't sure about the side-effects.

  

The implementation in the ticket subclasses VariableFormatter, why not
subclass just MapVariableResolver only?




Because of the above mentionned bloated API if you want to turn it
on/off in VariableFormatter.
  

I think part of the problem is that many method signatures expect a Map
and convert this automatically into a MapVariableResolver (e.g.
constructors of VariableFormatter, static replace() methods). This is
convenient for the users that only need the default functionality, but
makes it hard to use a different VariableResolver implementation.

Shouldn't we at least have static replace() methods that take a
VariableResolver as argument? Then a caller can decide if he/she wants a
default or a formatting enabled resolver.

Oliver

snip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398166 [4/4] - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/

2006-04-29 Thread dion
Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Token.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Token.java?rev=398166r1=398165r2=398166view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Token.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Token.java
 Sat Apr 29 07:48:32 2006
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2002-2006 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 /* Generated By:JavaCC: Do not edit this line. Token.java Version 2.1 */
 package org.apache.commons.jexl.parser;
 
@@ -7,75 +22,72 @@
 
 public class Token {
 
-  /**
-   * An integer that describes the kind of this token.  This numbering
-   * system is determined by JavaCCParser, and a table of these numbers is
-   * stored in the file ...Constants.java.
-   */
-  public int kind;
-
-  /**
-   * beginLine and beginColumn describe the position of the first character
-   * of this token; endLine and endColumn describe the position of the
-   * last character of this token.
-   */
-  public int beginLine, beginColumn, endLine, endColumn;
-
-  /**
-   * The string image of the token.
-   */
-  public String image;
-
-  /**
-   * A reference to the next regular (non-special) token from the input
-   * stream.  If this is the last token from the input stream, or if the
-   * token manager has not read tokens beyond this one, this field is
-   * set to null.  This is true only if this token is also a regular
-   * token.  Otherwise, see below for a description of the contents of
-   * this field.
-   */
-  public Token next;
-
-  /**
-   * This field is used to access special tokens that occur prior to this
-   * token, but after the immediately preceding regular (non-special) token.
-   * If there are no such special tokens, this field is set to null.
-   * When there are more than one such special token, this field refers
-   * to the last of these special tokens, which in turn refers to the next
-   * previous special token through its specialToken field, and so on
-   * until the first special token (whose specialToken field is null).
-   * The next fields of special tokens refer to other special tokens that
-   * immediately follow it (without an intervening regular token).  If there
-   * is no such token, this field is null.
-   */
-  public Token specialToken;
-
-  /**
-   * Returns the image.
-   */
-  public final String toString()
-  {
- return image;
-  }
-
-  /**
-   * Returns a new Token object, by default. However, if you want, you
-   * can create and return subclass objects based on the value of ofKind.
-   * Simply add the cases to the switch for all those special cases.
-   * For example, if you have a subclass of Token called IDToken that
-   * you want to create if ofKind is ID, simlpy add something like :
-   *
-   *case MyParserConstants.ID : return new IDToken();
-   *
-   * to the following switch statement. Then you can cast matchedToken
-   * variable to the appropriate type and use it in your lexical actions.
-   */
-  public static final Token newToken(int ofKind)
-  {
- switch(ofKind)
- {
-   default : return new Token();
- }
-  }
+/**
+ * An integer that describes the kind of this token. This numbering system
+ * is determined by JavaCCParser, and a table of these numbers is stored in
+ * the file ...Constants.java.
+ */
+public int kind;
+
+/**
+ * beginLine and beginColumn describe the position of the first character 
of
+ * this token; endLine and endColumn describe the position of the last
+ * character of this token.
+ */
+public int beginLine, beginColumn, endLine, endColumn;
+
+/**
+ * The string image of the token.
+ */
+public String image;
+
+/**
+ * A reference to the next regular (non-special) token from the input
+ * stream. If this is the last token from the input stream, or if the token
+ * manager has not read tokens beyond this one, this field is set to null.
+ * This is true only if this token is also a regular token. Otherwise, see
+ * below for a description of the contents of this field.
+ */
+public Token next;
+
+/**
+ * This field is used to access 

svn commit: r398166 [1/4] - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 07:48:32 2006
New Revision: 398166

URL: http://svn.apache.org/viewcvs?rev=398166view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpression.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTForeachStatement.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIfStatement.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMethod.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTModNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTSizeFunction.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTSizeMethod.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTStringLiteral.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/JJTParserState.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Node.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ParseException.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Parser.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ParserConstants.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ParserTokenManager.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ParserTreeConstants.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ParserVisitor.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleCharStream.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/Token.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/TokenMgrError.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java?rev=398166r1=398165r2=398166view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java
 Sat Apr 29 07:48:32 2006
@@ -27,7 +27,7 @@
 import java.lang.reflect.Array;
 
 /**
- * Like an ASTIdentifier, but with array access allowed
+ * Like an ASTIdentifier, but with array access allowed.
  * 
  * $foo[2]
  * 
@@ -35,8 +35,8 @@
  * @version $Id$
  */
 public class ASTArrayAccess extends SimpleNode {
-/** dummy velocity info */
-private static Info DUMMY = new Info(, 1, 1);
+/** dummy velocity info. */
+private static final Info DUMMY = new Info(, 1, 1);
 
 public ASTArrayAccess(int id) {
 super(id);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java?rev=398166r1=398165r2=398166view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java
 Sat Apr 29 07:48:32 2006
@@ -39,7 +39,7 @@
 }
 
 /**
- * Handle assignment ( left = right )
+ * Handle assignment ( left = right ).
  */
 public Object value(JexlContext context) throws Exception {
 // left should be the variable (reference) to assign to

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java?rev=398166r1=398165r2=398166view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java
 Sat Apr 29 07:48:32 2006
@@ -19,7 +19,23 @@
 import org.apache.commons.jexl.util.Coercion;
 
 /**
- * 

svn commit: r398171 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util: ./ introspection/

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 07:57:29 2006
New Revision: 398171

URL: http://svn.apache.org/viewcvs?rev=398171view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/AbstractExecutor.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/BooleanPropertyExecutor.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/Coercion.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/EnumerationIterator.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/GetExecutor.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/Introspector.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/PropertyExecutor.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/ClassMap.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Introspector.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/MethodMap.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/Uberspect.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/AbstractExecutor.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/AbstractExecutor.java?rev=398171r1=398170r2=398171view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/AbstractExecutor.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/AbstractExecutor.java
 Sat Apr 29 07:57:29 2006
@@ -1,12 +1,12 @@
 /*
  * Copyright 2000-2001,2004 The Apache Software Foundation.
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java?rev=398171r1=398170r2=398171view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java
 Sat Apr 29 07:57:29 2006
@@ -1,12 +1,12 @@
 /*
  * Copyright 1999-2001,2004 The Apache Software Foundation.
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/BooleanPropertyExecutor.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/BooleanPropertyExecutor.java?rev=398171r1=398170r2=398171view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/BooleanPropertyExecutor.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/BooleanPropertyExecutor.java
 Sat Apr 29 07:57:29 2006
@@ -1,12 +1,12 @@
 /*
  * Copyright 2000-2001,2004 The Apache Software Foundation.
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

Modified: 

svn commit: r398173 - /jakarta/commons/proper/jexl/trunk/src/test/org/apache/commons/jexl/BitwiseOperatorTest.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 08:00:46 2006
New Revision: 398173

URL: http://svn.apache.org/viewcvs?rev=398173view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/test/org/apache/commons/jexl/BitwiseOperatorTest.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/test/org/apache/commons/jexl/BitwiseOperatorTest.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/test/org/apache/commons/jexl/BitwiseOperatorTest.java?rev=398173r1=398172r2=398173view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/test/org/apache/commons/jexl/BitwiseOperatorTest.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/test/org/apache/commons/jexl/BitwiseOperatorTest.java
 Sat Apr 29 08:00:46 2006
@@ -1,12 +1,12 @@
 /*
  * Copyright 2002-2006 The Apache Software Foundation.
- * 
+ *
  * Licensed under the Apache License, Version 2.0 (the License);
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an AS IS BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -26,7 +26,7 @@
 public class BitwiseOperatorTest extends TestCase {
 
 /**
- * Create the named test
+ * Create the named test.
  * @param name test name
  */
 public BitwiseOperatorTest(String name) {
@@ -141,7 +141,7 @@
 Expression e = ExpressionFactory.createExpression(x | y);
 JexlContext jc = JexlHelper.createContext();
 jc.getVars().put(x, new Integer(12));
-jc.getVars().put(y, new Short((short)3));
+jc.getVars().put(y, new Short((short) 3));
 Object o = e.evaluate(jc);
 assertEquals(Result is wrong, new Long(15), o);
 }
@@ -187,7 +187,7 @@
 Expression e = ExpressionFactory.createExpression(x ^ y);
 JexlContext jc = JexlHelper.createContext();
 jc.getVars().put(x, new Integer(1));
-jc.getVars().put(y, new Short((short)3));
+jc.getVars().put(y, new Short((short) 3));
 Object o = e.evaluate(jc);
 assertEquals(Result is wrong, new Long(2), o);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398180 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTAddNode.java ASTAndNode.java ASTArrayAccess.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 08:40:35 2006
New Revision: 398180

URL: http://svn.apache.org/viewcvs?rev=398180view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAddNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAndNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAddNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAddNode.java?rev=398180r1=398179r2=398180view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAddNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAddNode.java
 Sat Apr 29 08:40:35 2006
@@ -27,12 +27,19 @@
  */
 public class ASTAddNode extends SimpleNode {
 /**
+ * Create the node given an id.
+ * 
+ * @param id node id.
  */
 public ASTAddNode(int id) {
 super(id);
 }
 
 /**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
  */
 public ASTAddNode(Parser p, int id) {
 super(p, id);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAndNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAndNode.java?rev=398180r1=398179r2=398180view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAndNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAndNode.java
 Sat Apr 29 08:40:35 2006
@@ -25,19 +25,31 @@
  * @version $Id$
  */
 public class ASTAndNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTAndNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTAndNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(jc);
 boolean leftValue = Coercion.coerceBoolean(left).booleanValue();

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java?rev=398180r1=398179r2=398180view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTArrayAccess.java
 Sat Apr 29 08:40:35 2006
@@ -38,25 +38,40 @@
 /** dummy velocity info. */
 private static final Info DUMMY = new Info(, 1, 1);
 
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTArrayAccess(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTArrayAccess(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
-/*
- * evaluate array access upon a base object
+/**
+ * evaluate array access upon a base object.
  * 
  * foo.bar[2]
  * 
  * makes me rethink the array operator :)
+ * @param jc the [EMAIL PROTECTED] JexlContext} to evaluate against.
+ * @param obj not used.
+ * @return the value of the array expression.
+ * @throws Exception on any error
  */
 public Object execute(Object obj, JexlContext jc) throws Exception {
 ASTIdentifier base = (ASTIdentifier) jjtGetChild(0);
@@ -79,9 +94,7 @@
 return result;
 }
 
-/**
- * return the value of this node
- */
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 /*
  * get the base ASTIdentifier
@@ -107,6 +120,21 @@
 return o;
 }
 
+/**
+ * Evaluate the Array 

svn commit: r398183 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTAssignment.java ASTBitwiseAndNode.java ASTBitwiseComplNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 08:49:03 2006
New Revision: 398183

URL: http://svn.apache.org/viewcvs?rev=398183view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseAndNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseComplNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java?rev=398183r1=398182r2=398183view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTAssignment.java
 Sat Apr 29 08:49:03 2006
@@ -25,22 +25,31 @@
  * 
  */
 public class ASTAssignment extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTAssignment(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTAssignment(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
-/**
- * Handle assignment ( left = right ).
- */
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext context) throws Exception {
 // left should be the variable (reference) to assign to
 SimpleNode left = (SimpleNode) jjtGetChild(0);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseAndNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseAndNode.java?rev=398183r1=398182r2=398183view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseAndNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseAndNode.java
 Sat Apr 29 08:49:03 2006
@@ -20,28 +20,37 @@
 import org.apache.commons.jexl.util.Coercion;
 
 /**
- * Bitwise And. Syntax: a  b Result is a Long
+ * Bitwise And. Syntax: a  b Result is a [EMAIL PROTECTED] Long}
  * 
  * @author Dion Gillard
  * @since 1.1
  */
 public class ASTBitwiseAndNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTBitwiseAndNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTBitwiseAndNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
-/**
- * @return a [EMAIL PROTECTED] Long} which is the bitwise and of the two 
operands.
- */
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext context) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(context);
 Object right = ((SimpleNode) jjtGetChild(1)).value(context);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseComplNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseComplNode.java?rev=398183r1=398182r2=398183view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseComplNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseComplNode.java
 Sat Apr 29 08:49:03 2006
@@ -26,22 +26,31 @@
  * @since 1.1
  */
 public class ASTBitwiseComplNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTBitwiseComplNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTBitwiseComplNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 

svn commit: r398187 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTBitwiseOrNode.java ASTBitwiseXorNode.java ASTBlock.java ASTDivNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 08:58:45 2006
New Revision: 398187

URL: http://svn.apache.org/viewcvs?rev=398187view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseOrNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseXorNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBlock.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTDivNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseOrNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseOrNode.java?rev=398187r1=398186r2=398187view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseOrNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseOrNode.java
 Sat Apr 29 08:58:45 2006
@@ -27,22 +27,31 @@
  */
 
 public class ASTBitwiseOrNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTBitwiseOrNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTBitwiseOrNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
-/**
- * @return a [EMAIL PROTECTED] Long} which is the bitwise or of the two 
operands.
- */
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext context) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(context);
 Object right = ((SimpleNode) jjtGetChild(1)).value(context);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseXorNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseXorNode.java?rev=398187r1=398186r2=398187view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseXorNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBitwiseXorNode.java
 Sat Apr 29 08:58:45 2006
@@ -26,21 +26,34 @@
  * @since 1.1
  */
 public class ASTBitwiseXorNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTBitwiseXorNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTBitwiseXorNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** 
+ * [EMAIL PROTECTED]
+ */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
-/**
- * @return a [EMAIL PROTECTED] Long} which is the bitwise xor of the two 
operands.
+/** 
+ * [EMAIL PROTECTED]
  */
 public Object value(JexlContext context) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(context);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBlock.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBlock.java?rev=398187r1=398186r2=398187view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBlock.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTBlock.java
 Sat Apr 29 08:58:45 2006
@@ -25,10 +25,21 @@
  * 
  */
 public class ASTBlock extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTBlock(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTBlock(Parser p, int id) {
 super(p, id);
 }
@@ -41,6 +52,8 @@
 /**
  * @return the value of the block. Execute all statements inside and return
  * the value of the last.
+ * @param context the [EMAIL PROTECTED] JexlContext} to execute against.
+ * @throws Exception on any error.
  */
 public Object value(JexlContext context) throws Exception {
 

svn commit: r398190 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTEQNode.java ASTEmptyFunction.java ASTExpression.java ASTExpressionExpression.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:04:10 2006
New Revision: 398190

URL: http://svn.apache.org/viewcvs?rev=398190view=rev
Log:
CheckStyle ASTE*

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEmptyFunction.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpression.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpressionExpression.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java?rev=398190r1=398189r2=398190view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEQNode.java
 Sat Apr 29 09:04:10 2006
@@ -41,19 +41,31 @@
  * @version $Id$
  */
 public class ASTEQNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTEQNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTEQNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext pc) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(pc);
 Object right = ((SimpleNode) jjtGetChild(1)).value(pc);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEmptyFunction.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEmptyFunction.java?rev=398190r1=398189r2=398190view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEmptyFunction.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTEmptyFunction.java
 Sat Apr 29 09:04:10 2006
@@ -29,10 +29,21 @@
  * @version $Id$
  */
 public class ASTEmptyFunction extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTEmptyFunction(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTEmptyFunction(Parser p, int id) {
 super(p, id);
 }

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpression.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpression.java?rev=398190r1=398189r2=398190view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpression.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpression.java
 Sat Apr 29 09:04:10 2006
@@ -24,19 +24,31 @@
  * @version $Id$
  */
 public class ASTExpression extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTExpression(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTExpression(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext context) throws Exception {
 return ((SimpleNode) jjtGetChild(0)).value(context);
 }

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpressionExpression.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpressionExpression.java?rev=398190r1=398189r2=398190view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTExpressionExpression.java
 (original)
+++ 

svn commit: r398194 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTFalseNode.java ASTFloatLiteral.java ASTForeachStatement.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:14:58 2006
New Revision: 398194

URL: http://svn.apache.org/viewcvs?rev=398194view=rev
Log:
CheckStyle ASTF*

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFalseNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFloatLiteral.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTForeachStatement.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFalseNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFalseNode.java?rev=398194r1=398193r2=398194view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFalseNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFalseNode.java
 Sat Apr 29 09:14:58 2006
@@ -25,10 +25,21 @@
  */
 public class ASTFalseNode extends SimpleNode {
 
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTFalseNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTFalseNode(Parser p, int id) {
 super(p, id);
 }

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFloatLiteral.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFloatLiteral.java?rev=398194r1=398193r2=398194view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFloatLiteral.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTFloatLiteral.java
 Sat Apr 29 09:14:58 2006
@@ -25,21 +25,34 @@
  * @version $Id$
  */
 public class ASTFloatLiteral extends SimpleNode {
+/** the value of the literal. */
 protected Float val;
 
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTFloatLiteral(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTFloatLiteral(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 return val;
 }

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTForeachStatement.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTForeachStatement.java?rev=398194r1=398193r2=398194view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTForeachStatement.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTForeachStatement.java
 Sat Apr 29 09:14:58 2006
@@ -31,29 +31,48 @@
 public class ASTForeachStatement extends SimpleNode {
 /** dummy velocity info. */
 private static final Info DUMMY = new Info(, 1, 1);
+/** index of the loop variable. */
+private static final int VAR_INDEX = 0;
+/** index of the items. */
+private static final int ITEMS_INDEX = 1;
+/** index of the code to execute. */
+private static final int STATEMENT_INDEX = 2;
 
+
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTForeachStatement(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTForeachStatement(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 Object result = null;
 /* first child is the loop variable */
-ASTReference loopVariable = (ASTReference) jjtGetChild(0);
+ASTReference loopVariable = (ASTReference) jjtGetChild(VAR_INDEX);
 /* second child is the variable to iterate */
-SimpleNode iterable = (SimpleNode) jjtGetChild(1);
+SimpleNode iterable = (SimpleNode) jjtGetChild(ITEMS_INDEX);
  

svn commit: r398197 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTGENode.java ASTGTNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:18:04 2006
New Revision: 398197

URL: http://svn.apache.org/viewcvs?rev=398197view=rev
Log:
CheckStyle ASTG*

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGENode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGTNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGENode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGENode.java?rev=398197r1=398196r2=398197view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGENode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGENode.java
 Sat Apr 29 09:18:04 2006
@@ -28,19 +28,31 @@
  * @version $Id$
  */
 public class ASTGENode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTGENode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTGENode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 /*
  * now get the values

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGTNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGTNode.java?rev=398197r1=398196r2=398197view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGTNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTGTNode.java
 Sat Apr 29 09:18:04 2006
@@ -28,19 +28,31 @@
  * @version $Id$
  */
 public class ASTGTNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTGTNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTGTNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 /*
  * now get the values



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398199 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTIdentifier.java ASTIfStatement.java ASTIntegerLiteral.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:30:05 2006
New Revision: 398199

URL: http://svn.apache.org/viewcvs?rev=398199view=rev
Log:
CheckStyle ASTI*

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIdentifier.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIfStatement.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIdentifier.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIdentifier.java?rev=398199r1=398198r2=398199view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIdentifier.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIdentifier.java
 Sat Apr 29 09:30:05 2006
@@ -25,33 +25,58 @@
  * @version $Id$
  */
 public class ASTIdentifier extends SimpleNode {
+/** the name of the variable. */
 protected String val;
 
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTIdentifier(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTIdentifier(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 return jc.getVars().get(val);
 }
 
 /**
  * returns the value of itself applied to the object. We assume that an
- * identifier can be gotten via a get(String)
+ * identifier can be gotten via a get(String).
+ * e.g. if we have bean.property, 'property' has been parsed as an 
identifier,
+ * and we need to resolve the expression by calling the property getter.
+ * 
+ * @param obj the object to evaluate against.
+ * @param jc the [EMAIL PROTECTED] JexlContext}.
+ * @throws Exception on any error.
+ * @return the resulting value.
+ * @see ASTArrayAccess#evaluateExpr(Object, Object)
  */
 public Object execute(Object obj, JexlContext jc) throws Exception {
 return ASTArrayAccess.evaluateExpr(obj, val);
 }
 
+/** 
+ * Gets the name of the variable.
+ * @return the variable name.
+ */
 public String getIdentifierString() {
 return val;
 }

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIfStatement.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIfStatement.java?rev=398199r1=398198r2=398199view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIfStatement.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIfStatement.java
 Sat Apr 29 09:30:05 2006
@@ -26,19 +26,33 @@
  * @since 1.1
  */
 public class ASTIfStatement extends SimpleNode {
+/** child index of the else statement to execute. */
+private static final int ELSE_STATEMENT_INDEX = 2;
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTIfStatement(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTIfStatement(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 Object result = null;
 /* first child is the expression */
@@ -48,7 +62,7 @@
 result = ((SimpleNode) jjtGetChild(1)).value(jc);
 } else {
 // if there is a false, execute it
-if (jjtGetNumChildren() == 3) {
+if (jjtGetNumChildren() == ELSE_STATEMENT_INDEX + 1) {
 result = ((SimpleNode) jjtGetChild(2)).value(jc);
 }
 }

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java?rev=398199r1=398198r2=398199view=diff

svn commit: r398200 - in /jakarta/commons/sandbox/jci/trunk: ./ compilers/eclipse/src/java/org/apache/commons/jci/compilers/ compilers/groovy/src/java/org/apache/commons/jci/compilers/ compilers/janin

2006-04-29 Thread tcurdt
Author: tcurdt
Date: Sat Apr 29 09:31:08 2006
New Revision: 398200

URL: http://svn.apache.org/viewcvs?rev=398200view=rev
Log:
added some docs, since we store bytes also read bytes, always use the proper 
resources paths, typesafe CompilationResult constructor, general cleanups

Modified:
jakarta/commons/sandbox/jci/trunk/TODO

jakarta/commons/sandbox/jci/trunk/compilers/eclipse/src/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java

jakarta/commons/sandbox/jci/trunk/compilers/groovy/src/java/org/apache/commons/jci/compilers/GroovyJavaCompiler.java

jakarta/commons/sandbox/jci/trunk/compilers/janino/src/java/org/apache/commons/jci/compilers/JaninoJavaCompiler.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/compilers/AbstractJavaCompiler.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/compilers/CompilationResult.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/compilers/JavaCompiler.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/compilers/JavaCompilerFactory.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitor.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/readers/FileResourceReader.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/readers/MemoryResourceReader.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/readers/ResourceReader.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/stores/FileResourceStore.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/stores/MemoryResourceStore.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/stores/ResourceStore.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/stores/ResourceStoreClassLoader.java

jakarta/commons/sandbox/jci/trunk/core/src/java/org/apache/commons/jci/stores/TransactionalResourceStore.java

jakarta/commons/sandbox/jci/trunk/tests/src/test/org/apache/commons/jci/CompilerUtils.java

jakarta/commons/sandbox/jci/trunk/tests/src/test/org/apache/commons/jci/MyBar.java

jakarta/commons/sandbox/jci/trunk/tests/src/test/org/apache/commons/jci/readers/FileResourceReaderTestCase.java

Modified: jakarta/commons/sandbox/jci/trunk/TODO
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/TODO?rev=398200r1=398199r2=398200view=diff
==
--- jakarta/commons/sandbox/jci/trunk/TODO (original)
+++ jakarta/commons/sandbox/jci/trunk/TODO Sat Apr 29 09:31:08 2006
@@ -1,12 +1,10 @@
 o integrate just4log into the build system (or a different logging solution?)
-o compiler factory
 o compiler implementations
   o javac 
   o jikes
   o pizza
   o jruby
   o jpython
-o make suffixes matching (*.java, *.class) configurable
 o turn the JavaCompilerFactory into an interface and maybe provide a simple 
default impl
 o documentation
 o dependency analysis for proper re-try after errors

Modified: 
jakarta/commons/sandbox/jci/trunk/compilers/eclipse/src/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/jci/trunk/compilers/eclipse/src/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java?rev=398200r1=398199r2=398200view=diff
==
--- 
jakarta/commons/sandbox/jci/trunk/compilers/eclipse/src/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
 (original)
+++ 
jakarta/commons/sandbox/jci/trunk/compilers/eclipse/src/java/org/apache/commons/jci/compilers/EclipseJavaCompiler.java
 Sat Apr 29 09:31:08 2006
@@ -26,6 +26,7 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.StringTokenizer;
+
 import org.apache.commons.jci.problems.CompilationProblem;
 import org.apache.commons.jci.readers.ResourceReader;
 import org.apache.commons.jci.stores.ResourceStore;
@@ -90,7 +91,7 @@
 }
 
 public char[] getContents() {
-return reader.getContent(fileName);
+return new String(reader.getBytes(fileName)).toCharArray();
 }
 
 public char[] getMainTypeName() {
@@ -266,6 +267,8 @@
 
 compiler.compile(compilationUnits);
 
-return new 
org.apache.commons.jci.compilers.CompilationResult(problems);
+final CompilationProblem[] result = new 
CompilationProblem[problems.size()];
+problems.toArray(result);
+return new org.apache.commons.jci.compilers.CompilationResult(result);
 }
 }

Modified: 
jakarta/commons/sandbox/jci/trunk/compilers/groovy/src/java/org/apache/commons/jci/compilers/GroovyJavaCompiler.java
URL: 

svn commit: r398202 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:40:34 2006
New Revision: 398202

URL: http://svn.apache.org/viewcvs?rev=398202view=rev
Log:
make val protected rather than just package

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java?rev=398202r1=398201r2=398202view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTIntegerLiteral.java
 Sat Apr 29 09:40:34 2006
@@ -25,7 +25,7 @@
  */
 public class ASTIntegerLiteral extends SimpleNode {
 /** literal value. */
-Integer val;
+protected Integer val;
 
 /**
  * Create the node given an id.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398203 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTJexlScript.java ASTLENode.java ASTLTNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:44:55 2006
New Revision: 398203

URL: http://svn.apache.org/viewcvs?rev=398203view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTJexlScript.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLENode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLTNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTJexlScript.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTJexlScript.java?rev=398203r1=398202r2=398203view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTJexlScript.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTJexlScript.java
 Sat Apr 29 09:44:55 2006
@@ -24,19 +24,31 @@
  * @since 1.1
  */
 public class ASTJexlScript extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTJexlScript(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTJexlScript(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 int numChildren = jjtGetNumChildren();
 Object result = null;

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLENode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLENode.java?rev=398203r1=398202r2=398203view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLENode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLENode.java
 Sat Apr 29 09:44:55 2006
@@ -28,19 +28,31 @@
  * @version $Id$
  */
 public class ASTLENode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTLENode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTLENode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 /*
  * now get the values

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLTNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLTNode.java?rev=398203r1=398202r2=398203view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLTNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTLTNode.java
 Sat Apr 29 09:44:55 2006
@@ -29,19 +29,31 @@
  * @version $Id$
  */
 public class ASTLTNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTLTNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTLTNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 /*
  * now get the values



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398206 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTMethod.java ASTModNode.java ASTMulNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 09:51:38 2006
New Revision: 398206

URL: http://svn.apache.org/viewcvs?rev=398206view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMethod.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTModNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMethod.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMethod.java?rev=398206r1=398205r2=398206view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMethod.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMethod.java
 Sat Apr 29 09:51:38 2006
@@ -31,22 +31,39 @@
 /** dummy velocity info. */
 private static final Info DUMMY = new Info(, 1, 1);
 
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTMethod(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTMethod(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
 /**
- * returns the value of itself applied to the object. We assume that an
- * identifier can be gotten via a get(String)
+ * evaluate a method invocation upon a base object.
+ * 
+ * foo.bar(2)
+ * 
+ * @param jc the [EMAIL PROTECTED] JexlContext} to evaluate against.
+ * @param obj The object to have the method invoked.
+ * @return the value of the method invocation.
+ * @throws Exception on any error
  */
 public Object execute(Object obj, JexlContext jc) throws Exception {
 String methodName = ((ASTIdentifier) jjtGetChild(0)).val;
@@ -103,6 +120,8 @@
  * will fail, but a call to substring(int,int) with an int and a short will
  * succeed.
  * 
+ * @param original the original number.
+ * @return a value of the smallest type the original number will fit into.
  * @since 1.1
  */
 private Number narrow(Number original) {

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTModNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTModNode.java?rev=398206r1=398205r2=398206view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTModNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTModNode.java
 Sat Apr 29 09:51:38 2006
@@ -26,19 +26,31 @@
  * @version $Id$
  */
 public class ASTModNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTModNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTModNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(jc);
 Object right = ((SimpleNode) jjtGetChild(1)).value(jc);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java?rev=398206r1=398205r2=398206view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTMulNode.java
 Sat Apr 29 09:51:38 2006
@@ -26,19 +26,31 @@
  * @version $Id$
  */
 public class ASTMulNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTMulNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTMulNode(Parser p, int id) 

Re: Jira id naming convention for Jakarta projects; WAS Re: [all] Jira?

2006-04-29 Thread Henri Yandell

On 4/29/06, Oleg Kalnichevski [EMAIL PROTECTED] wrote:

On Fri, 2006-04-28 at 23:58 +0200, Dennis Lundberg wrote:
 Henri Yandell wrote:

  In terms of the J***, we should we be asking infra@ what they want to do.

 If infra don't require us to use a prefix then we shouldn't use one.
 Keep it as simple as possible, but still readable.

Folks,

Then I will go ahead and try to scrap the existing project and create a
new one with JHTTPCORE as the project id. Please complain loudly if you
have any objections to that.


Let me find out if Infra are worried about clash with prefix or not.
If not, then it'll be HTTPCORE.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39449] New: - Alternate implementations of ResettableIterator

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39449.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39449

   Summary: Alternate implementations of ResettableIterator
   Product: Commons
   Version: unspecified
  Platform: All
OS/Version: other
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Collections
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Relates to Discussion on Mailing List:

first.patch turns ListIteratorWrapper into an ResettableIterator, and adds
ResettableListIteratorWrapper, which yields a ResettableListIterator from every 
List

second.patch - some more implementations of Decorators adding Resettability

third.patch - the reason I'm interested in resettability: CartesianIterator

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39449] - Alternate implementations of ResettableIterator

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39449.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39449





--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 19:10 ---
Created an attachment (id=18206)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=18206action=view)
Enhancement of ListIteratorWrapper


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39449] - Alternate implementations of ResettableIterator

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39449.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39449





--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 19:11 ---
Created an attachment (id=18207)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=18207action=view)
Three other ResettableIterators


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39449] - Alternate implementations of ResettableIterator

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39449.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39449





--- Additional Comments From [EMAIL PROTECTED]  2006-04-29 19:12 ---
Created an attachment (id=18208)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=18208action=view)
CartesianIterator


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [collections] suggested extensions to package oacc.iterator

2006-04-29 Thread Thomas Schapitz

Sorry for getting back that late, but I finally found the time to
add a sequence of patches to bugzilla for this: 
http://issues.apache.org/bugzilla/show_bug.cgi?id=39449


Stephen Colebourne schrieb:

Looking for a way, to turn any existing iterator into one,
that can be exercised repeatedly, I stumbled upon the classes/if's
ResettableIterator, AbstractIteratorDecorator, and ListIteratorWrapper,
but didn't actually found an elegant solution for this. Obviously, the
simplest option to include something like this into collections, was to
turn ListIteratorWrapper into a ResettableIterator by implementing the
reset() method.

I'd welcome an patch for this with tests.


.. added in first.patch



1.)
A derivation of AbstractIteratorDecorator, with the only function to
record the returned elements,
as they are traversed - candidate name: CachedIterator or
CachedIteratorDecorator.
This Decorator would use a List as cache, which could either be
injected, or created automatically;
This sounds no different to ListIteratorWrapper, or 
IteratorUtils.toList(). IMHO, [collections] is probably over 
abstracted now.
in a package with basic implemtations like this, I wouldn't mind a 
decent amount of abstractness

2.)
An Iterator, that wraps a list similar the manor, ArrayIterator wraps 
access

to an array, with the possible extension, that reset() and add() would
be supported too.
Why not just call iterator() on the List object? Perhaps you mean a 
ResettableIteratorWrapper, which could be useful.
.. the latter. Added as ResettableListIteratorWrapper, also in 
first.patch. But I'm not exactly happy with the name. But then, I'm no 
native speaker?



3.) Combining the two into ResettableCachedIterator (involves using
ChainedIterator to do the trick)
I'm suggesting to use the infix 'Cached' here, because there is the
possibility of a completely different implementation of a decorator
allowing resettability: by passing a factory, that is reproducing the
underlying iterator on reset, if necessary; The difference is obvious:
the cached approach is guaranteed to reproduce the sequence of elements
exactly, the factory appraoch is not;

This is probably best achieved as a patch to ListIteratorWrapper.


4.) Retrofitting ListIteratorWrapper, to use 1.) and 2.)
Changing a superclass is a binary incompatible change, so we couldn't 
do that.
As of Java Language Spec Chap 13.4: not so. Changing the inheritance 
will only affect binary compatibility, if you are dropping members or 
reducing their visibility, which will not happen when wedging an 
additional class into the tree.





5.) Writing a Decorator, that converts a ResettableIterator into a
LoopingIterator

Could be done but probably of limited value.

I dropped 3.) to 4.), mostly because I'm already wayward from my 
original goals, but also because one of some of the experiments included 
in second.patch.


In there is ResettableListIteratorDecorator which does, what actually I 
intended with 4.) turning any Iterator into an Resettable(List)Iterator. 
Thus it could be a binary compatible replacement for 
ListIteratorWrapper, if it wasn't semantically different, in that it is 
actually supporting the optional operations in a limited manner.


The other two provide total different aproaches:

- ResettableIteratorDecorator uses a Factory, that should simply 
reproduce the iterator on reset()

- RewindingDecorator rewinds a ListeIterator using previous()

The former might be interesting for wrapping JdbcQuerys, especially if 
you in fact want to see changes, that appeared in the db between passes, 
the latter is a bit over the top.


The reason for my interest in resettable iterators is the 
CartesianIterator in third.patch.


Names: I'm a bit uneasy with the suffix *Wrapper because:
- the way we use it here seems to indicate, that we wrap ListIterator or 
ResettableListIterator, while we are actually Wrapping an Iterator or 
List respectively.
- The developer guide of commons actually states, that the class names 
should be suffixed with the collection types.

Frankly, I'm a bit at a loss there.

If the commiters would shoot out with a vote, which of those classes are 
likely to be committed, I would start integrating the corresponding 
constructors into IteratorUtils and the Test into iterator.TestAll (yes, 
there are tests in the patches!)


Thomas



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [collections] suggested extensions to package oacc.iterator

2006-04-29 Thread Thomas Schapitz
P. S.: As comments and constructors in second.patch  third.patch need 
still some honing,

they certainly shouldn't be integrated right away. ;-)
Thomas



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [proposal] JSExtensions - Integrating Java into Javascript

2006-04-29 Thread Martin Cooper

On 4/27/06, Don Brown [EMAIL PROTECTED] wrote:


I propose a new commons sandbox project, JSExtensions, aimed at providing
a
library of server-side Javascript (Rhino ATM) extensions that better
integrate Java into the Javascript environment.  This is implemented in
two
areas:

- Making the Java collections more natural to Javascript
- Extending the Java API to add convenience properties and methods



Sounds fine to me. Interesting implementation, too. ;-)

--
Martin Cooper


The inital code will come from Struts Flow[1], a Struts sandbox project that

brought server-side Javascript to Struts.  In its development, I looked at
Groovy and saw how they improved the Java API [2] to make it better
integrated and more natural in the Groovy environment.  I brought its
ideas
over to Struts Flow [3], attempting to do the same for Javascript.  This
code is better suited as an individual project, usable by other
Javascript-using Apache projects like Cocoon.  In addition, these changes
make Javascript equally appropriate for standalone shell scripting-type
tasks.

As a quick example, here is the eachLine() extension method on the
java.io.File object, printing each line's contents to System.out:

file = new java.io.File(foo.txt);
file.eachLine(function(line) { print(line) });


To be clear, this proposal has nothing to do with client-side Javascript,
only server-side Javascript through Rhino and soon Java 6.  The code
already
runs and uses a special unit testing framework for testing.  Looking
forward
to the feedback.

Don

[1] http://struts.apache.org/struts-sandbox/struts-flow/
[2] http://groovy.codehaus.org/groovy-jdk.html
[3]
http://struts.apache.org/struts-sandbox/struts-flow/FileExtensions.html(one
example)




DO NOT REPLY [Bug 39450] New: - [scxml] please add datamodel explanation and examples to user guide

2006-04-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39450.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39450

   Summary: [scxml] please add datamodel explanation and examples to
user guide
   Product: Commons
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: SCXML
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


As you requested here is a reminder for this important topic to be
inserted/updated in the user guide ... thanks

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398270 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTNENode.java ASTNotNode.java ASTNullLiteral.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 20:02:58 2006
New Revision: 398270

URL: http://svn.apache.org/viewcvs?rev=398270view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNotNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNullLiteral.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java?rev=398270r1=398269r2=398270view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
 Sat Apr 29 20:02:58 2006
@@ -25,19 +25,31 @@
  * @version $Id$
  */
 public class ASTNENode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTNENode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTNENode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext pc) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(pc);
 Object right = ((SimpleNode) jjtGetChild(1)).value(pc);

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNotNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNotNode.java?rev=398270r1=398269r2=398270view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNotNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNotNode.java
 Sat Apr 29 20:02:58 2006
@@ -26,19 +26,31 @@
  */
 
 public class ASTNotNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTNotNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTNotNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 Object val = ((SimpleNode) jjtGetChild(0)).value(jc);
 

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNullLiteral.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNullLiteral.java?rev=398270r1=398269r2=398270view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNullLiteral.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNullLiteral.java
 Sat Apr 29 20:02:58 2006
@@ -24,19 +24,31 @@
  * @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
  */
 public class ASTNullLiteral extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTNullLiteral(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTNullLiteral(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext context) {
 return null;
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398271 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 20:05:47 2006
New Revision: 398271

URL: http://svn.apache.org/viewcvs?rev=398271view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java?rev=398271r1=398270r2=398271view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/SimpleNode.java
 Sat Apr 29 20:05:47 2006
@@ -163,7 +163,7 @@
  * Gets the value of this node.
  * 
  * @param context the context to retrieve values from.
- * @return the result of addition.
+ * @return the value of the node.
  * @throws Exception when evaluating the operands fails.
  */
 public Object value(JexlContext context) throws Exception {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r398272 - in /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser: ASTOrNode.java ASTReference.java

2006-04-29 Thread dion
Author: dion
Date: Sat Apr 29 20:14:01 2006
New Revision: 398272

URL: http://svn.apache.org/viewcvs?rev=398272view=rev
Log:
Checkstyle

Modified:

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTOrNode.java

jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTReference.java

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTOrNode.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTOrNode.java?rev=398272r1=398271r2=398272view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTOrNode.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTOrNode.java
 Sat Apr 29 20:14:01 2006
@@ -25,19 +25,31 @@
  * @version $Id$
  */
 public class ASTOrNode extends SimpleNode {
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTOrNode(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTOrNode(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 Object left = ((SimpleNode) jjtGetChild(0)).value(jc);
 boolean leftValue = Coercion.coerceBoolean(left).booleanValue();

Modified: 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTReference.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTReference.java?rev=398272r1=398271r2=398272view=diff
==
--- 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTReference.java
 (original)
+++ 
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTReference.java
 Sat Apr 29 20:14:01 2006
@@ -24,29 +24,54 @@
  * @version $Id$
  */
 public class ASTReference extends SimpleNode {
-SimpleNode root;
+/** first variable in the expression. */
+protected SimpleNode root;
 
+/**
+ * Create the node given an id.
+ * 
+ * @param id node id.
+ */
 public ASTReference(int id) {
 super(id);
 }
 
+/**
+ * Create a node with the given parser and id.
+ * 
+ * @param p a parser.
+ * @param id node id.
+ */
 public ASTReference(Parser p, int id) {
 super(p, id);
 }
 
-/** Accept the visitor. * */
+/** [EMAIL PROTECTED] */
 public Object jjtAccept(ParserVisitor visitor, Object data) {
 return visitor.visit(this, data);
 }
 
+/** [EMAIL PROTECTED] */
 public Object value(JexlContext jc) throws Exception {
 return execute(null, jc);
 }
 
+/** Store the first child as [EMAIL PROTECTED] ASTReference#root root}. */
 public void jjtClose() {
 root = (SimpleNode) jjtGetChild(0);
 }
 
+/**
+ * evaluate each piece of the reference.
+ * 
+ * e.g. foo.bar.woogie[2].name, foo is our 'root', and we need to
+ * evaluate 'bar.woogie[2].name' relative to foo.
+ * 
+ * @param jc the [EMAIL PROTECTED] JexlContext} to evaluate against.
+ * @param obj not used. root.value(jc) is used instead.
+ * @return the value of the array expression.
+ * @throws Exception on any error
+ */
 public Object execute(Object obj, JexlContext jc) throws Exception {
 Object o = root.value(jc);
 
@@ -89,6 +114,13 @@
 return varName.toString();
 }
 
+/**
+ * Gets the variable name of [EMAIL PROTECTED] ASTReference#root root}.
+ * @return the identifier.
+ * @throws Exception on any error
+ * @see ASTIdentifier#getIdentifierString()
+ * @see ASTArrayAccess#getIdentifierString()
+ */
 public String getRootString() throws Exception {
 if (root instanceof ASTIdentifier) {
 return ((ASTIdentifier) root).getIdentifierString();



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]