[jira] Commented: (BEANUTILS-258) Improve Converter Implementations
[
http://issues.apache.org/jira/browse/BEANUTILS-258?page=comments#action_12460981
]
Bradley Schaefer commented on BEANUTILS-258:
I think the current version of AbstractConverter (474175) has some rough spots.
1) I think this class should probably be immutable.
Right now there is a state variable, useDefault, which introduces some
potential threadsafety concerns since public void setDefaultValue(Object
defaultValue) flips it while the protected Object handleError(Class type,
Object value, Exception ex) method as well as the protected Object
handleMissing(Class type) method checks the value of useDefault to decide how
to behave. Those methods may be called asynchronously since they are triggered
by the method public Object convert(Class type, Object value), so there's room
for some unusual behavior based on the state. If this class were immutable,
this could be avoided, and it would take the burden off of the user from
understanding any sort of implementation detail relating to using converters in
threads.
2) I don't understand the hardcoded behavior for String.class and
StringBuffer.class in public Object convert(Class type, Object value) .. it
leads to some inconsistent behavior -- for example I added three very similar
test cases into ConvertUtilsTestCase, and they all behaved differently (albeit
in a weird edge case):
public void testNullStringConversion() throws Exception {
final Converter nullConverter = new AbstractConverter(String.class) {
public Object convertToType(Class clazz, Object obj) { return null;
}
};
ConvertUtils.register(nullConverter, String.class);
Object result = ConvertUtils.convert((String)null, String.class);
assertNull(null String conversion failed (1), result); // passes
result = ConvertUtils.convert(testNullStringConversion, String.class);
assertNull(null String conversion failed (2), result); // fails
result is testNullStringConversion
}
public void testNullStringBufferConversion() throws Exception {
final Converter nullConverter = new
AbstractConverter(StringBuffer.class) {
public Object convertToType(Class clazz, Object obj) { return null;
}
};
ConvertUtils.register(nullConverter, StringBuffer.class);
Object result = ConvertUtils.convert((String)null, StringBuffer.class);
assertNull(null StringBuffer conversion failed (1), result); // fails
- result is a new StringBuffer()
Object result2 = ConvertUtils.convert(testNullStringBufferConversion,
StringBuffer.class);
assertNull(null StringBuffer conversion failed (2), result2); //
passes
}
public void testNullObjectConversion() throws Exception {
final Converter nullConverter = new AbstractConverter(Object.class) {
public Object convertToType(Class clazz, Object obj) { return null;
}
};
ConvertUtils.register(nullConverter, Object.class);
Object result2 = ConvertUtils.convert(testNullObjectConversion,
Object.class);
assertNull(null Object conversion failed (2), result2); // passes
Object result = ConvertUtils.convert((String)null, Object.class);
//fails ConversionException: No value specified for 'Object'
assertNull(null Object conversion failed (1), result);
}
3) AbstractConverter doesn't need the concept of a defaultType. I think that
reduces the flexibility of this class, since it's conceivable that you might
want to make one Converter that works on a number of Types, but that would be
confusing with this implementation. Of course one might argue that one should
implement their own Converter in that situation -- but if it was to behave
similarly to any of the default converters using AbstractConverter as a base
class, they would have a difficult time reproducing the same quirky behavior.
My proposed solution is to have a much simpler immutable Abstract base class.
package org.apache.commons.beanutils.converters;
import org.apache.commons.beanutils.Converter;
import org.apache.commons.beanutils.ConversionException;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
/**
* p
* Basic [EMAIL PROTECTED] org.apache.commons.beanutils.Converter}
implementation that provides the structure
* for handling converting an arbitrary value to a target type, optionally
* using a default value.
* /p
*
* p
* Implementations are encouraged to override the
* [EMAIL PROTECTED] #canConvert(Class, Class)} method if they are unable to
handle
* converting every type of value to a target type.
* /p
*
* @version $Revision: $ $Date: $
* @since 1.8.0
*/
public abstract class MyAbstractConverter2 implements Converter {
/** Logging for this instance. */
protected final Log log = LogFactory.getLog(getClass());
private final Object defaultValue;
/**
[EMAIL PROTECTED]: Project commons-jelly-tags-soap (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-soap has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-soap : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-soap-27122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-soap -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.axis. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.jaxrpc-api. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.saaj-api. -DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for property maven.jar.servletapi. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 2027122006, vmgump.apache.org:vmgump-public:2027122006 Gump E-mail Identifier (unique within run) #29. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-soap (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-soap has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-soap : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-soap-27122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-soap -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.axis. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.jaxrpc-api. -DEBUG- Dependency on ws-axis exists, no need to add for property maven.jar.saaj-api. -DEBUG- Dependency on jakarta-servletapi-5-servlet exists, no need to add for property maven.jar.servletapi. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-soap/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 2027122006, vmgump.apache.org:vmgump-public:2027122006 Gump E-mail Identifier (unique within run) #29. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jaxme has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jaxme : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-jaxme-27122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-js on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-xs on: Maven on Project:commons-jelly-tags-jaxme -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 2027122006, vmgump.apache.org:vmgump-public:2027122006 Gump E-mail Identifier (unique within run) #37. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jaxme (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jaxme has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Configuration Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jaxme : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-jaxme-27122006.jar] identifier set to project name -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- No such project [ws-jaxme] for property. -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-js on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-api on: Maven on Project:commons-jelly-tags-jaxme -ERROR- Cannot resolve output/outputpath of *unknown* [ws-jaxme] -ERROR- Unhandled Property: maven.jar.jaxme-xs on: Maven on Project:commons-jelly-tags-jaxme -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -INFO- Failed with reason configuration failed -ERROR- Bad Dependency. Project: ws-jaxme unknown to *this* workspace -INFO- Failed to extract fallback artifacts from Gump Repository To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/rss.xml - Atom: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jaxme/atom.xml == Gump Tracking Only === Produced by Gump version 2.2. Gump Run 2027122006, vmgump.apache.org:vmgump-public:2027122006 Gump E-mail Identifier (unique within run) #37. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JIRA permissions
Henri Yandell flamefew at gmail.com writes: I would like to be added to jakarta-developers as well. Done. Thanks, Hen. Jörg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 79 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-27122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:64) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:59) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:263) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:66) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:113) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:161) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-jsl-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 79 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-jsl-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on ant exists, no need to add for property maven.jar.ant-optional. -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-jsl-test/gump_work/build_commons-jelly_commons-jelly-tags-jsl-test.html Work Name: build_commons-jelly_commons-jelly-tags-jsl-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/jsl] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/commons-cli-1.0.x/target/commons-cli-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/log/target/commons-jelly-tags-log-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/xml/target/commons-jelly-tags-xml-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-27122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:64) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:59) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:263) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:66) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:113) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:96) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:187) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:161) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:59) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:80) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:171) [junit]
[EMAIL PROTECTED]: Project commons-jelly-tags-fmt-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-fmt-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 23 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-fmt-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/gump_work/build_commons-jelly_commons-jelly-tags-fmt-test.html Work Name: build_commons-jelly_commons-jelly-tags-fmt-test (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-27122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/commons-jelly-tags-fmt-27122006.jar - [junit] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) [junit] at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) [junit] at java.net.URLClassLoader.access$100(URLClassLoader.java:56) [junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:195) [junit] at java.security.AccessController.doPrivileged(Native Method) [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:188) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306) [junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:251) [junit] at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:128)
[EMAIL PROTECTED]: Project commons-jelly-tags-fmt-test (in module commons-jelly) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-fmt-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 23 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-fmt-test : Commons Jelly Full details are available at: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on xml-xerces exists, no need to add for property maven.jar.xerces. -WARNING- Overriding Maven properties: [/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties] -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/project.properties -INFO- Project Reports in: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/test-reports The following work was performed: http://vmgump.apache.org/gump/public/commons-jelly/commons-jelly-tags-fmt-test/gump_work/build_commons-jelly_commons-jelly-tags-fmt-test.html Work Name: build_commons-jelly_commons-jelly-tags-fmt-test (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-commands-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/usr/local/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/target/commons-jelly-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/ant/target/commons-jelly-tags-ant-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/beanshell/target/commons-jelly-tags-beanshell-27122006.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/junit/target/commons-jelly-tags-junit-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-27122006.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-27122006.jar:/usr/local/gump/public/workspace/dom4j/build/dom4j.jar:/usr/local/gump/public/workspace/jaxen/target/jaxen-27122006.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/usr/local/gump/public/workspace/commons-jelly/jelly-tags/fmt/target/commons-jelly-tags-fmt-27122006.jar - [junit] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:124) [junit] at java.net.URLClassLoader.defineClass(URLClassLoader.java:260) [junit] at java.net.URLClassLoader.access$100(URLClassLoader.java:56) [junit] at java.net.URLClassLoader$1.run(URLClassLoader.java:195) [junit] at java.security.AccessController.doPrivileged(Native Method) [junit] at java.net.URLClassLoader.findClass(URLClassLoader.java:188) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:306) [junit] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:268) [junit] at java.lang.ClassLoader.loadClass(ClassLoader.java:251) [junit] at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319) [junit] at org.apache.commons.jelly.tags.ant.AntTagLibrary.createProject(AntTagLibrary.java:128)
[transaction] JDK 1.3 compatibility
Hello, when playing around with commons transaction I did a test compile with JDK 1.3. I wonder if we can still claim that 1.3 is the minimum requirement. One bug in the build.xml I fixed already [1]. But you still can't compile commons transaction with JDK 1.3 as it fails for ResourceManager extending javax.transaction.Status being JDK 1.4 compiled. Even compiling it with 1.4 and just running with 1.3 will fail as long as you don't provide the jta classes compiled with 1.3 - and I wonder if that exists. I don't see a problem if it would be only the jta/jca stuff requiring 1.4, but would like to see it clearly separated in the source tree then. (side note: How do other commons projects handle this?) But with ResourceManager and javax.transaction.Status that's not possible. Regards Jörg [1] http://svn.apache.org/viewvc?view=revrevision=490420 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [transaction] JDK 1.3 compatibility
On 12/27/06, Joerg Heinicke [EMAIL PROTECTED] wrote: Hello, when playing around with commons transaction I did a test compile with JDK 1.3. I wonder if we can still claim that 1.3 is the minimum requirement. One bug in the build.xml I fixed already [1]. But you still can't compile commons transaction with JDK 1.3 as it fails for ResourceManager extending javax.transaction.Status being JDK 1.4 compiled. Even compiling it with 1.4 and just running with 1.3 will fail as long as you don't provide the jta classes compiled with 1.3 - and I wonder if that exists. snip/ I think there should be 1.3 compatible binaries for JTA (as part of J2EE 1.3 compat requirements). Perhaps its just a matter of finding them or pinging the project that is producing the ones you are using. I don't see a problem if it would be only the jta/jca stuff requiring 1.4, but would like to see it clearly separated in the source tree then. (side note: How do other commons projects handle this?) But with ResourceManager and javax.transaction.Status that's not possible. snap/ Niall's handling of [validator] [1] is a recent example aimed at changing the minimum JDK requirement (and potentially maintaining more than one lines of development based on that, if there is interest). -Rahul Regards Jörg [1] http://svn.apache.org/viewvc?view=revrevision=490420 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [transaction] JDK 1.3 compatibility
And the link to post mentioned below: http://marc.theaimsgroup.com/?l=jakarta-commons-devm=116552696400850w=2 -Rahul On 12/27/06, Rahul Akolkar [EMAIL PROTECTED] wrote: On 12/27/06, Joerg Heinicke [EMAIL PROTECTED] wrote: Hello, when playing around with commons transaction I did a test compile with JDK 1.3. I wonder if we can still claim that 1.3 is the minimum requirement. One bug in the build.xml I fixed already [1]. But you still can't compile commons transaction with JDK 1.3 as it fails for ResourceManager extending javax.transaction.Status being JDK 1.4 compiled. Even compiling it with 1.4 and just running with 1.3 will fail as long as you don't provide the jta classes compiled with 1.3 - and I wonder if that exists. snip/ I think there should be 1.3 compatible binaries for JTA (as part of J2EE 1.3 compat requirements). Perhaps its just a matter of finding them or pinging the project that is producing the ones you are using. I don't see a problem if it would be only the jta/jca stuff requiring 1.4, but would like to see it clearly separated in the source tree then. (side note: How do other commons projects handle this?) But with ResourceManager and javax.transaction.Status that's not possible. snap/ Niall's handling of [validator] [1] is a recent example aimed at changing the minimum JDK requirement (and potentially maintaining more than one lines of development based on that, if there is interest). -Rahul Regards Jörg [1] http://svn.apache.org/viewvc?view=revrevision=490420 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-305) Deprecate methods found in the JDK 1.5/1.6?
[ http://issues.apache.org/jira/browse/LANG-305?page=comments#action_12461060 ] Stephen Colebourne commented on LANG-305: - I am opposed to this. [lang] provides lots of stuff that is still useful despite later versions of the JDK. StrBuilder cannot be replaced by StringBuilder as it has much more functionality. So do our enums. So do the static methods. I don't see vast benefits in generics either in [lang]. It would help in a few places, but whether its enough to justify it is questionable. Deprecate methods found in the JDK 1.5/1.6? --- Key: LANG-305 URL: http://issues.apache.org/jira/browse/LANG-305 Project: Commons Lang Issue Type: Task Affects Versions: 2.2 Reporter: Henri Yandell Fix For: 2.3 Not too sure on this one - but it seems to me that it would be a good time to deprecate the methods that now have replacements in the standard Java libraries. We could also consider deprecating methods that have replacements in Joda Time. This would allow us to consider removing them in 3.0. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-302) StrBuilder does not implement clone()
[ http://issues.apache.org/jira/browse/LANG-302?page=comments#action_12461061 ] Stephen Colebourne commented on LANG-302: - I disagree with this. It was probably an error to be Clonable, but now its there its doing no harm. Removing it breaks binary compatability, and thats a big deal in [lang]. -1 to the change. StrBuilder does not implement clone() - Key: LANG-302 URL: http://issues.apache.org/jira/browse/LANG-302 Project: Commons Lang Issue Type: Bug Affects Versions: 2.2 Reporter: Henri Yandell Fix For: 2.3 As reported by FindBugs. Does StrBuilder need to be Cloneable? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Reopened: (LANG-302) StrBuilder does not implement clone()
[ http://issues.apache.org/jira/browse/LANG-302?page=all ] Henri Yandell reopened LANG-302: Reopening due to Stephen's -1. I'll roll the commit back and move this fix to 3.0. StrBuilder does not implement clone() - Key: LANG-302 URL: http://issues.apache.org/jira/browse/LANG-302 Project: Commons Lang Issue Type: Bug Affects Versions: 2.2 Reporter: Henri Yandell Fix For: 2.3 As reported by FindBugs. Does StrBuilder need to be Cloneable? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[VOTE] Release Commons Transaction 1.2
We have worked our way through three release candidates now and the latest has been out there for quite some time without substantial shortcomings reported: http://people.apache.org/~ozeigermann/tx-1.2rc3/ To release 1.2 final based on that release candidate here is my +1 Cheers Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490555 - in /jakarta/commons/sandbox/commons-skin: ./ branches/ tags/ trunk/ trunk/src/ trunk/src/main/ trunk/src/main/resources/ trunk/src/main/resources/css/ trunk/src/main/resources/im
Author: dennisl Date: Wed Dec 27 12:01:03 2006 New Revision: 490555 URL: http://svn.apache.org/viewvc?view=revrev=490555 Log: Initial import of commons-skin. This is a copy of maven-classic-skin 1.0, except for pom.xml, which has been tweaked to fit into commons. Added: jakarta/commons/sandbox/commons-skin/ jakarta/commons/sandbox/commons-skin/branches/ jakarta/commons/sandbox/commons-skin/tags/ jakarta/commons/sandbox/commons-skin/trunk/ jakarta/commons/sandbox/commons-skin/trunk/pom.xml jakarta/commons/sandbox/commons-skin/trunk/src/ jakarta/commons/sandbox/commons-skin/trunk/src/main/ jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/ jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/ jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/ jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/external-classic.png (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/help_logo.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_arrowfolderclosed1_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_arrowfolderopen2_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_arrowwaste1_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_arrowwaste2_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_doc_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_doc_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_error_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_error_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_folder_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_folder_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_help_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_info_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_info_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_members_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_sortdown.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_sortup.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_success_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_success_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_usergroups_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_warning_lrg.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/icon_warning_sml.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/newwindow-classic.png (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/nw_maj_rond.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/strich.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/sw_maj_rond.gif (with props) jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/images/sw_med_rond.gif (with props) Added: jakarta/commons/sandbox/commons-skin/trunk/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/sandbox/commons-skin/trunk/pom.xml?view=autorev=490555 == --- jakarta/commons/sandbox/commons-skin/trunk/pom.xml (added) +++ jakarta/commons/sandbox/commons-skin/trunk/pom.xml Wed Dec 27 12:01:03 2006 @@ -0,0 +1,13 @@ +project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; + modelVersion4.0.0/modelVersion + parent +groupIdorg.apache.commons/groupId +artifactIdcommons-parent/artifactId +version1/version + /parent + artifactIdcommons-skin/artifactId + version1.0-SNAPSHOT/version + nameCommons Skin/name + descriptionCommons Skin/description +/project + Added: jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
Re: [VOTE] Release Commons Transaction 1.2
Oliver Zeigermann oliver.zeigermann at gmail.com writes: To release 1.2 final based on that release candidate here is my +1 Jörg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490556 - /jakarta/commons/trunks-sandbox/
Author: dennisl Date: Wed Dec 27 12:14:29 2006 New Revision: 490556 URL: http://svn.apache.org/viewvc?view=revrev=490556 Log: Add externals for commons-skin. Modified: jakarta/commons/trunks-sandbox/ (props changed) Propchange: jakarta/commons/trunks-sandbox/ -- --- svn:externals (original) +++ svn:externals Wed Dec 27 12:14:29 2006 @@ -1,13 +1,14 @@ -commons-build https://svn.apache.org/repos/asf/jakarta/commons/proper/commons-build/trunk -compress https://svn.apache.org/repos/asf/jakarta/commons/sandbox/compress/trunk -csv https://svn.apache.org/repos/asf/jakarta/commons/sandbox/csv/trunk -exec https://svn.apache.org/repos/asf/jakarta/commons/sandbox/exec/trunk -finder https://svn.apache.org/repos/asf/jakarta/commons/sandbox/finder/trunk -i18n https://svn.apache.org/repos/asf/jakarta/commons/sandbox/i18n/trunk -id https://svn.apache.org/repos/asf/jakarta/commons/sandbox/id/trunk -javaflow https://svn.apache.org/repos/asf/jakarta/commons/sandbox/javaflow/trunk -jci https://svn.apache.org/repos/asf/jakarta/commons/sandbox/jci/trunk -js2j https://svn.apache.org/repos/asf/jakarta/commons/sandbox/js2j/trunk -openpgp https://svn.apache.org/repos/asf/jakarta/commons/sandbox/openpgp/trunk -pipeline https://svn.apache.org/repos/asf/jakarta/commons/sandbox/pipeline/trunk -proxy https://svn.apache.org/repos/asf/jakarta/commons/sandbox/proxy/trunk +commons-build https://svn.apache.org/repos/asf/jakarta/commons/proper/commons-build/trunk +commons-skin https://svn.apache.org/repos/asf/jakarta/commons/sandbox/commons-skin/trunk +compress https://svn.apache.org/repos/asf/jakarta/commons/sandbox/compress/trunk +csv https://svn.apache.org/repos/asf/jakarta/commons/sandbox/csv/trunk +exec https://svn.apache.org/repos/asf/jakarta/commons/sandbox/exec/trunk +finder https://svn.apache.org/repos/asf/jakarta/commons/sandbox/finder/trunk +i18n https://svn.apache.org/repos/asf/jakarta/commons/sandbox/i18n/trunk +id https://svn.apache.org/repos/asf/jakarta/commons/sandbox/id/trunk +javaflow https://svn.apache.org/repos/asf/jakarta/commons/sandbox/javaflow/trunk +jci https://svn.apache.org/repos/asf/jakarta/commons/sandbox/jci/trunk +js2j https://svn.apache.org/repos/asf/jakarta/commons/sandbox/js2j/trunk +openpgp https://svn.apache.org/repos/asf/jakarta/commons/sandbox/openpgp/trunk +pipeline https://svn.apache.org/repos/asf/jakarta/commons/sandbox/pipeline/trunk +proxy https://svn.apache.org/repos/asf/jakarta/commons/sandbox/proxy/trunk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490559 - /jakarta/commons/sandbox/commons-skin/trunk/
Author: dennisl Date: Wed Dec 27 12:22:43 2006 New Revision: 490559 URL: http://svn.apache.org/viewvc?view=revrev=490559 Log: Ignore target directory. Modified: jakarta/commons/sandbox/commons-skin/trunk/ (props changed) Propchange: jakarta/commons/sandbox/commons-skin/trunk/ -- --- svn:ignore (added) +++ svn:ignore Wed Dec 27 12:22:43 2006 @@ -0,0 +1 @@ +target - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490560 - /jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
Author: dennisl
Date: Wed Dec 27 12:23:45 2006
New Revision: 490560
URL: http://svn.apache.org/viewvc?view=revrev=490560
Log:
Apply the look-and-feel of Jakarta Commons.
Modified:
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
Modified:
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css?view=diffrev=490560r1=490559r2=490560
==
---
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
(original)
+++
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
Wed Dec 27 12:23:45 2006
@@ -28,17 +28,19 @@
}
div#banner {
- border-top: 1px solid #369;
- border-bottom: 1px solid #003;
+ border-bottom: 1px solid #fff;
}
#banner, #banner td {
- background: #036;
+ background: #fff;
color: #fff;
}
#banner {
border-bottom: 1px solid #fff;
}
+#banner img {
+ padding: 8px;
+}
#leftColumn {
background-color: #eee;
@@ -46,6 +48,7 @@
border-right: 1px solid #aaa;
border-bottom: 1px solid #aaa;
border-top: 1px solid #fff;
+ width: 150px;
}
#navcolumn {
@@ -53,18 +56,30 @@
border-right: none;
border-bottom: none;
border-top: none;
- }
+ padding-top: 5px;
+}
#navcolumn h5 {
font-size: inherit;
+ border-bottom: 1px solid #aaa;
+ padding-top: 3px;
+}
+
+#navcolumn li {
+ padding-left: 8px;
}
#breadcrumbs {
- background-color: #ddd;
+ background-color: #ccc;
color: #000;
- border-top: 1px solid #fff;
+ border-top: 1px solid #aaa;
border-bottom: 1px solid #aaa;
- }
+ height: 14px;
+}
+
+#breadcrumbs div {
+ padding: 1px 8px 2px 2px;
+}
.source {
background-color: #fff;
@@ -87,9 +102,13 @@
color: inherit !important;
}
-a:link, #breadcrumbs a:visited, #navcolumn a:visited, .contentBox a:visited,
.tasknav a:visited {
- color: blue;
- }
+#breadcrumbs a:link, #navcolumn a:link {
+ color: #36a;
+}
+
+#breadcrumbs a:visited, #navcolumn a:visited, .contentBox a:visited, .tasknav
a:visited {
+ color: #47a;
+}
a:active, a:hover, #leftColumn a:active, #leftColumn a:hover {
color: #f30 !important;
@@ -521,6 +540,10 @@
font-size: x-small;
}
+#breadcrumbs div {
+ font-size: x-small;
+}
+
.tabs td, .tabs th, dt, .tasknav .selfref, #login .username, .selection {
font-weight: bold;
}
@@ -541,6 +564,7 @@
#bodyColumn h2 {
margin-top: .3em;
margin-bottom: .5em;
+ padding-left: .5em;
}
p, ul, ol, dl, .bars table {
@@ -554,9 +578,9 @@
#bodyColumn {
margin-right: 0;
- margin-top: 1em;
- padding-right: 12px;
- margin-left: 190px;
+ margin-top: 0.4em;
+ padding-right: 0px;
+ margin-left: 158px;
}
htmlbody #bodyColumn {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490561 - in /jakarta/commons/sandbox/commons-skin/trunk: pom.xml src/main/resources/css/maven-theme.css
Author: dennisl
Date: Wed Dec 27 12:24:25 2006
New Revision: 490561
URL: http://svn.apache.org/viewvc?view=revrev=490561
Log:
Set EOL-style to native.
Modified:
jakarta/commons/sandbox/commons-skin/trunk/pom.xml (contents, props
changed)
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
(contents, props changed)
Modified: jakarta/commons/sandbox/commons-skin/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/commons-skin/trunk/pom.xml?view=diffrev=490561r1=490560r2=490561
==
--- jakarta/commons/sandbox/commons-skin/trunk/pom.xml (original)
+++ jakarta/commons/sandbox/commons-skin/trunk/pom.xml Wed Dec 27 12:24:25 2006
@@ -1,13 +1,13 @@
-project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
- modelVersion4.0.0/modelVersion
- parent
-groupIdorg.apache.commons/groupId
-artifactIdcommons-parent/artifactId
-version1/version
- /parent
- artifactIdcommons-skin/artifactId
- version1.0-SNAPSHOT/version
- nameCommons Skin/name
- descriptionCommons Skin/description
-/project
-
+project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+ modelVersion4.0.0/modelVersion
+ parent
+groupIdorg.apache.commons/groupId
+artifactIdcommons-parent/artifactId
+version1/version
+ /parent
+ artifactIdcommons-skin/artifactId
+ version1.0-SNAPSHOT/version
+ nameCommons Skin/name
+ descriptionCommons Skin/description
+/project
+
Propchange: jakarta/commons/sandbox/commons-skin/trunk/pom.xml
--
svn:eol-style = native
Modified:
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css?view=diffrev=490561r1=490560r2=490561
==
---
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
(original)
+++
jakarta/commons/sandbox/commons-skin/trunk/src/main/resources/css/maven-theme.css
Wed Dec 27 12:24:25 2006
@@ -1,884 +1,884 @@
-body {
- background: #fff;
- color: #000;
- padding: 0px 0px 10px 0px;
- }
-
-h2 {
- background-color: #036;
- }
-
-h3 {
- background-color: #888;
- }
-
-.a td {
- background: #ddd;
- color: #000;
- }
-
-.b td {
- background: #efefef;
- color: #000;
- }
-
-th {
- background-color: #bbb;
- color: #fff;
- }
-
-div#banner {
- border-bottom: 1px solid #fff;
- }
-
-#banner, #banner td {
- background: #fff;
- color: #fff;
- }
-#banner {
- border-bottom: 1px solid #fff;
-}
-#banner img {
- padding: 8px;
-}
-
-#leftColumn {
- background-color: #eee;
- color: #000;
- border-right: 1px solid #aaa;
- border-bottom: 1px solid #aaa;
- border-top: 1px solid #fff;
- width: 150px;
-}
-
-#navcolumn {
- color: #000;
- border-right: none;
- border-bottom: none;
- border-top: none;
- padding-top: 5px;
-}
-
-#navcolumn h5 {
- font-size: inherit;
- border-bottom: 1px solid #aaa;
- padding-top: 3px;
-}
-
-#navcolumn li {
- padding-left: 8px;
-}
-
-#breadcrumbs {
- background-color: #ccc;
- color: #000;
- border-top: 1px solid #aaa;
- border-bottom: 1px solid #aaa;
- height: 14px;
-}
-
-#breadcrumbs div {
- padding: 1px 8px 2px 2px;
-}
-
-.source {
- background-color: #fff;
- color: #000;
- border-right: 1px solid #888;
- border-left: 1px solid #888;
- border-top: 1px solid #888;
- border-bottom: 1px solid #888;
- margin-right: 7px;
- margin-left: 7px;
- margin-top: 1em;
- }
-
-.source pre {
- margin-right: 7px;
- margin-left: 7px;
- }
-
-a[name]:hover, #leftColumn a[name]:hover {
- color: inherit !important;
- }
-
-#breadcrumbs a:link, #navcolumn a:link {
- color: #36a;
-}
-
-#breadcrumbs a:visited, #navcolumn a:visited, .contentBox a:visited, .tasknav
a:visited {
- color: #47a;
-}
-
-a:active, a:hover, #leftColumn a:active, #leftColumn a:hover {
- color: #f30 !important;
- }
-
-a:link.selfref, a:visited.selfref {
- color: #555 !important;
- }
-
-#legend li.externalLink {
- background: url(../images/external-classic.png) left top no-repeat;
- padding-left: 18px;
-}
-a.externalLink, a.externalLink:link, a.externalLink:visited,
a.externalLink:active, a.externalLink:hover {
- background: url(../images/external-classic.png) right center no-repeat;
- padding-right: 18px;
-}
-
-#legend li.newWindow {
- background: url(../images/newwindow-classic.png) left top no-repeat;
- padding-left: 18px;
-}
-a.newWindow, a.newWindow:link, a.newWindow:visited, a.newWindow:active,
a.newWindow:hover {
- background:
[Jakarta-commons Wiki] Update of CommonsCommitters by DennisLundberg
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by DennisLundberg: http://wiki.apache.org/jakarta-commons/CommonsCommitters -- * CreatingSiteWithMaven2 - a trial to see if it is possible to use Maven 2 to build commons sites. + * UsingCommonsSkin - Instructions on how to use the commons-skin in your Maven 2 generated site. + * MavenPlugins used in commons. * MavenWebsiteStucture for commons - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of UsingCommonsSkin by DennisLundberg
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki
for change notification.
The following page has been changed by DennisLundberg:
http://wiki.apache.org/jakarta-commons/UsingCommonsSkin
The comment on the change is:
Add instruction on how to use commons-skin
New page:
== Instructions ==
Follow these steps to include commons-skin in a component's Maven 2 build.
* Include commons-skin in the {{{src/site/site.xml}}} file of your component:
{{{
project name=...
...
skin
groupIdorg.apache.commons/groupId
artifactIdcommons-skin/artifactId
version1.0-SNAPSHOT/version
/skin
...
/project
}}}
* If you have both a Maven 1 and a Maven 2 site build for your component, you
need to exclude the Maven 1 navigation.xml file from the Maven 2. This is done
with a configuration snippet in the file {{{pom.xml}}}:
{{{
project ...
...
reporting
plugins
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-site-plugin/artifactId
configuration
moduleExcludes
xdocnavigation.xml/xdoc
/moduleExcludes
/configuration
/plugin
/plugins
/reporting
...
/project
}}}
* A final note for sandbox components. The site might not look as it should if
you have checked out your component as a part of
{{{/jakarta/commons/trunks-sandbox}}}. This is because trunks-sandbox has some
build-in stylesheet customizations that might interfere with the stylesheet
definitions in the skin. The solution is to check out the component on its own.
This problem will be fixed if/when commons-skin is released.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Introducing commons-skin
Hi all Finally I took the time to sit down and create a Maven 2 skin for Jakarta Commons. What I have done is taken maven-classic-skin and combined that with the stylesheet rules that can be found in the site.xml file in commons/trunks-sandbox. Then I played around with the site for commons-lang to try to create a site that resembles what we get when we build the site using Maven 1. A SNAPSHOT of the skin has been uploaded to the Apache M2 SNAPSHOT repository, so you don't need to build it yourself to try it. You may need to tweak some files in your component to be able try out the skin. Instructions for this is on the wiki [1]. They should really be in SVN along with commons-skin, but I figured we should use wiki to get things started. To make it easier for you to review I have staged the commons-lang site that was generated using Maven 2 and commons-skin [2]. Compare it to the original commons-lang site [3] and give me some feedback. [1] http://wiki.apache.org/jakarta-commons/UsingCommonsSkin [2] http://people.apache.org/~dennisl/commons-lang/ [3] http://jakarta.apache.org/commons/lang/ -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490575 - /jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml
Author: jochen Date: Wed Dec 27 14:06:21 2006 New Revision: 490575 URL: http://svn.apache.org/viewvc?view=revrev=490575 Log: Fixed a well-formedness error. Modified: jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml Modified: jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml?view=diffrev=490575r1=490574r2=490575 == --- jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml (original) +++ jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml Wed Dec 27 14:06:21 2006 @@ -84,7 +84,7 @@ /action action dev=jochen type=add issue=FILEUPLOAD-120 - due-to=Henry Yandell due-to-email=[EMAIL PROTECTED]/ + due-to=Henry Yandell due-to-email=[EMAIL PROTECTED] Added the FileCleanerCleanup as an example for how to close down the FileCleaner's reaper thread nicely. /action - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r490576 - /jakarta/commons/proper/fileupload/trunk/src/site/site.xml
Author: jochen Date: Wed Dec 27 14:07:37 2006 New Revision: 490576 URL: http://svn.apache.org/viewvc?view=revrev=490576 Log: The Jakarta Commons Skin is now used for building the site. Modified: jakarta/commons/proper/fileupload/trunk/src/site/site.xml Modified: jakarta/commons/proper/fileupload/trunk/src/site/site.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/site/site.xml?view=diffrev=490576r1=490575r2=490576 == --- jakarta/commons/proper/fileupload/trunk/src/site/site.xml (original) +++ jakarta/commons/proper/fileupload/trunk/src/site/site.xml Wed Dec 27 14:07:37 2006 @@ -22,6 +22,12 @@ hrefhttp://jakarta.apache.org/commons/fileupload/href /bannerLeft + skin +groupIdorg.apache.commons/groupId +artifactIdcommons-skin/artifactId +version1.0-SNAPSHOT/version + /skin + body links item name=Apache href=http://www.apache.org// - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Introducing commons-skin
Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Definitely don't care that 'About Lang' is gone; and I'm not bothered that 'Development Process' is gone either. I presume these are standard Maven things that have gone from m1 to m2. Hen On 12/27/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Hi all Finally I took the time to sit down and create a Maven 2 skin for Jakarta Commons. What I have done is taken maven-classic-skin and combined that with the stylesheet rules that can be found in the site.xml file in commons/trunks-sandbox. Then I played around with the site for commons-lang to try to create a site that resembles what we get when we build the site using Maven 1. A SNAPSHOT of the skin has been uploaded to the Apache M2 SNAPSHOT repository, so you don't need to build it yourself to try it. You may need to tweak some files in your component to be able try out the skin. Instructions for this is on the wiki [1]. They should really be in SVN along with commons-skin, but I figured we should use wiki to get things started. To make it easier for you to review I have staged the commons-lang site that was generated using Maven 2 and commons-skin [2]. Compare it to the original commons-lang site [3] and give me some feedback. [1] http://wiki.apache.org/jakarta-commons/UsingCommonsSkin [2] http://people.apache.org/~dennisl/commons-lang/ [3] http://jakarta.apache.org/commons/lang/ -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Introducing commons-skin
On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) A couple of things I noticed: * The Docs for 2.2 is missing. Personally, I think it's important to know the version that I'm looking at, so I hope that can be put back. * The current page now shows in the menu as black, and looks the same as a menu heading. Previously it was bolded blue, which made it a distinct style from other items and from the headers. Other than that, they look a lot alike. ;-) -- Martin Cooper Definitely don't care that 'About Lang' is gone; and I'm not bothered that 'Development Process' is gone either. I presume these are standard Maven things that have gone from m1 to m2. Hen On 12/27/06, Dennis Lundberg [EMAIL PROTECTED] wrote: Hi all Finally I took the time to sit down and create a Maven 2 skin for Jakarta Commons. What I have done is taken maven-classic-skin and combined that with the stylesheet rules that can be found in the site.xml file in commons/trunks-sandbox. Then I played around with the site for commons-lang to try to create a site that resembles what we get when we build the site using Maven 1. A SNAPSHOT of the skin has been uploaded to the Apache M2 SNAPSHOT repository, so you don't need to build it yourself to try it. You may need to tweak some files in your component to be able try out the skin. Instructions for this is on the wiki [1]. They should really be in SVN along with commons-skin, but I figured we should use wiki to get things started. To make it easier for you to review I have staged the commons-lang site that was generated using Maven 2 and commons-skin [2]. Compare it to the original commons-lang site [3] and give me some feedback. [1] http://wiki.apache.org/jakarta-commons/UsingCommonsSkin [2] http://people.apache.org/~dennisl/commons-lang/ [3] http://jakarta.apache.org/commons/lang/ -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JELLY-273) Reference to %JAVA_HOME%\bin\java in jelly.bat should be %JAVA_HOME%\bin\java
Reference to %JAVA_HOME%\bin\java in jelly.bat should be %JAVA_HOME%\bin\java - Key: JELLY-273 URL: http://issues.apache.org/jira/browse/JELLY-273 Project: Commons Jelly Issue Type: Bug Components: core / taglib.core Environment: Windows XP Reporter: David M. Karr Priority: Minor On Windows XP, when the released jelly.bat is executed, it complains very obtusely: Exception in thread main java.lang.NoClassDefFoundError: \bin\java With some experimentation, I realized that all that is required is to change: %JAVA_HOME%\bin\java -classpath %CLASSPATH%;%JELLY_HOME%\lib\forehead-1.0-beta-5.jar -Dforehead.conf.file=%FOREHEAD_CONF% -Djelly.home=%JELLY_HOME% -Dtools.jar=%JAVA_HOME%\lib\tools.jar %JELLY_OPTS% com.werken.forehead.Forehead %* to: %JAVA_HOME%\bin\java -classpath %CLASSPATH%;%JELLY_HOME%\lib\forehead-1.0-beta-5.jar -Dforehead.conf.file=%FOREHEAD_CONF% -Djelly.home=%JELLY_HOME% -Dtools.jar=%JAVA_HOME%\lib\tools.jar %JELLY_OPTS% com.werken.forehead.Forehead %* The only change is moving the double-quote from before /bin/java to after it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Introducing commons-skin
Thanks, Dennis! On 12/27/06, Martin Cooper [EMAIL PROTECTED] wrote: On 12/27/06, Henri Yandell [EMAIL PROTECTED] wrote: Looks good - nice work :) Only bit that leaps out to me as missing are the little arrows to symbolize external links. We may not care. Actually, I like those. :-) A couple of things I noticed: * The Docs for 2.2 is missing. Personally, I think it's important to know the version that I'm looking at, so I hope that can be put back. That should be no problem - that is the content. I think Dennis was just testing the skin. * The current page now shows in the menu as black, and looks the same as a menu heading. Previously it was bolded blue, which made it a distinct style from other items and from the headers. Other than that, they look a lot alike. ;-) The skin looks great to me - I don't have any problems with the arrows or menu bolding. I am, however, seeing a problem that I have seen before on Firefox. Could be a Firefox/Linux abnormality. Using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061208 Firefox/2.0.0.1, I get this: http://people.apache.org/~psteitz/newLang.jpg Thanks again for picking this up. Phil
