[jira] Created: (JXPATH-83) JXpath automatically trims string values
JXpath automatically trims string values Key: JXPATH-83 URL: https://issues.apache.org/jira/browse/JXPATH-83 Project: Commons JXPath Issue Type: Bug Affects Versions: 1.2 Final Reporter: Wim Biesemans When an xml contains a value with leading or trailing spaces, JXPath trims this value. example: value 12324 56/value is retrieved by JXPath as : '1234 56' while I expect ' 1234 56'. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[nightly build] id failed.
Failed build logs: http://vmbuild.apache.org/~commons/nightly/logs//20070516/id.log - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[VFS] Sftp session not closed after transmit
Hi, I'm trying to copy a file from a sftp Server to the local Filesystem. After some problems getting sftp connection running without special filesystemoptions I run into problems when the transfer is finished. I close both FileObjects, but the sftp session thread is not closed. There is also a SoftRefFilesCache$SoftRefReleaseThread running and the program is not terminating. Any hint about that? Thanks Mit freundlichen Grüßen Detlev Mörk Systementwickler Konradin Business GmbH Ernst-Mey-Str. 8 70771 Leinfelden-Echterdingen Tel.: +49 711/7594-504 Fax.: +49 711/7594-1504 Email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [VFS] Sftp session not closed after transmit
I had the similar but I do closeFileSystem like getFileSystemManager().closeFileSystem(fileObject.getFileSystem()) and everything closes. Best regards, Juri. -Original Message- From: Moerk, Detlev [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 16, 2007 3:29 PM To: commons-dev@jakarta.apache.org Subject: [VFS] Sftp session not closed after transmit Hi, I'm trying to copy a file from a sftp Server to the local Filesystem. After some problems getting sftp connection running without special filesystemoptions I run into problems when the transfer is finished. I close both FileObjects, but the sftp session thread is not closed. There is also a SoftRefFilesCache$SoftRefReleaseThread running and the program is not terminating. Any hint about that? Thanks Mit freundlichen Grüßen Detlev Mörk Systementwickler Konradin Business GmbH Ernst-Mey-Str. 8 70771 Leinfelden-Echterdingen Tel.: +49 711/7594-504 Fax.: +49 711/7594-1504 Email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
AW: [VFS] Sftp session not closed after transmit
Hello Juri, thanks for the hint, it works for me too. Mit freundlichen Grüßen Detlev Mörk Systementwickler Konradin Business GmbH Ernst-Mey-Str. 8 70771 Leinfelden-Echterdingen Tel.: +49 711/7594-504 Fax.: +49 711/7594-1504 Email: [EMAIL PROTECTED] Konradin Business GmbH Sitz der Gesellschaft: Ernst-Mey-Str. 8, 70771 Leinfelden- Echterdingen Amtsgericht Stuttgart HRB 224875 Geschäftsführer: Katja Kohlhammer, Peter Dilger -Ursprüngliche Nachricht- Von: Artamonov, Juri [mailto:[EMAIL PROTECTED] Gesendet: Mittwoch, 16. Mai 2007 14:59 An: Jakarta Commons Developers List Betreff: RE: [VFS] Sftp session not closed after transmit I had the similar but I do closeFileSystem like getFileSystemManager().closeFileSystem(fileObject.getFileSyste m()) and everything closes. Best regards, Juri. -Original Message- From: Moerk, Detlev [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 16, 2007 3:29 PM To: commons-dev@jakarta.apache.org Subject: [VFS] Sftp session not closed after transmit Hi, I'm trying to copy a file from a sftp Server to the local Filesystem. After some problems getting sftp connection running without special filesystemoptions I run into problems when the transfer is finished. I close both FileObjects, but the sftp session thread is not closed. There is also a SoftRefFilesCache$SoftRefReleaseThread running and the program is not terminating. Any hint about that? Thanks Mit freundlichen Grüßen Detlev Mörk Systementwickler Konradin Business GmbH Ernst-Mey-Str. 8 70771 Leinfelden-Echterdingen Tel.: +49 711/7594-504 Fax.: +49 711/7594-1504 Email: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email __ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (IO-119) Convenience Builder for creating complex FileFilter conditions
[ https://issues.apache.org/jira/browse/IO-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496310 ] Henri Yandell commented on IO-119: -- Just looking at the API from a user point of view: end() is a bit weird. Reminds me of the JODA JSR's resolve() :) orBuilder() seems a bit odd. Why not or()? orBuilder() is different to or()? --- I'm sure there are good reasons, will look at the code to grok more. Convenience Builder for creating complex FileFilter conditions Key: IO-119 URL: https://issues.apache.org/jira/browse/IO-119 Project: Commons IO Issue Type: Improvement Components: Filters Affects Versions: 1.3.1 Reporter: Niall Pemberton Assigned To: Niall Pemberton Priority: Minor Fix For: 1.4 Attachments: FileFilterBuilder.java, FileFilterBuilderTestCase.java I'd like to add a new convenience builder class (FileFilterBuilder) to make it easier to create complex FileFilter using Commons IO's IOFileFilter implementations. Heres an example of how it can be used to create a IOFileFilter for the following conditions: - Either, directories which are not hidden and not named .svn - or, files which have a suffix of .java IOFileFilter filter = FileFilterBuilder.orBuilder() .and().isDirectory().isHidden(false).not().name(.svn).end() .and().isFile().suffix(.java).end() .getFileFilter(); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (DIGESTER-114) SetPropertyRule throws /java.lang.IllegalArgumentException: No name specified/ when matched element has no attributes
SetPropertyRule throws /java.lang.IllegalArgumentException: No name specified/ when matched element has no attributes - Key: DIGESTER-114 URL: https://issues.apache.org/jira/browse/DIGESTER-114 Project: Commons Digester Issue Type: Bug Affects Versions: 1.8 Reporter: Britt Levy A /java.lang.IllegalArgumentException: No name specified/ is thrown from the SetPropertyRule.begin(Attributes attributes) method if the attributes list is empty (attributes.getLength() = 0). The method should check the length of the attributes list and simply return if there are no attributes. Add the follwowing to org.apache.commons.digester.SetPropertyRuleTestCase to reproduce: /** * Simple test xml document used in the tests. */ protected final static String TEST_XML_3 = ?xml version='1.0'?root + set/ + /root; /** * Test SetPropertyRule when matched XML element has no attributes. */ public void testElementWithNoAttributes() throws Exception { // Set up the rules we need digester.addObjectCreate(root, org.apache.commons.digester.SimpleTestBean); digester.addSetProperty(root/set, name, value); // Parse the input - should not throw an exception SimpleTestBean bean = (SimpleTestBean) digester.parse(xmlTestReader(TEST_XML_3)); } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [IO] Move to a minimum of JDK 1.4?
+1 here (Selfish POV: The product I work on now requires Java 1.4 already) Thank you, Gary -Original Message- From: Niall Pemberton [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 15, 2007 8:05 PM To: Jakarta Commons Developers List Subject: [IO] Move to a minimum of JDK 1.4? There are a couple of Jira tickets which require JDK 1.4 IO-74[1] - Regular Expression IOFileFilter implementation IO-77[2] - FileUtils.move() method that uses NIO Are there any objections to moving Commons IO's minimum requirement to JDK 1.4 for Commons IO 1.4? Niall [1] https://issues.apache.org/jira/browse/IO-74 [2] https://issues.apache.org/jira/browse/IO-77 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: RfC: Release commons-io-1.3.2
+1 to your +1; Release early, release often! Thank you, Gary -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 15, 2007 12:43 PM To: Jakarta Commons Developers List Subject: Re: RfC: Release commons-io-1.3.2 +1 to the idea. Release early, release often. On 5/16/07, Jochen Wiedmann [EMAIL PROTECTED] wrote: Hi, the commons-io project has been rather silent in the last months, apart from IO-116. Unfortunately, this bug is a blocker for the next release of commons-fileupload. Therefore, I'd like to ask whether anyone would object a bug fix release 1.3.2? If noone intervenes, I'd start a formal vote, with me as the release manager. Thanks, Jochen -- My cats know that I am a loser who goes out for hunting every day without ever returning as much as a single mouse. Fortunately, I've got a wife who's a real champ: She leaves the house and returns within half an hour, carrying whole bags full of meal. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- dIon Gillard Rule #131 of Acquisition: Information is Profit. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JXPATH-81) Allow paramaterized accessors
[ https://issues.apache.org/jira/browse/JXPATH-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Benson closed JXPATH-81. - Resolution: Invalid No arguments implies noone has found fault with my logic. Since such is not expressible in XPATH syntax, I am marking as invalid. Allow paramaterized accessors - Key: JXPATH-81 URL: https://issues.apache.org/jira/browse/JXPATH-81 Project: Commons JXPath Issue Type: Improvement Reporter: Rob van Dort Priority: Minor As I could make up until now, only attribute accessors without parameters are allowed, e.g. public Address getAddress(). Attribute accessors with an underlying map can be used, e.g. public Map getAddress() (see Map Element Access in JXPath User Guide) In some cases it may be useful to use accessors with parameters, e.g. public Address getAddress(String addressType), this is a feature I would like to see added to JXPath. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538698 - in /jakarta/commons/proper/jxpath/trunk/src: java/org/apache/commons/jxpath/ri/model/dom/ java/org/apache/commons/jxpath/ri/model/jdom/ test/org/apache/commons/jxpath/ test/org/a
Author: mbenson Date: Wed May 16 12:47:47 2007 New Revision: 538698 URL: http://svn.apache.org/viewvc?view=revrev=538698 Log: respect xml:space='preserve' Added: jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/XmlSpace.xml (with props) jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/XMLSpaceTest.java (with props) Modified: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/JXPathTestSuite.java Modified: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java?view=diffrev=538698r1=538697r2=538698 == --- jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java (original) +++ jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java Wed May 16 12:47:47 2007 @@ -293,12 +293,11 @@ : current.toUpperCase().startsWith(lang.toUpperCase()); } -protected String getLanguage() { -Node n = node; +protected static String findEnclosingAttribute(Node n, String attrName) { while (n != null) { if (n.getNodeType() == Node.ELEMENT_NODE) { Element e = (Element) n; -String attr = e.getAttribute(xml:lang); +String attr = e.getAttribute(attrName); if (attr != null !attr.equals()) { return attr; } @@ -308,6 +307,10 @@ return null; } +protected String getLanguage() { +return findEnclosingAttribute(node, xml:lang); +} + /** * Sets contents of the node to the specified value. If the value is * a String, the contents of the node are replaced with this text. @@ -628,37 +631,34 @@ } public Object getValue() { +if (node.getNodeType() == Node.COMMENT_NODE) { +String text = ((Comment) node).getData(); +return text == null ? : text.trim(); +} return stringValue(node); } private String stringValue(Node node) { int nodeType = node.getNodeType(); if (nodeType == Node.COMMENT_NODE) { -String text = ((Comment) node).getData(); -return text == null ? : text.trim(); +return ; } -if ( -nodeType == Node.TEXT_NODE -|| nodeType == Node.CDATA_SECTION_NODE) { +boolean trim = !preserve.equals(findEnclosingAttribute(node, xml:space)); +if (nodeType == Node.TEXT_NODE || nodeType == Node.CDATA_SECTION_NODE) { String text = node.getNodeValue(); -return text == null ? : text.trim(); +return text == null ? : trim ? text.trim() : text; } if (nodeType == Node.PROCESSING_INSTRUCTION_NODE) { String text = ((ProcessingInstruction) node).getData(); -return text == null ? : text.trim(); +return text == null ? : trim ? text.trim() : text; } NodeList list = node.getChildNodes(); StringBuffer buf = new StringBuffer(16); for (int i = 0; i list.getLength(); i++) { Node child = list.item(i); -if (child.getNodeType() == Node.TEXT_NODE) { -buf.append(child.getNodeValue()); -} -else { -buf.append(stringValue(child)); -} +buf.append(stringValue(child)); } -return buf.toString().trim(); +return buf.toString(); } /** Modified: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java?view=diffrev=538698r1=538697r2=538698 == --- jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java (original) +++ jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java Wed May 16 12:47:47 2007 @@ -49,7 +49,7 @@ */ public class JDOMNodePointer extends NodePointer { private static final long serialVersionUID = -6346532297491082651L; - + private Object node; private String id; @@ -237,7 +237,14 @@ public Object getValue() { if (node instanceof Element) { -
[jira] Commented: (IO-119) Convenience Builder for creating complex FileFilter conditions
[ https://issues.apache.org/jira/browse/IO-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496391 ] Niall Pemberton commented on IO-119: Answering in reverse - orBuilder() and andBuilder() are static convenience methods to create the initial builder. FileFilterBuilder builder = FileFilterBuilder.orBuilder() is the same as FileFilterBuilder builder = new FileFilterBuilder(new OrFileFilter()); The problem is there is also a (non-static) or() method - so I couldn't name them the same - suggesstions welcome :) On the end() method - its like adding a closing bracket (where and() or or() open them) - so if you wanted to do the following condition, using name() as an example: (A or (B and C) or (D and (E or F))) you would do something like the following FileFilterBuilder builder = FileFilterBuilder.orBuilder() .name(A) .and().name(B).name(C).end() .and().name(D) .or().name(E).name(F).endAll(); Its counter intuitive since usually the operators link conditions togther - whereas here they're defined at the start and everything that follows until an end(), or() or and() is joined with the same operator. Convenience Builder for creating complex FileFilter conditions Key: IO-119 URL: https://issues.apache.org/jira/browse/IO-119 Project: Commons IO Issue Type: Improvement Components: Filters Affects Versions: 1.3.1 Reporter: Niall Pemberton Assigned To: Niall Pemberton Priority: Minor Fix For: 1.4 Attachments: FileFilterBuilder.java, FileFilterBuilderTestCase.java I'd like to add a new convenience builder class (FileFilterBuilder) to make it easier to create complex FileFilter using Commons IO's IOFileFilter implementations. Heres an example of how it can be used to create a IOFileFilter for the following conditions: - Either, directories which are not hidden and not named .svn - or, files which have a suffix of .java IOFileFilter filter = FileFilterBuilder.orBuilder() .and().isDirectory().isHidden(false).not().name(.svn).end() .and().isFile().suffix(.java).end() .getFileFilter(); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538699 - /jakarta/commons/proper/io/branches/b1_3/
Author: jochen Date: Wed May 16 12:55:33 2007 New Revision: 538699 URL: http://svn.apache.org/viewvc?view=revrev=538699 Log: (empty) Added: jakarta/commons/proper/io/branches/b1_3/ - copied from r538698, jakarta/commons/proper/io/trunk/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn propchange: r538698 - svn:log
Author: mbenson Revision: 538698 Modified property: svn:log Modified: svn:log at Wed May 16 12:57:27 2007 -- --- svn:log (original) +++ svn:log Wed May 16 12:57:27 2007 @@ -1 +1 @@ -respect xml:space='preserve' +[JXPATH-83] respect xml:space='preserve' - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[IO] Created 1.3 branch
Hi, in light of the ongoing discussions regarding commons-io, I have created a branch https://svn.apache.org/repos/asf/jakarta/commons/proper/io/branches/b1_3 Reasons: - It will allow me to make release related changes without disturbing other peoples work. For example, I'll roll back the version numbers from 1.4-SNAPSHOT to 1.3.2. - If commons-io is actually switching to JDK 1.4, then it makes quite some sense to have a maintenance branch for 1.3. - It doesn't make too much sense, if Niall defers work just to wait for a release out of the trunk. Jochen -- My cats know that I am a loser who goes out for hunting every day without ever returning as much as a single mouse. Fortunately, I've got a wife who's a real champ: She leaves the house and returns within half an hour, carrying whole bags full of meal. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [IO] Created 1.3 branch
On 5/16/07, Jochen Wiedmann [EMAIL PROTECTED] wrote: Hi, in light of the ongoing discussions regarding commons-io, I have created a branch https://svn.apache.org/repos/asf/jakarta/commons/proper/io/branches/b1_3 Reasons: - It will allow me to make release related changes without disturbing other peoples work. For example, I'll roll back the version numbers from 1.4-SNAPSHOT to 1.3.2. - If commons-io is actually switching to JDK 1.4, then it makes quite some sense to have a maintenance branch for 1.3. - It doesn't make too much sense, if Niall defers work just to wait for a release out of the trunk. Great thanks - good plan, although I'll leave it a few days to allow time for any objectiions. Niall Jochen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538703 - in /jakarta/commons/proper/io/branches/b1_3: build.xml pom.xml project.xml
Author: jochen Date: Wed May 16 13:04:50 2007 New Revision: 538703 URL: http://svn.apache.org/viewvc?view=revrev=538703 Log: (empty) Modified: jakarta/commons/proper/io/branches/b1_3/build.xml jakarta/commons/proper/io/branches/b1_3/pom.xml jakarta/commons/proper/io/branches/b1_3/project.xml Modified: jakarta/commons/proper/io/branches/b1_3/build.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/build.xml?view=diffrev=538703r1=538702r2=538703 == --- jakarta/commons/proper/io/branches/b1_3/build.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/build.xml Wed May 16 13:04:50 2007 @@ -26,7 +26,7 @@ /property property name=testreportdir value=${basedir}/build/test-reports /property - property name=final.name value=commons-io-1.4-SNAPSHOT / + property name=final.name value=commons-io-1.3.2 / property name=dist.build.dir value=${basedir}/build/dist-build / property name=dist.bin value=${dist.build.dir}/${final.name} / property name=dist.src value=${dist.build.dir}/${final.name}-src / @@ -272,7 +272,7 @@ /tstamp property name=copyright value=Copyright amp;copy; The Apache Software Foundation. All Rights Reserved. /property -property name=title value=IO 1.4-SNAPSHOT +property name=title value=IO 1.3.2 /property javadoc use=true private=true destdir=${javadocdir} author=true version=true sourcepath=${basedir}/src/java packagenames=org.apache.commons.io.* overview=src/java/org/apache/commons/io/overview.html classpath Modified: jakarta/commons/proper/io/branches/b1_3/pom.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/pom.xml?view=diffrev=538703r1=538702r2=538703 == --- jakarta/commons/proper/io/branches/b1_3/pom.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/pom.xml Wed May 16 13:04:50 2007 @@ -27,7 +27,7 @@ modelVersion4.0.0/modelVersion groupIdcommons-io/groupId artifactIdcommons-io/artifactId - version1.4-SNAPSHOT/version + version1.3.2/version nameCommons IO/name inceptionYear2002/inceptionYear Modified: jakarta/commons/proper/io/branches/b1_3/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/project.xml?view=diffrev=538703r1=538702r2=538703 == --- jakarta/commons/proper/io/branches/b1_3/project.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/project.xml Wed May 16 13:04:50 2007 @@ -21,7 +21,7 @@ nameIO/name groupIdcommons-io/groupId artifactIdcommons-io/artifactId - currentVersion1.4-SNAPSHOT/currentVersion + currentVersion1.3.2/currentVersion inceptionYear2002/inceptionYear shortDescriptionCommons IO/shortDescription description - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (JXPATH-83) JXpath automatically trims string values
[ https://issues.apache.org/jira/browse/JXPATH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Benson resolved JXPATH-83. --- Resolution: Fixed Fix Version/s: 1.3 For reasons of backward compatibility it is inadvisable to change the default behavior here. We'll call trim-by-default an application implementation feature of JXPath. However, the XML spec refers to the special xml:space attribute, which can be set to preserve to hint that whitespace should be preserved. svn HEAD (rev. 538698) contains support for this attribute, about which you can read more at http://www.w3.org/TR/REC-xml/#sec-white-space . JXpath automatically trims string values Key: JXPATH-83 URL: https://issues.apache.org/jira/browse/JXPATH-83 Project: Commons JXPath Issue Type: Bug Affects Versions: 1.2 Final Reporter: Wim Biesemans Fix For: 1.3 When an xml contains a value with leading or trailing spaces, JXPath trims this value. example: value 12324 56/value is retrieved by JXPath as : '1234 56' while I expect ' 1234 56'. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538707 - /jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/XMLSpaceTest.java
Author: mbenson Date: Wed May 16 13:13:37 2007 New Revision: 538707 URL: http://svn.apache.org/viewvc?view=revrev=538707 Log: add keywords Modified: jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/XMLSpaceTest.java (props changed) Propchange: jakarta/commons/proper/jxpath/trunk/src/test/org/apache/commons/jxpath/ri/model/XMLSpaceTest.java -- svn:keywords = Date Author Id Revision HeadURL - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538709 - /jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml
Author: jochen Date: Wed May 16 13:18:28 2007 New Revision: 538709 URL: http://svn.apache.org/viewvc?view=revrev=538709 Log: (empty) Modified: jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml Modified: jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml?view=diffrev=538709r1=538708r2=538709 == --- jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml Wed May 16 13:18:28 2007 @@ -39,7 +39,7 @@ /properties body -release version=1.4 date=Not yet released +release version=1.4 date=2007-May-16 action dev=jochen type=fix issue=IO-115 Some tests, which are implicitly assuming a Unix-like file system, are now skipped on Windows. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538711 - /jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml
Author: jochen Date: Wed May 16 13:20:43 2007 New Revision: 538711 URL: http://svn.apache.org/viewvc?view=revrev=538711 Log: Fixed typo. Modified: jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml Modified: jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml?view=diffrev=538711r1=538710r2=538711 == --- jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml Wed May 16 13:20:43 2007 @@ -39,7 +39,7 @@ /properties body -release version=1.4 date=2007-May-16 +release version=1.4 date=2007-May-16 action dev=jochen type=fix issue=IO-115 Some tests, which are implicitly assuming a Unix-like file system, are now skipped on Windows. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538725 - in /jakarta/commons/proper/io/branches/b1_3: RELEASE-NOTES.txt src/conf/MANIFEST.MF xdocs/building.xml xdocs/index.xml xdocs/navigation.xml xdocs/upgradeto1_3_2.xml xdocs/upgrade
Author: jochen Date: Wed May 16 13:47:54 2007 New Revision: 538725 URL: http://svn.apache.org/viewvc?view=revrev=538725 Log: Release related changes. Added: jakarta/commons/proper/io/branches/b1_3/xdocs/upgradeto1_3_2.xml - copied, changed from r538699, jakarta/commons/proper/io/branches/b1_3/xdocs/upgradeto1_4.xml Removed: jakarta/commons/proper/io/branches/b1_3/xdocs/upgradeto1_4.xml Modified: jakarta/commons/proper/io/branches/b1_3/RELEASE-NOTES.txt jakarta/commons/proper/io/branches/b1_3/src/conf/MANIFEST.MF jakarta/commons/proper/io/branches/b1_3/xdocs/building.xml jakarta/commons/proper/io/branches/b1_3/xdocs/index.xml jakarta/commons/proper/io/branches/b1_3/xdocs/navigation.xml Modified: jakarta/commons/proper/io/branches/b1_3/RELEASE-NOTES.txt URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/RELEASE-NOTES.txt?view=diffrev=538725r1=538724r2=538725 == --- jakarta/commons/proper/io/branches/b1_3/RELEASE-NOTES.txt (original) +++ jakarta/commons/proper/io/branches/b1_3/RELEASE-NOTES.txt Wed May 16 13:47:54 2007 @@ -1,7 +1,7 @@ $Id$ Commons IO Package - Version 1.3.1 + Version 1.3.2 Release Notes @@ -15,6 +15,15 @@ and endian transformation classes. +Compatibility with 1.3.1 +-- +Binary compatible - Yes + +Source compatible - Yes + +Semantic compatible - Yes + + Compatibility with 1.3 -- Binary compatible - No @@ -26,12 +35,29 @@ Semantic compatible - Yes +Enhancements since 1.3.1 + + +- Created the FileCleaningTracker, basically a non-static version of the + FileCleaner, which can be controlled by the user. [IO-116] +- The FileCleaner is deprecated. + + +Bug fixes from 1.3.1 + + +- Some tests, which are implicitly assuming a Unix-like file system, are + now skipped on Windows. [IO-115] + + + Bug fixes from 1.3 -- - FileUtils - NPE in openOutputStream(File) when file has no parent in path [IO-112] - readFileToString(File) is not static [IO-113] + Feedback Modified: jakarta/commons/proper/io/branches/b1_3/src/conf/MANIFEST.MF URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/src/conf/MANIFEST.MF?view=diffrev=538725r1=538724r2=538725 == --- jakarta/commons/proper/io/branches/b1_3/src/conf/MANIFEST.MF (original) +++ jakarta/commons/proper/io/branches/b1_3/src/conf/MANIFEST.MF Wed May 16 13:47:54 2007 @@ -1,10 +1,10 @@ Manifest-Version: 1.0 Package: org.apache.commons.io Extension-Name: commons-io -Specification-Version: 1.3.1 +Specification-Version: 1.3.2 Specification-Vendor: Apache Software Foundation Specification-Title: Commons IO -Implementation-Version: 1.3.1 +Implementation-Version: 1.3.2 Implementation-Vendor: Apache Software Foundation Implementation-Title: Commons IO Implementation-Vendor-Id: org.apache Modified: jakarta/commons/proper/io/branches/b1_3/xdocs/building.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/xdocs/building.xml?view=diffrev=538725r1=538724r2=538725 == --- jakarta/commons/proper/io/branches/b1_3/xdocs/building.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/xdocs/building.xml Wed May 16 13:47:54 2007 @@ -29,6 +29,7 @@ /p p You may also be interested in the upgrade notes:br / + Upgrade a href=upgradeto1_3_2.htmlfrom 1.3, or 1.3.1 to 1.3.2/abr / Upgrade a href=upgradeto1_3_1.htmlfrom 1.3 to 1.3.1/abr / Upgrade a href=upgradeto1_3.htmlfrom 1.2 to 1.3/abr / Upgrade a href=upgradeto1_2.htmlfrom 1.1 to 1.2/abr / Modified: jakarta/commons/proper/io/branches/b1_3/xdocs/index.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/xdocs/index.xml?view=diffrev=538725r1=538724r2=538725 == --- jakarta/commons/proper/io/branches/b1_3/xdocs/index.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/xdocs/index.xml Wed May 16 13:47:54 2007 @@ -40,13 +40,14 @@ p A getting started a href=description.htmluser guide/a is available, as are some IO a href=bestpractices.htmlbest practices/a -and various a href=maven-reports.htmlproject reports/a. +and various a href=project-reports.htmlproject reports/a. /p p The JavaDoc API documents are available online: /p ul -liThe a href=api-release/index.htmlcurrent release 1.3.1/a/li +liThe a href=api-release/index.htmlcurrent release 1.3.2/a/li +liThe a href=api-1.3.1/index.htmlprevious version 1.3.1/a/li liThe a href=api-1.3/index.htmlprevious version 1.3/a/li liThe a href=api-1.2/index.htmlprevious version 1.2/a/li
svn commit: r538726 - /jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml
Author: jochen Date: Wed May 16 13:51:13 2007 New Revision: 538726 URL: http://svn.apache.org/viewvc?view=revrev=538726 Log: Invalid version number. Modified: jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml Modified: jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml?view=diffrev=538726r1=538725r2=538726 == --- jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml (original) +++ jakarta/commons/proper/io/branches/b1_3/src/changes/changes.xml Wed May 16 13:51:13 2007 @@ -39,7 +39,7 @@ /properties body -release version=1.4 date=2007-May-16 +release version=1.3.2 date=2007-May-16 action dev=jochen type=fix issue=IO-115 Some tests, which are implicitly assuming a Unix-like file system, are now skipped on Windows. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[VOTE] Release commons-io 1.3.2
Hi, I'd like to call for a vote on the release of commons-io 1.3.2. The proposed distributables can be found at http://people.apache.org/~jochen/commons-io/dist A KEYS file is included. The proposed site is at http://people.apache.org/~jochen/commons-io/site It includes a RAT report. Thanks, Jochen [ ] +1 [ ] =0 [ ] -1 -- My cats know that I am a loser who goes out for hunting every day without ever returning as much as a single mouse. Fortunately, I've got a wife who's a real champ: She leaves the house and returns within half an hour, carrying whole bags full of meal. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JCI-41) [jci] icl.loadIClass(Descriptor.fromClassName(pClasses[i])) now throws ClassNotFoundException
[ https://issues.apache.org/jira/browse/JCI-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt updated JCI-41: - Fix Version/s: 1.0.1 [jci] icl.loadIClass(Descriptor.fromClassName(pClasses[i])) now throws ClassNotFoundException - Key: JCI-41 URL: https://issues.apache.org/jira/browse/JCI-41 Project: Commons JCI Issue Type: Improvement Components: compiler janino Reporter: Mark Proctor Fix For: 1.0.1 For Janino 2.5.5 icl.loadIClass(Descriptor.fromClassName(pClasses[i])) now throws ClassNotFoundException. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JCI-43) javac fails on windows
[ https://issues.apache.org/jira/browse/JCI-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt updated JCI-43: - Fix Version/s: 1.0.1 javac fails on windows -- Key: JCI-43 URL: https://issues.apache.org/jira/browse/JCI-43 Project: Commons JCI Issue Type: Improvement Components: compiler javac Environment: Windows XP, JDK 1.6 Reporter: Torsten Curdt Priority: Minor Fix For: 1.0.1 For some reason we still have a backslash in there while it should be a simple slash junit.framework.AssertionFailedError: Failure executing javac, but could not parse the error: javac: file not found: jci\Simple.java Usage: javac options source files use -help for a list of possible options , expected:0 but was:1 at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.failNotEquals(Assert.java:282) at junit.framework.Assert.assertEquals(Assert.java:64) at junit.framework.Assert.assertEquals(Assert.java:201) at org.apache.commons.jci.compilers.AbstractCompilerTestCase.testSimpleCompile(AbstractCompilerTestCase.java:56) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JCI-49) wrap logging statements via build
[ https://issues.apache.org/jira/browse/JCI-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt updated JCI-49: - Component/s: fam examples core compiler rhino compiler jython compiler jsr199 compiler javac compiler janino compiler groovy compiler eclipse Fix Version/s: 1.0.1 wrap logging statements via build - Key: JCI-49 URL: https://issues.apache.org/jira/browse/JCI-49 Project: Commons JCI Issue Type: Improvement Components: compiler eclipse, compiler groovy, compiler janino, compiler javac, compiler jsr199, compiler jython, compiler rhino, core, examples, fam Reporter: Torsten Curdt Fix For: 1.0.1 Wrapping the logging statements should be added during the build using just4log. (I hate clutter!) http://just4log.sourceforge.net/ Would be good to wrap it in a little maven plugin. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JCI-48) Removed deprecations before JCI 1.0 release
[ https://issues.apache.org/jira/browse/JCI-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt updated JCI-48: - Fix Version/s: 1.0.1 Removed deprecations before JCI 1.0 release --- Key: JCI-48 URL: https://issues.apache.org/jira/browse/JCI-48 Project: Commons JCI Issue Type: Bug Components: core Affects Versions: 1.0RC2 Reporter: Niall Pemberton Fix For: 1.0.1 There are a number of deprecations in JCI which should be removed before the 1.0 release (since removing after becomes more difficult wrt to backwards compatibility) 1) JavaCompilerFactory - remove deprecated static instance and getInstance() method 2) FileResourceReader - remove deprecated list() methods 3) MemoryResourceReader - remove deprecated list() method 4) FileResourceStore - remove deprecated list() methods 5) MemoryResourceStore - remove deprecated list() methods -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JCI-45) ReloadingClassLoader's removeResourceStore() method doesn't work
[ https://issues.apache.org/jira/browse/JCI-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt updated JCI-45: - Fix Version/s: 1.0 ReloadingClassLoader's removeResourceStore() method doesn't work Key: JCI-45 URL: https://issues.apache.org/jira/browse/JCI-45 Project: Commons JCI Issue Type: Bug Components: core Affects Versions: 1.0RC2 Reporter: Niall Pemberton Fix For: 1.0 Attachments: JCI-45-ReloadingClassLoader-remove.patch, ReloadingClassLoaderRemoveTestCase.java There are a number of bugs in ReloadingClassLoader's removeResourceStore() method: 1) While Loop The While loop that searches for the ResourceStore to remove throws an ArrayOutOfBoundsException if the ResourceStore is not found 2) Removing the last ResourceStore fails to update the delegate ClassLoader If the ResourceStore being removed is the last one an empty array is created, but the delegate ResourceStoreClassLoader is not updated - which means calling loadClass() for a class in that store still returns the Class rather than throwing a ClassNotFoundException 3) Removing a ResourceStore when there is more than one in the array doesn't work at all The two System.arraycopy() statements used to create a new array without the ResourceStore being removed doesn't work. The position and length parameters are wrong and result in either a ArrayOutOfBoundsException being thrown or the wrong ResourceStore(s) being removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JCI-47) Swallowing Exceptions makes debugging difficult
[ https://issues.apache.org/jira/browse/JCI-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt updated JCI-47: - Component/s: core Swallowing Exceptions makes debugging difficult --- Key: JCI-47 URL: https://issues.apache.org/jira/browse/JCI-47 Project: Commons JCI Issue Type: Improvement Components: core Affects Versions: 1.0RC2 Reporter: Niall Pemberton I've noticed that JCI swallows exceptions in a number of places. For example both the read() and write() methods do this in FileResourceStore. I think I've also seen it in at least a couple of other places (I'll try to put together a full list). Maybe there should be a JCI run time exception that they throw - anyway at a minimum I think the exceptions should at least be logged IMO -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JCI-32) [jci] Improved Groovy Compiler Exception handling
[ https://issues.apache.org/jira/browse/JCI-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-32. [jci] Improved Groovy Compiler Exception handling - Key: JCI-32 URL: https://issues.apache.org/jira/browse/JCI-32 Project: Commons JCI Issue Type: Bug Environment: Operating System: other Platform: Other Reporter: Mark Proctor changed } catch (CompilationFailedException e) { e.printStackTrace(); throw new RuntimeException(no expected); } to } catch (CompilationFailedException e) { throw new RuntimeException(no expected, e); } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JCI-23) [jci] Remove runtime dependency on FileUtil and IOUtil
[ https://issues.apache.org/jira/browse/JCI-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-23. [jci] Remove runtime dependency on FileUtil and IOUtil -- Key: JCI-23 URL: https://issues.apache.org/jira/browse/JCI-23 Project: Commons JCI Issue Type: Bug Environment: Operating System: other Platform: Other Reporter: Mark Proctor Attachments: IOUtil.java, remove_runtime_commons-io_depdency.patch, remove_runtime_commons-io_depdency.patch the use case is small better to just rip the two copy methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JCI-17) [jci] GroovyJavaCompiler assumes extensions end in .java
[ https://issues.apache.org/jira/browse/JCI-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-17. [jci] GroovyJavaCompiler assumes extensions end in .java -- Key: JCI-17 URL: https://issues.apache.org/jira/browse/JCI-17 Project: Commons JCI Issue Type: Bug Environment: Operating System: other Platform: Other Reporter: Mark Proctor Looks like a bit of cut and paste code assumes groovy files end in .java: final String filename = clazzNames[i].replace('.','/') + .java; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JCI-16) [jci] Groovy JSR-04 SourceUnit api change
[ https://issues.apache.org/jira/browse/JCI-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-16. [jci] Groovy JSR-04 SourceUnit api change - Key: JCI-16 URL: https://issues.apache.org/jira/browse/JCI-16 Project: Commons JCI Issue Type: Bug Environment: Operating System: other Platform: Other Reporter: Mark Proctor Attachments: groovy update.diff SourceUnit has changed its constructor to insist on a GroovyClassLoader -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JCI-13) [jci] add list() method to readers and stores
[ https://issues.apache.org/jira/browse/JCI-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-13. [jci] add list() method to readers and stores - Key: JCI-13 URL: https://issues.apache.org/jira/browse/JCI-13 Project: Commons JCI Issue Type: Bug Environment: Operating System: other Platform: Other Reporter: Mark Proctor Attachments: list.patch, MemoryResourceReader.java It would be nice if the readers and stores could list their content. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (JCI-10) [jci] Stop Groovy from outputting to disk
[ https://issues.apache.org/jira/browse/JCI-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-10. [jci] Stop Groovy from outputting to disk - Key: JCI-10 URL: https://issues.apache.org/jira/browse/JCI-10 Project: Commons JCI Issue Type: Bug Environment: Operating System: other Platform: Other Reporter: Mark Proctor Attachments: groovy_phases.diff As JCI has its own stores that can be on disk or in memory we need to stop Groovy from outputting to disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r538753 - in /jakarta/commons/proper/jci/trunk/core/src: main/java/org/apache/commons/jci/ main/java/org/apache/commons/jci/utils/ test/java/org/apache/commons/jci/
Author: tcurdt Date: Wed May 16 14:57:58 2007 New Revision: 538753 URL: http://svn.apache.org/viewvc?view=revrev=538753 Log: https://issues.apache.org/jira/browse/JCI-45 Added: jakarta/commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/ReloadingClassLoaderRemoveTestCase.java (with props) Modified: jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/utils/ConversionUtils.java Modified: jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java?view=diffrev=538753r1=538752r2=538753 == --- jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java (original) +++ jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java Wed May 16 14:57:58 2007 @@ -71,7 +71,7 @@ // FIXME: this should be improved with a Map // find the pStore and index position with var i -while ( ( i = n ) ( stores[i] != pStore ) ) { +while ( ( i n ) ( stores[i] != pStore ) ) { i++; } @@ -81,17 +81,16 @@ } // if stores length 1 then array copy old values, else create new empty store -if (n 1) { -final ResourceStore[] newStores = new ResourceStore[n - 1]; - -System.arraycopy(stores, 0, newStores, 0, i-1); -System.arraycopy(stores, i, newStores, i, newStores.length - 1); - -stores = newStores; -delegate = new ResourceStoreClassLoader(parent, stores); -} else { -stores = new ResourceStore[0]; +final ResourceStore[] newStores = new ResourceStore[n - 1]; +if (i 0) { +System.arraycopy(stores, 0, newStores, 0, i); } +if (i n - 1) { +System.arraycopy(stores, i + 1, newStores, i, (n - i - 1)); +} + +stores = newStores; +delegate = new ResourceStoreClassLoader(parent, stores); return true; } Modified: jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/utils/ConversionUtils.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/utils/ConversionUtils.java?view=diffrev=538753r1=538752r2=538753 == --- jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/utils/ConversionUtils.java (original) +++ jakarta/commons/proper/jci/trunk/core/src/main/java/org/apache/commons/jci/utils/ConversionUtils.java Wed May 16 14:57:58 2007 @@ -21,6 +21,7 @@ /** * Mainly common path manipultation helper methods + * NOT FOR USE OUTSIDE OF JCI * * @author tcurdt */ @@ -61,6 +62,7 @@ return new String(name); } +/* public static String clazzName( final File base, final File file ) { final int rootLength = base.getAbsolutePath().length(); final String absFileName = file.getAbsolutePath(); @@ -69,7 +71,7 @@ final String clazzName = relFileName.replace(File.separatorChar, '.'); return clazzName; } - +*/ public static String relative( final File base, final File file ) { final int rootLength = base.getAbsolutePath().length(); final String absFileName = file.getAbsolutePath(); Added: jakarta/commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/ReloadingClassLoaderRemoveTestCase.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/ReloadingClassLoaderRemoveTestCase.java?view=autorev=538753 == --- jakarta/commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/ReloadingClassLoaderRemoveTestCase.java (added) +++ jakarta/commons/proper/jci/trunk/core/src/test/java/org/apache/commons/jci/ReloadingClassLoaderRemoveTestCase.java Wed May 16 14:57:58 2007 @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the License); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or
[jira] Closed: (JCI-45) ReloadingClassLoader's removeResourceStore() method doesn't work
[ https://issues.apache.org/jira/browse/JCI-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Torsten Curdt closed JCI-45. Resolution: Fixed applied. thanks! ReloadingClassLoader's removeResourceStore() method doesn't work Key: JCI-45 URL: https://issues.apache.org/jira/browse/JCI-45 Project: Commons JCI Issue Type: Bug Components: core Affects Versions: 1.0RC2 Reporter: Niall Pemberton Fix For: 1.0 Attachments: JCI-45-ReloadingClassLoader-remove.patch, ReloadingClassLoaderRemoveTestCase.java There are a number of bugs in ReloadingClassLoader's removeResourceStore() method: 1) While Loop The While loop that searches for the ResourceStore to remove throws an ArrayOutOfBoundsException if the ResourceStore is not found 2) Removing the last ResourceStore fails to update the delegate ClassLoader If the ResourceStore being removed is the last one an empty array is created, but the delegate ResourceStoreClassLoader is not updated - which means calling loadClass() for a class in that store still returns the Class rather than throwing a ClassNotFoundException 3) Removing a ResourceStore when there is more than one in the array doesn't work at all The two System.arraycopy() statements used to create a new array without the ResourceStore being removed doesn't work. The position and length parameters are wrong and result in either a ArrayOutOfBoundsException being thrown or the wrong ResourceStore(s) being removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: commons compress status?
On 5/15/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I'm interested in merging some earlier archival work (in C) into commons compress and would like to know who to coordinate with. The changes will be... substantial... and I'll probably just fork the project for now, with a goal of merging in late summer. It's a dormant component at the moment (we need to move it over to dormant I think). I don't know of anyone who is monitoring it - Chris Grobmeier was the last one who was discussing working on it (or am I forgetting someone more recently?) Also, what version of the JDK do projects use? Can we assume java5 yet? Given compress has never released, I don't think it would be bad to assume that. Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: commons compress status?
On 5/15/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I'm interested in merging some earlier archival work (in C) into commons compress and would like to know who to coordinate with. The changes will be... substantial... and I'll probably just fork the project for now, with a goal of merging in late summer. It's a dormant component at the moment (we need to move it over to dormant I think). I don't know of anyone who is monitoring it - Chris Grobmeier was the last one who was discussing working on it (or am I forgetting someone more recently?) Hmmm... dormant Seriously, that creates a lot of flexibility. The cool thing about archives is that you can think about them as persistent Maps if you're willing to be see a filename as potentially an arbitrary string key instead of just a concrete presentation of a concrete file on your hard disk. That insight makes you look at archive files in a whole new light, as something potentially occupying a space between a properties file and a full JDBC connection. Something that can even be nested, e.g., the .deb package format is nothing more than a couple compressed tar files inside of a unix 'ar' library/archive. You can't do that if you only see archives as boring things used in backups. Backups that are either windows (zip) or unix (tar), yawn. If you go hardcore, you'll notice that a lot of common file formats provide support for arbitrary data to be buried within the files. JPEG and PNG image formats, ELF executable files and shared libraries This definitely isn't 1.0 stuff, but it's something to keep in mind. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [all] parent pom repositories
On 5/16/07, Torsten Curdt [EMAIL PROTECTED] wrote: So we would basically always do a export PASSPHRASE=secret mvn release:prepare -Prc mvn release:perform -Prc -Dgpg.passphrase=$PASSPHRASE -Darguments=- Prc -Dgpg.passphrase=$PASSPHRASE Random thought ACK! I'm not putting my passphrase in my bash history :) Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [all] parent pom repositories
On 17.05.2007, at 01:52, Henri Yandell wrote: On 5/16/07, Torsten Curdt [EMAIL PROTECTED] wrote: So we would basically always do a export PASSPHRASE=secret mvn release:prepare -Prc mvn release:perform -Prc -Dgpg.passphrase=$PASSPHRASE - Darguments=- Prc -Dgpg.passphrase=$PASSPHRASE Random thought ACK! I'm not putting my passphrase in my bash history :) Well ...then you have to write it clear text into the settings.xml ...not sure what is better. http://gentoo-wiki.com/SECURITY_Bash_History_Functions You could have that file on a crypted partition though ...or you fix the plugin to ask for the passphrase :-D ...but what about the general question? cheers -- Torsten - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: commons compress status?
Torsten Curdt wrote: On 15.05.2007, at 23:29, [EMAIL PROTECTED] wrote: I'm interested in merging some earlier archival work (in C) into commons compress and would like to know who to coordinate with. The changes will be... substantial... and I'll probably just fork the project for now, with a goal of merging in late summer. I was trying to add a new archiver implementation a few months ago. Let's put it that way - substantial changes are good :) ...but I think leaving and just coming back with the new finished code base is not really open-source'ish. If you want to attract some people having discussions and incremental code contributions would be better. (My 2 cents) As I recall somebody did a study of successful open source project and discovered a common element was a good seed implementation and only a few people with a strong, shared vision. Otherwise projects tended to get mired down in a grey ooze. Fortunately it's easy to figure out what a good seed would be in this case -- the interfaces and a few sample (and simple!) archive formats. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: commons compress status?
On 5/16/07, Bear Giles [EMAIL PROTECTED] wrote: Torsten Curdt wrote: On 15.05.2007, at 23:29, [EMAIL PROTECTED] wrote: I'm interested in merging some earlier archival work (in C) into commons compress and would like to know who to coordinate with. The changes will be... substantial... and I'll probably just fork the project for now, with a goal of merging in late summer. I was trying to add a new archiver implementation a few months ago. Let's put it that way - substantial changes are good :) ...but I think leaving and just coming back with the new finished code base is not really open-source'ish. If you want to attract some people having discussions and incremental code contributions would be better. (My 2 cents) As I recall somebody did a study of successful open source project and discovered a common element was a good seed implementation and only a few people with a strong, shared vision. Otherwise projects tended to get mired down in a grey ooze. Fortunately it's easy to figure out what a good seed would be in this case -- the interfaces and a few sample (and simple!) archive formats. Getting from 0 to few is tradtionally the problem for compress :) Hen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]