Re: [lang] Remove checkstyle.properties?

2003-12-29 Thread Martin van den Bemt
Prepare for the worst :) esp. Avoid inline conditionals comes to mind...

Mvgr,
Martin

On Mon, 2003-12-29 at 06:42, Henri Yandell wrote:
 Sounds good. Why not just grab dbcp's and see what we (our code) disagree
 with? :)
 
 Hen
 
 On Sun, 28 Dec 2003, Phil Steitz wrote:
 
  Gary Gregory wrote:
   Hello,
  
   Since we now have checkstyle.xml, can we remove checkstyle.properties?
  
   Gary
 
  +1
 
  We should also think about updating this.  When I created checkstyle.xml,
  I just translated from the existing checkstyle.properties.  There is not
  much in there. That's OK with me personally, but if we want to consider a
  more aggressive set of checks, we might want to do some comparative
  shopping among the other commons components. One that has a pretty
  comprehensive set of checks is [dbcp].
 
  Phil
 
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
-- 
Martin van den Bemt [EMAIL PROTECTED]
mvdb.com


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[lang] Remove checkstyle.properties?

2003-12-28 Thread Gary Gregory
Hello,

Since we now have checkstyle.xml, can we remove checkstyle.properties?

Gary


Re: [lang] Remove checkstyle.properties?

2003-12-28 Thread Henri Yandell

Sounds good. Why not just grab dbcp's and see what we (our code) disagree
with? :)

Hen

On Sun, 28 Dec 2003, Phil Steitz wrote:

 Gary Gregory wrote:
  Hello,
 
  Since we now have checkstyle.xml, can we remove checkstyle.properties?
 
  Gary

 +1

 We should also think about updating this.  When I created checkstyle.xml,
 I just translated from the existing checkstyle.properties.  There is not
 much in there. That's OK with me personally, but if we want to consider a
 more aggressive set of checks, we might want to do some comparative
 shopping among the other commons components. One that has a pretty
 comprehensive set of checks is [dbcp].

 Phil


 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]