subject:"Cache"

svn commit: r551086 - /jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java

2007-06-27 Thread imario

Author: imario
Date: Wed Jun 27 00:43:53 2007
New Revision: 551086

URL: http://svn.apache.org/viewvc?view=revrev=551086
Log:
fixed race condition

Modified:

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java?view=diffrev=551086r1=551085r2=551086
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java
 Wed Jun 27 00:43:53 2007
@@ -36,7 +36,7 @@
  * This implementation caches every file as long as it is strongly reachable by
  * the java vm. As soon as the vm needs memory - every softly reachable file
  * will be discarded.
- * 
+ *
  * @author a href=mailto:[EMAIL PROTECTED]Mario Ivankovits/a
  * @version $Revision$ $Date: 2005-09-30 09:02:41 +0200 (Fr, 30 Sep
  *  2005) $
@@ -81,8 +81,12 @@
continue;
}
 
-   FileSystemAndNameKey key = 
(FileSystemAndNameKey) refReverseMap
-   .get(ref);
+   FileSystemAndNameKey key;
+   synchronized(refReverseMap)
+   {
+   key = (FileSystemAndNameKey) 
refReverseMap
+   .get(ref);
+   }
 
if (key != null)
{
@@ -152,7 +156,10 @@
synchronized (files)
{
files.put(file.getName(), ref);
-   refReverseMap.put(ref, key);
+   synchronized(refReverseMap)
+   {
+   refReverseMap.put(ref, key);
+   }
}
}
 
@@ -190,19 +197,21 @@
 
synchronized (files)
{
-   Iterator iterKeys = refReverseMap.values().iterator();
-   while (iterKeys.hasNext())
+   synchronized(refReverseMap)
{
-   FileSystemAndNameKey key = 
(FileSystemAndNameKey) iterKeys
-   .next();
-   if (key.getFileSystem() == filesystem)
+   Iterator iterKeys = 
refReverseMap.values().iterator();
+   while (iterKeys.hasNext())
{
-   iterKeys.remove();
-   files.remove(key.getFileName());
+   FileSystemAndNameKey key = 
(FileSystemAndNameKey) iterKeys.next();
+   if (key.getFileSystem() == filesystem)
+   {
+   iterKeys.remove();
+   files.remove(key.getFileName());
+   }
}
-   }
 
-   closeFilesystem = files.size()  1;
+   closeFilesystem = files.size()  1;
+   }
}
 
if (closeFilesystem)
@@ -240,7 +249,11 @@
{
filesystemCache.clear();
}
-   refReverseMap.clear();
+
+   synchronized(refReverseMap)
+   {
+   refReverseMap.clear();
+   }
}
 
public void removeFile(FileSystem filesystem, FileName name)
@@ -269,7 +282,10 @@
Object ref = files.remove(key.getFileName());
if (ref != null)
{
-   refReverseMap.remove(ref);
+   synchronized(refReverseMap)
+   {
+   refReverseMap.remove(ref);
+   }
}
 
return files.size()  1;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Created: (VFS-157) Cache the hashCode in AbstractFileName

2007-05-14 Thread Adam Heath (JIRA)

Cache the hashCode in AbstractFileName
--

 Key: VFS-157
 URL: https://issues.apache.org/jira/browse/VFS-157
 Project: Commons VFS
  Issue Type: Improvement
Reporter: Adam Heath


See $summary and patch.  Noticeable speedup.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Updated: (VFS-157) Cache the hashCode in AbstractFileName

2007-05-14 Thread Adam Heath (JIRA)


 [ 
https://issues.apache.org/jira/browse/VFS-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Heath updated VFS-157:
---

Affects Version/s: 1.1

 Cache the hashCode in AbstractFileName
 --

 Key: VFS-157
 URL: https://issues.apache.org/jira/browse/VFS-157
 Project: Commons VFS
  Issue Type: Improvement
Affects Versions: 1.1
Reporter: Adam Heath
 Attachments: feature_cache-AbstractFileName-hashCode.patch


 See $summary and patch.  Noticeable speedup.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Updated: (VFS-157) Cache the hashCode in AbstractFileName

2007-05-14 Thread Adam Heath (JIRA)


 [ 
https://issues.apache.org/jira/browse/VFS-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Heath updated VFS-157:
---

Attachment: feature_cache-AbstractFileName-hashCode.patch

Against svn 501759.

 Cache the hashCode in AbstractFileName
 --

 Key: VFS-157
 URL: https://issues.apache.org/jira/browse/VFS-157
 Project: Commons VFS
  Issue Type: Improvement
Affects Versions: 1.1
Reporter: Adam Heath
 Attachments: feature_cache-AbstractFileName-hashCode.patch


 See $summary and patch.  Noticeable speedup.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r537936 - in /jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs: cache/DefaultFilesCache.java cache/SoftRefFilesCache.java provider/AbstractFileName.java

2007-05-14 Thread imario

Author: imario
Date: Mon May 14 11:24:35 2007
New Revision: 537936

URL: http://svn.apache.org/viewvc?view=revrev=537936
Log:
VFS-145 + VFS-157: Use HashMap for caches and cache calculated hashCode in 
FileName - Thanks to Adam Heath for the patch!

Modified:

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/DefaultFilesCache.java

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java

jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileName.java

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/DefaultFilesCache.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/DefaultFilesCache.java?view=diffrev=537936r1=537935r2=537936
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/DefaultFilesCache.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/DefaultFilesCache.java
 Mon May 14 11:24:35 2007
@@ -22,7 +22,6 @@
 
 import java.util.HashMap;
 import java.util.Map;
-import java.util.TreeMap;
 
 /**
  * A [EMAIL PROTECTED] org.apache.commons.vfs.FilesCache} implementation.br
@@ -58,7 +57,7 @@
 Map files = (Map) filesystemCache.get(filesystem);
 if (files == null)
 {
-files = new TreeMap();
+files = new HashMap();
 filesystemCache.put(filesystem, files);
 }
 

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java?view=diffrev=537936r1=537935r2=537936
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/cache/SoftRefFilesCache.java
 Mon May 14 11:24:35 2007
@@ -16,14 +16,6 @@
  */
 package org.apache.commons.vfs.cache;
 
-import java.lang.ref.Reference;
-import java.lang.ref.ReferenceQueue;
-import java.lang.ref.SoftReference;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.Map;
-import java.util.TreeMap;
-
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.commons.vfs.FileName;
@@ -33,6 +25,13 @@
 import org.apache.commons.vfs.impl.DefaultFileSystemManager;
 import org.apache.commons.vfs.util.Messages;
 
+import java.lang.ref.Reference;
+import java.lang.ref.ReferenceQueue;
+import java.lang.ref.SoftReference;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
+
 /**
  * This implementation caches every file as long as it is strongly reachable by
  * the java vm. As soon as the vm needs memory - every softly reachable file
@@ -289,7 +288,7 @@
Map files = (Map) filesystemCache.get(filesystem);
if (files == null)
{
-   files = new TreeMap();
+   files = new HashMap();
filesystemCache.put(filesystem, files);
}
 

Modified: 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileName.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileName.java?view=diffrev=537936r1=537935r2=537936
==
--- 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileName.java
 (original)
+++ 
jakarta/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/provider/AbstractFileName.java
 Mon May 14 11:24:35 2007
@@ -29,479 +29,487 @@
  * @version $Revision$ $Date$
  */
 public abstract class AbstractFileName
-implements FileName
+   implements FileName
 {
 
-private final String scheme;
-private final String absPath;
-private FileType type;
-
-// Cached stuff
-private String uri;
-private String baseName;
-private String rootUri;
-private String extension;
-private String decodedAbsPath;
-
-public AbstractFileName(final String scheme,
-final String absPath, FileType type)
-{
-this.rootUri = null;
-this.scheme = scheme;
-this.type = type;
-if (absPath != null  absPath.length()  0)
-{
-if (absPath.length()  1  absPath.endsWith(/))
-{
-this.absPath

[jira] Resolved: (VFS-157) Cache the hashCode in AbstractFileName

2007-05-14 Thread Mario Ivankovits (JIRA)


 [ 
https://issues.apache.org/jira/browse/VFS-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mario Ivankovits resolved VFS-157.
--

   Resolution: Fixed
Fix Version/s: 1.1

A - TFTP! ;-)

 Cache the hashCode in AbstractFileName
 --

 Key: VFS-157
 URL: https://issues.apache.org/jira/browse/VFS-157
 Project: Commons VFS
  Issue Type: Improvement
Affects Versions: 1.1
Reporter: Adam Heath
 Fix For: 1.1

 Attachments: feature_cache-AbstractFileName-hashCode.patch


 See $summary and patch.  Noticeable speedup.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[jira] Commented: (CONFIGURATION-180) Cache DatabaseConfiguration values for higher performance

2007-04-25 Thread Emmanuel Bourg (JIRA)

[
https://issues.apache.org/jira/browse/CONFIGURATION-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491813
]

Emmanuel Bourg commented on CONFIGURATION-180:
--

I see several solutions to improve the performances by caching the properties.
We may either :

1. load the entire configuration in memory. A flush() method would save the
new/modified properties back to the database, a sync() method would reload the
properties. That may be nice to reuse the reloading strategies but currently
they are specific to the file configurations, that will require some
refactoring.

2. keep in memory the properties read for a certain time. getProperty(foo)
will hit the database only if foo was read more than 5 minutes ago for example.
The delay would be adjustable. Setting a property would still hit the database
directly.

3. same as 2, but the configuration is preloaded once.

The caching should be optional to preserve the current behavior if needed.

Cache DatabaseConfiguration values for higher performance
-

Key: CONFIGURATION-180
URL: https://issues.apache.org/jira/browse/CONFIGURATION-180
Project: Commons Configuration
Issue Type: Improvement
Reporter: Stephen Cooper
Assigned To: Emmanuel Bourg
Priority: Minor
Fix For: 1.5

Attachments: dbpreload.txt, Enhancement33553.checkstyle.patch,
Enhancement33553.patch

The DatabaseConfiguration class queries each property as it gets the request
for each property. This is
nice for ensuring that you're always up to date, but it doesn't give very
good performance in enterprise
applications, where the database may not be on the same subnet.
What we need is the ability to hit the database once, get all the keys/values
and then serve up
getString etc. from that cache.
I'll be opening a separate enhancement to have a generic Reloading Strategy
which could then be
applied to this caching DatabaseConfiguration approach.

1 2 >

1 - 100 of 177 matches

Mail list logo