Re: [chain] CopyCommand
You are correct. Actually, someone reported this bug already a few days ago:
http://issues.apache.org/bugzilla/show_bug.cgi?id=32894
For those [chain] committers who are listening, I submitted a patch
for that and its still waiting ;-)
sean
On Fri, 7 Jan 2005 13:11:22 -0500, James Mitchell [EMAIL PROTECTED] wrote:
Just poking around in the source (for my own learning) and came across this
bit of code.
I won't even pretend to know what this is supposed to do, but unless I'm way
off, shouldn't this
doing value = context.get(getFromKey()); on line 5?
1 public boolean execute(Context context) throws Exception {
2
3Object value = this.value;
4if (value == null) {
5context.get(getFromKey());
6}
7if (value != null) {
8context.put(getToKey(), value);
9} else {
10context.remove(getToKey());
11}
12return (false);
13
14 }
15
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] CopyCommand
I am a committer on Struts and a few Sandbox items, if I had the karma, I
could fix this add a few more tests that demonstrate/validate the fix.
I don't recall if there needs to be a vote.
Martin? Ted? Craig?
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
- Original Message -
From: Sean Schofield [EMAIL PROTECTED]
To: Jakarta Commons Developers List commons-dev@jakarta.apache.org
Sent: Friday, January 07, 2005 1:47 PM
Subject: Re: [chain] CopyCommand
You are correct. Actually, someone reported this bug already a few days
ago:
http://issues.apache.org/bugzilla/show_bug.cgi?id=32894
For those [chain] committers who are listening, I submitted a patch
for that and its still waiting ;-)
sean
On Fri, 7 Jan 2005 13:11:22 -0500, James Mitchell [EMAIL PROTECTED]
wrote:
Just poking around in the source (for my own learning) and came across
this
bit of code.
I won't even pretend to know what this is supposed to do, but unless I'm
way
off, shouldn't this
doing value = context.get(getFromKey()); on line 5?
1 public boolean execute(Context context) throws Exception {
2
3Object value = this.value;
4if (value == null) {
5context.get(getFromKey());
6}
7if (value != null) {
8context.put(getToKey(), value);
9} else {
10context.remove(getToKey());
11}
12return (false);
13
14 }
15
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] CopyCommand
On Fri, 7 Jan 2005 13:55:17 -0500, James Mitchell [EMAIL PROTECTED] wrote: I am a committer on Struts and a few Sandbox items, if I had the karma, I could fix this add a few more tests that demonstrate/validate the fix. It looks like you already have karma on jakarta-commons. I don't recall if there needs to be a vote. Martin? Ted? Craig? +1 for having you work on commons-chain. Just add yourself to the STATUS file. Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] CopyCommand
+1 for having you work on commons-chain. Just add yourself to the STATUS file. Yes the more the merrier! Craig sean - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [chain] CopyCommand
Cool, I forgot that probably happened when commons-resources got promoted. -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: Craig McClanahan [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Cc: Jakarta Commons Developers List commons-dev@jakarta.apache.org Sent: Friday, January 07, 2005 2:00 PM Subject: Re: [chain] CopyCommand On Fri, 7 Jan 2005 13:55:17 -0500, James Mitchell [EMAIL PROTECTED] wrote: I am a committer on Struts and a few Sandbox items, if I had the karma, I could fix this add a few more tests that demonstrate/validate the fix. It looks like you already have karma on jakarta-commons. I don't recall if there needs to be a vote. Martin? Ted? Craig? +1 for having you work on commons-chain. Just add yourself to the STATUS file. Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
