Re: [Components] Graph: Behavioural change: BC break?
Kore Nordmann wrote: > Hi, > > Jakob reported bug #11777 [1], which says, that the font configuration > assigned to the x axis of a chart is not used during rendering. Instead > of this the font configuration of the last axis (y axis) is used for all > axis. > > I have a patch ready to change this behaviour, but we would lose the > current behaviour, that the font sizes on both axis are always equal > (which often looks "better"), which will also change the output of > several test cases, but fixes the bug. > > The options I can see here: > > 1) Use different font configurations for both axis. > >BC break? Even if it is a BC break, I think it is more logical to have different font configurations for the axis. One axis might have a lot of divisions than the other one, so it would be better to render it with a smaller font size. So I would choose 1). Maybe an option which says "use the same font for all axis" would be useful here to avoid the BC break? > 2) Merge font configurations before rendering. > >This could / would mean to use the lower maximum font size, the >bigger minimum font size etc. Not sure about the other values in a >usual font options class - like colors or fonts. > > 3) Throw an exception, when modyfying the x axis font options. > >I don't like this, and I am not sure how this could be done without >intoducing some ugly hacks. > > If you see other options, please tell me. For now I am in favour of > option 1), even this could be considered as BC breaking. > > [1] http://issues.ez.no/11777 -- Alexandru Stanoi eZ Components System Developer eZ Systems | http://ez.no -- Components mailing list Components@lists.ez.no http://lists.ez.no/mailman/listinfo/components
Re: [Components] Graph: Behavioural change: BC break?
On Tue, 2007-10-30 at 11:47 +0100, Alexandru Stanoi wrote: > Kore Nordmann wrote: > > Hi, > > > > Jakob reported bug #11777 [1], which says, that the font configuration > > assigned to the x axis of a chart is not used during rendering. Instead > > of this the font configuration of the last axis (y axis) is used for all > > axis. > > > > I have a patch ready to change this behaviour, but we would lose the > > current behaviour, that the font sizes on both axis are always equal > > (which often looks "better"), which will also change the output of > > several test cases, but fixes the bug. > > > > The options I can see here: > > > > 1) Use different font configurations for both axis. > > > >BC break? > > Even if it is a BC break, I think it is more logical to have different > font configurations for the axis. One axis might have a lot of divisions > than the other one, so it would be better to render it with a smaller > font size. > > So I would choose 1). > > Maybe an option which says "use the same font for all axis" would be > useful here to avoid the BC break? Yeah, but I don't see a way to introduce such an option without any hacks. :/ ... I will evaluate this further. -- Mit freundlichen Grüßen / Med vennlig hilsen Kore Nordmann (GPG: 0xDDC70BBB) eZ Components Developer eZ systems Headquarters tel +49 (0) 231-9742-7750 | fax +49 (0) 231-9742-7751 [EMAIL PROTECTED] | eZ systems | ez.no signature.asc Description: This is a digitally signed message part -- Components mailing list Components@lists.ez.no http://lists.ez.no/mailman/listinfo/components
Re: [Components] Graph: Behavioural change: BC break?
On Tue, 30 Oct 2007, Kore Nordmann wrote: > > On Tue, 2007-10-30 at 11:47 +0100, Alexandru Stanoi wrote: > > Kore Nordmann wrote: > > > Hi, > > > > > > Jakob reported bug #11777 [1], which says, that the font configuration > > > assigned to the x axis of a chart is not used during rendering. Instead > > > of this the font configuration of the last axis (y axis) is used for all > > > axis. > > > > > > I have a patch ready to change this behaviour, but we would lose the > > > current behaviour, that the font sizes on both axis are always equal > > > (which often looks "better"), which will also change the output of > > > several test cases, but fixes the bug. > > > > > > The options I can see here: > > > > > > 1) Use different font configurations for both axis. > > > > > >BC break? > > > > Even if it is a BC break, I think it is more logical to have different > > font configurations for the axis. One axis might have a lot of divisions > > than the other one, so it would be better to render it with a smaller > > font size. > > > > So I would choose 1). > > > > Maybe an option which says "use the same font for all axis" would be > > useful here to avoid the BC break? > > Yeah, but I don't see a way to introduce such an option without any > hacks. :/ ... I will evaluate this further. I would favor this as well, how're the evaluations going? regards, Derick -- Components mailing list Components@lists.ez.no http://lists.ez.no/mailman/listinfo/components
