Re: [computer-go] More details about MM + source code
Petr Baudis wrote: Hi! On Thu, Oct 01, 2009 at 11:37:06AM +0200, Rémi Coulom wrote: I have been receiving a lot of questions about MM recently, so I have just updated my web page: http://remi.coulom.free.fr/Amsterdam2007/ You'll find the ICGA Journal version of my paper there, with more details about the math. You'll also find the C++ source code of my implementation of MM. It is a standalone tool that takes a data file as input and produces gammas as output. Thank you very much, this is helping a lot! I wonder, isn't there an off-by-one error in the MM() function? I think Max value is one too big, since you sum all elements in [Min..Max], not [Min..Max). Either the two sums need to be changed, or 1 substracted from Max while setting it and adjusting the FeatureIndex text (which seems right). Or did I miss anything? If I understand correctly, you are refering to that loop: for (int i = Max; --i = Min;) It starts at Max - 1, not Max. I am pretty confident this part is correct. Otherwise, it would have generated obvious errors. Rémi ___ computer-go mailing list computer-go@computer-go.org http://www.computer-go.org/mailman/listinfo/computer-go/
Re: [computer-go] More details about MM + source code
On Sun, Dec 13, 2009 at 12:15:42PM +0100, Rémi Coulom wrote: If I understand correctly, you are refering to that loop: for (int i = Max; --i = Min;) It starts at Max - 1, not Max. I am pretty confident this part is correct. Otherwise, it would have generated obvious errors. Oh, I'm sorry, you are right, it's obvious when I look at it after good night sleep. ;-) Petr Pasky Baudis ___ computer-go mailing list computer-go@computer-go.org http://www.computer-go.org/mailman/listinfo/computer-go/
Re: [computer-go] More details about MM + source code
2009/12/13 Petr Baudis pa...@ucw.cz: On Sun, Dec 13, 2009 at 12:15:42PM +0100, Rémi Coulom wrote: If I understand correctly, you are refering to that loop: for (int i = Max; --i = Min;) It starts at Max - 1, not Max. I am pretty confident this part is correct. Otherwise, it would have generated obvious errors. Oh, I'm sorry, you are right, it's obvious when I look at it after good night sleep. ;-) A few years ago I could have written that loop the same way, but now I think this is significantly easier to read: for (int i = Max-1; i=Min; --i) My job involves being called at 3 o'clock in the morning because a program is doing the wrong thing, and this has made me develop an enormous appreciation for clarity. I prefer code that is still obvious when you haven't had a good night sleep. Álvaro. ___ computer-go mailing list computer-go@computer-go.org http://www.computer-go.org/mailman/listinfo/computer-go/
Re: [computer-go] More details about MM + source code
Hi! On Thu, Oct 01, 2009 at 11:37:06AM +0200, Rémi Coulom wrote: I have been receiving a lot of questions about MM recently, so I have just updated my web page: http://remi.coulom.free.fr/Amsterdam2007/ You'll find the ICGA Journal version of my paper there, with more details about the math. You'll also find the C++ source code of my implementation of MM. It is a standalone tool that takes a data file as input and produces gammas as output. Thank you very much, this is helping a lot! I wonder, isn't there an off-by-one error in the MM() function? I think Max value is one too big, since you sum all elements in [Min..Max], not [Min..Max). Either the two sums need to be changed, or 1 substracted from Max while setting it and adjusting the FeatureIndex text (which seems right). Or did I miss anything? -- Petr Pasky Baudis A lot of people have my books on their bookshelves. That's the problem, they need to read them. -- Don Knuth ___ computer-go mailing list computer-go@computer-go.org http://www.computer-go.org/mailman/listinfo/computer-go/
[computer-go] More details about MM + source code
Hi, I have been receiving a lot of questions about MM recently, so I have just updated my web page: http://remi.coulom.free.fr/Amsterdam2007/ You'll find the ICGA Journal version of my paper there, with more details about the math. You'll also find the C++ source code of my implementation of MM. It is a standalone tool that takes a data file as input and produces gammas as output. Rémi ___ computer-go mailing list computer-go@computer-go.org http://www.computer-go.org/mailman/listinfo/computer-go/
