Re: [concordance-devel] Learn-IR not yet working?
On Wednesday 09 April 2008, Phil Dibowitz wrote:
Marcel de Jong wrote:
Hello all,
I'm afraid I have some bad news, not sure if others have had this as
well. When I tried to set up my 555, I needed to have the remote learn
some new trick via IR (basically because it refused to turn on or off me
TV and all other devices I have), but when I ran the command it gave me
this error message:
It got broken sometime recently - when the file_read() stuff was done. I
fixed it in CVS, thanks for pointing that out.
Did you? Cannot see any change yet.. In case you didn't have time, I found
meanwhile that it's actually two bugs - one probably from the file_read
changes in libharmony.cpp, which fails because checking an unset err
variable, and the next one in remote.cpp from the USB buffer changes, to the
effect that the length byte now sits in rsp[63], not in rsp[64].
Attached patch should fix both.
Andreas
Index: libconcord.cpp
===
RCS file: /cvsroot/concordance/concordance/libconcord/libconcord.cpp,v
retrieving revision 1.26
diff -u -3 -p -u -p -r1.26 libconcord.cpp
--- libconcord.cpp 4 Apr 2008 09:16:08 - 1.26
+++ libconcord.cpp 10 Apr 2008 19:39:52 -
@@ -1215,12 +1215,9 @@ int extract_firmware_binary(uint8_t *xml
int learn_ir_commands(uint8_t *data, uint32_t size, int post)
{
- int err;
+ int err = 0;
if (data) {
- if (err != 0) {
- return err;
- }
uint8_t *t = data;
string keyname;
Index: remote.cpp
===
RCS file: /cvsroot/concordance/concordance/libconcord/remote.cpp,v
retrieving revision 1.30
diff -u -3 -p -u -p -r1.30 remote.cpp
--- remote.cpp 4 Apr 2008 09:16:09 - 1.30
+++ remote.cpp 10 Apr 2008 19:39:52 -
@@ -638,7 +638,7 @@ int handle_ir_response(uint8_t rsp[64],
unsigned int t_on, unsigned int t_off, unsigned int pulse_count,
unsigned int *pulses, unsigned int freq)
{
- const unsigned int len = rsp[64];
+ const unsigned int len = rsp[63];
if ((len 1) == 0) {
for (unsigned int u = 2; u len; u += 2) {
const unsigned int t = rsp[u] 8 | rsp[1+u];
-
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Learn-IR not yet working?
Andreas Schulz wrote: On Wednesday 09 April 2008, Phil Dibowitz wrote: Marcel de Jong wrote: Hello all, I'm afraid I have some bad news, not sure if others have had this as well. When I tried to set up my 555, I needed to have the remote learn some new trick via IR (basically because it refused to turn on or off me TV and all other devices I have), but when I ran the command it gave me this error message: It got broken sometime recently - when the file_read() stuff was done. I fixed it in CVS, thanks for pointing that out. Did you? Cannot see any change yet.. In case you didn't have time, I found meanwhile that it's actually two bugs - one probably from the file_read changes in libharmony.cpp, which fails because checking an unset err variable, and the next one in remote.cpp from the USB buffer changes, to the effect that the length byte now sits in rsp[63], not in rsp[64]. No need to initialize that err there once the if() is removed. And yes, I removed the if() before I sent the email. The commit message was in my inbox at 16:46 on 4/8. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible -- Taylor's Laws of Programming signature.asc Description: OpenPGP digital signature - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Learn-IR not yet working?
On Wednesday 09 April 2008, Phil Dibowitz wrote: Marcel de Jong wrote: Hello all, I'm afraid I have some bad news, not sure if others have had this as well. When I tried to set up my 555, I needed to have the remote learn some new trick via IR (basically because it refused to turn on or off me TV and all other devices I have), but when I ran the command it gave me this error message: It got broken sometime recently - when the file_read() stuff was done. I fixed it in CVS, thanks for pointing that out. I grabbed the CVS version yesterday, and had it run, but it only took one command in the file. I had to download the learnIr file for each and every command separately. I kinda expected it to read through all the key commands selected in the screen, and which are available in the file. Bad assumption on my part? It does learn it, sadly the remote still does not turn my TV on or off, not sure why though (not a big problem, since I turn the TV off completely anyway), and the distance between tv IR-eye and remote IR transmitter needs to be pretty close. This latter issue kinda renders the remote rather useless for me. :( It has nothing to do with the work you guys perform, concordance works for me, it's just that the remote itself seems a paperweight to me. :) I'll try again this weekend when I have more time to work with the remote. Perhaps the batteries are running flat. greetings, Marcel - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Learn-IR not yet working?
Andreas Schulz wrote: On Thursday 10 April 2008, Marcel de Jong wrote: I grabbed the CVS version yesterday, and had it run, but it only took one command in the file. I had to download the learnIr file for each and every command separately. I kinda expected it to read through all the key commands selected in the screen, and which are available in the file. Bad assumption on my part? I'm afraid, yes - LearnIR will currently only learn the first key from the xml file, even if you selected multiple keys. I was just about to post a multiple-key xml file, just in case Phil or Steven would be interested to see one - see attachment: It's from a wireshark sniff of a session with the cuurent Windows software, and piped through tidy to make the XML better readable. (and anonymized to protect my privacy). Thanks. That's a whole lot of work when you coulda just opened firefox in linux, selected the keys you wanted, downloaded the XML file from the site and sent it along rather than piecing it together with wireshark. :) As I just wrote in this thread, there is still a bug in remote.cpp, which means that you learned nothing but garbage. Not anymore. :) -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible -- Taylor's Laws of Programming signature.asc Description: OpenPGP digital signature - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Learn-IR not yet working?
On Thu, Apr 10, 2008 at 11:13 PM, Phil Dibowitz [EMAIL PROTECTED] wrote: This is odd, I get great reception with my 880. Either the 5 series us significantly less powered than the 8 series, or your batteries are very weak. I think it's the battery as well. As for the one-file-per-key, does the official software allow you to learn more than one at a time? Sadly I don't have access to a Windows machine nor a Mac, so I can't tell, really. But the webinterface, and the XML file leads me to believe that it does support it. But I do believe that it involves quite a bit of communicating to the server to tell it that you've moved on to the next key. (it keeps track of that) And for some keys, such as the Teletext key and the red key make the connection bad, at least after setting those, I had to reboot the remote in order to get it identified again. I'll try it again this weekend, and make a list of the keys that break the identification until reboot. greetings, Marcel de Jong - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Learn-IR not yet working?
Hello all, I'm afraid I have some bad news, not sure if others have had this as well. When I tried to set up my 555, I needed to have the remote learn some new trick via IR (basically because it refused to turn on or off me TV and all other devices I have), but when I ran the command it gave me this error message: $ sudo concordance --learn-ir LearnIr.EZTut Concordance 0.13+CVS Copyright 2007 Kevin Timmerman and Phil Dibowitz This software is distributed under the GPLv3. Requesting Identity: 100% done Failed with error -1081309996 wherein that last number changed every time I tried to run the command. I hope I can help out. greetings, Marcel de Jong - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Learn-IR not yet working?
Marcel de Jong wrote: Hello all, I'm afraid I have some bad news, not sure if others have had this as well. When I tried to set up my 555, I needed to have the remote learn some new trick via IR (basically because it refused to turn on or off me TV and all other devices I have), but when I ran the command it gave me this error message: It got broken sometime recently - when the file_read() stuff was done. I fixed it in CVS, thanks for pointing that out. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible -- Taylor's Laws of Programming signature.asc Description: OpenPGP digital signature - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
