Re: 'Not supported' message
Hi Cliff, >Got to see you logs and something is weird: there is no messages coming >from plugins/wifi.c >You did not filtered out the logs, did you? No, not at all, but what is strange is that I have no plugins dir and hence no wifi.c! Maybe you built all as builtin. But in your case I don't think it's the issue, it really looks like you lack off wifi plugin at all. >Would be interesting to see gsupplicant's output as well. >Could you retest and get the log this way: > >CONNMAN_SUPPLICANT_DEBUG=1 connmand -n -d &> connman_log.txt > >Would be nice to get wpa_supplicant's log as well (start it before connman): > >wpa_supplicant -u -ddt &> wpa_supplicant_log.txt Attached are the two logs. It wasn't until I stopped supplicant that I got a log. Can I ask why starting Connman manually would create a soft block om Wireless LAN? Do you have a wifi technology appearing in connmanctl ? (technologies command) It looks like wifi plugin has not been built at all: wpa_supplicant is totally untouched. How did you build and installed ConnMan? (bootstrap-configure) Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH 1/1] Fix p2p driver probe
Hi Eduardo,
+ struct connman_technology *technology;
Useless var, see below.
for (list = driver_list; list; list = list->next) {
if (list->data == driver)
@@ -1254,8 +1255,11 @@ int connman_technology_driver_register(struct
connman_technology_driver *driver)
exist:
if (driver->type == CONNMAN_SERVICE_TYPE_P2P) {
- if (!technology_get(CONNMAN_SERVICE_TYPE_P2P))
+ technology = technology_get(CONNMAN_SERVICE_TYPE_P2P);
+ if (!technology)
Keep the code as before, you are not fixing anything here.
return -ENOMEM;
+ else if (driver->probe)
+ driver->probe(technology);
}
If wifi is disabled, it gets soft-rfkill: at this point p2p technology
should be unregistered, thus no longer exist in the technology list.
It seems you have found a p2p technology refcount issue.
I instrumented a bit and it's then visible:
connmand[10575]: src/technology.c:connman_technology_driver_unregister()
Unregistering driver 0x6b92c0 name p2p
connmand[10575]: src/technology.c:technology_find() type 9
connmand[10575]: src/technology.c:technology_put() technology 0x20ef690
- refs 2
When disabling wifi: p2p really should disappear.
Will fix that.
Thanks for testing and finding an issue,
Tomasz
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
[PATCH] technology: Do not refcount P2P technology as it is dependent on wifi
P2P technology exists if only wifi technology exists and does not own
any devices. Thus it's unnecessary to refcount it more than once.
Reported by Eduardo Abinader
---
src/technology.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/technology.c b/src/technology.c
index 5a12202..a917a6c 100644
--- a/src/technology.c
+++ b/src/technology.c
@@ -1157,7 +1157,8 @@ static struct connman_technology *technology_get(enum
connman_service_type type)
technology = technology_find(type);
if (technology) {
- __sync_fetch_and_add(&technology->refcount, 1);
+ if (type != CONNMAN_SERVICE_TYPE_P2P)
+ __sync_fetch_and_add(&technology->refcount, 1);
return technology;
}
--
1.8.3.2
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH] technology: Do not refcount P2P technology as it is dependent on wifi
On Fri, 2014-04-04 at 11:01 +0300, Tomasz Bursztyka wrote: > P2P technology exists if only wifi technology exists and does not own > any devices. Thus it's unnecessary to refcount it more than once. > > Reported by Eduardo Abinader Applied, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: Access Point mode set freq
Hi On Tue, Apr 1, 2014 at 8:56 AM, Tomasz Bursztyka wrote: > Hi, > > >> There >> was some initial work on Advanced Channel Selection in wpa_supplicant, > > > s/Advanced/Automatic > > Currently, only hostapd supports it. I did a q&d patch to support it into > wpa_supplicant as well > however ACS feature has an asynchronous logic, which does not fit into > wpa_s's AP logic currently. > And ACS error reporting won't fit either in its current state (it disables > the interface...) Can you point me to your patch in wpa_supplicant? Michael > > Tomasz > > ___ > connman mailing list > connman@connman.net > https://lists.connman.net/mailman/listinfo/connman -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: 'Not supported' message
> - Original Message - > From: Tomasz Bursztyka > Sent: 04/04/14 08:02 AM > To: connman@connman.net > Subject: Re: 'Not supported' message > > Hi Cliff, > > >> >Got to see you logs and something is weird: there is no messages coming > >> >from plugins/wifi.c > >> >You did not filtered out the logs, did you? > > No, not at all, but what is strange is that I have no plugins dir and hence > > no wifi.c! > > Maybe you built all as builtin. But in your case I don't think it's the > issue, > it really looks like you lack off wifi plugin at all. > > >> >Would be interesting to see gsupplicant's output as well. > >> >Could you retest and get the log this way: > >> > > >> >CONNMAN_SUPPLICANT_DEBUG=1 connmand -n -d &> connman_log.txt > >> > > >> >Would be nice to get wpa_supplicant's log as well (start it before > >> >connman): > >> > > >> >wpa_supplicant -u -ddt &> wpa_supplicant_log.txt > > Attached are the two logs. It wasn't until I stopped supplicant that I got > > a log. > > > > Can I ask why starting Connman manually would create a soft block om > > Wireless LAN? > > Do you have a wifi technology appearing in connmanctl ? (technologies > command) Yes, 'connmanctl technologies' gives: /net/connman/technology/wifi Name = WiFi Type = wifi Powered = True Connected = False Tethering = False > It looks like wifi plugin has not been built at all: wpa_supplicant is > totally untouched. > > How did you build and installed ConnMan? (bootstrap-configure) ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var I understood that wifi is enabled by default, as is gadget, bluetooth etc. thanks Cliff ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
