Re: [PATCH v2 0/6] Strip whitespace and empty strings from DBus input
Hi Jaakko, On ke, 2015-07-15 at 15:26 +0300, Jaakko Hannikainen wrote: > Hello, > > These patches remove empty strings and leading/trailing whitespace from DBus > > input for Domains.Configuration, Proxy.Configuration, > Timeservers.Configuration > and Nameservers.Configuration. > > > > Previously, Nameservers.Configuration accepted invalid values such as > > "192.0.2.1 invalid-ip 8.8.8.8 " and then split them with space as delimiter, > > resulting in Nameservers.Configuration containing > > [192.0.2.1, , invalid-ip, 8.8.8.8, ] rather than the valid value > > [192.0.2.1, 8.8.8.8]. > > > > The v2 implements remove_empty_strings much more sensibly, fixes some style > > issues and adds a patch for Nameservers.Configuration. > > Managed to fudge the cover letter first time around, sorry. > > Jaakko Hannikainen (6): > service: Add function to remove empty strings > service: Remove empty strings from Domains > service: Remove empty strings from Proxy > service: Strip whitespace from Proxy URL > service: Remove empty strings from Timeservers > service: Remove empty strings from Nameservers > > src/service.c | 109 > +++--- > 1 file changed, 74 insertions(+), 35 deletions(-) > All patches have been applied, thanks! Cheers, Jukka ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH v2 0/6] Strip whitespace and empty strings from DBus input
Hi Jaakko, Ack from me too. Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
Re: [PATCH v2 0/6] Strip whitespace and empty strings from DBus input
Hi Jaakko, On ke, 2015-07-15 at 15:26 +0300, Jaakko Hannikainen wrote: > Hello, > > These patches remove empty strings and leading/trailing whitespace from DBus > > input for Domains.Configuration, Proxy.Configuration, > Timeservers.Configuration > and Nameservers.Configuration. > > > > Previously, Nameservers.Configuration accepted invalid values such as > > "192.0.2.1 invalid-ip 8.8.8.8 " and then split them with space as delimiter, > > resulting in Nameservers.Configuration containing > > [192.0.2.1, , invalid-ip, 8.8.8.8, ] rather than the valid value > > [192.0.2.1, 8.8.8.8]. > > > > The v2 implements remove_empty_strings much more sensibly, fixes some style > > issues and adds a patch for Nameservers.Configuration. > > Managed to fudge the cover letter first time around, sorry. looks good so ACK from me. Cheers, Jukka ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
[PATCH v2 0/6] Strip whitespace and empty strings from DBus input
Hello, These patches remove empty strings and leading/trailing whitespace from DBus input for Domains.Configuration, Proxy.Configuration, Timeservers.Configuration and Nameservers.Configuration. Previously, Nameservers.Configuration accepted invalid values such as "192.0.2.1 invalid-ip 8.8.8.8 " and then split them with space as delimiter, resulting in Nameservers.Configuration containing [192.0.2.1, , invalid-ip, 8.8.8.8, ] rather than the valid value [192.0.2.1, 8.8.8.8]. The v2 implements remove_empty_strings much more sensibly, fixes some style issues and adds a patch for Nameservers.Configuration. Managed to fudge the cover letter first time around, sorry. Jaakko Hannikainen (6): service: Add function to remove empty strings service: Remove empty strings from Domains service: Remove empty strings from Proxy service: Strip whitespace from Proxy URL service: Remove empty strings from Timeservers service: Remove empty strings from Nameservers src/service.c | 109 +++--- 1 file changed, 74 insertions(+), 35 deletions(-) -- 2.1.0 ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman
