Re: [controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-25 Thread Luis Gomez 
+1, otherwise we can always grep for the offending features in the distribution 
and remove them from the distribution-check.

> On Oct 25, 2017, at 7:14 AM, Tomas Cere -X (tcere - PANTHEON TECHNOLOGIES at 
> Cisco)  wrote:
> 
> This is caused by some project that is still pulling in the old feature that 
> starts the loopback connection for config subsystem.
> Which pulls in the non clustered netconf-topology feature . Normally you 
> wouldn’t hit this in sft but since this is the one that
> starts a connector this incompatibility shows. We could remove the 
> preconfigured loopback altogether since people should
> have already moved on from cfg subsystem anyway.
>  
> Tomas
>  
> From: controller-dev-boun...@lists.opendaylight.org 
> [mailto:controller-dev-boun...@lists.opendaylight.org] On Behalf Of Vratko 
> Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco)
> Sent: Monday, October 23, 2017 18:03
> To: Tom Pantelis ; Michael Vorburger 
> 
> Cc: controller-dev 
> Subject: Re: [controller-dev] SingleFeatureTest (SFT) failure on 
> odl-integration-compatible-with-all due to 
> ConflictingModificationAppliedException: Node was created by other 
> transaction.
>  
> Previous story: [2].
>  
> > who would have to do what
>  
> Ideally, Netconf developers would unify their features,
> which does not seem to get done anytime soon [3].
>  
> There is a workaround in Int/Dist [4] prepared,
> but it keeps SFT unstable, this time due to
> (lack of) Karaf 4 memory efficiency [5].
>  
> Current road to stability seem to be
> fixing various ODL project features (like [6])
> to be less taxing on Karaf 4 bundle resolver,
> and then merging [4].
>  
> > It would be nice if the exception included some context like the path.
>  
> I have rebased my old [7].
> In this case, it is multiple netconf features trying to update
> operational topology status for "controller-config" device.
>  
> > How does SFT even pick this up to fail the test?
>  
> In general, a "caused by" thrown by featuresService.installFeature.
> In this case there was an ISE (visible in surefire report [8]
> at 12:27:25,742) coming from here [9] (at least in Nitrogen),
> not sure which component gets to throw it.
>  
> Vratko.
>  
> [2] https://lists.opendaylight.org/pipermail/release/2017-October/012728.html 
> 
> [3] https://jira.opendaylight.org/browse/NETCONF-479 
> 
> [4] https://git.opendaylight.org/gerrit/64410 
> 
> [5] https://jira.opendaylight.org/browse/ODLPARENT-125 
> 
> [6] https://jira.opendaylight.org/browse/INTDIST-92 
> 
> [7] https://git.opendaylight.org/gerrit/48118 
> 
> [8] 
> https://logs.opendaylight.org/releng/jenkins092/infrautils-distribution-check-oxygen/144/distribution/features/singles/odl-integration-compatible-with-all/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt.gz
>  
> 
> [9] 
> https://github.com/opendaylight/netconf/blob/release/nitrogen/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/NetconfDeviceTopologyAdapter.java#L243
>  
> 
>  
> From: controller-dev-boun...@lists.opendaylight.org 
>  
> [mailto:controller-dev-boun...@lists.opendaylight.org 
> ] On Behalf Of Tom 
> Pantelis
> Sent: 23 October, 2017 15:24
> To: Michael Vorburger >
> Cc: controller-dev  >
> Subject: Re: [controller-dev] SingleFeatureTest (SFT) failure on 
> odl-integration-compatible-with-all due to 
> ConflictingModificationAppliedException: Node was created by other 
> transaction.
>  
>  
>  
> On Mon, Oct 23, 2017 at 8:41 AM, Michael Vorburger  > wrote:
> Hello,
>  
> Any idea who would have to do what to precent SFT from (only occassionally?!) 
> failing on odl-integration-compatible-with-all due to 
> ConflictingModificationAppliedException: Node was created by other 
> transaction, as seen on 
>

Re: [controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-24 Thread Luis Gomez 
Vratko, I think we talked about this in the last integration call: if netconf 
project (or any other) has 2 or more features that are incompatible (e.g. 
produce SFT failures) but still required (e.g. for netconf device notifications 
xor netconf cluster use case), the project should select 1 as preferred and we 
should remove the non-preferred feature and any downstream project feature 
consuming this last from the distribution-check test. The workaround of 
allowing both incompatible features [1] has 2 issues imo:

- Extra distribution-check overhead to verify all compatible features twice.
- It sets a precedent for any project to create incompatible features and never 
move from that.

BR/Luis

[1] https://git.opendaylight.org/gerrit/#/c/64410/ 

> On Oct 24, 2017, at 2:44 PM, Michael Vorburger  wrote:
> 
> +unimgr-dev:
> 
> On Mon, Oct 23, 2017 at 6:02 PM, Vratko Polak -X (vrpolak - PANTHEON 
> TECHNOLOGIES at Cisco) > wrote:
> Previous story: [2].
> 
> 
> It's not that rare - just hit me again (on 
> https://git.opendaylight.org/gerrit/#/c/64674/ 
> ), had to override once more 
> - and find this annoying..
>   
> > who would have to do what
> 
>  
> 
> Ideally, Netconf developers would unify their features,
> 
> which does not seem to get done anytime soon [3].
> 
> 
> If I understand [3] correctly, Tomas Cere doesn't even consider this a 
> netconf issue, but asks for "unimgr should move towards odl-netconf-topology" 
> (instead of odl-netconf-connector-ssh, because "There is no reason to pull in 
> odl-netconf-connector-ssh unless you are using config subsystem still"). Is 
> this something the unimgr project would be willing to do?
> 
> If not, or if unimgr-dev, assuming I understand things correctly, why don't 
> we just kick unimgr project out of distribution?! I'll raise a patch 
> proposing this when it next hits me, if it's not resolved by then.
>  
> 
> There is a workaround in Int/Dist [4] prepared,
> 
> but it keeps SFT unstable, this time due to
> 
> (lack of) Karaf 4 memory efficiency [5].
> 
>  
> 
> Current road to stability seem to be
> 
> fixing various ODL project features (like [6])
> 
> to be less taxing on Karaf 4 bundle resolver,
> 
> and then merging [4].
> 
>  
> 
> > It would be nice if the exception included some context like the path.
> 
>  
> 
> I have rebased my old [7].
> 
> In this case, it is multiple netconf features trying to update
> 
> operational topology status for "controller-config" device.
> 
>  
> 
> > How does SFT even pick this up to fail the test?
> 
>  
> 
> In general, a "caused by" thrown by featuresService.installFeature.
> 
> In this case there was an ISE (visible in surefire report [8]
> 
> at 12:27:25,742) coming from here [9] (at least in Nitrogen),
> 
> not sure which component gets to throw it.
> 
>  
> 
> Vratko.
> 
>  
> 
> [2] https://lists.opendaylight.org/pipermail/release/2017-October/012728.html 
> 
> [3] https://jira.opendaylight.org/browse/NETCONF-479 
> 
> [4] https://git.opendaylight.org/gerrit/64410 
> 
> [5] https://jira.opendaylight.org/browse/ODLPARENT-125 
> 
> [6] https://jira.opendaylight.org/browse/INTDIST-92 
> 
> [7] https://git.opendaylight.org/gerrit/48118 
> 
> [8] 
> https://logs.opendaylight.org/releng/jenkins092/infrautils-distribution-check-oxygen/144/distribution/features/singles/odl-integration-compatible-with-all/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt.gz
>  
> 
> [9] 
> https://github.com/opendaylight/netconf/blob/release/nitrogen/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/NetconfDeviceTopologyAdapter.java#L243
>  
> 
>  
> 
> From: controller-dev-boun...@lists.opendaylight.org 
>  
> [mailto:controller-dev-boun...@lists.opendaylight.org 
> ] On Behalf Of Tom 
> Pantelis
> Sent: 23 October, 2017 15:24
> To: Michael Vorburger >
> Cc: controller-dev

Re: [controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-24 Thread Michael Vorburger 
+unimgr-dev:

On Mon, Oct 23, 2017 at 6:02 PM, Vratko Polak -X (vrpolak - PANTHEON
TECHNOLOGIES at Cisco)  wrote:

> Previous story: [2].
>

It's not that rare - just hit me again (on
https://git.opendaylight.org/gerrit/#/c/64674/), had to override once more
- and find this annoying..


> > who would have to do what
>
>
>
> Ideally, Netconf developers would unify their features,
>
> which does not seem to get done anytime soon [3].
>

If I understand [3] correctly, Tomas Cere doesn't even consider this a
netconf issue, but asks for "unimgr should move towards
odl-netconf-topology" (instead of odl-netconf-connector-ssh, because "There
is no reason to pull in odl-netconf-connector-ssh unless you are using
config subsystem still"). Is this something the unimgr project would be
willing to do?

If not, or if unimgr-dev, assuming I understand things correctly, why don't
we just kick unimgr project out of distribution?! I'll raise a patch
proposing this when it next hits me, if it's not resolved by then.


> There is a workaround in Int/Dist [4] prepared,
>
> but it keeps SFT unstable, this time due to
>
> (lack of) Karaf 4 memory efficiency [5].
>
>
>
> Current road to stability seem to be
>
> fixing various ODL project features (like [6])
>
> to be less taxing on Karaf 4 bundle resolver,
>
> and then merging [4].
>
>
>
> > It would be nice if the exception included some context like the path.
>
>
>
> I have rebased my old [7].
>
> In this case, it is multiple netconf features trying to update
>
> operational topology status for "controller-config" device.
>
>
>
> > How does SFT even pick this up to fail the test?
>
>
>
> In general, a "caused by" thrown by featuresService.installFeature.
>
> In this case there was an ISE (visible in surefire report [8]
>
> at 12:27:25,742) coming from here [9] (at least in Nitrogen),
>
> not sure which component gets to throw it.
>
>
>
> Vratko.
>
>
>
> [2] https://lists.opendaylight.org/pipermail/release/2017-
> October/012728.html
>
> [3] https://jira.opendaylight.org/browse/NETCONF-479
>
> [4] https://git.opendaylight.org/gerrit/64410
>
> [5] https://jira.opendaylight.org/browse/ODLPARENT-125
>
> [6] https://jira.opendaylight.org/browse/INTDIST-92
>
> [7] https://git.opendaylight.org/gerrit/48118
>
> [8] https://logs.opendaylight.org/releng/jenkins092/infrautils-
> distribution-check-oxygen/144/distribution/features/singles/
> odl-integration-compatible-with-all/target/surefire-
> reports/org.opendaylight.odlparent.featuretest.
> SingleFeatureTest-output.txt.gz
>
> [9] https://github.com/opendaylight/netconf/blob/
> release/nitrogen/netconf/sal-netconf-connector/src/main/
> java/org/opendaylight/netconf/sal/connect/netconf/sal/
> NetconfDeviceTopologyAdapter.java#L243
>
>
>
> *From:* controller-dev-boun...@lists.opendaylight.org [mailto:
> controller-dev-boun...@lists.opendaylight.org] *On Behalf Of *Tom Pantelis
> *Sent:* 23 October, 2017 15:24
> *To:* Michael Vorburger 
> *Cc:* controller-dev 
> *Subject:* Re: [controller-dev] SingleFeatureTest (SFT) failure on
> odl-integration-compatible-with-all due to 
> ConflictingModificationAppliedException:
> Node was created by other transaction.
>
>
>
>
>
>
>
> On Mon, Oct 23, 2017 at 8:41 AM, Michael Vorburger 
> wrote:
>
> Hello,
>
>
>
> Any idea who would have to do what to precent SFT from (only
> occassionally?!) failing on odl-integration-compatible-with-all due to
> ConflictingModificationAppliedException: Node was created by other
> transaction, as seen on https://logs.opendaylight.org/releng/jenkins092/
> infrautils-distribution-check-oxygen/144/console.log.gz for
> https://git.opendaylight.org/gerrit/#/c/63466/ ?
>
>
>
> It would be nice if the exception included some context like the path.
> Does this test install all netconf features? I've seen such sporadic issues
> with the callhome feature when it's installed with all the other netconf
> features.
>
>
>
> How does SFT even pick this up to fail the test? Log scraping?  Or was it
> a "caused by" thrown on blueprint startup?
>
>
>
>
> Tx,
>
> M.
>
> --
>
> Michael Vorburger, Red Hat
> vorbur...@redhat.com | IRC: vorburger @freenode | ~ = http://vorburger.ch
>
>
> ___
> controller-dev mailing list
> controller-dev@lists.opendaylight.org
> https://lists.opendaylight.org/mailman/listinfo/controller-dev
>
>
>
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-23 Thread Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) 
Previous story: [2].

> who would have to do what

Ideally, Netconf developers would unify their features,
which does not seem to get done anytime soon [3].

There is a workaround in Int/Dist [4] prepared,
but it keeps SFT unstable, this time due to
(lack of) Karaf 4 memory efficiency [5].

Current road to stability seem to be
fixing various ODL project features (like [6])
to be less taxing on Karaf 4 bundle resolver,
and then merging [4].

> It would be nice if the exception included some context like the path.

I have rebased my old [7].
In this case, it is multiple netconf features trying to update
operational topology status for "controller-config" device.

> How does SFT even pick this up to fail the test?

In general, a "caused by" thrown by featuresService.installFeature.
In this case there was an ISE (visible in surefire report [8]
at 12:27:25,742) coming from here [9] (at least in Nitrogen),
not sure which component gets to throw it.

Vratko.

[2] https://lists.opendaylight.org/pipermail/release/2017-October/012728.html
[3] https://jira.opendaylight.org/browse/NETCONF-479
[4] https://git.opendaylight.org/gerrit/64410
[5] https://jira.opendaylight.org/browse/ODLPARENT-125
[6] https://jira.opendaylight.org/browse/INTDIST-92
[7] https://git.opendaylight.org/gerrit/48118
[8] 
https://logs.opendaylight.org/releng/jenkins092/infrautils-distribution-check-oxygen/144/distribution/features/singles/odl-integration-compatible-with-all/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt.gz
[9] 
https://github.com/opendaylight/netconf/blob/release/nitrogen/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/NetconfDeviceTopologyAdapter.java#L243

From: controller-dev-boun...@lists.opendaylight.org 
[mailto:controller-dev-boun...@lists.opendaylight.org] On Behalf Of Tom Pantelis
Sent: 23 October, 2017 15:24
To: Michael Vorburger 
Cc: controller-dev 
Subject: Re: [controller-dev] SingleFeatureTest (SFT) failure on 
odl-integration-compatible-with-all due to 
ConflictingModificationAppliedException: Node was created by other transaction.



On Mon, Oct 23, 2017 at 8:41 AM, Michael Vorburger 
> wrote:
Hello,

Any idea who would have to do what to precent SFT from (only occassionally?!) 
failing on odl-integration-compatible-with-all due to 
ConflictingModificationAppliedException: Node was created by other transaction, 
as seen on 
https://logs.opendaylight.org/releng/jenkins092/infrautils-distribution-check-oxygen/144/console.log.gz
 for https://git.opendaylight.org/gerrit/#/c/63466/ ?

It would be nice if the exception included some context like the path. Does 
this test install all netconf features? I've seen such sporadic issues with the 
callhome feature when it's installed with all the other netconf features.

How does SFT even pick this up to fail the test? Log scraping?  Or was it a 
"caused by" thrown on blueprint startup?


Tx,
M.
--
Michael Vorburger, Red Hat
vorbur...@redhat.com | IRC: vorburger @freenode | 
~ = http://vorburger.ch

___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-23 Thread Michael Vorburger 
+netconf-dev:

On Mon, Oct 23, 2017 at 3:24 PM, Tom Pantelis  wrote:

> On Mon, Oct 23, 2017 at 8:41 AM, Michael Vorburger 
> wrote:
>
>> Hello,
>>
>> Any idea who would have to do what to precent SFT from (only
>> occassionally?!) failing on odl-integration-compatible-with-all due to
>> ConflictingModificationAppliedException: Node was created by other
>> transaction, as seen on https://logs.opendaylight.o
>> rg/releng/jenkins092/infrautils-distribution-check-oxygen/
>> 144/console.log.gz for https://git.opendaylight.org/gerrit/#/c/63466/ ?
>>
>
> It would be nice if the exception included some context like the path.
> Does this test install all netconf features? I've seen such sporadic issues
> with the callhome feature when it's installed with all the other netconf
> features.
>
> How does SFT even pick this up to fail the test? Log scraping?  Or was it
> a "caused by" thrown on blueprint startup?
>

No, no log scraping in SFT.. it must be a "caused by" thrown by a BP
constructor..

You can see interesting background on
https://logs.opendaylight.org/releng/jenkins092/infrautils-distribution-check-oxygen/144/distribution/features/singles/odl-integration-compatible-with-all/target/surefire-reports/org.opendaylight.odlparent.featuretest.SingleFeatureTest-output.txt.gz
...

>From what I gathered, it must be the
org.opendaylight.netconf.sal.connect.netconf.sal.NetconfDeviceTopologyAdapter,
NB its constructor -> initDeviceData() -> commitTransaction() -> with the
onFailure() doing a throw new IllegalStateException() in
Futures.addCallback() by MoreExecutors.directExecutor(), right? BTW:
Wouldn't that code better be sync and just do a block get() on the Tx? And
handle a ConflictingModificationAppliedException with a retry?

Also, somehow it feels something in SFT is slightly off somewhere, because
ideally really it should show that "IllegalStateException:
RemoteDevice{controller-config} Transaction(init) not committed correctly
at
org.opendaylight.netconf.sal.connect.netconf.sal.NetconfDeviceTopologyAdapter"
instead of (only) its "...ConflictingModificationAppliedException..." cause
- but I'm struggling to find the wrong getCause in odlparent's
bundles-test-lib or features4-test behind this! :-( If you can spot it,
please shout so we can fix it and make get a clearer pointer to the
offender more directly, next time.
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-23 Thread Tom Pantelis 
On Mon, Oct 23, 2017 at 8:41 AM, Michael Vorburger 
wrote:

> Hello,
>
> Any idea who would have to do what to precent SFT from (only
> occassionally?!) failing on odl-integration-compatible-with-all due to
> ConflictingModificationAppliedException: Node was created by other
> transaction, as seen on https://logs.opendaylight.org/releng/jenkins092/
> infrautils-distribution-check-oxygen/144/console.log.gz for
> https://git.opendaylight.org/gerrit/#/c/63466/ ?
>

It would be nice if the exception included some context like the path. Does
this test install all netconf features? I've seen such sporadic issues with
the callhome feature when it's installed with all the other netconf
features.

How does SFT even pick this up to fail the test? Log scraping?  Or was it a
"caused by" thrown on blueprint startup?


>
> Tx,
> M.
> --
> Michael Vorburger, Red Hat
> vorbur...@redhat.com | IRC: vorburger @freenode | ~ = http://vorburger.ch
>
> ___
> controller-dev mailing list
> controller-dev@lists.opendaylight.org
> https://lists.opendaylight.org/mailman/listinfo/controller-dev
>
>
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

[controller-dev] SingleFeatureTest (SFT) failure on odl-integration-compatible-with-all due to ConflictingModificationAppliedException: Node was created by other transaction.

2017-10-23 Thread Michael Vorburger 
Hello,

Any idea who would have to do what to precent SFT from (only
occassionally?!) failing on odl-integration-compatible-with-all due to
ConflictingModificationAppliedException: Node was created by other
transaction, as seen on
https://logs.opendaylight.org/releng/jenkins092/infrautils-distribution-check-oxygen/144/console.log.gz
for https://git.opendaylight.org/gerrit/#/c/63466/ ?

Tx,
M.
--
Michael Vorburger, Red Hat
vorbur...@redhat.com | IRC: vorburger @freenode | ~ = http://vorburger.ch
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev