Re: Review Request for 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip
Looks fine to me Dan. -Chris. On 18/09/12 06:29, Dan Xu wrote: Hi, This is the change to correct a java doc link in java.util.zip package page. The webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7195933/webrev/. Thanks! -Dan
hg: jdk8/tl/jdk: 7198871: cleanup security tests in problem lists with no CR attached
Changeset: 53ca38f76eaa Author:weijun Date: 2012-09-18 17:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ca38f76eaa 7198871: cleanup security tests in problem lists with no CR attached Reviewed-by: alanb ! test/ProblemList.txt
hg: jdk8/tl/jdk: 7198901: correct the field size check when decoding a point on ECC curve
Changeset: 95a93f039e5c Author:vinnie Date: 2012-09-18 11:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95a93f039e5c 7198901: correct the field size check when decoding a point on ECC curve Reviewed-by: xuelei ! src/share/classes/sun/security/ec/ECParameters.java
Re: Review Request for 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip
looks OK Dan and I was able to access the URL and download the zip Best Lance On Sep 18, 2012, at 1:29 AM, Dan Xu wrote: Hi, This is the change to correct a java doc link in java.util.zip package page. The webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7195933/webrev/. Thanks! -Dan Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk8/tl/jdk: 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11]
Changeset: bc5e7ec12717 Author:dxu Date: 2012-09-18 13:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc5e7ec12717 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/nio/channels/AsyncCloseAndInterrupt.java
hg: jdk8/tl/jdk: 7199066: Typo in method name
Changeset: 88a4f699d233 Author:xuelei Date: 2012-09-18 06:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a4f699d233 7199066: Typo in method name Reviewed-by: mullan ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java
Re: Review Request for 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip
Change looks fine. Thanks, -Sherman On 9/17/2012 10:29 PM, Dan Xu wrote: Hi, This is the change to correct a java doc link in java.util.zip package page. The webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7195933/webrev/. Thanks! -Dan
hg: jdk8/tl/jdk: 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt
Changeset: 0136fca60652 Author:naoto Date: 2012-09-18 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0136fca60652 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com ! test/ProblemList.txt
hg: jdk8/tl/jdk: 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions
Changeset: e7add6d98729 Author:mduigou Date: 2012-09-18 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7add6d98729 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions Reviewed-by: alanb ! test/java/util/Map/Collisions.java
Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable
Please review this minor usage note change for Bug 4722265:
diff -r 8a454e92aaf1 src/share/classes/java/lang/AbstractStringBuilder.java
--- a/src/share/classes/java/lang/AbstractStringBuilder.javaMon Sep
17 12:40:33 2012 +0200
+++ b/src/share/classes/java/lang/AbstractStringBuilder.javaTue Sep
18 13:46:34 2012 -0400
@@ -96,6 +96,9 @@
* /ul
* If the {@code minimumCapacity} argument is nonpositive, this
* method takes no action and simply returns.
+ * Note that a call to ensureCapacity does not guarantee an immutable
+ * setting of the minimum desired capacity. The capacity may change as
+ * the result of subsequent operations.
*
* @param minimumCapacity the minimum desired capacity.
*/
Thanks,
Jim
--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com
Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable
Jim,
I'm not all that sure that this is really such an issue. The methods
that can reduce the capacity seem to be clearly specified. But others
may have a stronger opinion, for or against, than me.
Coming up with small concise wording for these type of issues is always
difficult. I don't have a problem with yours, but how about..
* p Note that you cannot assume a successful invocation of
* {@code ensureCapacity} will guarantee the capacity will always
* be at least the size of {@code minimumCapacity}. The capacity
* may change due to subsequent operations, for example {@linkplain
* #timeToSize}
-Chris.
On 18/09/12 19:25, Jim Gish wrote:
Please review this minor usage note change for Bug 4722265:
diff -r 8a454e92aaf1 src/share/classes/java/lang/AbstractStringBuilder.java
--- a/src/share/classes/java/lang/AbstractStringBuilder.javaMon Sep
17 12:40:33 2012 +0200
+++ b/src/share/classes/java/lang/AbstractStringBuilder.javaTue Sep
18 13:46:34 2012 -0400
@@ -96,6 +96,9 @@
* /ul
* If the {@code minimumCapacity} argument is nonpositive, this
* method takes no action and simply returns.
+ * Note that a call to ensureCapacity does not guarantee an immutable
+ * setting of the minimum desired capacity. The capacity may
change as
+ * the result of subsequent operations.
*
* @param minimumCapacity the minimum desired capacity.
*/
Thanks,
Jim
hg: jdk8/tl/jdk: 7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler
Changeset: db381a2c0083 Author:alanb Date: 2012-09-18 21:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db381a2c0083 7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java
Re: Please Review : Javadoc - docencoding not available to stylesheet post 7006270
Hi Alan, True , but I am not seeing any mail conversations there,while I have posted there as well :-) Any suggestions would really help . Thanks a lot your quick response ! Regards, Jayashree Viswanathan On 13-09-2012 2:58 PM, Alan Bateman wrote: On 13/09/2012 10:05, jayashree viswanathan wrote: Hi all , Looking for a reviewer for a change request . This change is in Javadoc tool , which doesn't seems to take up value of the docencoding getting passed unlike the other generated HTML files . webrev is available at http://cr.openjdk.java.net/~luchsh/7006270/ Recreation steps and rest of the details at the bottom of the mail thread. I assume the mailing list you are looking for is javadoc-dev. -Alan.
Please Review : Javadoc - docencoding not available to stylesheet post 7006270
Hi all , Looking for a reviewer for a change request . This change is in Javadoc tool , which doesn't seems to take up value of the docencoding getting passed unlike the other generated HTML files . webrev is available at http://cr.openjdk.java.net/~luchsh/7006270/ Recreation steps and rest of the details at the bottom of the mail thread. Thanks Jonathan for helping . Thanks and Regards, Jayashree Viswanathan On 11-09-2012 12:49 PM, Jonathan Lu wrote: Hello Jayashree, The patch looks good to me. but I saw some extra tab characters from your patch, could you please reformat it according to the code convention from following link? it will help others to better understand it. http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html Thanks, Jonathan On 09/04/2012 02:59 PM, jayashree viswanathan wrote: Hi, Please let me know if any one is interested in having a look at this patch . Thanks and Regards, Jayashree V On 31-08-2012 3:20 PM, jayashree viswanathan wrote: *Problem statement : *Stylesheet.css is not getting encoded like the other generated html files while using -docencoding *Recreation step : * javadoc -docencoding use non-ascii encoding HelloWorld.java say , jdk1.8.0\bin\javadoc.exe -docencoding Cp930 -d docencoding3 HelloWorld.java *Explanation :* The stylesheet.css is not getting generated in the proper encoding as in the code the configuration.docencoding is not getting passed to the output stream . while this scenario works in JDK 6 [as confirmed in Java 6u14] , below changeset seems to have regressed this when adding new copyFile method. Changeset: 792 (ffbf2b2a8611) 7006270: Several javadoc regression tests are failing on windows Please find the webrev patch with changes and jtreg test . http://cr.openjdk.java.net/~luchsh/ojdk-660/ Thanks and Regards, Jayashree V
hg: jdk8/tl/jdk: 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip
Changeset: e143d8f8e477 Author:dxu Date: 2012-09-18 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e143d8f8e477 7195933: There is incorrect link to Info-ZIP Application Note 970311 in doc page of Package java.util.zip Summary: Correct a java doc link in java.util.zip package page Reviewed-by: chegar, lancea, sherman Contributed-by: dan...@oracle.com ! src/share/classes/java/util/zip/package.html
hg: jdk8/tl/jdk: 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties
Changeset: 045a0962b430 Author:mchung Date: 2012-09-18 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/045a0962b430 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties Reviewed-by: alanb ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java
Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable
I also think this is a non-issue - particularly from a report 10 years
ago. I wouldn't waste time on it. You can't document every nuance of
every method when used in conjunction with other methods.
If you feel the need to complete this now then the shorter the better:
Note that subsequent operations on this StringBuffer can reduce the
actual capacity below that requested here.
David
On 19/09/2012 6:20 AM, Chris Hegarty wrote:
Jim,
I'm not all that sure that this is really such an issue. The methods
that can reduce the capacity seem to be clearly specified. But others
may have a stronger opinion, for or against, than me.
Coming up with small concise wording for these type of issues is always
difficult. I don't have a problem with yours, but how about..
* p Note that you cannot assume a successful invocation of
* {@code ensureCapacity} will guarantee the capacity will always
* be at least the size of {@code minimumCapacity}. The capacity
* may change due to subsequent operations, for example {@linkplain
* #timeToSize}
-Chris.
On 18/09/12 19:25, Jim Gish wrote:
Please review this minor usage note change for Bug 4722265:
diff -r 8a454e92aaf1
src/share/classes/java/lang/AbstractStringBuilder.java
--- a/src/share/classes/java/lang/AbstractStringBuilder.java Mon Sep
17 12:40:33 2012 +0200
+++ b/src/share/classes/java/lang/AbstractStringBuilder.java Tue Sep
18 13:46:34 2012 -0400
@@ -96,6 +96,9 @@
* /ul
* If the {@code minimumCapacity} argument is nonpositive, this
* method takes no action and simply returns.
+ * Note that a call to ensureCapacity does not guarantee an immutable
+ * setting of the minimum desired capacity. The capacity may
change as
+ * the result of subsequent operations.
*
* @param minimumCapacity the minimum desired capacity.
*/
Thanks,
Jim
