hg: jdk8/tl/jdk: 8001569: Regression test GetPeerHost uses static port number
Changeset: 9edfa0e761b9 Author:xuelei Date: 2012-11-09 01:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9edfa0e761b9 8001569: Regression test GetPeerHost uses static port number Reviewed-by: weijun ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/GetPeerHost.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/GetPeerHostClient.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/GetPeerHostServer.java
Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract
Sean, Thank you for adding a test. Rather than creating a dependency on rt.jar it may be best to have the test use the java.util.jar API to create a small temporary jar file. The problem with the dependency on rt.jar is that the test will fail if run against a development build where the images have not been created ( run against an exploded classes directory ). -Chris. On 09/11/2012 04:31, Sean Chou wrote: Hello Chris, Alan, and Xueming, I added the testcase, please take a look. webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.01/ On Wed, Nov 7, 2012 at 6:16 PM, Chris Hegarty chris.hega...@oracle.com mailto:chris.hega...@oracle.com wrote: The change looks fine to me. I wonder if it is worth creating an automatic regression test to verify this change ( so an future regression in behavior gets caught early ). You could call sun.tools.jar.Main directly passing suitable streams to check the output. -Chris. On 07/11/2012 08:31, Sean Chou wrote: Hello, This is the suggested fix described in sun bug 7201156 page. Please take a look. sunbug: http://bugs.sun.com/__bugdatabase/view_bug.do?bug___id=7201156 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7201156 webrev: http://cr.openjdk.java.net/~__zhouyx/7201156/webrev.00/ http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/ -- Best Regards, Sean Chou
Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData
Frank, If you can please post the bug info here, I will take a look at your patch Best Lance On Nov 8, 2012, at 10:01 PM, Frank Ding wrote: Hi guys, We discovered a bug in CachedRowSetWriter.writeData method where incorrect number of conflicts is reported. I searched in Oracle bug database and no similar record was found. So I submitted a new one whose internal review ID is 2376620. A test case with code is illustrated in the bug submission that leverages PostgreSQL server but the issue is platform independent and easy to reproduce. I provided a patch review, available @ http://cr.openjdk.java.net/~dingxmin/2376620/webrev.01/ Is there anybody who is interested in patch and can also review bug 2376620? Your reply is appreciated. Best regards, Frank Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract
On 09/11/2012 04:31, Sean Chou wrote: Hello Chris, Alan, and Xueming, I added the testcase, please take a look. webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.01/ Thanks for adding a test, I agree with Chris that it would be great if the test didn't use rt.jar. As Chris mentions, rt.jar is only created for images builds and most of it working on the JDK doesn't bother with images. Also rt.jar will go away once we move to modules. One other comment on the test is that it only exercises the t option, I think the issue that is being fixed also impacts the extract (x) option. -Alan
RFR: 6244047: impossible to specify directories to logging FileHandler unless they exist
Please review http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/ http://cr.openjdk.java.net/%7Ejgish/Bug6244047-FileHandler-CheckLockLocation/ This updates the logging FileHandler to actually check the directory passed to it via the pattern to ensure that it exists and is writable. It does this before going into the loop to create lock files there which will fail repeatedly if the directory specified is invalid. If the file specified does not exist, or is not a directory or not writable, an IOException with a precise message is thrown. Note that this fix does not do as some users would like, which is to go ahead and create directories that don't exist. Thanks, Jim -- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.g...@oracle.com
RE: RFR: 6244047: impossible to specify directories to logging FileHandler unless they exist
Jim, You might just want to change the code to create and close a FileOutputStream in a way that doesn't truncate or damage the target file. Or maybe use the NIO file code if that is possible. See BUG ID 4420020. Jason Date: Fri, 9 Nov 2012 16:37:02 -0500 From: jim.g...@oracle.com To: core-libs-dev@openjdk.java.net Subject: RFR: 6244047: impossible to specify directories to logging FileHandler unless they exist Please review http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/ http://cr.openjdk.java.net/%7Ejgish/Bug6244047-FileHandler-CheckLockLocation/ This updates the logging FileHandler to actually check the directory passed to it via the pattern to ensure that it exists and is writable. It does this before going into the loop to create lock files there which will fail repeatedly if the directory specified is invalid. If the file specified does not exist, or is not a directory or not writable, an IOException with a precise message is thrown. Note that this fix does not do as some users would like, which is to go ahead and create directories that don't exist. Thanks, Jim -- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.g...@oracle.com
