Re: JDK 8 RFR, redux, for JDK-8005294 : Consider default methods for additions to AnnotatedElement
Hi Peter,
On 10/28/2013 07:24 AM, Peter Levart wrote:
On 10/28/2013 06:59 AM, Joe Darcy wrote:
Hello Joel and Peter,
Working in previous feedback, please review the revised code changes for
JDK-8005294 : Consider default methods for additions to
AnnotatedElement
http://cr.openjdk.java.net/~darcy/8005294.4/
I think the versions of getAnnotationsByType and
getDeclaredAnnotation in this patch are solid, but
getDeclaredAnnotationsByType may require some more refinement. (The
asserts in getDeclaredAnnotationsByType are commented out since I was
getting a bad build as a result; I'm following up with the HotSpot
team.)
Hi Joe,
After un-comenting asserts, the one in line 404...
if (indirectlyPresent == null || indirectlyPresent.length
== 0) {
...
} else {
// assert indirectlyPresent != null
&& indirectlyPresent.length > 0;
if (resultSize == indirectlyPresent.length){
404: // assert *resultSize == 0
||* directlyPresent == null;
...should be changed to: "assert directlyPresent == null" since
resultSize (== indirectlyPresent.length) is always > 0 in this line...
Right; the old assert was a hold-over from a previous version of the code.
Then perhaps a small optimization in loop at line 416 to avoid calling
annotationType() (a Proxy method) twice:
416: for (Annotation a : getDeclaredAnnotations()) {
*Class aType = a.annotationType();*
if (*aType*.equals(annotationClass)) {
indirectOffset = 1;
break;
} else if (*aType*.equals(containerType)) {
break;
}
}
Good suggestion.
The test looks fine. I just wonder whether you intended to uncomment
or to remove the following lines of AnnotatedElementDelegate:
228 // // FIXME -- adjust once build / vm problems resolved
229 // @Override
230 // public T[]
getDeclaredAnnotationsByType(Class annotationClass) {
231 // return base.getDeclaredAnnotationsByType(annotationClass);
232 // }
...since by un-commenting you would defeat the purpose of testing the
default method.
They should be deleted; I had that code live before I determined the
asserts were causing the build woes.
Maybe also add the following two annotations:
@AssociatedDirectOnSuperclassIndirectOnSubclass
@AssociatedIndirectOnSuperclassDirectOnSubclass
Done.
Your comments, along with some spec refinements from the other OpenJDK
list, are reflected in the next iteration of the webrev:
http://cr.openjdk.java.net/~darcy/8005294.5/
Thanks,
-Joe
hg: jdk8/tl: 17 new changesets
Changeset: 22c6f0b7e2b5 Author:dcubed Date: 2013-10-15 08:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/22c6f0b7e2b5 7165611: implement Full Debug Symbols on MacOS X hotspot Summary: Add MacOS X FDS support to hotspot; add minimal MacOS X FDS import support to jdk; add MacOS X FDS support to install; add MacOS X FDS support to root. Reviewed-by: erikj, sla, dholmes, rdurbin, tbell, ihse ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/NativeCompilation.gmk Changeset: ac09e62d5e6b Author:amurillo Date: 2013-10-19 08:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ac09e62d5e6b Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/makefiles/NativeCompilation.gmk Changeset: 9d5284dfc00d Author:amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9d5284dfc00d Merge Changeset: 5b4f14990dd1 Author:ihse Date: 2013-10-18 10:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/5b4f14990dd1 8001912: Improve detection of msvcr100.dll Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 Changeset: 65c1752b4c38 Author:katleman Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/65c1752b4c38 Merge Changeset: 17d195bd56fc Author:erikj Date: 2013-10-18 11:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/17d195bd56fc 8025869: make docs doesn't regenerate docs correctly after changing API doc comments in jaxp sources Reviewed-by: ihse, tbell ! common/makefiles/JavaCompilation.gmk Changeset: e27dda53d4f5 Author:erikj Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e27dda53d4f5 Merge Changeset: 1a853fac18ff Author:erikj Date: 2013-10-21 11:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1a853fac18ff 8026528: [build] configure does not recognize newer make in cygwin Reviewed-by: tbell, ksrini, ihse ! NewMakefile.gmk ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh Changeset: dffe654ab24c Author:ihse Date: 2013-10-22 11:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dffe654ab24c 8001925: Add useful help messages if freetype is not found on Windows Reviewed-by: erikj, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 Changeset: 56db38956113 Author:ihse Date: 2013-10-22 12:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/56db38956113 8026864: Deprecate --disable-macosx-runtime-support. Reviewed-by: erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 9e177e7fc438 Author:katleman Date: 2013-10-22 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/9e177e7fc438 Merge ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/makefiles/JavaCompilation.gmk Changeset: 4293401d683b Author:katleman Date: 2013-10-22 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4293401d683b 8027068: Update to NewMakefile.gmk check of MAKE_VERSION broke jdk8-build nightly builds on windows, saying 3.82.90 is too low Reviewed-by: ihse, tbell, wetmore ! NewMakefile.gmk Changeset: 269497597620 Author:tbell Date: 2013-10-22 16:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/269497597620 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 2cc1a52d37ef Author:tbell Date: 2013-10-22 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2cc1a52d37ef Merge Changeset: 6f19b2440412 Author:ihse Date: 2013-10-23 13:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6f19b2440412 8001922: Improve freetype handling. Reviewed-by: erikj ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/libraries.m4 ! common/autoconf/spec.gmk.in Changeset: 6ba4c7cb623e Author:erikj Date: 2013-10-23 17:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/6ba4c7cb623e 8026888: Licensee build failure due to wrong libs being called Reviewed-by: tbell, ihse, simonis ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: a36df87b3901 Author:cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a36df87b3901 Added tag jdk8-b113 for changeset 6ba4c7cb623e ! .hgtags
Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing
Looks good as a temporary solution. Thanks, Masayoshi On 10/24/2013 11:47 PM, Michael Fang wrote: Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch located here: http://cr.openjdk.java.net/~aefimov/8026772/8026772_jdk8.patch. Thank you, Aleksej On 10/24/2013 04:27 PM, Aleksej Efimov wrote: Alan, I have added this test to ProblemList.txt and keep the test update: http://cr.openjdk.java.net/~aefimov/8026772/webrev.01/. I suppose, with such resolution we can safely close this minor bug. And we will decide this test destiny in 8025051. Thanks, Aleksej On 10/24/2013 04:00 PM, Alan Bateman wrote: On 24/10/2013 10:05, Aleksej Efimov wrote: Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questionable test, but add some replacement for it. It is possible to exclude the test (by adding it to jdk/test/ProblemList.txt) while you resolve this? At it stands then it's pointless running it. -Alan.
hg: jdk8/tl/jdk: 17 new changesets
Changeset: 01b81253f2d5 Author:dcubed Date: 2013-10-15 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/01b81253f2d5 7165611: implement Full Debug Symbols on MacOS X hotspot Summary: Add MacOS X FDS support to hotspot; add minimal MacOS X FDS import support to jdk; add MacOS X FDS support to install; add MacOS X FDS support to root. Reviewed-by: erikj, sla, dholmes, rdurbin, tbell, ihse ! make/common/Defs-macosx.gmk ! make/common/Defs.gmk ! make/java/redist/Makefile ! makefiles/Import.gmk ! makefiles/Tools.gmk Changeset: 969e8c6c26cc Author:amurillo Date: 2013-10-19 08:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/969e8c6c26cc Merge ! makefiles/Import.gmk ! makefiles/Tools.gmk Changeset: c4ab67d1e0ce Author:amurillo Date: 2013-10-22 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4ab67d1e0ce Merge ! makefiles/Tools.gmk Changeset: a5b57fca66da Author:ihse Date: 2013-10-16 20:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5b57fca66da 8025715: Split CompileNativeLibraries.gmk Reviewed-by: erikj ! makefiles/CompileNativeLibraries.gmk + makefiles/lib/Awt2dLibraries.gmk + makefiles/lib/CoreLibraries.gmk + makefiles/lib/NetworkingLibraries.gmk + makefiles/lib/NioLibraries.gmk + makefiles/lib/PlatformLibraries.gmk + makefiles/lib/SecurityLibraries.gmk + makefiles/lib/ServiceabilityLibraries.gmk + makefiles/lib/SoundLibraries.gmk Changeset: 1e99d539088d Author:katleman Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e99d539088d Merge Changeset: 7ec4ddc36ad6 Author:erikj Date: 2013-10-17 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ec4ddc36ad6 8019540: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated. Reviewed-by: dholmes, sla ! makefiles/CopyIntoClasses.gmk Changeset: 11e90e4167d4 Author:erikj Date: 2013-10-21 10:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11e90e4167d4 Merge Changeset: 3a6ac3484b05 Author:cl Date: 2013-10-21 23:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a6ac3484b05 8026974: solaris build missing java-rmi.cgi Reviewed-by: ksrini ! makefiles/CompileLaunchers.gmk Changeset: b121e84392fa Author:erikj Date: 2013-10-22 11:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b121e84392fa 8026966: Most native libs broken on mac in jdk8/build Reviewed-by: ihse, anthony ! makefiles/lib/PlatformLibraries.gmk Changeset: 9850efaedc50 Author:katleman Date: 2013-10-22 16:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9850efaedc50 Merge ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk + makefiles/lib/Awt2dLibraries.gmk + makefiles/lib/CoreLibraries.gmk + makefiles/lib/NetworkingLibraries.gmk + makefiles/lib/NioLibraries.gmk + makefiles/lib/PlatformLibraries.gmk + makefiles/lib/SecurityLibraries.gmk + makefiles/lib/ServiceabilityLibraries.gmk + makefiles/lib/SoundLibraries.gmk Changeset: 698937f18761 Author:tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/698937f18761 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties ! makefiles/jprt.properties Changeset: 81431a7c17cf Author:tbell Date: 2013-10-22 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81431a7c17cf Merge - make/sun/awt/FILES_c_macosx.gmk - make/sun/awt/FILES_export_macosx.gmk - src/macosx/classes/com/apple/resources/MacOSXResourceBundle.java - src/macosx/native/com/apple/resources/MacOSXResourceBundle.m - src/share/classes/com/sun/jdi/connect/package.html - src/share/classes/com/sun/jdi/connect/spi/package.html - src/share/classes/com/sun/jdi/event/package.html - src/share/classes/com/sun/jdi/package.html - src/share/classes/com/sun/jdi/request/package.html - src/share/classes/com/sun/management/package.html - src/share/classes/com/sun/tools/attach/package.html - src/share/classes/com/sun/tools/attach/spi/package.html - src/share/classes/com/sun/tools/jconsole/package.html - src/share/classes/java/net/HttpURLPermission.java - test/com/oracle/security/ucrypto/TestAES.java - test/com/oracle/security/ucrypto/TestDigest.java - test/com/oracle/security/ucrypto/TestRSA.java - test/com/oracle/security/ucrypto/UcryptoTest.java - test/java/net/HttpURLPermission/HttpURLPermissionTest.java - test/java/net/HttpURLPermission/URLTest.java - test/java/net/HttpURLPermission/policy.1 - test/java/net/HttpURLPermission/policy.2 - test/java/net/HttpURLPermission/policy.3 Changeset: aabaae5de1ee Author:ihse Date: 2013-10-23 13:06 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aabaae5de1ee 8001922: Improve freetype handling. Reviewed-by: erikj ! makefiles/CopyFiles.gmk ! makefiles/lib/Awt2dLibraries.gmk Changeset: ab0e61a57df7 Author:chegar D
hg: jdk8/tl/hotspot: 70 new changesets
Changeset: 7c26dced065e
Author:amurillo
Date: 2013-10-11 13:14 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c26dced065e
8026265: new hotspot build - hs25-b55
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: b4a4fdc1f464
Author:coleenp
Date: 2013-10-09 21:45 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4a4fdc1f464
8025185: MethodHandleInError and MethodTypeInError not handled in
ConstantPool::compare_entry_to and copy_entry_to
Summary: Add missing cases.
Reviewed-by: sspitsyn, dcubed
! src/share/vm/oops/constantPool.cpp
Changeset: e831448418ac
Author:coleenp
Date: 2013-10-09 22:01 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e831448418ac
Merge
Changeset: cd7ea1d79dac
Author:sla
Date: 2013-10-11 13:48 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cd7ea1d79dac
8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation
failed
Summary: Fixed a compilation failure due to changed method name
Reviewed-by: sla, jbachorik
Contributed-by: fredrik.arvids...@oracle.com
! test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
! test/testlibrary/com/oracle/java/testlibrary/JDKToolLauncher.java
Changeset: 539144972c1e
Author:sla
Date: 2013-10-11 14:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/539144972c1e
8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump
Summary: Switched from using SystemDictionary to using ClassLoaderDataGraph to
get the anonymous classes included.
Reviewed-by: sla, sspitsyn
Contributed-by: fredrik.arvids...@oracle.com
! src/share/vm/services/heapDumper.cpp
Changeset: 301ece1880ad
Author:sla
Date: 2013-10-11 14:57 +
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/301ece1880ad
Merge
Changeset: 28ca974cc21a
Author:coleenp
Date: 2013-10-11 11:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28ca974cc21a
8022592: assert at constantTag.cpp:57: ShouldNotReachHere()
Summary: more missing cases for JVM_CONSTANT_Method{Handle,Type}InError
Reviewed-by: hseigel, dcubed
! src/share/vm/oops/constantPool.cpp
! src/share/vm/utilities/constantTag.cpp
! src/share/vm/utilities/constantTag.hpp
Changeset: 26ae62bc26c4
Author:coleenp
Date: 2013-10-11 15:04 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26ae62bc26c4
Merge
Changeset: 0db3ba3f6870
Author:hseigel
Date: 2013-10-11 15:33 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0db3ba3f6870
8026041: JVM crashes with assert "assert(is_updated()) failed: must not be
clear" with -XX:+PrintGCApplicationConcurrentTime in -Xcomp mode
Summary: Prior to printing the time interval in
RuntimeService::record_safepoint_begin(), check first that VM initialization is
complete.
Reviewed-by: coleenp, dholmes, sla, ctornqvi
Contributed-by: lois.fol...@oracle.com
! src/share/vm/services/runtimeService.cpp
Changeset: df268195b0ea
Author:hseigel
Date: 2013-10-11 17:08 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df268195b0ea
Merge
Changeset: 41459da469ae
Author:ccheung
Date: 2013-10-11 18:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/41459da469ae
Merge
Changeset: 83dbf427fedd
Author:ccheung
Date: 2013-10-11 22:22 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/83dbf427fedd
Merge
Changeset: 3e265ce4d2dd
Author:hseigel
Date: 2013-10-12 13:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3e265ce4d2dd
8025942: os::Bsd::available_memory() needs implementation
Summary: Implement using the host_statistics64() api.
Reviewed-by: dsamersoff, morris, dholmes, coleenp, hseigel, dcubed
Contributed-by: gerard.ziem...@oracle.com
! src/os/bsd/vm/os_bsd.cpp
Changeset: d37a0525c0fe
Author:hseigel
Date: 2013-10-12 15:39 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d37a0525c0fe
8024667: VM crashes with "assert(method() != NULL) failed: must have set method"
Summary: Check if data is in shared spaces before deallocating it.
Reviewed-by: coleenp, dcubed
! src/share/vm/memory/metadataFactory.hpp
! src/share/vm/oops/instanceKlass.cpp
Changeset: 2f8728d92483
Author:acorn
Date: 2013-10-14 21:52 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2f8728d92483
8026299: invokespecial gets ICCE when it should get AME.
Reviewed-by: ccheung, coleenp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/vm/interpreter/linkResolver.hpp
Changeset: f509b8f4699b
Author:dcubed
Date: 2013-10-15 08:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f509b8f4699b
7165611: implement Full Debug Symbols on MacOS X hotspot
Summary: Add MacOS X FDS support to hotspot; add minimal MacOS X FDS import
support to jdk; add MacOS X FDS support to install; add MacOS X FDS support to
root.
Reviewed-by: erikj, sla, dholm
hg: jdk8/tl/jaxws: 4 new changesets
Changeset: 17f1b13cd401 Author:simonis Date: 2013-10-21 15:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/17f1b13cd401 8026874: During JAXWS build the newly built JAXP classes should be in the bootclasspath (not only in the classpath) Reviewed-by: erikj ! makefiles/BuildJaxws.gmk Changeset: f20820d1582f Author:katleman Date: 2013-10-22 16:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f20820d1582f Merge Changeset: 9261f342aa73 Author:tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9261f342aa73 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 9ad289610fc6 Author:cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9ad289610fc6 Added tag jdk8-b113 for changeset 9261f342aa73 ! .hgtags
hg: jdk8/tl/langtools: 4 new changesets
Changeset: 127c2e74d2cf Author:tbell Date: 2013-10-22 16:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/127c2e74d2cf 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 54150586ba78 Author:katleman Date: 2013-10-23 08:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/54150586ba78 Merge Changeset: 850d2602ae98 Author:cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/850d2602ae98 Added tag jdk8-b113 for changeset 54150586ba78 ! .hgtags Changeset: 44e3ba40e00c Author:lana Date: 2013-10-28 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e3ba40e00c Merge
hg: jdk8/tl/jaxp: 3 new changesets
Changeset: 0046d2278204 Author:tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/0046d2278204 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 1b1e12117fe2 Author:cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1b1e12117fe2 Added tag jdk8-b113 for changeset 0046d2278204 ! .hgtags Changeset: 96562bf197f2 Author:lana Date: 2013-10-28 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/96562bf197f2 Merge
hg: jdk8/tl/corba: 3 new changesets
Changeset: a259ff3e42d9 Author:tbell Date: 2013-10-22 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a259ff3e42d9 8027039: [jprt] Remove 32-bit Solaris from jprt.properties files Reviewed-by: mduigou, mchung ! make/jprt.properties Changeset: 0bbccf77c23e Author:cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0bbccf77c23e Added tag jdk8-b113 for changeset a259ff3e42d9 ! .hgtags Changeset: 219e616a6a4f Author:lana Date: 2013-10-28 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/219e616a6a4f Merge
hg: jdk8/tl/nashorn: 2 new changesets
Changeset: 79f7b79bf97b Author:cl Date: 2013-10-24 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/79f7b79bf97b Added tag jdk8-b113 for changeset 676cd7bf5e09 ! .hgtags Changeset: 767e85d2a1b3 Author:lana Date: 2013-10-28 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/767e85d2a1b3 Merge
hg: jdk8/tl/jdk: 8026863: regression in anonymous Logger.setParent method
Changeset: af4dd45bc7f7 Author:dfuchs Date: 2013-10-28 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af4dd45bc7f7 8026863: regression in anonymous Logger.setParent method Summary: restore behaviour of setParent in anonymous logger and clarifies the spec with respect to security permissions. Reviewed-by: mchung, prr ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/AnonymousLogger/TestAnonymousLogger.java
Re: JDK 8 RFR, redux, for JDK-8005294 : Consider default methods for additions to AnnotatedElement
On 10/28/2013 06:59 AM, Joe Darcy wrote:
Hello Joel and Peter,
Working in previous feedback, please review the revised code changes for
JDK-8005294 : Consider default methods for additions to
AnnotatedElement
http://cr.openjdk.java.net/~darcy/8005294.4/
I think the versions of getAnnotationsByType and getDeclaredAnnotation
in this patch are solid, but getDeclaredAnnotationsByType may require
some more refinement. (The asserts in getDeclaredAnnotationsByType are
commented out since I was getting a bad build as a result; I'm
following up with the HotSpot team.)
Hi Joe,
After un-comenting asserts, the one in line 404...
if (indirectlyPresent == null || indirectlyPresent.length
== 0) {
...
} else {
// assert indirectlyPresent != null &&
indirectlyPresent.length > 0;
if (resultSize == indirectlyPresent.length){
404: // assert *resultSize == 0 ||*
directlyPresent == null;
...should be changed to: "assert directlyPresent == null" since
resultSize (== indirectlyPresent.length) is always > 0 in this line...
Then perhaps a small optimization in loop at line 416 to avoid calling
annotationType() (a Proxy method) twice:
416: for (Annotation a : getDeclaredAnnotations()) {
*Class aType = a.annotationType();*
if (*aType*.equals(annotationClass)) {
indirectOffset = 1;
break;
} else if (*aType*.equals(containerType)) {
break;
}
}
The test looks fine. I just wonder whether you intended to uncomment or
to remove the following lines of AnnotatedElementDelegate:
228 // // FIXME -- adjust once build / vm problems resolved
229 // @Override
230 // public T[]
getDeclaredAnnotationsByType(Class annotationClass) {
231 // return base.getDeclaredAnnotationsByType(annotationClass);
232 // }
...since by un-commenting you would defeat the purpose of testing the
default method.
Maybe also add the following two annotations:
@AssociatedDirectOnSuperclassIndirectOnSubclass
@AssociatedIndirectOnSuperclassDirectOnSubclass
Regards, Peter
Also new in this version, the test program fleshed out.
Thank,
-Joe
Re: RFR [8024521] (process) Async close issues with Process InputStream
On 25/10/2013 16:59, Martin Buchholz wrote: After rebasing, I propose this change which is shorter and is more obviously correct. I agree, this is simpler (more obvious) so it is a good clean-up. One additional thing may be to add a comment to explain why processExited is synchronized (or alternatively move the synchronization to drainInputStream where it is required to ensure that other threads don't read anything between available and read). -Alan
