Re: [9] 8149571: [launcher] create a regression test to test symlinks on Windows

2016-04-21 Thread Kumar Srinivasan 





On 21/04/2016 16:12, Kumar Srinivasan wrote:


As Alan says, we can't run this test in an automated fashion,
we have to make this a manual test.
I would expect that the tests are run with admin privileges on some 
systems so the test could just silently pass when it can't create the 
sym link. That might be preferable to a manual tests that is run rarely.


I think we should have two flavors. A manual one which is stringent, forcing
to tester to run with elevated privileges if necessary, and the other 
which passes

if link  cannot be created. Amy did something similar with a pack200 test.

Kumar



-Alan

Re: [9] 8149571: [launcher] create a regression test to test symlinks on Windows

2016-04-21 Thread Alan Bateman 



On 21/04/2016 16:12, Kumar Srinivasan wrote:


As Alan says, we can't run this test in an automated fashion,
we have to make this a manual test.
I would expect that the tests are run with admin privileges on some 
systems so the test could just silently pass when it can't create the 
sym link. That might be preferable to a manual tests that is run rarely.


-Alan

Re: [9] 8149571: [launcher] create a regression test to test symlinks on Windows

2016-04-21 Thread Kumar Srinivasan 


As Alan says, we can't run this test in an automated fashion,
we have to make this a manual test.

Kumar


21.04.2016 9:12, Alan Bateman пишет:



On 20/04/2016 23:58, Oleg G. Barbashov wrote:

Hi,

Please review the simple test of launcher started using a symlink.

issue: https://bugs.openjdk.java.net/browse/JDK-8149571
webrev: http://cr.openjdk.java.net/~ogb/8149571/
Creating sym link on Windows requires permissions so I assume this 
test just pass when createSymbolicLInk fails (no guarantee that the 
test is run with Administrator rights for example).


-Alan


In case of weak privilege level (UAC is on, etc.) it fails with 
"java.nio.file.FileSystemException: A required privilege is not held 
by the client" (0x80070522).
We can re-throw the exception with additional comments about 
UAC/privileges or create the manual test with appropriate instructions 
about changing the security policy or disabling UAC.


-Oleg

Re: [9] 8149571: [launcher] create a regression test to test symlinks on Windows

2016-04-21 Thread Oleg G. Barbashov 

21.04.2016 9:12, Alan Bateman пишет:



On 20/04/2016 23:58, Oleg G. Barbashov wrote:

Hi,

Please review the simple test of launcher started using a symlink.

issue: https://bugs.openjdk.java.net/browse/JDK-8149571
webrev: http://cr.openjdk.java.net/~ogb/8149571/
Creating sym link on Windows requires permissions so I assume this 
test just pass when createSymbolicLInk fails (no guarantee that the 
test is run with Administrator rights for example).


-Alan


In case of weak privilege level (UAC is on, etc.) it fails with 
"java.nio.file.FileSystemException: A required privilege is not held by 
the client" (0x80070522).
We can re-throw the exception with additional comments about 
UAC/privileges or create the manual test with appropriate instructions 
about changing the security policy or disabling UAC.


-Oleg

Re: [9] 8149571: [launcher] create a regression test to test symlinks on Windows

2016-04-20 Thread Alan Bateman 



On 20/04/2016 23:58, Oleg G. Barbashov wrote:

Hi,

Please review the simple test of launcher started using a symlink.

issue: https://bugs.openjdk.java.net/browse/JDK-8149571
webrev: http://cr.openjdk.java.net/~ogb/8149571/
Creating sym link on Windows requires permissions so I assume this test 
just pass when createSymbolicLInk fails (no guarantee that the test is 
run with Administrator rights for example).


-Alan

Re: [9] 8149571: [launcher] create a regression test to test symlinks on Windows

2016-04-20 Thread Oleg G. Barbashov 

Hi,

Please review the simple test of launcher started using a symlink.

issue: https://bugs.openjdk.java.net/browse/JDK-8149571
webrev: http://cr.openjdk.java.net/~ogb/8149571/

Thanks,
Oleg