Re: [jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon" [v2]

2021-06-22 Thread Alexey Semenyuk 
On Tue, 22 Jun 2021 12:34:04 GMT, Andy Herrick  wrote:

>> …t.java failed "AssertionError: Failed: Check icon"
>
> Andy Herrick has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java 
> failed "AssertionError: Failed: Check icon"

Marked as reviewed by asemenyuk (Reviewer).

-

PR: https://git.openjdk.java.net/jdk17/pull/111

Re: [jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon" [v2]

2021-06-22 Thread Andy Herrick 
On Mon, 21 Jun 2021 22:56:32 GMT, Andy Herrick  wrote:

>> test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
>> 
>>> 73: 
>>> 74: // Create another installer with custom icon.
>>> 75: long size3 = createInstaller(customIcon, "WithCustom3Icon");
>> 
>> The test should produce WinInstallerIconTest-1.0.exe artifact referenced in 
>> SQE test spec. But this patch will not produce it. It will produce 
>> WinInstallerIconTestWithDefaultIcon-1.0.exe, 
>> WinInstallerIconTestWithCustom2Icon-1.0.exe and 
>> WinInstallerIconTestWithCustom3Icon-1.0.exe artifacts and all of them will 
>> be deleted.
>
> yes - I was changing the names to be the same length in attempt to create 
> repeatable exe size - but that doesn't matter, so will restore the suffix's 
> to what they were so WinInstallerIconTest-1.0.exe  will be left for 
> JPKG001-024 in Test Spec.

done - name change and test reverted so remaining artifact is 
WinInstallerIconTest-1.0.exe (and it contains the custom icon)

-

PR: https://git.openjdk.java.net/jdk17/pull/111

Re: [jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon" [v2]

2021-06-22 Thread Andy Herrick 
> …t.java failed "AssertionError: Failed: Check icon"

Andy Herrick has updated the pull request incrementally with one additional 
commit since the last revision:

  JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java 
failed "AssertionError: Failed: Check icon"

-

Changes:
  - all: https://git.openjdk.java.net/jdk17/pull/111/files
  - new: https://git.openjdk.java.net/jdk17/pull/111/files/cf5b0242..f8714c8a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk17=111=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=111=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk17/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/111/head:pull/111

PR: https://git.openjdk.java.net/jdk17/pull/111

Re: [jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"

2021-06-21 Thread Andy Herrick 
On Mon, 21 Jun 2021 20:42:54 GMT, Alexey Semenyuk  wrote:

>> …t.java failed "AssertionError: Failed: Check icon"
>
> test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
> 
>> 73: 
>> 74: // Create another installer with custom icon.
>> 75: long size3 = createInstaller(customIcon, "WithCustom3Icon");
> 
> The test should produce WinInstallerIconTest-1.0.exe artifact referenced in 
> SQE test spec. But this patch will not produce it. It will produce 
> WinInstallerIconTestWithDefaultIcon-1.0.exe, 
> WinInstallerIconTestWithCustom2Icon-1.0.exe and 
> WinInstallerIconTestWithCustom3Icon-1.0.exe artifacts and all of them will be 
> deleted.

yes - I was changing the names to be the same length in attempt to create 
repeatable exe size - but that doesn't matter, so will restore the suffix's to 
what they were so WinInstallerIconTest-1.0.exe  will be left for JPKG001-024 in 
Test Spec.

-

PR: https://git.openjdk.java.net/jdk17/pull/111

Re: [jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"

2021-06-21 Thread Alexey Semenyuk 
On Mon, 21 Jun 2021 20:21:58 GMT, Andy Herrick  wrote:

> …t.java failed "AssertionError: Failed: Check icon"

Changes requested by asemenyuk (Reviewer).

test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:

> 73: 
> 74: // Create another installer with custom icon.
> 75: long size3 = createInstaller(customIcon, "WithCustom3Icon");

The test should produce WinInstallerIconTest-1.0.exe artifact referenced in SQE 
test spec. But this patch will not produce it. It will produce 
WinInstallerIconTestWithDefaultIcon-1.0.exe, 
WinInstallerIconTestWithCustom2Icon-1.0.exe and 
WinInstallerIconTestWithCustom3Icon-1.0.exe artifacts and all of them will be 
deleted.

test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 114:

> 112: size = installerExePath[0].toFile().length();
> 113: TKit.trace(" installer: " + installerExePath[0] + " - size: 
> " + size);
> 114: if (nameSuffix != "3") {

Value of `nameSuffix` parameter is never equals to "3"

-

PR: https://git.openjdk.java.net/jdk17/pull/111

[jdk17] RFR: JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"

2021-06-21 Thread Andy Herrick 
…t.java failed "AssertionError: Failed: Check icon"

-

Commit messages:
 - JDK-8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java 
failed "AssertionError: Failed: Check icon"

Changes: https://git.openjdk.java.net/jdk17/pull/111/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=111=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268404
  Stats: 79 lines in 2 files changed: 0 ins; 59 del; 20 mod
  Patch: https://git.openjdk.java.net/jdk17/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/111/head:pull/111

PR: https://git.openjdk.java.net/jdk17/pull/111