hg: jdk8/tl/jdk: 8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012

2012-10-26 Thread chris . hegarty 
Changeset: 3fc5457cf779
Author:dl
Date:  2012-10-26 21:34 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779

8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012
Reviewed-by: chegar, dholmes

! src/share/classes/java/util/concurrent/AbstractExecutorService.java
! src/share/classes/java/util/concurrent/BlockingQueue.java
! src/share/classes/java/util/concurrent/BrokenBarrierException.java
! src/share/classes/java/util/concurrent/CompletionService.java
! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java
! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java
! src/share/classes/java/util/concurrent/ConcurrentMap.java
! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java
! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java
! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java
! src/share/classes/java/util/concurrent/CountDownLatch.java
! src/share/classes/java/util/concurrent/CyclicBarrier.java
! src/share/classes/java/util/concurrent/Delayed.java
! src/share/classes/java/util/concurrent/ExecutionException.java
! src/share/classes/java/util/concurrent/Executor.java
! src/share/classes/java/util/concurrent/ExecutorService.java
! src/share/classes/java/util/concurrent/Executors.java
! src/share/classes/java/util/concurrent/Future.java
! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java
! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java
! src/share/classes/java/util/concurrent/LinkedTransferQueue.java
! src/share/classes/java/util/concurrent/RecursiveAction.java
! src/share/classes/java/util/concurrent/RejectedExecutionException.java
! src/share/classes/java/util/concurrent/ScheduledExecutorService.java
! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java
! src/share/classes/java/util/concurrent/Semaphore.java
! src/share/classes/java/util/concurrent/SynchronousQueue.java
! src/share/classes/java/util/concurrent/ThreadFactory.java
! src/share/classes/java/util/concurrent/TimeUnit.java
! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java
! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicLong.java
! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/AtomicReference.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java
! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java
! src/share/classes/java/util/concurrent/atomic/package-info.java
! 
src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java
! src/share/classes/java/util/concurrent/locks/Condition.java
! src/share/classes/java/util/concurrent/locks/Lock.java
! src/share/classes/java/util/concurrent/locks/LockSupport.java
! src/share/classes/java/util/concurrent/locks/ReentrantLock.java
! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java
! src/share/classes/java/util/concurrent/package-info.java

Re: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012

2012-10-26 Thread Chris Hegarty 

Thanks David,

  java.sun.com... D'oh. Updated and pushed. The meat will come shortly!

http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779

-Chris.


On 10/26/2012 03:06 AM, David Holmes wrote:

Hi Chris,

You can count me as a reviewer anyway. :)

A couple of observations:

--- old/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:15 2012
+++ new/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:14 2012
@@ -79,11 +79,9 @@

  /**
   * Constructs an ttExecutionException/tt with the specified
cause.
- * The detail message is set to:
- * pre
- *  (cause == null ? null : cause.toString())/pre
- * (which typically contains the class and detail message of
- * ttcause/tt).
+ * The detail message is set to {@code (cause == null ? null :
+ * cause.toString())} (which typically contains the class and
+ * detail message of ttcause/tt).

The last ttcause/tt should be replaced by {@Code cause}.

There are a couple of places that refer to JLS (eg package-info,
Locks.java)

+ * a href=http://java.sun.com/docs/books/jls/; The Java Language
+ * Specification, Third Edition (17.4 Memory Model)/a:

which should, I believe, be updated to:

http://docs.oracle.com/javase/specs/jls/se7/html/index.html

Thanks,
David

On 26/10/2012 12:13 AM, Chris Hegarty wrote:


In preparation to a re-sync of the java.util.concurrent classes with
Doug's CVS, I've extracted most of the minor/small changes. This will
reduce the noise when reviewing the remainder of the implementation
changes. More specifically,

Cleanup:
javadoc style/consistency
javadoc example code style
imports
whitespace
uniform serialization method javadoc
typos

Minor/small impl changes:
remove redundant null checks
throw NPE when more efficient
rework timeouts, lasttime - deadline
STPE, make drainTo methods more robust when add throws

To be clear, I'm not requested a review here. These are Doug's changes
are I am already a reviewer, but please feel free ( be warned, nothing
interesting here! )

http://cr.openjdk.java.net/~chegar/8001575/webrev.00/webrev/

-Chris.

Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012

2012-10-25 Thread Chris Hegarty 


In preparation to a re-sync of the java.util.concurrent classes with 
Doug's CVS, I've extracted most of the minor/small changes. This will 
reduce the noise when reviewing the remainder of the implementation 
changes. More specifically,


Cleanup:
  javadoc style/consistency
  javadoc example code style
  imports
  whitespace
  uniform serialization method javadoc
  typos

Minor/small impl changes:
  remove redundant null checks
  throw NPE when more efficient
  rework timeouts, lasttime - deadline
  STPE, make drainTo methods more robust when add throws

To be clear, I'm not requested a review here. These are Doug's changes 
are I am already a reviewer, but please feel free ( be warned, nothing 
interesting here! )


http://cr.openjdk.java.net/~chegar/8001575/webrev.00/webrev/

-Chris.

Re: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012

2012-10-25 Thread David Holmes 

Hi Chris,

You can count me as a reviewer anyway. :)

A couple of observations:

--- old/src/share/classes/java/util/concurrent/ExecutionException.java 
Thu Oct 25 14:14:15 2012
+++ new/src/share/classes/java/util/concurrent/ExecutionException.java 
Thu Oct 25 14:14:14 2012

@@ -79,11 +79,9 @@

 /**
  * Constructs an ttExecutionException/tt with the specified cause.
- * The detail message is set to:
- * pre
- *  (cause == null ? null : cause.toString())/pre
- * (which typically contains the class and detail message of
- * ttcause/tt).
+ * The detail message is set to {@code (cause == null ? null :
+ * cause.toString())} (which typically contains the class and
+ * detail message of ttcause/tt).

The last ttcause/tt should be replaced by {@Code cause}.

There are a couple of places that refer to JLS (eg package-info, Locks.java)

+ * a href=http://java.sun.com/docs/books/jls/; The Java Language
+ * Specification, Third Edition (17.4 Memory Model)/a:

which should, I believe, be updated to:

http://docs.oracle.com/javase/specs/jls/se7/html/index.html

Thanks,
David

On 26/10/2012 12:13 AM, Chris Hegarty wrote:


In preparation to a re-sync of the java.util.concurrent classes with
Doug's CVS, I've extracted most of the minor/small changes. This will
reduce the noise when reviewing the remainder of the implementation
changes. More specifically,

Cleanup:
javadoc style/consistency
javadoc example code style
imports
whitespace
uniform serialization method javadoc
typos

Minor/small impl changes:
remove redundant null checks
throw NPE when more efficient
rework timeouts, lasttime - deadline
STPE, make drainTo methods more robust when add throws

To be clear, I'm not requested a review here. These are Doug's changes
are I am already a reviewer, but please feel free ( be warned, nothing
interesting here! )

http://cr.openjdk.java.net/~chegar/8001575/webrev.00/webrev/

-Chris.