Re: RFR: 8252537: Updated @exception with @throws [v4]

[Roger Riggs]

On Sun, 27 Sep 2020 12:46:21 GMT, Vipin Sharma  wrote:

>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks 
>> of JDK-8252536.
>> 
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>> 
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Replaced ... with {@code ...} for modified statement in 
> java.sql

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v4]

[Lance Andersen]

On Sun, 27 Sep 2020 12:46:21 GMT, Vipin Sharma  wrote:

>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks 
>> of JDK-8252536.
>> 
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>> 
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Replaced ... with {@code ...} for modified statement in 
> java.sql

The changes look good.  Thank you for addressing this.

-

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v4]

[Vipin Sharma]

> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of 
> JDK-8252536.
> 
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
> 
> Previous conversation on this:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html

Vipin Sharma has updated the pull request incrementally with one additional 
commit since the last revision:

  Replaced ... with {@code ...} for modified statement in java.sql

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/95/files
  - new: https://git.openjdk.java.net/jdk/pull/95/files/37b69369..b9ed6571

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=95=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=95=02-03

  Stats: 432 lines in 7 files changed: 0 ins; 0 del; 432 mod
  Patch: https://git.openjdk.java.net/jdk/pull/95.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/95/head:pull/95

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v3]

[Lance Andersen]

On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma  wrote:

> > Overall the changes look OK. in the java.sql set of classes, please updated 
> > the modified statements to also use {@code}
> 
> Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a 
> separate bug JDK-8253612 to fix this for all
> java.sql and all other core-libs classes. Following is earlier discussion on 
> this.
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html

Hi Vipin,  I agree overall that to replace all of places in the JDK with 
{@code} where needed should be a separate task
with an umbrella issue with a subtask for each module.   Unless there are a 
large number of other exceptions that are
being modified  and require  updates for {@code} I would prefer to have it done 
as part of this set of changes

-

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v3]

[Vipin Sharma]

On Thu, 24 Sep 2020 17:30:52 GMT, Lance Andersen  wrote:

> Overall the changes look OK. in the java.sql set of classes, please updated 
> the modified statements to also use {@code}

Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a 
separate bug JDK-8253612 to fix this for all
java.sql and all other core-libs classes.  Following is earlier discussion on 
this.
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html

-

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v3]

[Lance Andersen]

On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma  wrote:

>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks 
>> of JDK-8252536.
>> 
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>> 
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now
> contains one commit:
>   JDK-8252537 Updated @exception with @throws, implemented review comments

Overall the changes look OK.  in the java.sql set of classes, please updated 
the modified statements to also use {@code}

src/java.sql/share/classes/java/sql/CallableStatement.java line 131:

> 129:  * a ARRAY, BLOB, CLOB,
> 130:  * DATALINK, JAVA_OBJECT, 
> NCHAR,
> 131:  * NCLOB, NVARCHAR, 
> LONGNVARCHAR,

Please change to use {@code) as part of the update

src/java.sql/share/classes/java/sql/CallableStatement.java line 613:

> 611:  * a ARRAY, BLOB, CLOB,
> 612:  * DATALINK, JAVA_OBJECT, 
> NCHAR,
> 613:  * NCLOB, NVARCHAR, 
> LONGNVARCHAR,

Same comment regarding {@code}

-

Changes requested by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v3]

[Serguei Spitsyn]

On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma  wrote:

>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks 
>> of JDK-8252536.
>> 
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>> 
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now
> contains one commit:
>   JDK-8252537 Updated @exception with @throws, implemented review comments

I've reviewed the management files only. They look good.

-

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v3]

[Vipin Sharma]

> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of 
> JDK-8252536.
> 
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
> 
> Previous conversation on this:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html

Vipin Sharma has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now
contains one commit:

  JDK-8252537 Updated @exception with @throws, implemented review comments

-

Changes: https://git.openjdk.java.net/jdk/pull/95/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=95=02
  Stats: 1690 lines in 86 files changed: 0 ins; 0 del; 1690 mod
  Patch: https://git.openjdk.java.net/jdk/pull/95.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/95/head:pull/95

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v2]

[Vipin Sharma]

On Tue, 15 Sep 2020 19:19:07 GMT, Roger Riggs  wrote:

>> @RogerRiggs I understand your point and will update PR with correct 
>> indentation.
>> But I think adding 3 spaces after throws may not be right for all cases.
>> For example when
>> 1. Another tag in same method is using only 1 space.
>> 2. In some cases (e.g. free method of Blob.java) we had a mix of throws and 
>> exception in the same method both with one
>> space after. Here after adding 3 spaces throws tags will have the different 
>> number of spaces and indentation will not
>> be same as before.  I will update PR to make sure the indentation looks same 
>> as before and there is no change in
>> javadoc. Please tell me in case my understnding is not correct here.
>
> HI Vipin,
> 
> Correct, a better description is "fix the indentation".
> I mnetioned 3 because that was the difference in length between
> "exception" and "throws".
> 
> Thanks for the followup, Roger
> 
> 
> 
> On 9/15/20 3:14 PM, Vipin Sharma wrote:
>>
>> @RogerRiggs
>> 
>> I understand your point and will update PR with correct indentation.
>> But I think adding 3 spaces after throws may not be right for all cases.
>> For example when
>>
>>  1. Another tag in same method is using only 1 space.
>>  2. In some cases (e.g. free method of Blob.java) we had a mix of
>> throws and exception in the same method both with one space after.
>> Here after adding 3 spaces throws tags will have the different
>> number of spaces and indentation will not be same as before.
>>
>> I will update PR to make sure the indentation looks same as before and
>> there is no change in javadoc.
>> Please tell me in case my understnding is not correct here.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> ,
>> or unsubscribe
>> .
>>

There was something wrong with the way I updated this PR, please ignore this. I 
will try to correct this or will close
this PR and create a new one.

-

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws [v2]

[Vipin Sharma]

> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of 
> JDK-8252536.
> 
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
> 
> Previous conversation on this:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html

Vipin Sharma has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request 
contains three additional commits since
the last revision:

 - JDK-8252537 Updated @exception with @throws
 - JDK-8252537 Updated @exception with @throws
 - JDK-8252537 Updated @exception with @throws

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/95/files
  - new: https://git.openjdk.java.net/jdk/pull/95/files/a84158ac..e9953466

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=95=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=95=00-01

  Stats: 20314 lines in 606 files changed: 10333 ins; 7230 del; 2751 mod
  Patch: https://git.openjdk.java.net/jdk/pull/95.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/95/head:pull/95

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws

[Roger Riggs]

On Tue, 15 Sep 2020 19:13:55 GMT, Vipin Sharma  wrote:

>> I've only looked at the management files. They look good in general.
>> 
>> src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java
>> 
>> 108  * @throws  java.lang.SecurityException if a security manager
>> 109  * exists and the caller does not have
>> 110  * ManagementPermission("control").
>> 
>> 
>> src/java.management/share/classes/java/lang/management/MemoryMXBean.java
>> 
>> 286  * @throws  java.lang.SecurityException if a security manager
>> 287  * exists and the caller does not have
>> 288  * ManagementPermission("control").
>> 
>> Could you, please, fix the indentation?
>
> @RogerRiggs I understand your point and will update PR with correct 
> indentation.
> But I think adding 3 spaces after throws may not be right for all cases.
> For example when
> 1. Another tag in same method is using only 1 space.
> 2. In some cases (e.g. free method of Blob.java) we had a mix of throws and 
> exception in the same method both with one
> space after. Here after adding 3 spaces throws tags will have the different 
> number of spaces and indentation will not
> be same as before.  I will update PR to make sure the indentation looks same 
> as before and there is no change in
> javadoc. Please tell me in case my understnding is not correct here.

HI Vipin,

Correct, a better description is "fix the indentation".
I mnetioned 3 because that was the difference in length between
"exception" and "throws".

Thanks for the followup, Roger



On 9/15/20 3:14 PM, Vipin Sharma wrote:
>
> @RogerRiggs
> 
> I understand your point and will update PR with correct indentation.
> But I think adding 3 spaces after throws may not be right for all cases.
> For example when
>
>  1. Another tag in same method is using only 1 space.
>  2. In some cases (e.g. free method of Blob.java) we had a mix of
> throws and exception in the same method both with one space after.
> Here after adding 3 spaces throws tags will have the different
> number of spaces and indentation will not be same as before.
>
> I will update PR to make sure the indentation looks same as before and
> there is no change in javadoc.
> Please tell me in case my understnding is not correct here.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> .
>

-

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws

[Vipin Sharma]

On Tue, 15 Sep 2020 18:14:58 GMT, Serguei Spitsyn  wrote:

>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks 
>> of JDK-8252536.
>> 
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>> 
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> I've only looked at the management files. They look good in general.
> 
> src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java
> 
> 108  * @throws  java.lang.SecurityException if a security manager
> 109  * exists and the caller does not have
> 110  * ManagementPermission("control").
> 
> 
> src/java.management/share/classes/java/lang/management/MemoryMXBean.java
> 
> 286  * @throws  java.lang.SecurityException if a security manager
> 287  * exists and the caller does not have
> 288  * ManagementPermission("control").
> 
> Could you, please, fix the indentation?

@RogerRiggs I understand your point and will update PR with correct indentation.
But I think adding 3 spaces after throws may not be right for all cases.
For example when
1. Another tag in same method is using only 1 space.
2. In some cases (e.g. free method of Blob.java) we had a mix of throws and 
exception in the same method both with one
space after. Here after adding 3 spaces throws tags will have the different 
number of spaces and indentation will not
be same as before.

I will update PR to make sure the indentation looks same as before and there is 
no change in javadoc.
Please tell me in case my understnding is not correct here.

-

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws

[Serguei Spitsyn]

On Wed, 9 Sep 2020 19:29:30 GMT, Vipin Sharma  wrote:

> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of 
> JDK-8252536.
> 
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
> 
> Previous conversation on this:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html

I've only looked at the management files. They look good in general.

src/java.management/share/classes/java/lang/management/ClassLoadingMXBean.java

108  * @throws  java.lang.SecurityException if a security manager
109  * exists and the caller does not have
110  * ManagementPermission("control").


src/java.management/share/classes/java/lang/management/MemoryMXBean.java

286  * @throws  java.lang.SecurityException if a security manager
287  * exists and the caller does not have
288  * ManagementPermission("control").

Could you, please, fix the indentation?

-

Changes requested by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/95

Re: RFR: 8252537: Updated @exception with @throws

[Roger Riggs]

On Wed, 9 Sep 2020 19:29:30 GMT, Vipin Sharma  wrote:

> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of 
> JDK-8252536.
> 
> Open Subtasks part of this fix are:
> 1. JDK-8252537
> 2. JDK-8252539
> 3. JDK-8252540
> 4. JDK-8252541
> 
> Previous conversation on this:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html

Please re-indent the @throws lines to add 3 spaces after so that the comments 
are aligned as they were previously.

-

Changes requested by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/95

RFR: 8252537: Updated @exception with @throws

[Vipin Sharma]

Updated @exception with @throws for core-libs, it fixes all open sub-tasks of 
JDK-8252536.

Open Subtasks part of this fix are:
1. JDK-8252537
2. JDK-8252539
3. JDK-8252540
4. JDK-8252541

-

Commit messages:
 - JDK-8252537 Updated @exception with @throws

Changes: https://git.openjdk.java.net/jdk/pull/95/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=95=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252537
  Stats: 1585 lines in 86 files changed: 0 ins; 0 del; 1585 mod
  Patch: https://git.openjdk.java.net/jdk/pull/95.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/95/head:pull/95

PR: https://git.openjdk.java.net/jdk/pull/95