Re: RFR: 8252537: Updated @exception with @throws [v3]
On Thu, 24 Sep 2020 18:20:15 GMT, Vipin Sharma wrote:
> > Overall the changes look OK. in the java.sql set of classes, please updated
> > the modified statements to also use {@code}
>
> Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
> separate bug JDK-8253612 to fix this for all
> java.sql and all other core-libs classes. Following is earlier discussion on
> this.
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html
Hi Vipin, I agree overall that to replace all of places in the JDK with
{@code} where needed should be a separate task
with an umbrella issue with a subtask for each module. Unless there are a
large number of other exceptions that are
being modified and require updates for {@code} I would prefer to have it done
as part of this set of changes
-
PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR: 8252537: Updated @exception with @throws [v3]
On Thu, 24 Sep 2020 17:30:52 GMT, Lance Andersen wrote:
> Overall the changes look OK. in the java.sql set of classes, please updated
> the modified statements to also use {@code}
Hi @LanceAndersen, it was suggested by @RogerRiggs also. I have created a
separate bug JDK-8253612 to fix this for all
java.sql and all other core-libs classes. Following is earlier discussion on
this.
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068510.html
-
PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR: 8252537: Updated @exception with @throws [v3]
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote:
>> Updated @exception with @throws for core-libs, it fixes all open sub-tasks
>> of JDK-8252536.
>>
>> Open Subtasks part of this fix are:
>> 1. JDK-8252537
>> 2. JDK-8252539
>> 3. JDK-8252540
>> 4. JDK-8252541
>>
>> Previous conversation on this:
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html
>
> Vipin Sharma has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
> contains one commit:
> JDK-8252537 Updated @exception with @throws, implemented review comments
Overall the changes look OK. in the java.sql set of classes, please updated
the modified statements to also use {@code}
src/java.sql/share/classes/java/sql/CallableStatement.java line 131:
> 129: * a ARRAY, BLOB, CLOB,
> 130: * DATALINK, JAVA_OBJECT,
> NCHAR,
> 131: * NCLOB, NVARCHAR,
> LONGNVARCHAR,
Please change to use {@code) as part of the update
src/java.sql/share/classes/java/sql/CallableStatement.java line 613:
> 611: * a ARRAY, BLOB, CLOB,
> 612: * DATALINK, JAVA_OBJECT,
> NCHAR,
> 613: * NCLOB, NVARCHAR,
> LONGNVARCHAR,
Same comment regarding {@code}
-
Changes requested by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR: 8252537: Updated @exception with @throws [v3]
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation on this: >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html > > Vipin Sharma has updated the pull request with a new target base due to a > merge or a rebase. The pull request now > contains one commit: > JDK-8252537 Updated @exception with @throws, implemented review comments I've reviewed the management files only. They look good. - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/95
Re: RFR: 8252537: Updated @exception with @throws [v3]
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068540.html Vipin Sharma has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JDK-8252537 Updated @exception with @throws, implemented review comments - Changes: https://git.openjdk.java.net/jdk/pull/95/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=95=02 Stats: 1690 lines in 86 files changed: 0 ins; 0 del; 1690 mod Patch: https://git.openjdk.java.net/jdk/pull/95.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/95/head:pull/95 PR: https://git.openjdk.java.net/jdk/pull/95
