Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current [v2]
On Tue, 18 May 2021 23:35:12 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleTest.java line 683:
>>
>>> 681: * @bug 4052404 4778440 8263202
>>> 682: */
>>> 683: public void TestChangedISO639Codes() {
>>
>> Could probably be simplified with a DataProvider.
>
> That would be nice, but the test is not testng based, and it would be an
> entire test rewrite which I would not do it at this time.
I see. Good old test is still good.
-
PR: https://git.openjdk.java.net/jdk/pull/4069
Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current [v2]
On Tue, 18 May 2021 23:39:37 GMT, Naoto Sato wrote: >> Please review the changes to the subject issue. java.util.Locale class has a >> long-standing issue for those obsolete ISO 639 languages where its >> normalization ends up in the obsolete codes. This change intends to flip the >> normalization towards the current codes, providing a system property for >> compatibility behavior. ResourceBundle class is also modified to load either >> obsolete/current bundles. For more detail, take a look at the CSR. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Locale's class description modification Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4069
Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current [v2]
> Please review the changes to the subject issue. java.util.Locale class has a > long-standing issue for those obsolete ISO 639 languages where its > normalization ends up in the obsolete codes. This change intends to flip the > normalization towards the current codes, providing a system property for > compatibility behavior. ResourceBundle class is also modified to load either > obsolete/current bundles. For more detail, take a look at the CSR. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Locale's class description modification - Changes: - all: https://git.openjdk.java.net/jdk/pull/4069/files - new: https://git.openjdk.java.net/jdk/pull/4069/files/dee95bf1..0f76ac45 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4069&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4069&range=00-01 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/4069.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4069/head:pull/4069 PR: https://git.openjdk.java.net/jdk/pull/4069
Re: RFR: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current [v2]
On Tue, 18 May 2021 22:22:06 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Locale's class description modification
>
> src/java.base/share/classes/java/util/Locale.java line 462:
>
>> 460: * backward compatible forms.
>> 461: *
>> 462: * The APIs added in 1.7 map between the old and new language codes,
>
> This paragraph needs a rewrite as well it seems, esp. the part that states
> "getLanguage and toString reflect the old code" is no longer true.
Good catch! In fact, I had modified this paragraph in my preliminary fix, but
it slipped away somehow along the fix. Corrected the PR and CSR as well.
> test/jdk/java/util/Locale/LocaleTest.java line 683:
>
>> 681: * @bug 4052404 4778440 8263202
>> 682: */
>> 683: public void TestChangedISO639Codes() {
>
> Could probably be simplified with a DataProvider.
That would be nice, but the test is not testng based, and it would be an entire
test rewrite which I would not do it at this time.
-
PR: https://git.openjdk.java.net/jdk/pull/4069
