Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-20 Thread Andy Herrick 




On 6/20/2019 1:44 PM, Kevin Rushforth wrote:
Looks good. I presume you will update the HelpResources.properties for 
other languages before you push?



yes - they are updated - I just left them out of the file list.
/Andy

-- Kevin


On 6/20/2019 9:54 AM, Andy Herrick wrote:

On 6/19/2019 1:34 PM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/
/Andy


Minor revision [3] of help and message text in response to feedback:

[3] http://cr.openjdk.java.net/~herrick/8225428/webrev.02/

/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-20 Thread Kevin Rushforth 
Looks good. I presume you will update the HelpResources.properties for 
other languages before you push?


-- Kevin


On 6/20/2019 9:54 AM, Andy Herrick wrote:

On 6/19/2019 1:34 PM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/
/Andy


Minor revision [3] of help and message text in response to feedback:

[3] http://cr.openjdk.java.net/~herrick/8225428/webrev.02/

/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-20 Thread Alexey Semenyuk 

Looks good.

- Alexey

On 6/20/2019 12:54 PM, Andy Herrick wrote:

On 6/19/2019 1:34 PM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/
/Andy


Minor revision [3] of help and message text in response to feedback:

[3] http://cr.openjdk.java.net/~herrick/8225428/webrev.02/

/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-20 Thread Andy Herrick 

On 6/19/2019 1:34 PM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/
/Andy


Minor revision [3] of help and message text in response to feedback:

[3] http://cr.openjdk.java.net/~herrick/8225428/webrev.02/

/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-19 Thread Andy Herrick 




On 6/19/2019 6:26 PM, Alexander Matveev wrote:

Hi Andy,

1) Looks like you forgot to update HelpResources_ja.properties and 
HelpResources_zh_CN.properties.

Yes I need to re-run my script to update these.


2) 
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html

Line 84: Error: creating app-image requires
Should we change it to "Error: Creating application image requires", 
since we do not have app-image option anymore?

yes - will fix .
/Andy


Otherwise looks fine.

Thanks,
Alexander


On 6/19/2019 10:34 AM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/ 



/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-19 Thread Alexander Matveev 

Hi Andy,

1) Looks like you forgot to update HelpResources_ja.properties and 
HelpResources_zh_CN.properties.


2) 
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html

Line 84: Error: creating app-image requires
Should we change it to "Error: Creating application image requires", 
since we do not have app-image option anymore?


Otherwise looks fine.

Thanks,
Alexander


On 6/19/2019 10:34 AM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/ 



/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-19 Thread Andy Herrick 




On 6/19/2019 2:08 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~herrick/8225428/webrev.01/test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java.sdiff.html: 


---
private static final String [] RESULT_7 = {"--module-path", 
"--runtime-image", "app-image"};

---
Should it be "--app-image"?
yes - there is no need for a change here, either will work (since 
checking code uses String.contains()) but will revert in the next revision.

/Andy


- Alexey

On 6/19/2019 1:34 PM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/ 



/Andy

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-19 Thread Alexey Semenyuk 

http://cr.openjdk.java.net/~herrick/8225428/webrev.01/test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java.sdiff.html:
---
private static final String [] RESULT_7 = {"--module-path", 
"--runtime-image", "app-image"};

---
Should it be "--app-image"?

- Alexey

On 6/19/2019 1:34 PM, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and 
build only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/ 



/Andy

RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

2019-06-19 Thread Andy Herrick 

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


JDK-8225428: CLI change to remove "mode", rename to "package", and build 
only one target


[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/ 



/Andy