Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote:
>> …n name.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8256475: Fix Behavior when Installer name differs from application name.
Looks good.
src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_zh_CN.properties
line 75:
> 73: error.jlink.failed=jlink \u5931\u8D25\uFF0C\u51FA\u73B0 {0}
> 74: error.blocked.option=\u4E0D\u5141\u8BB8\u5728 --jlink-options
> \u4E2D\u4F7F\u7528 jlink \u9009\u9879 [{0}]
> 75: error.no.name=Name not specified with --name and cannot infer one from
> app-image
Do we need to submit a follow-up bug for localization team that we have new
non-localized messages in the region specific properties file? I see that
foreign app image warning is still not localized.
-
Marked as reviewed by kizune (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]
On Thu, 19 Nov 2020 23:32:22 GMT, Alexander Matveev wrote: >> Andy Herrick has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8256475: Fix Behavior when Installer name differs from application >> name. > > Marked as reviewed by almatvee (Committer). @azuev-java - can you review as well ? - PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]
On Thu, 19 Nov 2020 20:45:23 GMT, Andy Herrick wrote: >> …n name. > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8256475: Fix Behavior when Installer name differs from application name. Marked as reviewed by asemenyuk (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v4]
> …n name. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8256475: Fix Behavior when Installer name differs from application name. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new: https://git.openjdk.java.net/jdk/pull/1300/files/f7f910b8..1d9e5aee Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1300=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1300=02-03 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/1300.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1300/head:pull/1300 PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v3]
> …n name. Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8256475: Fix Behavior when Installer name differs from application name. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new: https://git.openjdk.java.net/jdk/pull/1300/files/2e044b91..f7f910b8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1300=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1300=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/1300.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1300/head:pull/1300 PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v2]
On Thu, 19 Nov 2020 16:49:23 GMT, Andy Herrick wrote:
>> …n name.
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains 69 additional
> commits since the last revision:
>
> - JDK-8256475: Fix Behavior when Installer name differs from application
> name.
> - Merge branch 'master' into JDK-8256475
> - 8221554: aarch64 cross-modifying code
>
>Reviewed-by: rehn, aph
> - 8255978: [windows] os::release_memory may not release the full range
>
>Reviewed-by: iklam, minqi
> - 8256375: AArch64: aarch64-asmtest.py may generate undefined register r18
>
>Reviewed-by: aph
> - 8252304: Seed an HttpRequest.Builder from an existing HttpRequest
>
>Co-authored-by: Chris Hegarty
>Reviewed-by: chegar, dfuchs, michaelm
> - 8256499: Zero: enable Epsilon GC
>
>Reviewed-by: rkennke, ihse
> - 8256552: Let ReplayCompiles set UseDebuggerErgo
>
>Reviewed-by: vlivanov, redestad
> - 8256172: Clean up CDS handling of i2i_entry
>
>Reviewed-by: minqi, ccheung
> - 8256178: Add RAII object for file lock
>
>Reviewed-by: dholmes, coleenp
> - ... and 59 more:
> https://git.openjdk.java.net/jdk/compare/64b64ac9...2e044b91
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line 218:
> 216: }
> 217:
> 218: public String installerName() {
I'd suggest to insert `verifyIsOfType(PackageType.NATIVE);` call at the
beginning of the function body. This will help to catch situations if
installerName() is called on jpackage command building app image by accident.
test/jdk/tools/jpackage/share/MultiNameTwoPhaseTest.java line 37:
> 35:
> 36: /*
> 37: * @test
Without ` * @requires jpackage.test.SQETest == null` this test will be used to
create test artifacts for SQE. I don't think we need any manual testing here.
Especially for five test scenarios. I think automated testing should be
sufficient.
-
PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio… [v2]
> …n name. Andy Herrick has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 69 additional commits since the last revision: - JDK-8256475: Fix Behavior when Installer name differs from application name. - Merge branch 'master' into JDK-8256475 - 8221554: aarch64 cross-modifying code Reviewed-by: rehn, aph - 8255978: [windows] os::release_memory may not release the full range Reviewed-by: iklam, minqi - 8256375: AArch64: aarch64-asmtest.py may generate undefined register r18 Reviewed-by: aph - 8252304: Seed an HttpRequest.Builder from an existing HttpRequest Co-authored-by: Chris Hegarty Reviewed-by: chegar, dfuchs, michaelm - 8256499: Zero: enable Epsilon GC Reviewed-by: rkennke, ihse - 8256552: Let ReplayCompiles set UseDebuggerErgo Reviewed-by: vlivanov, redestad - 8256172: Clean up CDS handling of i2i_entry Reviewed-by: minqi, ccheung - 8256178: Add RAII object for file lock Reviewed-by: dholmes, coleenp - ... and 59 more: https://git.openjdk.java.net/jdk/compare/f9b55367...2e044b91 - Changes: - all: https://git.openjdk.java.net/jdk/pull/1300/files - new: https://git.openjdk.java.net/jdk/pull/1300/files/63b6631c..2e044b91 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1300=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1300=00-01 Stats: 8778 lines in 311 files changed: 5399 ins; 1776 del; 1603 mod Patch: https://git.openjdk.java.net/jdk/pull/1300.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1300/head:pull/1300 PR: https://git.openjdk.java.net/jdk/pull/1300
Re: RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio…
On Wed, 18 Nov 2020 22:17:07 GMT, Andy Herrick wrote:
> …n name.
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java line
312:
> 310: Path appDir;
> 311: if (appName == null) {
> 312: // this can only happen when no name is given and using
> forign app-image
forign -> foreign
test/jdk/tools/jpackage/share/MultiNameTwoPhaseTest.java line 34:
> 32:
> 33: /**
> 34: */
Needs description for test.
-
PR: https://git.openjdk.java.net/jdk/pull/1300
RFR: JDK-8256475: Fix Behavior when Installer name differs from applicatio…
…n name. - Commit messages: - JDK-8256475: Fix Behavior when Installer name differs from application name. Changes: https://git.openjdk.java.net/jdk/pull/1300/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1300=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256475 Stats: 207 lines in 18 files changed: 167 ins; 13 del; 27 mod Patch: https://git.openjdk.java.net/jdk/pull/1300.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1300/head:pull/1300 PR: https://git.openjdk.java.net/jdk/pull/1300
