Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote: > - We need to unsign all executables and libraries in the app-image before > signing. (not just those in the runtime). > - Clean up excessive output by executing the individual file sign and > unsigning commands in quiet mode. > - Add conditions in SigningAppImageTest to test signing of additional > launchers. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6654
Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote: > - We need to unsign all executables and libraries in the app-image before > signing. (not just those in the runtime). > - Clean up excessive output by executing the individual file sign and > unsigning commands in quiet mode. > - Add conditions in SigningAppImageTest to test signing of additional > launchers. Marked as reviewed by asemenyuk (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6654
RFR: JDK-8276837: [macos]: Error when signing the additional launcher
- We need to unsign all executables and libraries in the app-image before signing. (not just those in the runtime). - Clean up excessive output by executing the individual file sign and unsigning commands in quiet mode. - Add conditions in SigningAppImageTest to test signing of additional launchers. - Commit messages: - JDK-8276837: [macos]: Error when signing the additional launcher - JDK-8276837: [macos]: Errorwhen signing the additional launcher Changes: https://git.openjdk.java.net/jdk/pull/6654/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6654=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276837 Stats: 52 lines in 3 files changed: 21 ins; 5 del; 26 mod Patch: https://git.openjdk.java.net/jdk/pull/6654.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6654/head:pull/6654 PR: https://git.openjdk.java.net/jdk/pull/6654
Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote: > Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has > additional launcher works, and results in validly signed launcher and > additional launcher (original reported problem). last push was meant to be only one file - but got lots of unrelated changes. will close this one and open new PR. - PR: https://git.openjdk.java.net/jdk/pull/6636
Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher [v2]
> Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has > additional launcher works, and results in validly signed launcher and > additional launcher (original reported problem). Andy Herrick has updated the pull request incrementally with 85 additional commits since the last revision: - JDK-8276837: [macos]: Error when signing the additional launcher - 8277797: Remove undefined/unused SharedRuntime::trampoline_size() Reviewed-by: dholmes, stuefe - 8277789: G1: G1CardSetConfiguration prefixes num_ and max_ used interchangeably Reviewed-by: mli, tschatzl - 8277878: Fix compiler tests after JDK-8275908 Reviewed-by: thartmann, chagedorn - 8277904: G1: Remove G1CardSetArray::max_entries Reviewed-by: tschatzl - 8277896: Remove unused BOTConstants member methods Reviewed-by: kbarrett - 8277450: Record number of references into collection set during gc Reviewed-by: kbarrett, iwalulya - 8277928: Fix compilation on macosx-aarch64 after 8276108 Reviewed-by: shade, dholmes - 8275241: Unused ArrayList is created in RequestEngine.addHooks Reviewed-by: egahlin - 8276108: Wrong instruction generation in aarch64 backend Co-authored-by: Nick Gasson Reviewed-by: aph, neliasso - ... and 75 more: https://git.openjdk.java.net/jdk/compare/34692c5d...2a3e19ff - Changes: - all: https://git.openjdk.java.net/jdk/pull/6636/files - new: https://git.openjdk.java.net/jdk/pull/6636/files/34692c5d..2a3e19ff Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=6636=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=6636=00-01 Stats: 23719 lines in 463 files changed: 13755 ins; 6525 del; 3439 mod Patch: https://git.openjdk.java.net/jdk/pull/6636.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6636/head:pull/6636 PR: https://git.openjdk.java.net/jdk/pull/6636
Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher
On Wed, 1 Dec 2021 19:59:57 GMT, Alexey Semenyuk wrote: >> Before signing, unsign all executables and libraries (not just those in >> runtime). >> Also, run individual file sign and unsign commands in quiet mode. >> Also, add test case to SigningAppImageTest to test that signing app that has >> additional launcher works, and results in validly signed launcher and >> additional launcher (original reported problem). > > test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 95: > >> 93: SigningBase.verifyCodesign(launcherPath, true); >> 94: SigningBase.verifyCodesign(testALPath, true); >> 95: } > > Would it make sense to extend the existing test with additional launcher > checks instead of creating another one? Packaging of a full JDK with signing > probably takes a while yes - that would be simpler - will do. - PR: https://git.openjdk.java.net/jdk/pull/6636
Re: RFR: JDK-8276837: [macos]: Error when signing the additional launcher
On Wed, 1 Dec 2021 14:25:52 GMT, Andy Herrick wrote: > Before signing, unsign all executables and libraries (not just those in > runtime). > Also, run individual file sign and unsign commands in quiet mode. > Also, add test case to SigningAppImageTest to test that signing app that has > additional launcher works, and results in validly signed launcher and > additional launcher (original reported problem). Changes requested by asemenyuk (Reviewer). test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 95: > 93: SigningBase.verifyCodesign(launcherPath, true); > 94: SigningBase.verifyCodesign(testALPath, true); > 95: } Would it make sense to extend the existing test with additional launcher checks instead of creating another one? Packaging of a full JDK with signing probably takes a while - PR: https://git.openjdk.java.net/jdk/pull/6636
RFR: JDK-8276837: [macos]: Error when signing the additional launcher
Before signing, unsign all executables and libraries (not just those in runtime). Also, run individual file sign and unsign commands in quiet mode. Also, add test case to SigningAppImageTest to test that signing app that has additional launcher works, and results in validly signed launcher and additional launcher (original reported problem). - Commit messages: - JDK-8276837: [macos]: Errorwhen signing the additional launcher Changes: https://git.openjdk.java.net/jdk/pull/6636/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6636=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276837 Stats: 64 lines in 3 files changed: 33 ins; 5 del; 26 mod Patch: https://git.openjdk.java.net/jdk/pull/6636.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6636/head:pull/6636 PR: https://git.openjdk.java.net/jdk/pull/6636
