Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]
On Mon, 13 Jun 2022 10:33:24 GMT, Andrey Turbanov wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use round directly > > src/hotspot/share/adlc/main.cpp line 491: > >> 489: } >> 490: >> 491: // VS2005 has its own definition, identical to this one. > > Let's adjust comment too. No need to mention VS2005. Thanks for the hint, I removed the VS2005 related comment. - PR: https://git.openjdk.org/jdk/pull/9105
Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote:
>> We still handle at a number of places ancient historic _MSC_VER versions of
>> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
>> This should be cleaned up, as long as it is not 3rd party code that we don't
>> want to adjust.
>>
>> Currently still supported ("valid") VS version are 2017+, see
>> https://github.com/openjdk/jdk/blob/master/make/autoconf/toolchain_microsoft.m4
>> .
>> VALID_VS_VERSIONS="2019 2017 2022"
>> Even with adjusted toolchain m4 files, something older than VS2013 (also
>> probably older than VS2015) would not be able to build jdk anymore.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> use round directly
src/hotspot/share/adlc/main.cpp line 491:
> 489: }
> 490:
> 491: // VS2005 has its own definition, identical to this one.
Let's adjust comment too. No need to mention VS2005.
-
PR: https://git.openjdk.org/jdk/pull/9105
Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]
On Mon, 13 Jun 2022 07:24:52 GMT, Matthias Baesken wrote:
>> We still handle at a number of places ancient historic _MSC_VER versions of
>> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
>> This should be cleaned up, as long as it is not 3rd party code that we don't
>> want to adjust.
>>
>> Currently still supported ("valid") VS version are 2017+, see
>> https://github.com/openjdk/jdk/blob/master/make/autoconf/toolchain_microsoft.m4
>> .
>> VALID_VS_VERSIONS="2019 2017 2022"
>> Even with adjusted toolchain m4 files, something older than VS2013 (also
>> probably older than VS2015) would not be able to build jdk anymore.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> use round directly
Nice!
-
Marked as reviewed by mdoerr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9105
Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]
On Fri, 10 Jun 2022 21:04:04 GMT, Phil Race wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use round directly > > src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 38: > >> 36: # define ROUND_TO_INT(num)((int) round(num)) >> 37: #else >> 38: # define ROUND_TO_INT(num)((int) floor((num) + 0.5)) > > If you look at when and why this was introduced (*), the "else" was not to > support some other compiler - it was to support the older MS compiler. So if > you don't want that, then the whole thing reduces to > #define ROUND_TO_INT(num) ((int) round(num)) > > .. you could even go further and eliminate the macro altogether if it makes > sense - you'd have to look at the usages. > > Same logic applies to the other files. > > > (*) https://mail.openjdk.java.net/pipermail/awt-dev/2016-March/010889.html Hi Phil, I simplified the code more and now use round directly. - PR: https://git.openjdk.org/jdk/pull/9105
Re: RFR: JDK-8288094: cleanup old _MSC_VER handling [v2]
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to adjust.
>
> Currently still supported ("valid") VS version are 2017+, see
> https://github.com/openjdk/jdk/blob/master/make/autoconf/toolchain_microsoft.m4
> .
> VALID_VS_VERSIONS="2019 2017 2022"
> Even with adjusted toolchain m4 files, something older than VS2013 (also
> probably older than VS2015) would not be able to build jdk anymore.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
use round directly
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9105/files
- new: https://git.openjdk.org/jdk/pull/9105/files/ee8dc996..e97c8329
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk=9105=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk=9105=00-01
Stats: 21 lines in 3 files changed: 0 ins; 17 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/9105.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9105/head:pull/9105
PR: https://git.openjdk.org/jdk/pull/9105
