Re: RFR 8173817: StackOverflowError in "process reaper" thread

[Roger Riggs]

Hi,

One option is to make code the function in a private method and use a 
method reference.
But the code to generate the binding and the lambda mechanism would 
still look appear like magic.


Thanks, Roger


On 8/21/2017 9:42 PM, Martin Buchholz wrote:
I suspect this won't save any stack frames in the stack-starved 
thread... but seems like small progress nevertheless.


Perhaps lambdas that are likely to show up in stack traces should be 
given real static classes with good names to make those stack traces 
more readable.


On Fri, Aug 18, 2017 at 7:48 AM, Roger Riggs > wrote:


Please review a change to the process reaper completion handler's
choice of an anonymous inner class
for more consistent stack usage.  Additional background and
discussion in the issue 8173817 [1].

Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-stackoverflow-8173817/


Issue:
[1] https://bugs.openjdk.java.net/browse/JDK-8173817


Thanks, Roger

Re: RFR 8173817: StackOverflowError in "process reaper" thread

[Martin Buchholz]

I suspect this won't save any stack frames in the stack-starved thread...
but seems like small progress nevertheless.

Perhaps lambdas that are likely to show up in stack traces should be given
real static classes with good names to make those stack traces more
readable.

On Fri, Aug 18, 2017 at 7:48 AM, Roger Riggs  wrote:

> Please review a change to the process reaper completion handler's choice
> of an anonymous inner class
> for more consistent stack usage.  Additional background and discussion in
> the issue 8173817 [1].
>
> Webrev:
>http://cr.openjdk.java.net/~rriggs/webrev-stackoverflow-8173817/
>
> Issue:
> [1]   https://bugs.openjdk.java.net/browse/JDK-8173817
>
> Thanks, Roger
>
>

Re: RFR 8173817: StackOverflowError in "process reaper" thread

[David Holmes]

Looks good to me Roger!

Thanks,
David

On 19/08/2017 12:48 AM, Roger Riggs wrote:
Please review a change to the process reaper completion handler's choice 
of an anonymous inner class
for more consistent stack usage.  Additional background and discussion 
in the issue 8173817 [1].


Webrev:
    http://cr.openjdk.java.net/~rriggs/webrev-stackoverflow-8173817/

Issue:
[1]   https://bugs.openjdk.java.net/browse/JDK-8173817

Thanks, Roger

RFR 8173817: StackOverflowError in "process reaper" thread

[Roger Riggs]

Please review a change to the process reaper completion handler's choice 
of an anonymous inner class
for more consistent stack usage.  Additional background and discussion 
in the issue 8173817 [1].


Webrev:
   http://cr.openjdk.java.net/~rriggs/webrev-stackoverflow-8173817/

Issue:
[1]   https://bugs.openjdk.java.net/browse/JDK-8173817

Thanks, Roger