Re: RFR: 8286191: misc tests fail due to JDK-8285987 [v4]
> The isMusl method had to be handled in > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . > Additionally, the vm.musl predicate seem not to be available in the langtools > tests. Matthias Baesken has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into JDK-8286191 - restore year in ExternalEditorTest, remove test exclusion - Merge remote-tracking branch 'origin/master' into JDK-8286191 - remove from ProblemList - Merge remote-tracking branch 'origin/master' into JDK-8286191 - JDK-8286191 - Changes: - all: https://git.openjdk.java.net/jdk/pull/8556/files - new: https://git.openjdk.java.net/jdk/pull/8556/files/2337301c..4c9e5b7e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8556&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8556&range=02-03 Stats: 104552 lines in 1272 files changed: 94955 ins; 4519 del; 5078 mod Patch: https://git.openjdk.java.net/jdk/pull/8556.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8556/head:pull/8556 PR: https://git.openjdk.java.net/jdk/pull/8556
Re: RFR: 8286191: misc tests fail due to JDK-8285987 [v3]
On Fri, 6 May 2022 06:41:31 GMT, Matthias Baesken wrote: >> The isMusl method had to be handled in >> test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . >> Additionally, the vm.musl predicate seem not to be available in the >> langtools tests. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > restore year in ExternalEditorTest, remove test exclusion Looks good. Thanks for resolving both ProblemLists. Hopefully, the real problem and solution on Musl can be found separately. - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8556
Re: RFR: 8286191: misc tests fail due to JDK-8285987 [v3]
On Thu, 5 May 2022 16:14:32 GMT, Daniel D. Daugherty wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> restore year in ExternalEditorTest, remove test exclusion > > test/langtools/jdk/jshell/ExternalEditorTest.java line 29: > >> 27: * @bug 8143955 8080843 8163816 8143006 8169828 8171130 8162989 8210808 >> 28: * @comment musl/Alpine has problems executing some shell scripts, see >> 8285987 >> 29: * @requires !vm.musl > > So this change backs out an "@requires" that was added by: > > JDK-8285987 executing shell scripts without #! fails on Alpine linux > https://bugs.openjdk.java.net/browse/JDK-8285987 > > Presumably this "@requires" was added for some reason so what's > going to happen if this test is run on Alpine Linux? Also, the fix in > JDK-8285987 updated the copyright year. Do you plan on restoring > it to the original "2017" value? Hi Daniel, I restored the original year 2017. (additionally I removed the langtools exclusion) > Presumably this "@requires" was added for some reason so what's going to > happen if this test is run on Alpine Linux I can only speak about our Alpine setup (3.15 in a container) and there the test fails with error=8, Exec format error. Looks like something similar has been observed as well by these people https://www.openwall.com/lists/musl/2018/03/09/2 https://github.com/scala-steward-org/scala-steward/issues/1374 - PR: https://git.openjdk.java.net/jdk/pull/8556
Re: RFR: 8286191: misc tests fail due to JDK-8285987
On Thu, 5 May 2022 16:33:53 GMT, Daniel D. Daugherty wrote: > ... update the PR's synopsis. Done . - PR: https://git.openjdk.java.net/jdk/pull/8556
Re: RFR: 8286191: misc tests fail due to JDK-8285987 [v3]
> The isMusl method had to be handled in > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . > Additionally, the vm.musl predicate seem not to be available in the langtools > tests. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: restore year in ExternalEditorTest, remove test exclusion - Changes: - all: https://git.openjdk.java.net/jdk/pull/8556/files - new: https://git.openjdk.java.net/jdk/pull/8556/files/96f508df..2337301c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8556&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8556&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8556.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8556/head:pull/8556 PR: https://git.openjdk.java.net/jdk/pull/8556
Re: RFR: 8286191: misc tests fail due to JDK-8285987 [v2]
> The isMusl method had to be handled in > test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java . > Additionally, the vm.musl predicate seem not to be available in the langtools > tests. Matthias Baesken has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into JDK-8286191 - remove from ProblemList - Merge remote-tracking branch 'origin/master' into JDK-8286191 - JDK-8286191 - Changes: - all: https://git.openjdk.java.net/jdk/pull/8556/files - new: https://git.openjdk.java.net/jdk/pull/8556/files/afdc9797..96f508df Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8556&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8556&range=00-01 Stats: 515 lines in 30 files changed: 194 ins; 107 del; 214 mod Patch: https://git.openjdk.java.net/jdk/pull/8556.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8556/head:pull/8556 PR: https://git.openjdk.java.net/jdk/pull/8556
