Re: RFR (T): 8224042 Add private alignDown method to MappedByteBuffer

2019-05-16 Thread Andrew Dinn 
On 16/05/2019 17:27, Alan Bateman wrote:
> On 16/05/2019 15:49, Andrew Dinn wrote:
>> Please review this trivial change to MapperByteBuffer which encapsulates
>> the page align down operation in a suitably named method.
>>
>> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8224042
>> webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/
>>
> Looks okay (private static, as Thomas prefers, is fine too).
Thank you for the review, Alan.

regards,


Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

Re: RFR (T): 8224042 Add private alignDown method to MappedByteBuffer

2019-05-16 Thread Andrew Dinn 
On 16/05/2019 17:24, Mikael Vidstedt wrote:
> 
> Looks good, thanks for doing it!

Thanks for the review Mikael.

regards,


Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

Re: RFR (T): 8224042 Add private alignDown method to MappedByteBuffer

2019-05-16 Thread Alan Bateman 

On 16/05/2019 15:49, Andrew Dinn wrote:

Please review this trivial change to MapperByteBuffer which encapsulates
the page align down operation in a suitably named method.

JIRA:   https://bugs.openjdk.java.net/browse/JDK-8224042
webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/


Looks okay (private static, as Thomas prefers, is fine too).

-Alan

Re: RFR (T): 8224042 Add private alignDown method to MappedByteBuffer

2019-05-16 Thread Mikael Vidstedt 


Looks good, thanks for doing it!

Cheers,
Mikael

> On May 16, 2019, at 7:49 AM, Andrew Dinn  wrote:
> 
> Please review this trivial change to MapperByteBuffer which encapsulates
> the page align down operation in a suitably named method.
> 
> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8224042
> webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/
> 
> Testing:
> This was successfully exercised by running
> 
>  jdk/java/nio/channels/FileChannel/MapTest.java
> 
> The test rounds down a sequence of sub-page offsets to successive pages
> within a mapped buffer during testing of MappedByteBuffer method force().
> 
> regards,
> 
> 
> Andrew Dinn
> ---
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

Re: RFR (T): 8224042 Add private alignDown method to MappedByteBuffer

2019-05-16 Thread Andrew Dinn 
Hi Thomas,

Thanks for the review.

On 16/05/2019 16:54, Thomas Stüfe wrote:
> looks good and trivial. Method could be static.

Yes, good point! I will modify accordingly and then push.

regards,


Andrew Dinn
---

Re: RFR (T): 8224042 Add private alignDown method to MappedByteBuffer

2019-05-16 Thread Thomas Stüfe 
Hi Andrew,

looks good and trivial. Method could be static.

Cheers, Thomas

On Thu, May 16, 2019 at 4:49 PM Andrew Dinn  wrote:

> Please review this trivial change to MapperByteBuffer which encapsulates
> the page align down operation in a suitably named method.
>
> JIRA:   https://bugs.openjdk.java.net/browse/JDK-8224042
> webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/
>
> Testing:
> This was successfully exercised by running
>
>   jdk/java/nio/channels/FileChannel/MapTest.java
>
> The test rounds down a sequence of sub-page offsets to successive pages
> within a mapped buffer during testing of MappedByteBuffer method force().
>
> regards,
>
>
> Andrew Dinn
> ---
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>