Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/16 15:47, Alan Bateman wrote: On 25/01/2016 15:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ Bringing this into jdk9/dev in the advance looks good. One thing, should we add a README so that we know exactly which version of JOpt Simple this is? Good idea Alan. Added and webrev updated in-place. -Chris.
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/16 15:39, Claes Redestad wrote: +1 Thanks for looking at this Claes. module-info.java missing? No. There is an update to modules.xml. This is all that is required in jdk9/dev, for now. "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? For consistency, I took the same terse approach applied to the jdk.internal.le module. -Chris. /Claes On 2016-01-25 16:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ -Chris. [1] https://pholser.github.io/jopt-simple/ [2] http://hg.openjdk.java.net/jigsaw/jake/jdk/file/tip/src/jdk.internal.opt/share/classes
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
Hi Chris, Are there any tests that can be included? Roger On 1/25/2016 10:39 AM, Claes Redestad wrote: +1 module-info.java missing? "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? /Claes On 2016-01-25 16:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ -Chris. [1] https://pholser.github.io/jopt-simple/ [2] http://hg.openjdk.java.net/jigsaw/jake/jdk/file/tip/src/jdk.internal.opt/share/classes
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
Hi Chris, On 1/25/2016 10:45 AM, Chris Hegarty wrote: On 25/01/16 15:39, Claes Redestad wrote: "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? For consistency, I took the same terse approach applied to the jdk.internal.le module. More explicit is better; I think 'le' was/is too terse to be informative. and a simple 'opt' is too vague. $.02, Roger -Chris. /Claes On 2016-01-25 16:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ -Chris. [1] https://pholser.github.io/jopt-simple/ [2] http://hg.openjdk.java.net/jigsaw/jake/jdk/file/tip/src/jdk.internal.opt/share/classes
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/16 15:45, Roger Riggs wrote: Hi Chris, Are there any tests that can be included? No, I am not planning to add specific tests for JOpt Simple. The tools that eventually use it, should provide sufficient testing. -Chris. Roger On 1/25/2016 10:39 AM, Claes Redestad wrote: +1 module-info.java missing? "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? /Claes On 2016-01-25 16:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ -Chris. [1] https://pholser.github.io/jopt-simple/ [2] http://hg.openjdk.java.net/jigsaw/jake/jdk/file/tip/src/jdk.internal.opt/share/classes
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/2016 15:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ Bringing this into jdk9/dev in the advance looks good. One thing, should we add a README so that we know exactly which version of JOpt Simple this is? -Alan
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/2016 15:45, Chris Hegarty wrote: : "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? For consistency, I took the same terse approach applied to the jdk.internal.le module. Right, and the module name is deliberately named because it is JDK-internal, it will not have any unconditional exports. -Alan.
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/2016 16:09, Chris Hegarty wrote: Bringing this into jdk9/dev in the advance looks good. One thing, should we add a README so that we know exactly which version of JOpt Simple this is? Good idea Alan. Added and webrev updated in-place. Thanks, that should make it easy to identify. We need to make sure there is a bug tracking an update to the THIRD_PARTY_README too. -Alan.
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
+1 module-info.java missing? "jdk.internal.opt" might be ever so slightly misleading, wouldn't "jdk.internal.joptsimple" be a better name for the module? /Claes On 2016-01-25 16:38, Chris Hegarty wrote: JOpt Simple [1] is a Java library for parsing command line options. The JDK has several different home-grown versions of command line option-parsing code. Where possible, new and existing tools in the JDK should consider using JOpt Simple. JOpt Simple is being used in a number of tools in project jigsaw [2]. This issue proposes to integrate JOpt Simple into JDK 9 as a new module that can be used internally by tools in the JDK. The webrev proposes to add the new module, it is yet to be used. Qualified exports to specific JDK tool modules can be added later. http://cr.openjdk.java.net/~chegar/8148154/ -Chris. [1] https://pholser.github.io/jopt-simple/ [2] http://hg.openjdk.java.net/jigsaw/jake/jdk/file/tip/src/jdk.internal.opt/share/classes
Re: RFR [9] 8148154: JOpt Simple - a Java library for parsing command line options
On 25/01/16 16:16, Alan Bateman wrote: On 25/01/2016 16:09, Chris Hegarty wrote: Bringing this into jdk9/dev in the advance looks good. One thing, should we add a README so that we know exactly which version of JOpt Simple this is? Good idea Alan. Added and webrev updated in-place. Thanks, that should make it easy to identify. Thanks. > We need to make sure there is a bug tracking an update to the THIRD_PARTY_README too. Filed: https://bugs.openjdk.java.net/browse/JDK-8148164 -Chris.
