Re: RFR: 8329335: HttpsURLConnectionTest fails due to network firewall rules
On Mon, 17 Jun 2024 09:16:45 GMT, Fernando Guallini wrote: > Since HttpsURLConnectionTest attempts to reach external servers, it can fail > if run on hosts without outbound traffic allowed. Therefore, it should not be > executed in CI pipelines but rather manually on a host with no firewall rules > preventing egress traffic. Hi @fguallini , what if NAT Gateway of CI machines VCN is configured to allow one way initiation traffic to specific external server. Then this change is not required. - PR Comment: https://git.openjdk.org/jdk/pull/19745#issuecomment-2173618927
Integrated: 8319678: Several tests from corelibs areas ignore VM flags
On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa wrote: > Updated following tests to use ProcessTools methods: > test/jdk/java/lang/Thread/UncaughtExceptionsTest.java > test/jdk/java/lang/annotation/LoaderLeakTest.java > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java > test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java This pull request has now been integrated. Changeset: 2e3682a7 Author: Mahendra Chhipa URL: https://git.openjdk.org/jdk/commit/2e3682a7f2983cd58b9564253dc698760faba4b8 Stats: 161 lines in 6 files changed: 56 ins; 58 del; 47 mod 8319678: Several tests from corelibs areas ignore VM flags Reviewed-by: naoto, jpai - PR: https://git.openjdk.org/jdk/pull/18602
Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v3]
On Thu, 11 Apr 2024 09:26:27 GMT, Jaikiran Pai wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented the review comments.
>
> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 301:
>
>> 299: .map(Path::toString)
>> 300: .collect(Collectors.joining(File.pathSeparator));
>> 301: //System.setProperty("test.noclasspath", "true");
>
> This newly introduced commented code can be removed.
Sorry, I missed this. Removed in current commit.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1560754800
Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v4]
> Updated following tests to use ProcessTools methods: > test/jdk/java/lang/Thread/UncaughtExceptionsTest.java > test/jdk/java/lang/annotation/LoaderLeakTest.java > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java > test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Removed commented code. - Changes: - all: https://git.openjdk.org/jdk/pull/18602/files - new: https://git.openjdk.org/jdk/pull/18602/files/4d258b00..8aba98ce Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/18602.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18602/head:pull/18602 PR: https://git.openjdk.org/jdk/pull/18602
Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v3]
> Updated following tests to use ProcessTools methods: > test/jdk/java/lang/Thread/UncaughtExceptionsTest.java > test/jdk/java/lang/annotation/LoaderLeakTest.java > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java > test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/18602/files - new: https://git.openjdk.org/jdk/pull/18602/files/04a35331..4d258b00 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=01-02 Stats: 21 lines in 3 files changed: 0 ins; 10 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/18602.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18602/head:pull/18602 PR: https://git.openjdk.org/jdk/pull/18602
Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v2]
On Wed, 10 Apr 2024 10:57:33 GMT, Jaikiran Pai wrote:
>> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 286:
>>
>>> 284: OutputAnalyzer outputAnalyzer =
>>> ProcessTools.executeCommand(commands.toArray(new String[commands.size()]));
>>> 285: if(outputAnalyzer.getExitValue() != 0) {
>>> 286: throw new RuntimeException(outputAnalyzer.getOutput());
>>
>> Same comment as above `outputAnalyzer.shouldHaveExitValue(0)` would be
>> better.
>
> Applies to some other files in this PR as well.
Thanks. Implemented in this commit.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1560682745
Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v2]
On Wed, 10 Apr 2024 10:40:55 GMT, Jaikiran Pai wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 65:
>
>> 63: * @library /test/lib
>> 64: * @build jdk.test.lib.process.ProcessTools
>> 65: * @run main/othervm InitialContextTest
>
> Hello Mahendra, I see that this test and one other test is being changed to
> `/othervm` and I suspect it's because, we now call:
>
>
> System.setProperty("test.noclasspath", "true");
>
> for the `ProcessTools` to skip adding the default `-cp` option to the
> launched Java process.
> In reality, we don't have to set that system property and thus you don't have
> to change this and the other test to `othervm`. See a previous discussion
> about the classpath handling by `ProcessTools` here
> https://github.com/openjdk/jdk/pull/17787/files/a9fcc6c2900356250b29b3d11b402790a84d9317#r1484276695
> - essentially, whatever classpath you end up passing as part of the command
> to `ProcessTools.createTestJavaProcessBuilder()` will end up getting used.
Thanks. Implemented in this commit.
> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 268:
>
>> 266: OutputAnalyzer outputAnalyzer =
>> ProcessTools.executeCommand(commands);
>> 267: if(outputAnalyzer.getExitValue() != 0) {
>> 268: throw new RuntimeException(outputAnalyzer.getOutput());
>
> I think it would be better to just call:
>
> outputAnalyzer.shouldHaveExitValue(0);
>
> that way it even prints the stdout/stderr logs and throws the exception.
Thanks. Implemented in this commit.
> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 271:
>
>> 269: }
>> 270: } catch (Exception ex) {
>> 271: throw new RuntimeException(ex.getMessage());
>
> This and other similar places in this PR will end up swallowing the
> underlying exception. It would be better to just have the method have a
> `throws Exception` or change this to:
>
>
> throw new RuntimeException(ex);
Thanks. Implemented in this commit.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1560681857
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1560682373
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1560683141
Re: RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]
On Wed, 3 Apr 2024 20:08:43 GMT, Naoto Sato wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java line 72:
>
>> 70: Path launcher = outputPath.resolve("bin").resolve("java");
>> 71: OutputAnalyzer analyzer =
>> ProcessTools.executeCommand(launcher.toAbsolutePath().toString(),"-ea",
>> "-esa", "HijrahConfigCheck");
>> 72: analyzer.shouldHaveExitValue(0);
>
> The variable `analyzer` may not be needed
Yes, I left it to improve readability.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1552113345
Re: RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]
On Wed, 3 Apr 2024 20:08:04 GMT, Naoto Sato wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
> test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java line 71:
>
>> 69: // Run tests
>> 70: Path launcher = outputPath.resolve("bin").resolve("java");
>> 71: OutputAnalyzer analyzer =
>> ProcessTools.executeCommand(launcher.toAbsolutePath().toString(),"-ea",
>> "-esa", "HijrahConfigCheck");
>
> Nit: need a space before `"-ea"`
Thanks, updated in next commit.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18602#discussion_r1552108497
Re: RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]
> Updated following tests to use ProcessTools methods: > test/jdk/java/lang/Thread/UncaughtExceptionsTest.java > test/jdk/java/lang/annotation/LoaderLeakTest.java > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java > test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. Updated EscapePath test. - Changes: - all: https://git.openjdk.org/jdk/pull/18602/files - new: https://git.openjdk.org/jdk/pull/18602/files/95605aaf..04a35331 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=00-01 Stats: 31 lines in 2 files changed: 19 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/18602.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18602/head:pull/18602 PR: https://git.openjdk.org/jdk/pull/18602
RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags
Updated following tests to use ProcessTools methods: test/jdk/java/lang/Thread/UncaughtExceptionsTest.java test/jdk/java/lang/annotation/LoaderLeakTest.java test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java test/jdk/javax/naming/spi/providers/InitialContextTest.java - Commit messages: - JDK-8319678: Several tests from corelibs areas ignore VM flags Changes: https://git.openjdk.org/jdk/pull/18602/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18602&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319678 Stats: 138 lines in 5 files changed: 45 ins; 55 del; 38 mod Patch: https://git.openjdk.org/jdk/pull/18602.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18602/head:pull/18602 PR: https://git.openjdk.org/jdk/pull/18602
Re: RFR: JDK-8311961 Update Manual Test Groups for ATR JDK22
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote: > Updated jdk_core_manual test groups. LGTM - PR Comment: https://git.openjdk.org/jdk/pull/16531#issuecomment-1798412093
Integrated: JDK-8077371: Binary files in JAXP test should be removed
On Wed, 19 Apr 2023 15:51:01 GMT, Mahendra Chhipa wrote: > Test is updated to create the binary files during test execution. This pull request has now been integrated. Changeset: 40106422 Author: Mahendra Chhipa URL: https://git.openjdk.org/jdk/commit/40106422bd2ae3da98d028bdbab2c240a71081e3 Stats: 928 lines in 16 files changed: 808 ins; 68 del; 52 mod 8077371: Binary files in JAXP test should be removed Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]
On Wed, 18 Oct 2023 14:55:13 GMT, Roger Riggs wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Corrected use of whitespace in text block.
>
> test/jdk/javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil.java
> line 127:
>
>> 125: HexFormat hex = HexFormat.of().withPrefix(" (byte)
>> 0x").withSuffix(",");
>> 126: for (int i = 0; i < bytes.length; i += linelen) {
>> 127: sb.append("\n");
>
> Add some indentation before each line so the resulting code is properly
> indented.
Added the indentation, reverted back to the use of Formatter class instead of
HexFormat class.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1365396006
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v12]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Added indentation to generate the properly indented code. Revert back to Formatter class from HexFormat class, so that Any Java version serialization code can be generated. Added "Mechanically generated" notation to already generated classes with Old Java versions. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/2512e026..e2c4880e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=10-11 Stats: 36 lines in 6 files changed: 12 ins; 2 del; 22 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Corrected use of whitespace in text block. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/b292c9d0..2512e026 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=09-10 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v10]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with two additional commits since the last revision: - Removed commented code. - Use of HexFormatter clas instead of Formatter. Addition of copyright section in autogenerated source file. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/5326282f..b292c9d0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=08-09 Stats: 82 lines in 3 files changed: 36 ins; 14 del; 32 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v9]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Tests with base64 input are removed. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/a01dc7e2..5326282f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=07-08 Stats: 232 lines in 8 files changed: 0 ins; 228 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id [v2]
On Thu, 12 Oct 2023 14:18:16 GMT, Agnibho Hom Chowdhury wrote: >> Please review this PR as a fix of >> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the >> bug with after @ignore annotation. > > Agnibho Hom Chowdhury has updated the pull request incrementally with one > additional commit since the last revision: > > upadted copyright year Looks Good to me. - PR Comment: https://git.openjdk.org/jdk/pull/16073#issuecomment-1761300374
Re: RFR: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote: > Please review this PR as a fix of > [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the > bug with after @ignore annotation. test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 1: > 1: /* Could you please update the Copyright year. - PR Review Comment: https://git.openjdk.org/jdk/pull/16073#discussion_r1356618161
Re: RFR: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote: > Please review this PR as a fix of > [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the > bug with after @ignore annotation. Looks good to me. - PR Comment: https://git.openjdk.org/jdk/pull/16073#issuecomment-1759259625
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v8]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Implemented the review comments. 1. Now test uses Junit5. 2. Created the seperate Utility class to generate the JDK version specific java src file. - Merge branch 'master' into JDK-8077371 - Implemented review comments. - Implemented the review comments. - Move the pseudo code generation part from setup() to seperate methods. - 1. Added JDK version in Data files. 2. Updated copyright year. - Implemented the review comments. - Implemented the review comment. - closed file handlers. - JDK-8077371: Binary files in JAXP test should be removed - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/a940f237..a01dc7e2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=06-07 Stats: 830759 lines in 11186 files changed: 571572 ins; 156454 del; 102733 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v7]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/b690e77b..a940f237 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=05-06 Stats: 113 lines in 2 files changed: 36 ins; 10 del; 67 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v6]
On Fri, 5 May 2023 21:50:06 GMT, Lance Andersen wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move the pseudo code generation part from setup() to seperate methods. > > test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 232: > >> 230: * JDKGregorianCalendarAndDurationSerData.java files. >> 231: * @param baos >> 232: */ > > I think there needs to be a general comment describing how these methods are > used to create the JDKGregorianCalendarAndDurationSerData.java > files. There should also be a description/comment for the methods defined in > GregorianCalendarAndDurationSerData.java > > We need to try and put ourselves in the place of a future maintainer who > needs to understand how to create a version of one of these files. > > You could probably also create a method which generates a > JDKGregorianCalendarAndDurationSerData.java file to save the > developer from multiple cut an pastes. > > At a minimum, there really should be a step by step guide How these methods can be used, added comment regarding this under setup method. Added description for the methods defined in GregorianCalendarAndDurationSerData.java file. Now developer should be able to create the GregorianCalendarAndDurationSerData.java file after reading these comments. - PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1190014838
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]
On Tue, 2 May 2023 16:27:25 GMT, Lance Andersen wrote: >> This is added in setup method to create the serialized data with current JDK >> version (JDK under test). In addition to serialized data generated with old >> JDK version. > > Sorry, I still disagree with this. Your comment in the test is as follows: > > `// Generates the Java Pseudo code for base64 encoded string that can be cut > & pasted into the test` > > Which is what the method does and to facilitate it, as an example print it > out so that it can be copied and pasted > > ` System.out.println(sb);` > > Again, there is no reason to include this code in the setup method, it should > be segmented out into its own method with instructions with how to create the > encoded string Hi Lance, Initially I misunderstood the comment. Now I move the pseudo code generation code to separate methods. - PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1183746563
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v6]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Move the pseudo code generation part from setup() to seperate methods. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/1ddb5e69..b690e77b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=04-05 Stats: 172 lines in 1 file changed: 92 ins; 78 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v5]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: 1. Added JDK version in Data files. 2. Updated copyright year. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/f867ba2e..1ddb5e69 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=03-04 Stats: 5 lines in 5 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]
On Fri, 28 Apr 2023 18:43:32 GMT, Joe Wang wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 2: > >> 1: /* >> 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. > > missed the original copyright year, e.g. 2014, 2023, Added the copyright year and added the JDK version information in Data files. - PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1182592044
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]
On Sat, 29 Apr 2023 16:15:58 GMT, Lance Andersen wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85: > >> 83: >> 84: // Generates the Java Pseudo code for base64 encoded string that >> can be cut & pasted into the test >> 85: final StringBuilder sb = new StringBuilder(); > > Can you please explain the purpose of the following code in the `setup` > method?. This appears to be what you used to generate the > _JDK**X**GregorianCalendarAndDurationSerData.java_ files. I don't see why > this would be needed in a setup method. > > Providing a method, along with comments of how to use it, to create byte > arrays make sense, just not in a setup method. This is added in setup method to create the serialized data with current JDK version (JDK under test). In addition to serialized data generated with old JDK version. - PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1182597550
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/45567f28..f867ba2e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=02-03 Stats: 837 lines in 6 files changed: 764 ins; 19 del; 54 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comment. Thanks for your review comments. I will implement them and push again. - PR Comment: https://git.openjdk.org/jdk/pull/13537#issuecomment-1517843647
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comment. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/209152ad..45567f28 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=01-02 Stats: 3 lines in 1 file changed: 1 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v2]
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: closed file handlers. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files - new: https://git.openjdk.org/jdk/pull/13537/files/911da859..209152ad Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
RFR: JDK-8077371: Binary files in JAXP test should be removed
Test is updated to create the binary files during test execution. - Commit messages: - JDK-8077371: Binary files in JAXP test should be removed Changes: https://git.openjdk.org/jdk/pull/13537/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8077371 Stats: 140 lines in 9 files changed: 45 ins; 54 del; 41 mod Patch: https://git.openjdk.org/jdk/pull/13537.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13537/head:pull/13537 PR: https://git.openjdk.org/jdk/pull/13537
Withdrawn: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote: > Following tests read the unicode data files > (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, > these files should be in test directories. No source code is using these > files. Only tests are using these files. Tests are : > java/lang/Character/CharPropTest.java > java/lang/Character/CheckProp.java > java/lang/Character/CheckScript.java > java/lang/Character/CheckUnicode.java > java/lang/Character/UnicodeBlock/CheckBlocks.java > java/lang/Character/UnicodeCasingTest.java > java/lang/String/SpecialCasingTest.java > java/lang/String/UnicodeCasingTest.java > java/text/Normalizer/ConformanceTest.java This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/13447
Re: RFR: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote: > Following tests read the unicode data files > (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, > these files should be in test directories. No source code is using these > files. Only tests are using these files. Tests are : > java/lang/Character/CharPropTest.java > java/lang/Character/CheckProp.java > java/lang/Character/CheckScript.java > java/lang/Character/CheckUnicode.java > java/lang/Character/UnicodeBlock/CheckBlocks.java > java/lang/Character/UnicodeCasingTest.java > java/lang/String/SpecialCasingTest.java > java/lang/String/UnicodeCasingTest.java > java/text/Normalizer/ConformanceTest.java > Hi Roger, Sorry I was not aware of uses in makefiles. I will undo the changes. - PR Comment: https://git.openjdk.org/jdk/pull/13447#issuecomment-1508531123
RFR: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.
Following tests read the unicode data files (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, these files should be in test directories. No source code is using these files. Only tests are using these files. Tests are : java/lang/Character/CharPropTest.java java/lang/Character/CheckProp.java java/lang/Character/CheckScript.java java/lang/Character/CheckUnicode.java java/lang/Character/UnicodeBlock/CheckBlocks.java java/lang/Character/UnicodeCasingTest.java java/lang/String/SpecialCasingTest.java java/lang/String/UnicodeCasingTest.java java/text/Normalizer/ConformanceTest.java - Commit messages: - JDK-8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories. Changes: https://git.openjdk.org/jdk/pull/13447/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13447&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305904 Stats: 1 line in 13 files changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/13447.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13447/head:pull/13447 PR: https://git.openjdk.org/jdk/pull/13447
Re: RFR: JDK-8295859 Update Manual Test Groups [v2]
On Mon, 20 Mar 2023 23:29:25 GMT, Bill Huang wrote: >> The purpose of this task is to add the difference between -manual jdk_core >> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order >> to streamline the manual test execution process, a new test group called >> jdk_core_manual_human has been created for manual tests that demand extra >> preparation or test input. > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Implemented review comments. LGTM - PR Comment: https://git.openjdk.org/jdk/pull/12840#issuecomment-1477607865
Re: RFR: JDK-8295859 Update Manual Test Groups
On Thu, 2 Mar 2023 21:34:28 GMT, Bill Huang wrote: > The purpose of this task is to add the difference between -manual jdk_core > and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order > to streamline the manual test execution process, a new test group called > jdk_core_manual_human has been created for manual tests that demand extra > preparation or test input. test/jdk/TEST.groups line 644: > 642: > 643: jdk_core_manual_human = \ > 644: :jdk_core_manual_requires_human_input \ Move tests from jdk_core_manual_requires_human_input group to here. And remove jdk_core_manual_requires_human_input this group. test/jdk/TEST.groups line 647: > 645: :jdk_core_manual_requires_root_privilege > 646: > 647: jdk_core_manual_requires_human_input = \ Move tests from this group to jdk_core_manual_human group, and remove this group. - PR: https://git.openjdk.org/jdk/pull/12840
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]
On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang wrote: >> The current non local registry tests require a manual process that runs >> rmiregitrty on a different machine and changes the -Dregistry.host property >> in the source before running the tests on the local machine. This task is >> created to improve this manual process and provide a clearer instruction to >> the test engineer about the test requirement. >> >> Tests include: >> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java >> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java >> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Implemented review comments. LGTM - PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]
On Thu, 27 Oct 2022 19:08:06 GMT, Bill Huang wrote:
>> The current non local registry tests require a manual process that runs
>> rmiregitrty on a different machine and changes the -Dregistry.host property
>> in the source before running the tests on the local machine. This task is
>> created to improve this manual process and provide a clearer instruction to
>> the test engineer about the test requirement.
>>
>> Tests include:
>> java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java
>> java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java
>> javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java
>
> Bill Huang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reverted exclusion of nonlocal registry tests.
test/jdk/java/rmi/registry/nonLocalRegistry/NonLocalRegistryBase.java line 31:
> 29: static final String instructions =
> 30: "This is a manual test that requires rmiregistry run on a
> different host"
> 31: + ". Login or ssh to a different host, install the
> latest JDK "
replace "latest JDK" with "JDK under test"
test/jdk/java/rmi/registry/nonLocalRegistry/NonLocalRegistryTest.java line 55:
> 53: * property -Dregistry.host set to the hostname or IP address of the
> different host.
> 54: */
> 55: public class NonLocalRegistryTest extends NonLocalRegistryBase {
Move private static void assertIsAccessException(Throwable ex) method to
NonLocalRegistryBase class.
test/jdk/java/rmi/registry/nonLocalRegistry/NonLocalSkeletonTest.java line 81:
> 79: * with the hostname or IP address of the different host and run the test
> with jtreg.
> 80: */
> 81: public class NonLocalSkeletonTest extends NonLocalRegistryBase {
Move private static void assertIsAccessException(Throwable ex) method to
NonLocalRegistryBase class.
test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line
222:
> 220: System.out.printf("Found expected AccessException: %s%n%n",
> t);
> 221: } else {
> 222: throw new RuntimeException("AccessException did not occur
> when expected", ex);
private static void assertIsAccessException(Throwable ex) is define in all
these three test classes, move this method in lib/jdk/test/lib
test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line
226:
> 224: }
> 225:
> 226: private String readHostInput(int index) {
Duplicate code, this code is also in NonLocalRegistryBase.java, Please move
this code in a common class under lib/jdk/test/lib. Or move this
NonLocalRegistryBase.java under lib/jdk/test/lib and provide some generic name.
-
PR: https://git.openjdk.org/jdk/pull/10825
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java >> javax/crypto/CryptoPermissions/InconsistentEntries.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > AssertThrows an exception in InconsistentEntries test. Looks good to me. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Tue, 18 Oct 2022 22:11:57 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: >> >>> 2: permission javax.crypto.CryptoAllPermission; >>> 3: permission javax.crypto.CryptoPermission "DES", 64; >>> 4: } >> >> please remove extra line. > > I double-checked, there is no extra line at the end of this file. Ok >> test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line >> 46: >> >>> 44: * @summary standard extensions path is hard-coded in default >>> 45: * system policy file >>> 46: * >> >> No need to repeat these statement again. > > Are you saying that we don't need to run the ExtDir2.policy and > ExtDir3.policy? Its fine, ignore my previous comment. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java >> javax/crypto/CryptoPermissions/InconsistentEntries.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > AssertThrows an exception in InconsistentEntries test. Looks good to me. Please update few formatting related comments. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java >> javax/crypto/CryptoPermissions/InconsistentEntries.java > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > AssertThrows an exception in InconsistentEntries test. test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: > 2: permission javax.crypto.CryptoAllPermission; > 3: permission javax.crypto.CryptoPermission "DES", 64; > 4: } please remove extra line. test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line 46: > 44: * @summary standard extensions path is hard-coded in default > 45: * system policy file > 46: * No need to repeat these statement again. test/jdk/sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java line 54: > 52: * @bug 4993819 > 53: * @summary standard extensions path is hard-coded in default > 54: * system policy file No need to repeat these statement. - PR: https://git.openjdk.org/jdk/pull/10637
Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote:
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java
> javax/crypto/CryptoPermissions/InconsistentEntries.java
Changes requested by mchhipa (Committer).
test/jdk/java/security/Policy/Root/Root.java line 48:
> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy");
> 47: public static void main(String[] args) throws Exception {
> 48: Files.copy(SOURCE, TARGET, StandardCopyOption.REPLACE_EXISTING);
Could you please use the testng framework for initial setup of test.
test/jdk/java/security/Policy/Root/Root.java line 57:
> 55:
> 56: private static void test() throws Exception{
> 57: ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
No need to create ProceesBuilder if use the testng framework
test/jdk/java/security/Policy/Root/Root.java line 64:
> 62: OutputAnalyzer output = new OutputAnalyzer(proc);
> 63: output.stdoutShouldNotBeEmpty();
> 64: output.shouldContain("Test succeeded");
p.implies() returns boolean value, instead of checking for string "Test
succeded", use Assert.assertTrue()
test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 31:
> 29: * @summary Test limited/default_local.policy containing inconsistent
> entries
> 30: * @library /test/lib
> 31: * @run driver InconsistentEntries
Use the testng framework.
test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 76:
> 74: OutputAnalyzer output = new OutputAnalyzer(proc);
> 75: output.shouldContain("Test completed successfully");
> 76: System.out.println("Test passed.");
Please use testng framework instead of creating ProcessBuilder
test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 105:
> 103: } catch (ExceptionInInitializerError e) {
> 104: e.printStackTrace();
> 105: System.out.println("Test completed successfully");
This test can be rewritten and use @Test(expectedException =
ExceptionInInitializerError.class) instead of creating the ProcessBuilder to
capture the output.
-
PR: https://git.openjdk.org/jdk/pull/10637
Integrated: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote: > Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling This pull request has now been integrated. Changeset: 1961e81e Author:Mahendra Chhipa URL: https://git.openjdk.org/jdk/commit/1961e81e02e707cd0c8241aa3af6ddabf7668589 Stats: 358 lines in 2 files changed: 358 ins; 0 del; 0 mod 8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling Reviewed-by: bhuang, joehw - PR: https://git.openjdk.org/jdk/pull/10557
Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v3]
> Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Added predicate tests. - Changes: - all: https://git.openjdk.org/jdk/pull/10557/files - new: https://git.openjdk.org/jdk/pull/10557/files/5489dcf1..7dd36ecb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10557&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10557&range=01-02 Stats: 25 lines in 2 files changed: 20 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/10557.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10557/head:pull/10557 PR: https://git.openjdk.org/jdk/pull/10557
Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v2]
> Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/10557/files - new: https://git.openjdk.org/jdk/pull/10557/files/a3aeea91..5489dcf1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10557&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10557&range=00-01 Stats: 47 lines in 2 files changed: 30 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk/pull/10557.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10557/head:pull/10557 PR: https://git.openjdk.org/jdk/pull/10557
Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote: > Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Hi @JoeWang-Java , @bwhuang-us , Could you please review this PR. - PR: https://git.openjdk.org/jdk/pull/10557
RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
Added test cases for xpath Axis: 1. descendant 2. descendant-or-self 3. following 4. following-sibling - Commit messages: - JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self - JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling Changes: https://git.openjdk.org/jdk/pull/10557/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10557&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289509 Stats: 308 lines in 2 files changed: 308 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10557.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10557/head:pull/10557 PR: https://git.openjdk.org/jdk/pull/10557
Integrated: JDK-8289510 : Improve test coverage for XPath Axes: namespace
On Wed, 17 Aug 2022 15:32:49 GMT, Mahendra Chhipa wrote: > Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. This pull request has now been integrated. Changeset: 3d254d3c Author:Mahendra Chhipa URL: https://git.openjdk.org/jdk/commit/3d254d3c8ea7f409e8f709413f80d88913eb0ce8 Stats: 245 lines in 1 file changed: 245 ins; 0 del; 0 mod 8289510: Improve test coverage for XPath Axes: namespace Reviewed-by: joehw - PR: https://git.openjdk.org/jdk/pull/9906
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v4]
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/9906/files - new: https://git.openjdk.org/jdk/pull/9906/files/a75a6dc3..a8d4039e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=02-03 Stats: 14 lines in 1 file changed: 11 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/9906.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9906/head:pull/9906 PR: https://git.openjdk.org/jdk/pull/9906
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v3]
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Added defaukt namsespace expressions. - Changes: - all: https://git.openjdk.org/jdk/pull/9906/files - new: https://git.openjdk.org/jdk/pull/9906/files/be00c2c6..a75a6dc3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=01-02 Stats: 9 lines in 1 file changed: 4 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/9906.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9906/head:pull/9906 PR: https://git.openjdk.org/jdk/pull/9906
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v2]
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/9906/files - new: https://git.openjdk.org/jdk/pull/9906/files/7bb690bf..be00c2c6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=00-01 Stats: 69 lines in 1 file changed: 68 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/9906.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9906/head:pull/9906 PR: https://git.openjdk.org/jdk/pull/9906
Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace
On Wed, 17 Aug 2022 15:32:49 GMT, Mahendra Chhipa wrote: > Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Hi @JoeWang-Java , Could you please review this PR. - PR: https://git.openjdk.org/jdk/pull/9906
RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace
Added tests for namespace Axis. Tests incluse namspace expressions, namespace node counts and namespace node scope. - Commit messages: - JDK-8289510 : Improve test coverage for XPath Axes: namespace Changes: https://git.openjdk.org/jdk/pull/9906/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9906&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289510 Stats: 163 lines in 1 file changed: 163 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/9906.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9906/head:pull/9906 PR: https://git.openjdk.org/jdk/pull/9906
