Re: RFR: 8319556: Harmonize interface formatting in the FFM API [v3]
On Tue, 7 Nov 2023 16:32:43 GMT, Per Minborg wrote: >> This PR proposes to remove two `permits` declarations where the line >> overflows the stipulated maximum column with. Also, it proposes to harmonize >> the layout of `permit` formatting so they are the the same throughout the >> API. >> >> This PR might be perceived as over worked but I think it nice to get >> consistency across the API now that we go final. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revert some foramtting Marked as reviewed by mcimadamore (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16528#pullrequestreview-1718171040
Re: RFR: 8319556: Harmonize interface formatting in the FFM API [v3]
> This PR proposes to remove two `permits` declarations where the line > overflows the stipulated maximum column with. Also, it proposes to harmonize > the layout of `permit` formatting so they are the the same throughout the API. > > This PR might be perceived as over worked but I think it nice to get > consistency across the API now that we go final. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Revert some foramtting - Changes: - all: https://git.openjdk.org/jdk/pull/16528/files - new: https://git.openjdk.org/jdk/pull/16528/files/bc07305d..14ed6c90 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16528=02 - incr: https://webrevs.openjdk.org/?repo=jdk=16528=01-02 Stats: 22 lines in 4 files changed: 0 ins; 11 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/16528.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16528/head:pull/16528 PR: https://git.openjdk.org/jdk/pull/16528
Re: RFR: 8319556: Harmonize interface formatting in the FFM API [v2]
On Tue, 7 Nov 2023 15:11:25 GMT, Per Minborg wrote: > Hrmm. I reformatted all classes of the same category where at least one of > them needed reformatting to make it more consistent. For example: `OfBoolean` > overflows but not `OfByte`. So, all of the of* were consistently reformatted. > So, let's pick a choice here: > > 1. Reformat only those specific classes needing it not bothering if > similar classes look different > > 2. Keep it as it is. > > > I am happy to do either. I'm fine with value layout nested classes, but what about AddressLayout/GroupLayout? - PR Comment: https://git.openjdk.org/jdk/pull/16528#issuecomment-1799040997
Re: RFR: 8319556: Harmonize interface formatting in the FFM API [v2]
On Tue, 7 Nov 2023 11:41:06 GMT, Per Minborg wrote: >> This PR proposes to remove two `permits` declarations where the line >> overflows the stipulated maximum column with. Also, it proposes to harmonize >> the layout of `permit` formatting so they are the the same throughout the >> API. >> >> This PR might be perceived as over worked but I think it nice to get >> consistency across the API now that we go final. > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove redundandt space > - Use permits reformatting only when needed Hrmm. I reformatted all classes of the same category where at least one of them needed reformatting to make it more consistent. For example: `OfBoolean` overflows but not `OfByte`. So, all of the of* were consistently reformatted. So, let's pick a choice here: 1) Reformat only those specific classes needing it not bothering if similar classes look different 2) Keep it as it is. I am happy to do either. - PR Comment: https://git.openjdk.org/jdk/pull/16528#issuecomment-1798832942
Re: RFR: 8319556: Harmonize interface formatting in the FFM API [v2]
On Tue, 7 Nov 2023 11:41:06 GMT, Per Minborg wrote: >> This PR proposes to remove two `permits` declarations where the line >> overflows the stipulated maximum column with. Also, it proposes to harmonize >> the layout of `permit` formatting so they are the the same throughout the >> API. >> >> This PR might be perceived as over worked but I think it nice to get >> consistency across the API now that we go final. > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove redundandt space > - Use permits reformatting only when needed There seems to be still changes that are not needed. E.g. `AddressLayout`, `GroupLayout` and all the nested classes inside `ValueLayout`. - PR Comment: https://git.openjdk.org/jdk/pull/16528#issuecomment-1798789694
Re: RFR: 8319556: Harmonize interface formatting in the FFM API [v2]
> This PR proposes to remove two `permits` declarations where the line > overflows the stipulated maximum column with. Also, it proposes to harmonize > the layout of `permit` formatting so they are the the same throughout the API. > > This PR might be perceived as over worked but I think it nice to get > consistency across the API now that we go final. Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Remove redundandt space - Use permits reformatting only when needed - Changes: - all: https://git.openjdk.org/jdk/pull/16528/files - new: https://git.openjdk.org/jdk/pull/16528/files/0d5774c8..bc07305d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16528=01 - incr: https://webrevs.openjdk.org/?repo=jdk=16528=00-01 Stats: 16 lines in 7 files changed: 0 ins; 8 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/16528.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16528/head:pull/16528 PR: https://git.openjdk.org/jdk/pull/16528
Re: RFR: 8319556: Harmonize interface formatting in the FFM API
On Mon, 6 Nov 2023 21:05:58 GMT, Per Minborg wrote: > This PR proposes to remove two `permits` declarations where the line > overflows the stipulated maximum column with. Also, it proposes to harmonize > the layout of `permit` formatting so they are the the same throughout the API. > > This PR might be perceived as over worked but I think it nice to get > consistency across the API now that we go final. I will prefer to see this done on a by-need basis. E.g. if the line fits in the 100 char margin, (as it seems the case in a lot of the changes here), I don't see an immediate need to make changes? - PR Review: https://git.openjdk.org/jdk/pull/16528#pullrequestreview-1717460098
RFR: 8319556: Harmonize interface formatting in the FFM API
This PR proposes to remove two `permits` declarations where the line overflows the stipulated maximum column with. Also, it proposes to harmonize the layout of `permit` formatting so they are the the same throughout the API. This PR might be perceived as over worked but I think it nice to get consistency across the API now that we go final. - Commit messages: - Reformat interface permit declarations Changes: https://git.openjdk.org/jdk/pull/16528/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16528=00 Issue: https://bugs.openjdk.org/browse/JDK-8319556 Stats: 44 lines in 11 files changed: 21 ins; 0 del; 23 mod Patch: https://git.openjdk.org/jdk/pull/16528.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16528/head:pull/16528 PR: https://git.openjdk.org/jdk/pull/16528
