Re: RFR: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory [v7]
On Fri, 17 May 2024 08:28:15 GMT, Raffaello Giulietti
wrote:
>> All random number generator algorithms are implemented in module
>> `java.base`. The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory`
>> is no longer needed.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> SecureRandom added to the table in package documentation.
src/java.base/share/classes/java/util/random/package-info.java line 129:
> 127: *
> 128: * Random number generator algorithms are organized in groups,
> 129: * as described below.
FYI, it is possible to link to an anchor in a package-info file using syntax
like
`{@linkplain java.util.random##algorithms below}`
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19212#discussion_r1607475198
Re: RFR: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory [v7]
On Fri, 17 May 2024 08:28:15 GMT, Raffaello Giulietti wrote: >> All random number generator algorithms are implemented in module >> `java.base`. The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory` >> is no longer needed. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > SecureRandom added to the table in package documentation. Thank you Raffaello for fixing this as well as considering the review suggestions. The latest state of this PR in `880138d7` looks good to me. I've also reviewed the linked CSR and that too looks fine to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19212#pullrequestreview-2063525156
Re: RFR: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory [v7]
> All random number generator algorithms are implemented in module `java.base`. > The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory` is no longer > needed. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: SecureRandom added to the table in package documentation. - Changes: - all: https://git.openjdk.org/jdk/pull/19212/files - new: https://git.openjdk.org/jdk/pull/19212/files/a77146f5..880138d7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19212&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19212&range=05-06 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19212.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19212/head:pull/19212 PR: https://git.openjdk.org/jdk/pull/19212
