Re: [jdk23] RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Jun 2024 and was > reviewed by Naoto Sato and Justin Lu. > > Thanks! Thanks for the sponsor. - PR Comment: https://git.openjdk.org/jdk/pull/19817#issuecomment-2183087424
Re: [jdk23] RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Jun 2024 and was > reviewed by Naoto Sato and Justin Lu. > > Thanks! Thanks for review. - PR Comment: https://git.openjdk.org/jdk/pull/19817#issuecomment-2183078007
Re: [jdk23] RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by SendaoYan on 20 Jun 2024 and was > reviewed by Naoto Sato and Justin Lu. > > Thanks! Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19817#pullrequestreview-2133028593
[jdk23] RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root
Hi all, This pull request contains a backport of commit [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 20 Jun 2024 and was reviewed by Naoto Sato and Justin Lu. Thanks! - Commit messages: - Backport de8ee97718d7e12b541b310cf5b67f3e10e91ad9 Changes: https://git.openjdk.org/jdk/pull/19817/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19817&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334333 Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19817.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19817/head:pull/19817 PR: https://git.openjdk.org/jdk/pull/19817
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v4]
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote: >> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add bug id 8334333 to jtreg tag @bug Thanks for the sponsor. - PR Comment: https://git.openjdk.org/jdk/pull/19732#issuecomment-2181783165
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v4]
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote: >> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add bug id 8334333 to jtreg tag @bug Thanks all for the review. - PR Comment: https://git.openjdk.org/jdk/pull/19732#issuecomment-2177319690
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v4]
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote: >> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add bug id 8334333 to jtreg tag @bug Marked as reviewed by jlu (Committer). - PR Review: https://git.openjdk.org/jdk/pull/19732#pullrequestreview-2126241928
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v4]
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote: >> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add bug id 8334333 to jtreg tag @bug Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19732#pullrequestreview-2126195112
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v3]
On Tue, 18 Jun 2024 07:31:59 GMT, Justin Lu wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add a whitespace before if > > test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java > line 54: > >> 52: import jdk.test.lib.Utils; >> 53: import jdk.test.lib.process.ProcessTools; >> 54: import jdk.test.lib.Platform; > > It would be beneficial to add this issue's bug ID to the Jtreg `@bug` tag. Thanks for the suggestion. The bug id `8334333` has been added. - PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643982602
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v4]
> Hi all, > Testcase > `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` > run fails with root user privileged. I think it's necessary to skip this > testcase when user is root. > Why run the jtreg test by root user? It's because during rpmbuild process for > linux distribution of JDK, root user is the default user to build the > openjdk, also is the default user to run the `make test-tier1`, this PR make > this testcase more robustness. > The change has been verified, only change the testcase, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: add bug id 8334333 to jtreg tag @bug - Changes: - all: https://git.openjdk.org/jdk/pull/19732/files - new: https://git.openjdk.org/jdk/pull/19732/files/90d3b335..23f99429 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19732.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19732/head:pull/19732 PR: https://git.openjdk.org/jdk/pull/19732
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v3]
On Tue, 18 Jun 2024 06:31:37 GMT, SendaoYan wrote: >> Hi all, >> Testcase >> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` >> run fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root user? It's because during rpmbuild process >> for linux distribution of JDK, root user is the default user to build the >> openjdk, also is the default user to run the `make test-tier1`, this PR make >> this testcase more robustness. >> The change has been verified, only change the testcase, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > add a whitespace before if test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java line 54: > 52: import jdk.test.lib.Utils; > 53: import jdk.test.lib.process.ProcessTools; > 54: import jdk.test.lib.Platform; It would be beneficial to add this issue's bug ID to the Jtreg `@bug` tag. - PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643972916
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v3]
> Hi all, > Testcase > `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` > run fails with root user privileged. I think it's necessary to skip this > testcase when user is root. > Why run the jtreg test by root user? It's because during rpmbuild process for > linux distribution of JDK, root user is the default user to build the > openjdk, also is the default user to run the `make test-tier1`, this PR make > this testcase more robustness. > The change has been verified, only change the testcase, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: add a whitespace before if - Changes: - all: https://git.openjdk.org/jdk/pull/19732/files - new: https://git.openjdk.org/jdk/pull/19732/files/9b8a0bcb..90d3b335 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19732.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19732/head:pull/19732 PR: https://git.openjdk.org/jdk/pull/19732
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
On Tue, 18 Jun 2024 06:18:48 GMT, Andrey Turbanov wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change the excption meassges to: Unable to create an unreadable properties
>> file
>
> test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java
> line 59:
>
>> 57: public class MissingResourceCauseTestRun {
>> 58: public static void main(String[] args) throws Throwable {
>> 59: if(Platform.isRoot() && !Platform.isWindows()) {
>
> Suggestion:
>
> if (Platform.isRoot() && !Platform.isWindows()) {
Thanks for the review. A white space before `if` has been added.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643892712
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
On Tue, 18 Jun 2024 02:00:41 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root user? It's because during rpmbuild process
>> for linux distribution of JDK, root user is the default user to build the
>> openjdk, also is the default user to run the `make test-tier1`, this PR make
>> this testcase more robustness.
>> The change has been verified, only change the testcase, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> change the excption meassges to: Unable to create an unreadable properties
> file
test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java line
59:
> 57: public class MissingResourceCauseTestRun {
> 58: public static void main(String[] args) throws Throwable {
> 59: if(Platform.isRoot() && !Platform.isWindows()) {
Suggestion:
if (Platform.isRoot() && !Platform.isWindows()) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643875207
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
On Mon, 17 Jun 2024 18:46:34 GMT, Naoto Sato wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change the excption meassges to: Unable to create an unreadable properties
>> file
>
> test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java
> line 60:
>
>> 58: public static void main(String[] args) throws Throwable {
>> 59: if(Platform.isRoot() && !Platform.isWindows()) {
>> 60: throw new SkippedException("root user has privileged will
>> make this test fail.");
>
> The exception message can be improved. How about "Unable to create an
> unreadable properties file"?
Thanks for the suggestion. The exception message has been change.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643627352
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
> Hi all, > Testcase > `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` > run fails with root user privileged. I think it's necessary to skip this > testcase when user is root. > Why run the jtreg test by root user? It's because during rpmbuild process for > linux distribution of JDK, root user is the default user to build the > openjdk, also is the default user to run the `make test-tier1`, this PR make > this testcase more robustness. > The change has been verified, only change the testcase, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: change the excption meassges to: Unable to create an unreadable properties file - Changes: - all: https://git.openjdk.org/jdk/pull/19732/files - new: https://git.openjdk.org/jdk/pull/19732/files/5cf26a11..9b8a0bcb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19732.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19732/head:pull/19732 PR: https://git.openjdk.org/jdk/pull/19732
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root
On Sat, 15 Jun 2024 09:56:53 GMT, SendaoYan wrote:
> Hi all,
> Testcase
> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
> run fails with root user privileged. I think it's necessary to skip this
> testcase when user is root.
> Why run the jtreg test by root user? It's because during rpmbuild process for
> linux distribution of JDK, root user is the default user to build the
> openjdk, also is the default user to run the `make test-tier1`, this PR make
> this testcase more robustness.
> The change has been verified, only change the testcase, no risk.
test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java line
60:
> 58: public static void main(String[] args) throws Throwable {
> 59: if(Platform.isRoot() && !Platform.isWindows()) {
> 60: throw new SkippedException("root user has privileged will
> make this test fail.");
The exception message can be improved. How about "Unable to create an
unreadable properties file"?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643295899
