Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
On Tue, 18 Jun 2024 06:18:48 GMT, Andrey Turbanov wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change the excption meassges to: Unable to create an unreadable properties
>> file
>
> test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java
> line 59:
>
>> 57: public class MissingResourceCauseTestRun {
>> 58: public static void main(String[] args) throws Throwable {
>> 59: if(Platform.isRoot() && !Platform.isWindows()) {
>
> Suggestion:
>
> if (Platform.isRoot() && !Platform.isWindows()) {
Thanks for the review. A white space before `if` has been added.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643892712
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
On Tue, 18 Jun 2024 02:00:41 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root user? It's because during rpmbuild process
>> for linux distribution of JDK, root user is the default user to build the
>> openjdk, also is the default user to run the `make test-tier1`, this PR make
>> this testcase more robustness.
>> The change has been verified, only change the testcase, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revision:
>
> change the excption meassges to: Unable to create an unreadable properties
> file
test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java line
59:
> 57: public class MissingResourceCauseTestRun {
> 58: public static void main(String[] args) throws Throwable {
> 59: if(Platform.isRoot() && !Platform.isWindows()) {
Suggestion:
if (Platform.isRoot() && !Platform.isWindows()) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643875207
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
On Mon, 17 Jun 2024 18:46:34 GMT, Naoto Sato wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change the excption meassges to: Unable to create an unreadable properties
>> file
>
> test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java
> line 60:
>
>> 58: public static void main(String[] args) throws Throwable {
>> 59: if(Platform.isRoot() && !Platform.isWindows()) {
>> 60: throw new SkippedException("root user has privileged will
>> make this test fail.");
>
> The exception message can be improved. How about "Unable to create an
> unreadable properties file"?
Thanks for the suggestion. The exception message has been change.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19732#discussion_r1643627352
Re: RFR: 8334333: MissingResourceCauseTestRun.java fails if run by root [v2]
> Hi all, > Testcase > `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java` > run fails with root user privileged. I think it's necessary to skip this > testcase when user is root. > Why run the jtreg test by root user? It's because during rpmbuild process for > linux distribution of JDK, root user is the default user to build the > openjdk, also is the default user to run the `make test-tier1`, this PR make > this testcase more robustness. > The change has been verified, only change the testcase, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: change the excption meassges to: Unable to create an unreadable properties file - Changes: - all: https://git.openjdk.org/jdk/pull/19732/files - new: https://git.openjdk.org/jdk/pull/19732/files/5cf26a11..9b8a0bcb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19732&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19732.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19732/head:pull/19732 PR: https://git.openjdk.org/jdk/pull/19732
