Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
> Open l10n drop. Files have been updated with translated versions. Whitespace > tool has been ran on files. > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert culture attribute - Changes: - all: https://git.openjdk.org/jdk20/pull/116/files - new: https://git.openjdk.org/jdk20/pull/116/files/fc32c37f..616b2502 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=116&range=03-04 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/116.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/116/head:pull/116 PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert culture attribute jpackage changes look good - Marked as reviewed by asemenyuk (Reviewer). PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert culture attribute Marked as reviewed by jlu (Author). - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert culture attribute Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert culture attribute I skimmed through this, basically looking for trailing white space changes only, and it generally looks okay. Note that some of these trailing whitespace fixes has been independently address in mainline. Forward-porting this might involve some (virtual) conflicts. It is also impossible to see in the Github interface if you are introducing *new* trailing white spaces in the added texts. I hope you are not, and that you have verified this. - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert culture attribute LGTM - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert culture attribute
src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties
line 32:
> 30:
> err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519:
> {1}
> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
> 32:
> err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199
> Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
While personally I like to see Chinese-style punctuation marks (Ex: `：`) used
in Chinese contexts instead of their English-style ones (Ex: `:`), it's only
updated on this single line and all the others are still using the
English-style.
There should be a general rule on which style we should use throughout all
display messages.
-
PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert culture attribute
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties
line 113:
> 111:
> doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528
> @inheritDoc
> 112:
> doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
> {0}
> 113:
> doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684
> exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301
> @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
Should `exception-type` be translated?
-
PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 17:49:59 GMT, Weijun Wang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert culture attribute
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties
> line 113:
>
>> 111:
>> doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528
>> @inheritDoc
>> 112:
>> doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>> {0}
>> 113:
>> doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684
>> exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301
>> @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>
> Should `exception-type` be translated?
The translation tool didn't seem to translate this. Either because it couldn't
or because it somehow missed it. I'm not sure which, but I'm open to replacing
this with a translation suggestion you have. Or I can leave it as is.
> src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties
> line 32:
>
>> 30:
>> err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519:
>> {1}
>> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
>> 32:
>> err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199
>> Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
>
> While personally I like to see Chinese-style punctuation marks (Ex: `：`) used
> in Chinese contexts instead of their English-style ones (Ex: `:`), it's only
> updated on this single line and all the others are still using the
> English-style.
>
> There should be a general rule on which style we should use throughout all
> display messages.
Updated the punctuation (colons and comma) to be more consistent throughout the
file.
-
PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 17:56:15 GMT, Damon Nguyen wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties
>> line 113:
>>
>>> 111:
>>> doclet.inheritDocWithinInappropriateTag=\u4E0D\u80FD\u5728\u6B64\u6807\u8BB0\u4E2D\u4F7F\u7528
>>> @inheritDoc
>>> 112:
>>> doclet.inheritDocNoDoc=\u88AB\u8986\u76D6\u7684\u65B9\u6CD5\u4E0D\u8BB0\u5F55\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>>> {0}
>>> 113:
>>> doclet.throwsInheritDocUnsupported=\u4E0D\u662F\u7531\u65B9\u6CD5\u58F0\u660E\u7684
>>> exception-type \u7C7B\u578B\u53C2\u6570\u4E0D\u652F\u6301
>>> @inheritDoc\uFF1B\u76F4\u63A5\u8BB0\u5F55\u6B64\u7C7B\u5F02\u5E38\u9519\u8BEF\u7C7B\u578B
>>
>> Should `exception-type` be translated?
>
> The translation tool didn't seem to translate this. Either because it
> couldn't or because it somehow missed it. I'm not sure which, but I'm open to
> replacing this with a translation suggestion you have. Or I can leave it as
> is.
I'm not sure either. You can ask a javadoc expert whether this is a proper noun
or just plain English. I noticed it's also not translated in the Japanese
version but the German version has translated it.
>> src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties
>> line 32:
>>
>>> 30:
>>> err.bad.constant.pool=\u8BFB\u53D6{0}\u7684\u5E38\u91CF\u6C60\u65F6\u51FA\u9519:
>>> {1}
>>> 31: err.class.not.found=\u627E\u4E0D\u5230\u7C7B: {0}
>>> 32:
>>> err.crash=\u51FA\u73B0\u4E25\u91CD\u7684\u5185\u90E8\u9519\u8BEF\uFF1A{0}\n\u8BF7\u586B\u5199
>>> Bug \u62A5\u544A\uFF0C\u5E76\u5305\u62EC\u4EE5\u4E0B\u4FE1\u606F\uFF1A\n{1}
>>
>> While personally I like to see Chinese-style punctuation marks (Ex: `：`)
>> used in Chinese contexts instead of their English-style ones (Ex: `:`), it's
>> only updated on this single line and all the others are still using the
>> English-style.
>>
>> There should be a general rule on which style we should use throughout all
>> display messages.
>
> Updated the punctuation (colons and comma) to be more consistent throughout
> the file.
Looks good now.
-
PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 18:00:33 GMT, Weijun Wang wrote: >> The translation tool didn't seem to translate this. Either because it >> couldn't or because it somehow missed it. I'm not sure which, but I'm open >> to replacing this with a translation suggestion you have. Or I can leave it >> as is. > > I'm not sure either. You can ask a javadoc expert whether this is a proper > noun or just plain English. I noticed it's also not translated in the > Japanese version but the German version has translated it. It's not a noun. It's an adjective that I had to synthesize for extra clarity and closeness to Java Language Specification (JLS). The English version of that entry is as follows: doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for exception-type type parameters \ that are not declared by a method; document such exception types directly JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a list of which may appear in the `throws` clause, as `ExceptionType`. To make it more English-like and separate two otherwise consecutive occurrences of "type" in that sentence, I split the words with a hyphen and lower-cased them: exception-type. @jonathan-gibbons thoughts? - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 20:03:48 GMT, Pavel Rappo wrote: >> I'm not sure either. You can ask a javadoc expert whether this is a proper >> noun or just plain English. I noticed it's also not translated in the >> Japanese version but the German version has translated it. > > It's not a noun. It's an adjective that I had to synthesize for extra clarity > and closeness to Java Language Specification (JLS). The English version of > that entry is as follows: > > doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for > exception-type type parameters \ > that are not declared by a method; document such exception types directly > > JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a > list of which may appear in the `throws` clause, as `ExceptionType`. To make > it more English-like and separate two otherwise consecutive occurrences of > "type" in that sentence, I split the words with a hyphen and lower-cased > them: exception-type. > > @jonathan-gibbons thoughts? While the text is technically correct, it may not be as clear as it could be to all folk that will read this message for whom English is not their primary language. I would suggest translating the phrase as if it were something like @inheritDoc is not supported for type parameters that are exception types and not declared by a method and secondarily, changing the English resource to something like that as well. - PR: https://git.openjdk.org/jdk20/pull/116
Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]
On Wed, 25 Jan 2023 22:38:38 GMT, Jonathan Gibbons wrote: >> It's not a noun. It's an adjective that I had to synthesize for extra >> clarity and closeness to Java Language Specification (JLS). The English >> version of that entry is as follows: >> >> doclet.throwsInheritDocUnsupported=@inheritDoc is not supported for >> exception-type type parameters \ >> that are not declared by a method; document such exception types directly >> >> JLS _8.4.6. Method Throws_ defines BNF which conveniently labels elements, a >> list of which may appear in the `throws` clause, as `ExceptionType`. To make >> it more English-like and separate two otherwise consecutive occurrences of >> "type" in that sentence, I split the words with a hyphen and lower-cased >> them: exception-type. >> >> @jonathan-gibbons thoughts? > > While the text is technically correct, it may not be as clear as it could be > to all folk that will read this message for whom English is not their primary > language. > > I would suggest translating the phrase as if it were something like > > @inheritDoc is not supported for type parameters that are exception types and > not declared by a method > > > and secondarily, changing the English resource to something like that as well. Updated this line with `exception-type` translated. Hopefully this will be addressed in future drops with changes to the translation tool after some bug fixes. - PR: https://git.openjdk.org/jdk20/pull/116
