Re: Question: Review process of release notes

2023-04-13 Thread Eirik Bjørsnøs 
>
>
> Unless your reviewers indicate they have seen the Release Note I would
> not assume that. If unclear ask someone to add a comment to the JBS
> issue saying they think it is okay.
>

This was very useful.

Thank,
Eirik.

Re: Question: Review process of release notes

2023-04-13 Thread David Holmes 

On 13/04/2023 5:20 pm, Eirik Bjørsnøs wrote:

https://openjdk.org/guide/#release-notes



Thanks David, I just found this and it seems to answer most of my 
questions. It does not explicitly say that the release note is 
considered approved when the PR is approved, but I guess I'm safe to 
assume so.


Unless your reviewers indicate they have seen the Release Note I would 
not assume that. If unclear ask someone to add a comment to the JBS 
issue saying they think it is okay.


Cheers,
David


Cheers,
Eirik.

Re: Question: Review process of release notes

2023-04-13 Thread Eirik Bjørsnøs 
>
> https://openjdk.org/guide/#release-notes


Thanks David, I just found this and it seems to answer most of my
questions. It does not explicitly say that the release note is considered
approved when the PR is approved, but I guess I'm safe to assume so.

Cheers,
Eirik.

Re: Question: Review process of release notes

2023-04-13 Thread David Holmes 

Hi Eirik,

https://openjdk.org/guide/#release-notes

HTH

David

On 13/04/2023 4:40 pm, Eirik Bjørsnøs wrote:

Hi,

My understanding of the review process for release notes is a bit 
sketchy, I could need some clarification.


Consider my release note for JDK-8205129 Remove java.lang.Compiler as an 
example:


https://bugs.openjdk.org/browse/JDK-8304459 



The PR is approved and integrated and the issue Resolved as Fixed. 
However, the Release Note sub-task is still New and Unresolved


Questions:

- Is the Release note issue considered implicitly reviewed as part of 
the PR process?
- Now that the issue is integrated, what should I do with the Release 
Note issue? Mark it as fixed in 21 and resolve it?
- The referenced release note does not appear in 
https://jdk.java.net/21/ , that's perhaps 
because the JBS issue is not resolved?


Thanks,
Eirik.