Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v4]

2023-03-16 Thread David Holmes 
On Fri, 17 Mar 2023 00:02:12 GMT, Leonid Mesnik  wrote:

>> The StreamPumper is fixed to process the last line even it is not finishes 
>> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify 
>> that tests are not broken.
>
> Leonid Mesnik has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fixed test and comments

One minor correction in the test otherwise looks good.

Thanks.

test/lib-test/jdk/test/lib/process/ProcessToolsLastLineTest.java line 57:

> 55: test("\nARG1");
> 56: test("\nARG1\n");
> 57: test("ARG1/n");

Sorry there was a typo in my suggestion - should be "ARG1\n"

-

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/13034

Re: RFR: 8303697: ProcessTools doesn't print last line of process output [v4]

2023-03-16 Thread Leonid Mesnik 
> The StreamPumper is fixed to process the last line even it is not finishes 
> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify 
> that tests are not broken.

Leonid Mesnik has updated the pull request incrementally with one additional 
commit since the last revision:

  fixed test and comments

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/13034/files
  - new: https://git.openjdk.org/jdk/pull/13034/files/aa12782b..47df1034

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13034&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13034&range=02-03

  Stats: 17 lines in 2 files changed: 11 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/13034.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/13034/head:pull/13034

PR: https://git.openjdk.org/jdk/pull/13034