On Fri, 17 Mar 2023 00:02:12 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:

>> The StreamPumper is fixed to process the last line even it is not finishes 
>> with '\n' or '\r'. The test included. Testing with tier1-3 also to verify 
>> that tests are not broken.
>
> Leonid Mesnik has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fixed test and comments

One minor correction in the test otherwise looks good.

Thanks.

test/lib-test/jdk/test/lib/process/ProcessToolsLastLineTest.java line 57:

> 55:             test("\nARG1");
> 56:             test("\nARG1\n");
> 57:             test("ARG1/n");

Sorry there was a typo in my suggestion - should be "ARG1\n"

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/13034

Reply via email to