Re: RFR: 8328812: Update and move siphash license
On Mon, 25 Mar 2024 22:23:03 GMT, Jesper Wilhelmsson wrote: >> The problem is that the project is a joined work and has multiple variants >> of copyrights (see the readme). I don’t think it’s on the safe side to pick >> a single (non recent) copyright - especially if you change attribution after >> the fact. But that’s just me. This is especially a problem because the file >> does NOT contain a dual license claim - the claim is in the readme with this >> text: >> >>> Intellectual property >> >>> This code is copyright (c) 2014-2023 Jean-Philippe Aumasson, Daniel J. >>> Bernstein. It is dual-licensed >>> [CC0](https://github.com/veorq/SipHash/blob/master/LICENCE_CC0) and >>> [MIT](https://github.com/veorq/SipHash/blob/master/LICENSE_MIT). > > Copyright and license are two different things. The project has a dual > license which we attribute. Code in different files can have different > copyrights (as is the case in e.g. our own OpenJDK code). We copied the > copyright from the file that we looked at. If you feel it has the wrong > copyright please contact the authors of that file and ask them to update > their code. The file has a different license also. Either you use the joined copyright and dual license or only the single copyright and cc0 license which is in the file. But I asked DJB to clarify. - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538369236
Re: RFR: 8328812: Update and move siphash license
On Mon, 25 Mar 2024 20:40:50 GMT, Bernd wrote: >> That header only contains a single function declaration for an entry point >> into the implementation. >> HotSpot doesn't use that function, and doesn't have anything with a >> corresponding signature. So it's >> not in any way derived from that header. The HotSpot code is derived from >> the .c file only, so that's >> the license we should be referencing. > > The problem is that the project is a joined work and has multiple variants of > copyrights (see the readme). I don’t think it’s on the safe side to pick a > single (non recent) copyright - especially if you change attribution after > the fact. But that’s just me. This is especially a problem because the file > does NOT contain a dual license claim - the claim is in the readme with this > text: > >> Intellectual property > >> This code is copyright (c) 2014-2023 Jean-Philippe Aumasson, Daniel J. >> Bernstein. It is dual-licensed >> [CC0](https://github.com/veorq/SipHash/blob/master/LICENCE_CC0) and >> [MIT](https://github.com/veorq/SipHash/blob/master/LICENSE_MIT). Copyright and license are two different things. The project has a dual license which we attribute. Code in different files can have different copyrights (as is the case in e.g. our own OpenJDK code). We copied the copyright from the file that we looked at. If you feel it has the wrong copyright please contact the authors of that file and ask them to update their code. - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538303713
Re: RFR: 8328812: Update and move siphash license
On Mon, 25 Mar 2024 20:34:06 GMT, Kim Barrett wrote: >> The header file contains more claims >> https://github.com/veorq/SipHash/blob/master/halfsiphash.h > > That header only contains a single function declaration for an entry point > into the implementation. > HotSpot doesn't use that function, and doesn't have anything with a > corresponding signature. So it's > not in any way derived from that header. The HotSpot code is derived from > the .c file only, so that's > the license we should be referencing. The problem is that the project is a joined work and has multiple variants of copyrights (see the readme). I don’t think it’s on the safe side to pick a single (non recent) copyright - especially if you change attribution after the fact. But that’s just me - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538209271
Re: RFR: 8328812: Update and move siphash license
On Mon, 25 Mar 2024 20:10:45 GMT, Bernd wrote: >> To match the license claim in the code we are using: >> https://github.com/openjdk/jdk/blob/fb8f2a0a929ebe7f65c69741712b89bbb403ade9/src/hotspot/share/classfile/altHashing.cpp#L32-L43 > > The header file contains more claims > https://github.com/veorq/SipHash/blob/master/halfsiphash.h That header only contains a single function declaration for an entry point into the implementation. HotSpot doesn't use that function, and doesn't have anything with a corresponding signature. So it's not in any way derived from that header. The HotSpot code is derived from the .c file only, so that's the license we should be referencing. - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538202785
Re: RFR: 8328812: Update and move siphash license
On Mon, 25 Mar 2024 20:07:02 GMT, Kim Barrett wrote: >> src/hotspot/share/legal/siphash.md line 9: >> >>> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson >>> 8: >>> 9:Copyright (c) 2012-2014 Daniel J. Bernstein >> >> Why would you remove a author or year range? > > To match the license claim in the code we are using: > https://github.com/openjdk/jdk/blob/fb8f2a0a929ebe7f65c69741712b89bbb403ade9/src/hotspot/share/classfile/altHashing.cpp#L32-L43 The header file contains more claims https://github.com/veorq/SipHash/blob/master/halfsiphash.h - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538174915
Re: RFR: 8328812: Update and move siphash license
On Sun, 24 Mar 2024 17:24:49 GMT, Bernd wrote: >> Updated and moved the license file. > > src/hotspot/share/legal/siphash.md line 9: > >> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson >> 8: >> 9:Copyright (c) 2012-2014 Daniel J. Bernstein > > Why would you remove a author or year range? To match the license claim in the code we are using: https://github.com/openjdk/jdk/blob/fb8f2a0a929ebe7f65c69741712b89bbb403ade9/src/hotspot/share/classfile/altHashing.cpp#L32-L43 - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1538171151
Re: RFR: 8328812: Update and move siphash license
On Fri, 22 Mar 2024 15:18:29 GMT, Jesper Wilhelmsson wrote: > Updated and moved the license file. src/hotspot/share/legal/siphash.md line 9: > 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson > 8: > 9:Copyright (c) 2012-2014 Daniel J. Bernstein Why would you remove a author or year range? - PR Review Comment: https://git.openjdk.org/jdk/pull/18455#discussion_r1536867069
Re: RFR: 8328812: Update and move siphash license
On Fri, 22 Mar 2024 15:18:29 GMT, Jesper Wilhelmsson wrote: > Updated and moved the license file. Looks good. Lois - Marked as reviewed by lfoltan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18455#pullrequestreview-1955180960
