Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Revert 2 lines in method scan - Changes: - all: https://git.openjdk.org/jdk/pull/16725/files - new: https://git.openjdk.org/jdk/pull/16725/files/149304e7..e66f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16725&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16725&range=03-04 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/16725.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16725/head:pull/16725 PR: https://git.openjdk.org/jdk/pull/16725
Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]
On Mon, 27 Nov 2023 22:44:30 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Revert 2 lines in method scan src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3123: > 3121: throw unchecked; > 3122: } catch (Exception checked) { > 3123: throw new RuntimeException(checked); We should probably a test that uses invoke(adaptInterruptible(callable)) to check that a checked exception is wrapped, just in case it breaks with some future change. - PR Review Comment: https://git.openjdk.org/jdk/pull/16725#discussion_r1407815979
Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]
On Tue, 28 Nov 2023 14:04:13 GMT, Alan Bateman wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert 2 lines in method scan > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3123: > >> 3121: throw unchecked; >> 3122: } catch (Exception checked) { >> 3123: throw new RuntimeException(checked); > > We should probably add a test that uses invoke(adaptInterruptible(callable)) > to check that a checked exception is wrapped, just in case it breaks with > some future change. Yes, somehow a test for this has been missing since first release. I added it to tck/ForkJoinPoolTest.java - PR Review Comment: https://git.openjdk.org/jdk/pull/16725#discussion_r1413154556