[coreboot] Re: Syntax highlighting screwed up (orange function parameters)?
> We do not have coreboot specific changes to the syntax highlighting code > (e.g. this is stock Gerrit). 2.16.7 had a number of changes in their syntax > highlighting though, and typically Chromium is not running on a release build > but something in between releases or highly customized. Ah, okay. I think it's this: https://bugs.chromium.org/p/gerrit/issues/detail?id=10658 That still doesn't explain why it's not matching braces, but I guess the parser may have always been broken and we just didn't notice because it uses the same color for so many things. ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
[coreboot] Re: Syntax highlighting screwed up (orange function parameters)?
On 29 Apr 2019 17:46, Julius Werner wrote:> Wanna file a bug at https://bugs.chromium.org/p/gerrit/issues/list ? Are we sure this is a general Gerrit bug? I've not seen the same thing on the Chromium Gerrit so I'm assuming it's specific to the coreboot installation. I've opened a coreboot bug for now (https://ticket.coreboot.org/issues/205), if Patrick (or whoever manages that stuff) decides it's not specific to our setup we can still complain to Gerrit directly. We do not have coreboot specific changes to the syntax highlighting code (e.g. this is stock Gerrit). 2.16.7 had a number of changes in their syntax highlighting though, and typically Chromium is not running on a release build but something in between releases or highly customized.Stefan ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
[coreboot] Re: Syntax highlighting screwed up (orange function parameters)?
> Wanna file a bug at https://bugs.chromium.org/p/gerrit/issues/list ? Are we sure this is a general Gerrit bug? I've not seen the same thing on the Chromium Gerrit so I'm assuming it's specific to the coreboot installation. I've opened a coreboot bug for now (https://ticket.coreboot.org/issues/205), if Patrick (or whoever manages that stuff) decides it's not specific to our setup we can still complain to Gerrit directly. ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
[coreboot] Re: Syntax highlighting screwed up (orange function parameters)?
Has anything changed with the syntax highlighting on Gerrit recently? I'm seeing many function parameters in orange (which is hard to read on a green background), and signs that it misparsed the code somehow (e.g. coloring opening braces different than closing ones). Example attached. Yeah, something seems broken with how it's parsing, and orange is not a great color to use on a green background anyway. Here is an example where a function's return type is highlighted in orange rather than the usual purple: https://review.coreboot.org/c/coreboot/+/30414/22/src/mainboard/facebook/fbg1701/gpio.c#250 Here is an example where a variable is highlighted in orange while its type is purple (and the function return type is also purple, unlike in the previous example): https://review.coreboot.org/c/coreboot/+/30414/22/src/mainboard/facebook/fbg1701/acpi_tables.c Wanna file a bug at https://bugs.chromium.org/p/gerrit/issues/list ? From: Julius Werner Sent: Monday, April 22, 2019 5:06:03 PM To: Coreboot; Patrick Georgi Subject: [coreboot] Syntax highlighting screwed up (orange function parameters)? Has anything changed with the syntax highlighting on Gerrit recently? I'm seeing many function parameters in orange (which is hard to read on a green background), and signs that it misparsed the code somehow (e.g. coloring opening braces different than closing ones). Example attached. ___ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
