Re: xterm (or x11) pastes are highlighted
On Fri, 18 Mar 2022 at 07:23, n952162 wrote: > > Am 18.03.2022 um 00:22 schrieb Andy Koppe: > > On Thu, 17 Mar 2022 at 20:32, René Berber wrote: > >> On 3/17/2022 1:03 PM, n952162 wrote: > >> > >>> Does anyone know how I can disable the highlighting that occurs when I > >>> copy and paste in xterm? > >>> > >>> Escape sequences are added to achieve that and sometimes they're not > >>> being properly interpreted. > >>> > >>> Why would I want that anyway? > >> The same thing happens to (plain, non X windows) mintty. > >> > >> It started recently, maybe a couple of weeks. No idea how to fix it, > >> haven't really tried. > >> > >> Very annoying. > > It came in with the readline 8.1 update in September last year, which > > enabled "bracketed paste mode" by default. (I think zsh has had it > > enabled for a few years.) > > > > As n952162 said, it tells the terminal to enclose pasted text in > > escape sequences. > > > > There are several points to this: > > - It stops accidental multi-line pastes from getting immediately > > executed line by line. > > - It makes it easier to undo a paste, as you can cut it out in one go > > rather than deleting manually. > > - Pasting can be faster, as the application can process the paste in > > one chunk rather than treating it as char-by-char keyboard input. > > > > But yep, sometimes it can go wonky, in particular when the bracketing > > mode for some reason is left on for an application that doesn't expect > > it. > > > > For readline, it can be disabled in ~/.inputrc: > > > > set enable-bracketed-paste off > > > > Regards, > > Andy > > > Andy, perhaps you can speak to another, almost related issue, which I > posted on 10th of March: > > /xterm*VT100.Translations only when mouse is over the window with focus/ > > A copy is attached here. This is only a Cygwin issue, as far as I know. > > Perhaps you can recommend someone who I could turn to, to get a fix, an > explanation, a workaround, or help to get started doing a fix? I'm afraid I can't help with that, but hopefully the Cygwin/X maintainer has seen your report. It might be interesting whether it happens in the different XWin modes (single window, rootless, multiwindow), or on a Linux host. -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: Typed characters are mis-ordered when CPU usage is high
On Fri, 18 Mar 2022 15:04:31 +0200 Orgad Shaneh wrote: > On Fri, Mar 18, 2022 at 2:15 PM Takashi Yano wrote: > > Thanks. I can reproduce the issue. I think I found the cause. > > The two unexpected things happen. > > > > (1) wVirtualKeyCode and wVirtualScanCode of readback key event may > > be null'ed even if they are not zero on WriteConsoleInputW(). > > Therefore, memcmp() report the event is not equal. > > (2) WriteConsoleInputW() may not be atomic. The event sequence which > > is written by WriteConsoleInputW() may be inserted by key input > > in the middle of the sequence. > > > > A patch for these issues is attached. Could you please test? > > Awesome, looks good now. Thank you very much! > > Hope this is the last bit :) Thanks for testing! -- Takashi Yano -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: Typed characters are mis-ordered when CPU usage is high
On Fri, Mar 18, 2022 at 2:15 PM Takashi Yano wrote: > > On Fri, 18 Mar 2022 13:21:00 +0200 > Orgad Shaneh wrote: > > > Git for Windows > > > > Were you able to reproduce? > > > > I found an easier way to reproduce, which works almost every time. > > > > It still happens only on Git Bash, and not on MSYS2 MINGW64, although > > I use the same dll in both. I have no idea why there's a difference. > > :/ > > > > I run Windows Terminal, but it reproduces also in cmd, as you tried. > > > > 1. In Control Panel -> Keyboard, set Repeat delay to shortest and > > Repeat rate to fastest. > > 2. In msys2-runtime run git fetch > > 3. Type git and press and hold q > > Thanks. I can reproduce the issue. I think I found the cause. > The two unexpected things happen. > > (1) wVirtualKeyCode and wVirtualScanCode of readback key event may > be null'ed even if they are not zero on WriteConsoleInputW(). > Therefore, memcmp() report the event is not equal. > (2) WriteConsoleInputW() may not be atomic. The event sequence which > is written by WriteConsoleInputW() may be inserted by key input > in the middle of the sequence. > > A patch for these issues is attached. Could you please test? > > -- > Takashi Yano Awesome, looks good now. Thank you very much! Hope this is the last bit :) - Orgad -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: Typed characters are mis-ordered when CPU usage is high
On Fri, 18 Mar 2022 13:21:00 +0200 Orgad Shaneh wrote: > > Git for Windows > > Were you able to reproduce? > > I found an easier way to reproduce, which works almost every time. > > It still happens only on Git Bash, and not on MSYS2 MINGW64, although > I use the same dll in both. I have no idea why there's a difference. > :/ > > I run Windows Terminal, but it reproduces also in cmd, as you tried. > > 1. In Control Panel -> Keyboard, set Repeat delay to shortest and > Repeat rate to fastest. > 2. In msys2-runtime run git fetch > 3. Type git and press and hold q Thanks. I can reproduce the issue. I think I found the cause. The two unexpected things happen. (1) wVirtualKeyCode and wVirtualScanCode of readback key event may be null'ed even if they are not zero on WriteConsoleInputW(). Therefore, memcmp() report the event is not equal. (2) WriteConsoleInputW() may not be atomic. The event sequence which is written by WriteConsoleInputW() may be inserted by key input in the middle of the sequence. A patch for these issues is attached. Could you please test? -- Takashi Yano prevent-swap.patch Description: Binary data -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: Typed characters are mis-ordered when CPU usage is high
On Fri, Mar 18, 2022 at 8:32 AM Orgad Shaneh wrote: > > On Fri, Mar 18, 2022, 8:31 AM Takashi Yano wrote: >> >> On Fri, 18 Mar 2022 07:57:27 +0200 >> Orgad Shaneh wrote: >> > I'm using the dll that was built here: >> > https://github.com/git-for-windows/msys2-runtime/actions/runs/218081 >> > for my PR: https://github.com/git-for-windows/msys2-runtime/pull/43 >> > >> > I can reproduce in msys2-runtime repo, but it's quite hard. Try this: >> > 1. git fetch >> > 2. While it is running, write git and then very quickly type >> > ququququququququququququququququ until the prompt appears. >> > >> > Sometimes you'll get q or u before git. >> >> Do you run git in Git for Windows? or msys2 git? > > > Git for Windows Were you able to reproduce? I found an easier way to reproduce, which works almost every time. It still happens only on Git Bash, and not on MSYS2 MINGW64, although I use the same dll in both. I have no idea why there's a difference. :/ I run Windows Terminal, but it reproduces also in cmd, as you tried. 1. In Control Panel -> Keyboard, set Repeat delay to shortest and Repeat rate to fastest. 2. In msys2-runtime run git fetch 3. Type git and press and hold q - Orgad -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
Re: xterm (or x11) pastes are highlighted
Am 18.03.2022 um 00:22 schrieb Andy Koppe: On Thu, 17 Mar 2022 at 20:32, René Berber wrote: On 3/17/2022 1:03 PM, n952162 wrote: Does anyone know how I can disable the highlighting that occurs when I copy and paste in xterm? Escape sequences are added to achieve that and sometimes they're not being properly interpreted. Why would I want that anyway? The same thing happens to (plain, non X windows) mintty. It started recently, maybe a couple of weeks. No idea how to fix it, haven't really tried. Very annoying. It came in with the readline 8.1 update in September last year, which enabled "bracketed paste mode" by default. (I think zsh has had it enabled for a few years.) As n952162 said, it tells the terminal to enclose pasted text in escape sequences. There are several points to this: - It stops accidental multi-line pastes from getting immediately executed line by line. - It makes it easier to undo a paste, as you can cut it out in one go rather than deleting manually. - Pasting can be faster, as the application can process the paste in one chunk rather than treating it as char-by-char keyboard input. But yep, sometimes it can go wonky, in particular when the bracketing mode for some reason is left on for an application that doesn't expect it. For readline, it can be disabled in ~/.inputrc: set enable-bracketed-paste off Regards, Andy Andy, perhaps you can speak to another, almost related issue, which I posted on 10th of March: /xterm*VT100.Translations only when mouse is over the window with focus/ A copy is attached here. This is only a Cygwin issue, as far as I know. Perhaps you can recommend someone who I could turn to, to get a fix, an explanation, a workaround, or help to get started doing a fix? n952162 // --- Begin Message --- xterm*VT100.Translations only when mouse is over the window with focus Discovered with click-to-focus, in FVWM In particular, I'm talking about the function keys. In this case, these are NOT mapped in fvwm, but in xterm. Pressing a function key, like F1, always writes to the window with focus, but only performs the X11/xterm translations when the mouse is hovering over the window with focus. So, I always have to move the mouse to the window to be able to write to the window. Otherwise, \e[P is written to the window, for example Note that I can visit various windows with keyboard shortcuts, so there's no natural correspondence with mouse position and window focus. This failure to do the X11/xterm translation only occurs with x11/cygwin xterms. Windows opened locally via sshd (port forwarded) behave normally, performing the translation to the focused window, no matter where the mouse is. Welcome to the XWin X Server Vendor: The Cygwin/X Project Release: 1.21.1.3 OS: CYGWIN_NT-10.0-19042 me 3.3.4-341.x86_64 2022-01-31 19:35 UTC x86_64 OS: Windows 10 [Windows NT 10.0 build 19042] x64 Package: version 21.1.3-1 built 2022-01-14 XWin was started with the following command line: /usr/bin/X :0 -auth /home/ge45tep/.serverauth.6258 00675~>xterm -version XTerm(370) fvwm 2.6.6 compiled on Oct 10 2016 at 00:25:52 with support for: ReadLine, XPM, PNG, SVG, Shape, XShm, SM, Bidi text, Xinerama, XRender, XCursor, XFT, NLS -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple --- End Message --- -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
