Re: [ITP] biosig [was: Re: newcomer issues when packaging biosig, stimfit, etc.]
Am 1/14/22 um 11:09 schrieb Marco Atzeri:
On 12.01.2022 23:59, Alois Schlögl wrote:
Am 1/12/22 um 06:47 schrieb Marco Atzeri:
In the meantime, please find below the status for the libb64 and
biosig packages.
Thanks that was helpful. Attached is an updated version for biosig
and libb64.
cygport libb64.cygport all
cygport biosig.cygport all
runs now w/o error. How can I test whether result can be installed
and used ?
One major problem.
Never build in the source directory, the final src.patch
must fit with you desired patch.
So only what you patched should come out.
For this package that does not respect the build in a
different directory than source, you shoud start
with something like:
src_compile() {
cd ${S}
lndirs
cd ${B}
cygautoreconf
cygconf
cygmake
}
I've adapted biosig.cygport accordingly and addressed this in the
attached version. It runs fine when doing
cygport biosig.cygport all
runs w/o error. Also testing the package with
tar -C / -xvf
biosig-2.3.3-1.x86_64/dist/biosig/biosig-tools/biosig-tools-2.3.3-1.tar.xz
tar -C / -xvf
biosig-2.3.3-1.x86_64/dist/biosig/libbiosig/libbiosig-2.3.3-1.tar.xz
tar -C / -xvf
biosig-2.3.3-1.x86_64/dist/biosig/libbiosig-devel/libbiosig-devel-2.3.3-1.tar.xz
and running
save2gdf -h
works fine.
Moreover, I understand now why my libb64.cygport file is not ready.
ecause libb64 is not necessary for libbiosig's support of Stimfit,
I'll omit libb64 for now.
Would you please check whether Biosig is ready to be included in
cygwin ?
Cheers,
Alois
Hi Alois.
it is almost fine
Hi Marco,
thanks for the feedback.
the only problem I see is that the shared library are build as
libbiosig.dll while they should be called cygbiosig.dll
(probably better cygbiosig-3.dll to handle the SOMANE)
I tried to do that, but run into issue. The exe-files still expect
libbbiosig.dll, and do not recognise cygbiosig-3.dll
It seems this would require significant changes by upstream, also by
other projects that would make use of libbiosig (e.g. stimfit,
sigviewer, python-biosig, etc.)
Since I do not under stand the purpose of renaming libbiosig to
cygbiosig, I'm reluctant to go that route.
What kind of problems is this renaming supposed to solve ?
Concerning SONAME-versioning, I'd like to avoid this for now, and
introduce versioning only when its really needed.
In the foreseeable future, I do not expect any changes will be needed
that would break the API
please also run the test in the ${B} directory
Done, this works without error. Please adapt that change accordingly.
I was playing with the CMakeList.txt to see if that was more easy
than your deep patch of the upstream Makefile's
I'm afraid that this "deep patch" is just an accidental artifact.
When running configure, all Makefile are rebuild from Makefile.in,
The Makefile(s) were packaged just by accident in v2.3.3.
But in fact these Makefiles should not have part of the released package.
Cheers,
Alois
Re: [PATCH setup] Show a MessageBox warning if running on a deprecated Windows version
On Jan 14 10:54, Adam Dinwoodie wrote: > On Fri, 14 Jan 2022 at 09:05, Corinna Vinschen wrote: > > On Jan 13 15:13, Jon Turney wrote: > > > Show a MessageBox warning if we are running on a Windows version which > > > we have deprecated Cygwin support for: > > > > > > - Windows 6.0 (Windows Vista, Windows Server 2008) > > > - 32-bit Windows > > > > > > This warning can be disabled with '--allow-unsupported-windows'. > > > --- > > > > > > Notes: > > > Not sure if this is needed, or maybe this is just annoying to the ~3% > > > of > > > users who are running effected OSes. But maybe we want to annoy them > > > into doing something about it? > > > > Question is, how often should setup show this message? Every time might > > really be a bit annoying. Some kind of "I saw it, now leave me alone, > > at least for a while" kind of function would be great. > > Eh. The installer tries to add icons to my desktop every time I run it > unless I provide a command-line argument every time. This behaviour > seems no more or less annoying to me, and I think having users see > that warning is much more important than adding a desktop icon. Point. Corinna
Re: [PATCH setup] Show a MessageBox warning if running on a deprecated Windows version
On Fri, 14 Jan 2022 at 09:05, Corinna Vinschen wrote: > On Jan 13 15:13, Jon Turney wrote: > > Show a MessageBox warning if we are running on a Windows version which > > we have deprecated Cygwin support for: > > > > - Windows 6.0 (Windows Vista, Windows Server 2008) > > - 32-bit Windows > > > > This warning can be disabled with '--allow-unsupported-windows'. > > --- > > > > Notes: > > Not sure if this is needed, or maybe this is just annoying to the ~3% of > > users who are running effected OSes. But maybe we want to annoy them > > into doing something about it? > > Question is, how often should setup show this message? Every time might > really be a bit annoying. Some kind of "I saw it, now leave me alone, > at least for a while" kind of function would be great. Eh. The installer tries to add icons to my desktop every time I run it unless I provide a command-line argument every time. This behaviour seems no more or less annoying to me, and I think having users see that warning is much more important than adding a desktop icon.
Re: [ITP] biosig [was: Re: newcomer issues when packaging biosig, stimfit, etc.]
On 12.01.2022 23:59, Alois Schlögl wrote:
Am 1/12/22 um 06:47 schrieb Marco Atzeri:
In the meantime, please find below the status for the libb64 and
biosig packages.
Thanks that was helpful. Attached is an updated version for biosig
and libb64.
cygport libb64.cygport all
cygport biosig.cygport all
runs now w/o error. How can I test whether result can be installed
and used ?
One major problem.
Never build in the source directory, the final src.patch
must fit with you desired patch.
So only what you patched should come out.
For this package that does not respect the build in a
different directory than source, you shoud start
with something like:
src_compile() {
cd ${S}
lndirs
cd ${B}
cygautoreconf
cygconf
cygmake
}
I've adapted biosig.cygport accordingly and addressed this in the
attached version. It runs fine when doing
cygport biosig.cygport all
runs w/o error. Also testing the package with
tar -C / -xvf
biosig-2.3.3-1.x86_64/dist/biosig/biosig-tools/biosig-tools-2.3.3-1.tar.xz
tar -C / -xvf
biosig-2.3.3-1.x86_64/dist/biosig/libbiosig/libbiosig-2.3.3-1.tar.xz
tar -C / -xvf
biosig-2.3.3-1.x86_64/dist/biosig/libbiosig-devel/libbiosig-devel-2.3.3-1.tar.xz
and running
save2gdf -h
works fine.
Moreover, I understand now why my libb64.cygport file is not ready.
ecause libb64 is not necessary for libbiosig's support of Stimfit, I'll
omit libb64 for now.
Would you please check whether Biosig is ready to be included in cygwin ?
Cheers,
Alois
Hi Alois.
it is almost fine
the only problem I see is that the shared library are build as
libbiosig.dll while they should be called cygbiosig.dll
(probably better cygbiosig-3.dll to handle the SOMANE)
please also run the test in the ${B} directory
I was playing with the CMakeList.txt to see if that was more easy
than your deep patch of the upstream Makefile's
src_compile() {
cd ${B}
CYGCMAKE_SOURCE="${S}/biosig4c++"
cygcmake
cygmake
I see however that also the CMakeLists.txt need some patching as
it builds only the shared lib withouh the SONAME and it is not updated
to include all the needed file in the t40x directory
and does not build the utility.
Sorry for slow response, but I have little time in this moment
Regards
Marco
Re: [PATCH setup] Show a MessageBox warning if running on a deprecated Windows version
On Jan 13 15:13, Jon Turney wrote: > Show a MessageBox warning if we are running on a Windows version which > we have deprecated Cygwin support for: > > - Windows 6.0 (Windows Vista, Windows Server 2008) > - 32-bit Windows > > This warning can be disabled with '--allow-unsupported-windows'. > --- > > Notes: > Not sure if this is needed, or maybe this is just annoying to the ~3% of > users who are running effected OSes. But maybe we want to annoy them > into doing something about it? Question is, how often should setup show this message? Every time might really be a bit annoying. Some kind of "I saw it, now leave me alone, at least for a while" kind of function would be great. Other than that, for people not visiting the home page or subscribing to the mailing lists that may turn out to be an important info, so I'm for it. Corinna
