Re: [darktable-dev] Feature request: camera model in export module

2015-11-24 Thread Šarūnas Burdulis
On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote:
> On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis
>  wrote:
>> would someone care to take a look at the attached patch? It ads
>> $(EXIF_MODEL) to recognized variables in the export to files on disk
>> file naming field. I used darktable-org/darktable master branch to start
>> with.
> 
> Is exif_model actually what you want? Here's what's in the img struct:
> 
> exif_make: the camera make exactly as reported in EXIF (cameras from
> the same manufacturer will have slightly different values)
> exif_model: the model exactly as reported in EXIF (often the maker is
> also in the model)
> camera_make: the camera make cleaned up (no needlessly long names, all
> cameras will report the same)
> camera_model: the camera model cleaned up (no needlessly long names,
> if there are aliases the base name is used so "EOS REBEL SL1" becomes
> "EOS 100D")
> camera_alias: same as before but the alias is used (so "EOS REBEL SL1"
> stays that way)
> [...]

I just made a pull request on GitHub to add MAKER and MODEL using
img->camera_maker and img->camera_model. It's a minor patch.

Thanks for considering it.

-- 
Šarūnas Burdulis
http://math.dartmouth.edu/~sarunas
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Feature request: camera model in export module

2015-11-24 Thread Tobias Ellinghaus
Am Freitag, 20. November 2015, 23:40:47 schrieb Pedro Côrte-Real:

[...]

> As for submitting the patch ideally you'd do a pull request on github.
> It's easier to review there and that way you actually get credited in
> the commit history. If that's too inconvenient a patch attached to
> email as you've already done also works.

As long as patches are created using "git format-patch" the credits are not a 
problem.

> Cheers,
> 
> Pedro

Tobias

signature.asc
Description: This is a digitally signed message part.


Re: [darktable-dev] Darktable not picking the correct color profile

2015-11-24 Thread Tobias Ellinghaus
Am Sonntag, 22. November 2015, 17:58:02 schrieb Caio S. Souza:
> Hi,
> I have a dual monitor setup using a notebook. The second monitor (Dell
> U2415) is plugged to the HDMI port of my notebook. Both are calibrated and
> correctly configured using colord. When I run darktable-cmtest, everything
> seems to be fine:
> darktable-cmstest version 2.0~rc2+29~g8c1da7b
> this executable was built with colord support enabled
> darktable itself was built without colord support
> 
> eDP1the X atom and colord returned the same profile
> X atom:_ICC_PROFILE (1125424 bytes)
> description:
> AVELLVCM8X-N156HG_Mode-RX-GX-BX-BRX-COX-GX_2015-11-15_gamma2.2_D6500_XYZLUT+
> MTX_6509_tests_Auto-optimized colord:
> "/home/csouza/.local/share/icc/AVELLVCM8X-N156HG_Mode-RX-GX-BX-BRX-COX-GX_20
> 15-11-15_gamma2.2_D6500_XYZLUT+MTX_6509_tests_Auto-optimized.icc"
> description:
> AVELLVCM8X-N156HG_Mode-RX-GX-BX-BRX-COX-GX_2015-11-15_gamma2.2_D6500_XYZLUT+
> MTX_6509_tests_Auto-optimized
> 
> HDMI1the X atom and colord returned the same profile
> X atom:_ICC_PROFILE_1 (1056224 bytes)
> description:
> DELLU2415_Mode-R99-G97-B98-BR57-CO60-GPC_2015-11-14_gamma2.2_D6500_XYZLUT+MT
> X_5336_tests_Auto-optimized colord:
> "/var/lib/colord/icc/DELLU2415_Mode-R99-G97-B98-BR57-CO60-GPC_2015-11-14_gam
> ma2.2_D6500_XYZLUT+MTX_5336_tests_Auto-optimized.icc" description:
> DELLU2415_Mode-R99-G97-B98-BR57-CO60-GPC_2015-11-14_gamma2.2_D6500_XYZLUT+MT
> X_5336_tests_Auto-optimized
> 
> Your system seems to be correctly configured
> 
> But when I run darktable, the profiles are swapped! If darktable's window
> is shown in the Dell monitor, it uses the notebook color profile. When it
> is in the notebook screen, it uses the Dell profile (I ran "darktable -d
> all" to track it). If I invert the monitors position in the system
> configuration, darktable is able to get the correct profiles, but it's very
> weird to work with this configuration. This problem doesn't occurs in
> version 1.6.9, only in the development version. I am currently using
> darktable version 2.0~rc2+29~g8c1da7b from the unstable ppa under Ubuntu
> 15.10 64 bits. If you already know about this bug, please disconsider this
> message.

There was someone else a while ago with the same problem. Back then we 
couldn't figure out what's happening. Now that you mention the order set in 
the system settings we have another hint what to look at. So thanks for 
reporting it. I will try to reproduce the problem once I am near an external 
monitor again. In the meantime, please add your findings to 
http://redmine.darktable.org/issues/10453

> Cheers

Tobias

signature.asc
Description: This is a digitally signed message part.