Re: [darktable-dev] Local Contrast Module broken using OpenCL

2020-08-14 Thread Šarūnas
On 8/14/20 2:37 PM, Dusenberg wrote:
> Thanks for the prompt reply Andreas. 
> What a pain, I use local laplacian a lot. The github threads say the
> AMDGPU-PRO drivers don't have this problem, so I'm wondering if I should
> replace the open source amdgpu driver with the PRO version as a
> workaround for the time being. Do you know if this is a realistic option
> for a non-dev user?

If this is a problem with the open source ROCm OpenCL library, you can
run open source amdgpu (present in Linux kernel) with OpenCL from
AMDGPU-PRO.

Here is for Ubuntu, but might be adaptable to others:
https://math.dartmouth.edu/~sarunas/amdgpu.html


-- 
Šarūnas Burdulis
math.dartmouth.edu/~sarunas

· https://useplaintext.email ·



signature.asc
Description: OpenPGP digital signature


Re: [darktable-dev] Local Contrast Module broken using OpenCL

2020-08-14 Thread Germano Massullo
Il 14/08/20 20:37, Dusenberg ha scritto:
> Thanks for the prompt reply Andreas. 
> What a pain, I use local laplacian a lot. The github threads say the
> AMDGPU-PRO drivers don't have this problem, so I'm wondering if I
> should replace the open source amdgpu driver with the PRO version as a
> workaround for the time being. Do you know if this is a realistic
> option for a non-dev user?

I everyday use amdgpu drivers, but when I use darktable, I use the
proprietary amdgpu-pro OpenCL drivers. Here is my procedure:


Just download the drivers for the distro that is more similar to yours
(example, RPM or Deb packages).
The example will follow RPM architecture, but for Debs the procedure is
almost the same.
Unpack the tar.xz file in a folder let's call it
/home/user/unpacked
After that, you will have folder
/home/user/unpacked/amdgpu-pro
that contains subfolders
amdgpu-pro-install  repodata  RPMS  SRPMS
go in RPMS and take all RPM files that are in subfolder
/home/user/unpacked/amdgpu-pro/x86_64
and put them together someelsewhere, for example
/home/user/amd_opencl
then unpack them all.
You will get
/home/user/amd_opencl/etc/
/home/user/amd_opencl/lib/
/home/user/amd_opencl/opt/
/home/user/amd_opencl/usr/

Then to run darktable
OPENCL_VENDOR_PATH=/home/user/amd_opencl/etc/OpenCL/vendors/
LD_LIBRARY_PATH=/home/user/amd_opencl/opt/amdgpu-pro/lib64/ darktable

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Local Contrast Module broken using OpenCL

2020-08-14 Thread Dusenberg

  
  
Thanks for the prompt reply Andreas.  
  What a pain, I use local laplacian a lot. The github threads say
  the AMDGPU-PRO drivers don't have this problem, so I'm wondering
  if I should replace the
open source amdgpu driver with the PRO version as a workaround
for the time being. Do you know
  if this is a realistic option for a non-dev user?
  

On 13/08/2020 13:53, Andreas Schneider
  wrote:

On Thursday, 13 August 2020 14:50:02 CEST Dusenberg wrote:


  I recently migrated to a new Linux workstation with OpenCL capability, and
Darktable 3.0.2 from the OpenSUSE 15.1 distro repository. The Local
Contrast Module (LC) is broken and produces ugly, extreme 'shading' and
artifacts in local laplacian mode that makes it unusable. The problem
manifests on viewing images previously developed on my old laptop with LC
enabled (same DT version but no OpenCL) as well as developing on the
workstation. Everything else in DT (and other apps) that I use in my
workflow is working as normal on the workstation.  OpenCL compiled and
loaded with no errors. There are no runtime error messages, normal or with
debug.  Disabling OpenCL fixes the Local Contrast module and it works as
expected. I've tried rebuilding locallaplacian.cl.bin, which again compiled
and loaded without error, but the problem remains.

Appears to a be bug in OpenCL code.  Any ideas/help?



___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org