Re: [darktable-dev] Issue with Tamron lens
On 10/04/2016 09:46 AM, Roman Lebedev wrote:
> On Tue, Oct 4, 2016 at 4:42 PM, Maurizio Paglia wrote:
>> Hi all,
>> my Tamron SP AF 17-50mm F/2.8 XR Di II VC LD Aspherical (IF) is not
>> recognized inside darktable
>
>> but I have to select manually Tamron SP AF 17-50mm f/2.8 XR Di II VC LD
>> Aspherical (IF).
>
> On http://lensfun.sourceforge.net/lenslist/ i only see the following lens:
> Tamron SP AF 17-50mm f/2.8 XR Di II LD Aspherical (IF)
>
> Which is not "Tamron SP AF 17-50mm f/2.8 XR Di II VC LD Aspherical (IF)"
> ('VC' is missing)
Might be OT for darktable, but: these are indeed two optically different
lenses. The VC version however was calibrated too, and data is already
in the Git version of lensfun (which is used for calibration uploads and
tests; will appear in SourceForge version eventually):
Git commit 9d64f493418b30e93d9b926241d138ede126ff4d:
Date: Thu Aug 11 22:20:23 2016 +0100
Add Calibration for Tamron 17-50 f/2.8 VC
Data from upload 895905 (issue #50). The lens is misidentified by
the current version of exiv2 as the Sigma 17-50, so must be manually
selected.
However there seems to be an issue with exiv2 reporting the lens identity.
--
Šarūnas Burdulis
http://math.dartmouth.edu/~sarunas
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Feature request: camera model in export module
On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote: > On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis > wrote: >> would someone care to take a look at the attached patch? It ads >> $(EXIF_MODEL) to recognized variables in the export to files on disk >> file naming field. I used darktable-org/darktable master branch to start >> with. > > Is exif_model actually what you want? Here's what's in the img struct: > > exif_make: the camera make exactly as reported in EXIF (cameras from > the same manufacturer will have slightly different values) > exif_model: the model exactly as reported in EXIF (often the maker is > also in the model) > camera_make: the camera make cleaned up (no needlessly long names, all > cameras will report the same) > camera_model: the camera model cleaned up (no needlessly long names, > if there are aliases the base name is used so "EOS REBEL SL1" becomes > "EOS 100D") > camera_alias: same as before but the alias is used (so "EOS REBEL SL1" > stays that way) > [...] I just made a pull request on GitHub to add MAKER and MODEL using img->camera_maker and img->camera_model. It's a minor patch. Thanks for considering it. -- Šarūnas Burdulis http://math.dartmouth.edu/~sarunas ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Feature request: camera model in export module
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2015 05:29 PM, Šarūnas Burdulis wrote: > On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote: >> On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis >> wrote: >>> would someone care to take a look at the attached patch? It ads >>> $(EXIF_MODEL) to recognized variables in the export to files on disk >>> file naming field. I used darktable-org/darktable master branch to start >>> with. > >> Is exif_model actually what you want? Here's what's in the img struct: > >> exif_make: the camera make exactly as reported in EXIF (cameras from >> the same manufacturer will have slightly different values) >> exif_model: the model exactly as reported in EXIF (often the maker is >> also in the model) >> camera_make: the camera make cleaned up (no needlessly long names, all >> cameras will report the same) >> camera_model: the camera model cleaned up (no needlessly long names, >> if there are aliases the base name is used so "EOS REBEL SL1" becomes >> "EOS 100D") >> camera_alias: same as before but the alias is used (so "EOS REBEL SL1" >> stays that way) > >> Depending on what you want to do some are better than others. I >> suspect camera_make and camera_alias are actually better for most >> purposes and is what we show in the interface. > > Pedro, thanks for a quick reply. > > Frankly, I didn't even think about what else might be available in img > struct. So yes, let's use whichever element looks best for showing the > camera model in most of the cases (I only tested with files from Olympus > E-M5 and Moto X cameraphone). > > Is the patch itself OK, i.e. is it the way this option should be added? > Do you want me to resend a patch with 'camera_make'? Sorry, I meant 'camera_model'. Šarūnas -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlZPnzMACgkQVVkpJ1MUn+b/uQCdGNRbFw58yZPyj/K5ORMZ2g3G K4UAnjJp1O7iA2ITrkMJCFGKi7HoPkS7 =KkxM -END PGP SIGNATURE- ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Feature request: camera model in export module
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote: > On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis > wrote: >> would someone care to take a look at the attached patch? It ads >> $(EXIF_MODEL) to recognized variables in the export to files on disk >> file naming field. I used darktable-org/darktable master branch to start >> with. > > Is exif_model actually what you want? Here's what's in the img struct: > > exif_make: the camera make exactly as reported in EXIF (cameras from > the same manufacturer will have slightly different values) > exif_model: the model exactly as reported in EXIF (often the maker is > also in the model) > camera_make: the camera make cleaned up (no needlessly long names, all > cameras will report the same) > camera_model: the camera model cleaned up (no needlessly long names, > if there are aliases the base name is used so "EOS REBEL SL1" becomes > "EOS 100D") > camera_alias: same as before but the alias is used (so "EOS REBEL SL1" > stays that way) > > Depending on what you want to do some are better than others. I > suspect camera_make and camera_alias are actually better for most > purposes and is what we show in the interface. Pedro, thanks for a quick reply. Frankly, I didn't even think about what else might be available in img struct. So yes, let's use whichever element looks best for showing the camera model in most of the cases (I only tested with files from Olympus E-M5 and Moto X cameraphone). Is the patch itself OK, i.e. is it the way this option should be added? Do you want me to resend a patch with 'camera_make'? Thanks! Šarūnas -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlZPntYACgkQVVkpJ1MUn+ZoMgCgiQOxauw0zdUZK7sF0JrXA8OB QyIAn0FAEE5NgpPRTx4wVN7fpHf2i4up =2BfH -END PGP SIGNATURE- ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Feature request: camera model in export module
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/19/2015 02:39 PM, Šarūnas Burdulis wrote:
> Hello,
>
> Would it be possible to make camera model variable, e.g. $(EXIF_MODEL),
> available in lighttable > export > storage options?
Hello, developers,
would someone care to take a look at the attached patch? It ads
$(EXIF_MODEL) to recognized variables in the export to files on disk
file naming field. I used darktable-org/darktable master branch to start
with.
Sorry if this is not how it should be done. Too many years have passed
since I have written anything in C, and this is the first time I looked
at the darktable source.
Best,
- --
Šarūnas Burdulis
http://math.dartmouth.edu/~sarunas
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
iEYEARECAAYFAlZPiJ4ACgkQVVkpJ1MUn+b9YQCfXcpKSjzfHI80CZCshUqLEGKZ
nZMAn3Ua5s8RK8cJwYmjch842Su8r+Qj
=C/dd
-END PGP SIGNATURE-
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org>From 915c74abcfe308fac32e09bb0509bbd2d979c71f Mon Sep 17 00:00:00 2001
From: sarunasb
Date: Fri, 20 Nov 2015 15:39:09 -0500
Subject: [PATCH] Ads $(EXIF_MODEL) variable to the list of recognized
variables while exporting to files on disk.
---
src/common/variables.c | 4
src/gui/gtkentry.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/common/variables.c b/src/common/variables.c
index 62aa3ef..423ce5e 100644
--- a/src/common/variables.c
+++ b/src/common/variables.c
@@ -117,6 +117,7 @@ gboolean _variable_get_value(dt_variables_params_t *params, gchar *variable, gch
/* image exif time */
gboolean have_exif_tm = FALSE;
int exif_iso = 100;
+ char exif_model[64];
int version = 0;
int stars = 0;
struct tm exif_tm = { 0 };
@@ -131,6 +132,7 @@ gboolean _variable_get_value(dt_variables_params_t *params, gchar *variable, gch
have_exif_tm = TRUE;
}
exif_iso = img->exif_iso;
+g_strlcpy(exif_model, img->exif_model, sizeof(exif_model));
version = img->version;
stars = (img->flags & 0x7);
if(stars == 6) stars = -1;
@@ -165,6 +167,8 @@ gboolean _variable_get_value(dt_variables_params_t *params, gchar *variable, gch
snprintf(value, value_len, "%.2d", (have_exif_tm ? exif_tm.tm_sec : tim->tm_sec));
else if(g_strcmp0(variable, "$(EXIF_ISO)") == 0 && (got_value = TRUE))
snprintf(value, value_len, "%d", exif_iso);
+ else if(g_strcmp0(variable, "$(EXIF_MODEL)") == 0 && (got_value = TRUE))
+snprintf(value, value_len, "%s", exif_model);
else if(g_strcmp0(variable, "$(ID)") == 0 && (got_value = TRUE))
snprintf(value, value_len, "%d", params->imgid);
else if(g_strcmp0(variable, "$(VERSION)") == 0 && (got_value = TRUE))
diff --git a/src/gui/gtkentry.c b/src/gui/gtkentry.c
index bee97d8..fa05d9a 100644
--- a/src/gui/gtkentry.c
+++ b/src/gui/gtkentry.c
@@ -203,6 +203,7 @@ const dt_gtkentry_completion_spec *dt_gtkentry_get_default_path_compl_list()
{ "EXIF_MINUTE", N_("$(EXIF_MINUTE) - EXIF minute") },
{ "EXIF_SECOND", N_("$(EXIF_SECOND) - EXIF second") },
{ "EXIF_ISO", N_("$(EXIF_ISO) - ISO value") },
+ { "EXIF_MODEL", N_("$(EXIF_MODEL) - camera model") },
{ "STARS", N_("$(STARS) - star rating") },
{ "LABELS", N_("$(LABELS) - colorlabels") },
{ "PICTURES_FOLDER", N_("$(PICTURES_FOLDER) - pictures folder") },
--
2.5.0
[darktable-dev] Feature request: camera model in export module
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, Would it be possible to make camera model variable, e.g. $(EXIF_MODEL), available in lighttable > export > storage options? And thanks for making darktable! - -- Šarūnas Burdulis http://math.dartmouth.edu/~sarunas -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlZOJXAACgkQVVkpJ1MUn+a33ACfZx9PJHeQ0onMOLd9AR5RR8o6 CcIAn29RaZKy7QlziHuhhPU6TG/HGKxc =+KU1 -END PGP SIGNATURE- ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
