Re: [darktable-dev] 2.6.0rc1 filmic - exposure interaction

2018-12-08 Thread William Ferguson
Thanks Matthieu, that makes sense.

Aurélien, thanks for adding the nodes on the curve. It make's it much
easier to understand how filmic is affected when the sliders are adjusted.

Bill

On Sat, Dec 8, 2018 at 3:54 PM Matthieu Moy  wrote:

> - Original Message -
> > From: "William Ferguson" 
>
> > Open an image in darkroom. Activate filmic. Click the eye dropper for
> middle
> > gray luminance. Move the mouse to the histogram and adjust the exposure.
> Each
> > adjustment results in two entries in the history stack, one from
> exposure and
> > one from filmic. The exposure does adjust, but the history stack grows
> quickly.
>
> Indeed. The problem is that the picker is still active while you adjust
> exposure on the histogram, hence each change in exposure triggers the
> colorpicker's callback.
>
> Probably the right thing to do would be to disable the color picker
> whenever the histogram is touched.
>
> --
> Matthieu Moy
> https://matthieu-moy.fr/
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] 2.6.0rc1 filmic - exposure interaction

2018-12-08 Thread Matthieu Moy
- Original Message -
> From: "William Ferguson" 

> Open an image in darkroom. Activate filmic. Click the eye dropper for middle
> gray luminance. Move the mouse to the histogram and adjust the exposure. Each
> adjustment results in two entries in the history stack, one from exposure and
> one from filmic. The exposure does adjust, but the history stack grows 
> quickly.

Indeed. The problem is that the picker is still active while you adjust 
exposure on the histogram, hence each change in exposure triggers the 
colorpicker's callback.

Probably the right thing to do would be to disable the color picker whenever 
the histogram is touched.

-- 
Matthieu Moy
https://matthieu-moy.fr/
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] 2.6.0rc1 filmic - exposure interaction

2018-12-08 Thread Aurélien Pierre
Hi,

exposure comes before filmic in the pipe. That means everytime you
change the exposure, you wrong filmic settings (black, grey and white
levels). You should always follow this order:

 1. disable base curves,
 2. adjust the white balance,
 3. fix the exposure (avoid clipping in blacks and in whites, use the
color-picker),
 4. set filmic,
 5. perform additional color corrections (the enhanced color balance is
designed to be filmic's complement),
 6. everything else comes after (but, at high ISO, maybe denoise before
anything else if you want to use filmic's black detection).

Inside filmic, you should set the sliders in the order they are
presented in the UI and use the color-pickers to avoid guesses (if you
set the exposure right on the verge of clipping, the white exposure in
filmic shall always be 2.45 EV). That way, you avoid circular editings
and accomplish 80 % of the job in 4 modules (2 if your camera did her
job properly). Once you have it figured out, even the tricky
backlighting cases take no more than 45 s to edit, provided your
subjects/details are roughly in the center of the histogram (recovering
dark subjects *and* bright backgrounds as well might require additional
masking jobs).

Of course, if you fly around modules in whatever order, I guarantee
nothing. I'm a lazy fool who once took wedding jobs, rest assured I did
not design tools to just work, I designed them to be efficient and based
on years of editing pain/experience. That's why I wanted to have the
modules re-ordered in the UI, as much as possible, in the same order
they are applied in the pipe, a few months ago.

The history behaviour you observe will happen with any combination of
modules : as soon as you switch from one module to another, a new
history entry is created. The fact that you needed this sort of back and
forth editing means your workflow was wrong in the first place and
should generally alert you. You can read my article to understand how to
use filmic :
https://eng.aurelienpierre.com/2018/11/30/filmic-darktable-and-the-quest-of-the-hdr-tone-mapping/

I have got feedback from several users now, who tried to squeeze filmic
into their old flawed workflow : it will never work. Don't enable filmic
if you are using base curves, global tone-mapping, or using the exposure
module to get the mid-tones right (meaning letting the highlights clip).
Bad software design and forgiving low-dynamic range pictures have given
users an acquired taste for self-harming practices. Time to re-evaluate
and work in a clever way to work less.

Regards,

Aurélien.

Le 18-12-08 à 14 h 30, William Ferguson a écrit :
> Open an image in darkroom.  Activate filmic.  Click the eye dropper
> for middle gray luminance.  Move the mouse to the histogram and adjust
> the exposure.  Each adjustment results in two entries in the history
> stack, one from exposure and one from filmic. The exposure does
> adjust, but the history stack grows quickly.
>
> I also tried starting filmic, calculating the middle gray luminance,
> then adjusting exposure in the exposure module.  That didn't exhibit
> the history stack issue.  After adjusting exposure with the exposure
> module, adjusting exposure in the histogram didn't result in the
> filmic/exposure history stack pairs.
>
> ubuntu 18.04
> dt 2.6.0rc1
>
> Bill
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

[darktable-dev] 2.6.0rc1 filmic - exposure interaction

2018-12-08 Thread William Ferguson
Open an image in darkroom.  Activate filmic.  Click the eye dropper for
middle gray luminance.  Move the mouse to the histogram and adjust the
exposure.  Each adjustment results in two entries in the history stack, one
from exposure and one from filmic. The exposure does adjust, but the
history stack grows quickly.

I also tried starting filmic, calculating the middle gray luminance, then
adjusting exposure in the exposure module.  That didn't exhibit the history
stack issue.  After adjusting exposure with the exposure module, adjusting
exposure in the histogram didn't result in the filmic/exposure history
stack pairs.

ubuntu 18.04
dt 2.6.0rc1

Bill

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org