[darktable-dev] Base curve for Nikon D810?
I was just exploring the settings in darktable 2.0 rc3, when I noticed that although there is a base curve for the Nikon D800, there isn't for the D810 (my camera). But when I go to the base curve module, that preset isn't listed (the only Nikon ones are nikon like and nikon like alternative). So I can't see what the D800 curve looks like. Also is http://www.darktable.org/2013/10/about-basecurves/ still up-to-date wrt. darktable 2.0? If so, I could have a go at generating one for the D810 (Nikon-like seems OK, but maybe a specific one would look even better?) ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
Hello Colin, > Also is http://www.darktable.org/2013/10/about-basecurves/ still up- > to-date wrt. darktable 2.0? If so, I could have a go at generating > one for the D810 (Nikon-like seems OK, but maybe a specific one would > look even better?) Yes it looks better for me. I did the D800 basecure (and denoise profile). For the basecurve, you can edit: src/iop/basecurve.c Duplicate the D800 code and change D800 to D810. You'll be able to tests it. But this basecure is often quite model specific and could not be that ok, but D810 is maybe very close to D800. Let us know. There is also tutorials to do a proper base curve, not difficult. See: http://www.darktable.org/2013/10/about-basecurves/ -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
Trying to build the tool, I get: /usr/bin/ld: CMakeFiles/dt-curve-tool.dir/exif-wrapper.o: undefined reference to symbol '_ZNSt8ios_base4InitD1Ev@@GLIBCXX_3.4' Any idea what I might need to install for this (I'm on Fedora 23). On 5 December 2015 at 19:54, Pascal Obry wrote: > > Hello Colin, > > > Also is http://www.darktable.org/2013/10/about-basecurves/ still up- > > to-date wrt. darktable 2.0? If so, I could have a go at generating > > one for the D810 (Nikon-like seems OK, but maybe a specific one would > > look even better?) > > Yes it looks better for me. I did the D800 basecure (and denoise > profile). > > For the basecurve, you can edit: > > src/iop/basecurve.c > > Duplicate the D800 code and change D800 to D810. You'll be able to > tests it. But this basecure is often quite model specific and could not > be that ok, but D810 is maybe very close to D800. > > Let us know. > > There is also tutorials to do a proper base curve, not difficult. See: > > http://www.darktable.org/2013/10/about-basecurves/ > > -- > Pascal Obry / Magny Les Hameaux (78) > > The best way to travel is by means of imagination > > http://v2p.fr.eu.org > http://www.obry.net > > gpg --keyserver keys.gnupg.net --recv-key F949BD3B > > ___ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
Le samedi 05 décembre 2015 à 20:13 +, Colin Adams a écrit : > Trying to build the tool, I get: > > /usr/bin/ld: CMakeFiles/dt-curve-tool.dir/exif-wrapper.o: undefined > reference to symbol '_ZNSt8ios_base4InitD1Ev@@GLIBCXX_3.4' > > Any idea what I might need to install for this (I'm on Fedora 23). Not sure. I'm on Debian. But this could be an issue with different name mangling just introduced with GCC 5.x. Please make sure you remove the build directory first. And then start building from scratch. -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
Starting from scratch again worked. Thanks. Now when I run dt-curve-tool-helper against my raw file it says: "if you accumulated enough data, you can now output the curves with dt-curve-tool -z -e DSC_5373.NEF -n 16" How do I know if I accumulated enough data? On 6 December 2015 at 17:34, Pascal Obry wrote: > Le samedi 05 décembre 2015 à 20:13 +, Colin Adams a écrit : > > Trying to build the tool, I get: > > > > /usr/bin/ld: CMakeFiles/dt-curve-tool.dir/exif-wrapper.o: undefined > > reference to symbol '_ZNSt8ios_base4InitD1Ev@@GLIBCXX_3.4' > > > > Any idea what I might need to install for this (I'm on Fedora 23). > > Not sure. I'm on Debian. But this could be an issue with different name > mangling just introduced with GCC 5.x. Please make sure you remove the > build directory first. And then start building from scratch. > > -- > Pascal Obry / Magny Les Hameaux (78) > > The best way to travel is by means of imagination > > http://v2p.fr.eu.org > http://www.obry.net > > gpg --keyserver keys.gnupg.net --recv-key F949BD3B > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
Anyway, I do think the generated curves are a lot better than "nikon like".
The instructions say:
# if it pleases you, then in iop/basecurve.c append the following line to
the array basecurve_presets and modify its name
# {"NIKON D810", "NIKON CORPORATION", "NIKON D810", 0, 51200, 0.00,
0.00}, {0.008285, 0.006637}, {0.015402, 0.014062}, {0.018124,
0.018489}, {0.021400, 0.024305}, {0.050415, 0.115441}, {0.078395,
0.225730}, {0.120612, 0.383772}, {0.151048, 0.486800}, {0.249231,
0.715335}, {0.371102, 0.875616}, {0.485427, 0.938709}, {0.605960,
0.988895}, {0.688174, 0.997034}, {0.864083, 0.995551}, {1.00,
1.00}}}, {16}, {m}}, 0, 1},
and:
# if it pleases you, then in iop/tonecurve.c append the following line to
the array preset_camera_curves and modify its name
# {"NIKON D810", "NIKON CORPORATION", "NIKON D810", 0, 51200, 0.00,
0.00}, {0.000471, 0.004044}, {0.002270, 0.004188}, {0.013512,
0.014291}, {0.015679, 0.015850}, {0.030955, 0.024344}, {0.071709,
0.058637}, {0.107682, 0.099315}, {0.148409, 0.156235}, {0.261161,
0.381440}, {0.281248, 0.432857}, {0.423166, 0.704551}, {0.557746,
0.867976}, {0.699408, 0.961516}, {0.814214, 0.994765}, {1.00,
1.00}, },{{0.00, 0.00}, {0.062500, 0.062500}, {0.125000,
0.125000}, {0.187500, 0.187500}, {0.25, 0.25}, {0.312500,
0.312500}, {0.375000, 0.375000}, {0.437500, 0.437500}, {0.50,
0.50}, {0.562500, 0.562500}, {0.625000, 0.625000}, {0.687500,
0.687500}, {0.75, 0.75}, {0.812500, 0.812500}, {0.875000,
0.875000}, {0.937500, 0.937500}, },{{0.00, 0.00}, {0.062500,
0.062500}, {0.125000, 0.125000}, {0.187500, 0.187500}, {0.25,
0.25}, {0.312500, 0.312500}, {0.375000, 0.375000}, {0.437500,
0.437500}, {0.50, 0.50}, {0.562500, 0.562500}, {0.625000,
0.625000}, {0.687500, 0.687500}, {0.75, 0.75}, {0.812500,
0.812500}, {0.875000, 0.875000}, {0.937500, 0.937500}, },}, {16, 16, 16},
{2, 2, 2}, 1, 0, 0}},
I'm not sure why the name needs modifying.
Anyway, do I have to make the modifications, and then submit patches, or is
this email sufficient to get the curves into the distribution?
On 6 December 2015 at 19:42, Colin Adams wrote:
> Starting from scratch again worked.
> Thanks.
>
> Now when I run dt-curve-tool-helper against my raw file it says:
>
> "if you accumulated enough data, you can now output the curves with
> dt-curve-tool -z -e DSC_5373.NEF -n 16"
>
> How do I know if I accumulated enough data?
>
>
> On 6 December 2015 at 17:34, Pascal Obry wrote:
>
>> Le samedi 05 décembre 2015 à 20:13 +, Colin Adams a écrit :
>> > Trying to build the tool, I get:
>> >
>> > /usr/bin/ld: CMakeFiles/dt-curve-tool.dir/exif-wrapper.o: undefined
>> > reference to symbol '_ZNSt8ios_base4InitD1Ev@@GLIBCXX_3.4'
>> >
>> > Any idea what I might need to install for this (I'm on Fedora 23).
>>
>> Not sure. I'm on Debian. But this could be an issue with different name
>> mangling just introduced with GCC 5.x. Please make sure you remove the
>> build directory first. And then start building from scratch.
>>
>> --
>> Pascal Obry / Magny Les Hameaux (78)
>>
>> The best way to travel is by means of imagination
>>
>> http://v2p.fr.eu.org
>> http://www.obry.net
>>
>> gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>>
>>
>
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
Le dimanche 06 décembre 2015 à 19:55 +, Colin Adams a écrit : > I'm not sure why the name needs modifying. > > Anyway, do I have to make the modifications, and then submit patches, > or is this email sufficient to get the curves into the distribution? If you are ok with Git a patch would be better I think. -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
OK. On 6 December 2015 at 21:19, Pascal Obry wrote: > Le dimanche 06 décembre 2015 à 19:55 +, Colin Adams a écrit : > > I'm not sure why the name needs modifying. > > > > Anyway, do I have to make the modifications, and then submit patches, > > or is this email sufficient to get the curves into the distribution? > > If you are ok with Git a patch would be better I think. > > -- > Pascal Obry / Magny Les Hameaux (78) > > The best way to travel is by means of imagination > > http://v2p.fr.eu.org > http://www.obry.net > > gpg --keyserver keys.gnupg.net --recv-key F949BD3B > > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
I have a formatted patch ready, but I can't submit it to the bug tracker because I don't know my user-id (I tried to register, but it said my email address is already taken, so I must have registered long before). How can i find out my user id? On 6 December 2015 at 21:19, Pascal Obry wrote: > Le dimanche 06 décembre 2015 à 19:55 +, Colin Adams a écrit : > > I'm not sure why the name needs modifying. > > > > Anyway, do I have to make the modifications, and then submit patches, > > or is this email sufficient to get the curves into the distribution? > > If you are ok with Git a patch would be better I think. > > -- > Pascal Obry / Magny Les Hameaux (78) > > The best way to travel is by means of imagination > > http://v2p.fr.eu.org > http://www.obry.net > > gpg --keyserver keys.gnupg.net --recv-key F949BD3B > > > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Base curve for Nikon D810?
My login-id was mis-spelled. Fixed that and created issue 10760 On 7 December 2015 at 07:27, Colin Adams wrote: > I have a formatted patch ready, but I can't submit it to the bug tracker > because I don't know my user-id (I tried to register, but it said my email > address is already taken, so I must have registered long before). How can i > find out my user id? > > On 6 December 2015 at 21:19, Pascal Obry wrote: > >> Le dimanche 06 décembre 2015 à 19:55 +, Colin Adams a écrit : >> > I'm not sure why the name needs modifying. >> > >> > Anyway, do I have to make the modifications, and then submit patches, >> > or is this email sufficient to get the curves into the distribution? >> >> If you are ok with Git a patch would be better I think. >> >> -- >> Pascal Obry / Magny Les Hameaux (78) >> >> The best way to travel is by means of imagination >> >> http://v2p.fr.eu.org >> http://www.obry.net >> >> gpg --keyserver keys.gnupg.net --recv-key F949BD3B >> >> >> > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
